Re: [PATCH] KVM: x86: Fix page-tables reserved bits

2014-04-28 Thread Nadav Amit
On Apr 28, 2014, at 1:41 PM, Paolo Bonzini wrote: > Il 17/04/2014 00:04, Marcelo Tosatti ha scritto: > > >> @@ -3550,9 +3550,9 @@ static void reset_rsvds_bits_mask(struct > > >> kvm_vcpu *vcpu, > > >> break; > > >> case PT64_ROOT_LEVEL: > > >>

Re: [PATCH] KVM: x86: Fix page-tables reserved bits

2014-04-28 Thread Paolo Bonzini
Il 17/04/2014 00:04, Marcelo Tosatti ha scritto: > >> @@ -3550,9 +3550,9 @@ static void reset_rsvds_bits_mask(struct kvm_vcpu *vcpu, > >> break; > >> case PT64_ROOT_LEVEL: > >> context->rsvd_bits_mask[0][3] = exb_bit_rsvd | > >> - rsvd_bits(maxphyaddr, 51)

Re: [PATCH] KVM: x86: Fix page-tables reserved bits

2014-04-28 Thread Paolo Bonzini
Il 17/04/2014 00:04, Marcelo Tosatti ha scritto: @@ -3550,9 +3550,9 @@ static void reset_rsvds_bits_mask(struct kvm_vcpu *vcpu, break; case PT64_ROOT_LEVEL: context-rsvd_bits_mask[0][3] = exb_bit_rsvd | - rsvd_bits(maxphyaddr, 51) | rsvd_bits(7,

Re: [PATCH] KVM: x86: Fix page-tables reserved bits

2014-04-28 Thread Nadav Amit
On Apr 28, 2014, at 1:41 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 17/04/2014 00:04, Marcelo Tosatti ha scritto: @@ -3550,9 +3550,9 @@ static void reset_rsvds_bits_mask(struct kvm_vcpu *vcpu, break; case PT64_ROOT_LEVEL:

Re: [PATCH] KVM: x86: Fix page-tables reserved bits

2014-04-16 Thread Marcelo Tosatti
On Wed, Apr 16, 2014 at 02:17:08PM -0700, H. Peter Anvin wrote: > On 04/16/2014 12:03 PM, Marcelo Tosatti wrote: > >> @@ -3550,9 +3550,9 @@ static void reset_rsvds_bits_mask(struct kvm_vcpu > >> *vcpu, > >>break; > >>case PT64_ROOT_LEVEL: > >>

Re: [PATCH] KVM: x86: Fix page-tables reserved bits

2014-04-16 Thread H. Peter Anvin
On 04/16/2014 12:03 PM, Marcelo Tosatti wrote: >> @@ -3550,9 +3550,9 @@ static void reset_rsvds_bits_mask(struct kvm_vcpu >> *vcpu, >> break; >> case PT64_ROOT_LEVEL: >> context->rsvd_bits_mask[0][3] = exb_bit_rsvd | >> -rsvd_bits(maxphyaddr, 51)

Re: [PATCH] KVM: x86: Fix page-tables reserved bits

2014-04-16 Thread Marcelo Tosatti
On Fri, Apr 04, 2014 at 06:31:04AM +0300, Nadav Amit wrote: > KVM does not handle the reserved bits of x86 page tables correctly: > In PAE, bits 5:8 are reserved in the PDPTE. > In IA-32e, bit 8 is not reserved. > > Signed-off-by: Nadav Amit > --- > arch/x86/kvm/mmu.c |6 +++--- > 1 file

Re: [PATCH] KVM: x86: Fix page-tables reserved bits

2014-04-16 Thread Marcelo Tosatti
On Fri, Apr 04, 2014 at 06:31:04AM +0300, Nadav Amit wrote: KVM does not handle the reserved bits of x86 page tables correctly: In PAE, bits 5:8 are reserved in the PDPTE. In IA-32e, bit 8 is not reserved. Signed-off-by: Nadav Amit na...@cs.technion.ac.il --- arch/x86/kvm/mmu.c |6

Re: [PATCH] KVM: x86: Fix page-tables reserved bits

2014-04-16 Thread H. Peter Anvin
On 04/16/2014 12:03 PM, Marcelo Tosatti wrote: @@ -3550,9 +3550,9 @@ static void reset_rsvds_bits_mask(struct kvm_vcpu *vcpu, break; case PT64_ROOT_LEVEL: context-rsvd_bits_mask[0][3] = exb_bit_rsvd | -rsvd_bits(maxphyaddr, 51) |

Re: [PATCH] KVM: x86: Fix page-tables reserved bits

2014-04-16 Thread Marcelo Tosatti
On Wed, Apr 16, 2014 at 02:17:08PM -0700, H. Peter Anvin wrote: On 04/16/2014 12:03 PM, Marcelo Tosatti wrote: @@ -3550,9 +3550,9 @@ static void reset_rsvds_bits_mask(struct kvm_vcpu *vcpu, break; case PT64_ROOT_LEVEL: context-rsvd_bits_mask[0][3] =

[PATCH] KVM: x86: Fix page-tables reserved bits

2014-04-03 Thread Nadav Amit
KVM does not handle the reserved bits of x86 page tables correctly: In PAE, bits 5:8 are reserved in the PDPTE. In IA-32e, bit 8 is not reserved. Signed-off-by: Nadav Amit --- arch/x86/kvm/mmu.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kvm/mmu.c

[PATCH] KVM: x86: Fix page-tables reserved bits

2014-04-03 Thread Nadav Amit
KVM does not handle the reserved bits of x86 page tables correctly: In PAE, bits 5:8 are reserved in the PDPTE. In IA-32e, bit 8 is not reserved. Signed-off-by: Nadav Amit na...@cs.technion.ac.il --- arch/x86/kvm/mmu.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git