Re: [PATCH] LSM: ModPin LSM for module loading restrictions

2013-11-02 Thread Casey Schaufler
On 10/26/2013 6:51 AM, Tetsuo Handa wrote: > Tetsuo Handa wrote: >> I would send another one which uses only security_file_alloc/free . > I sent it to James, Casey and Kees on "Fri, 18 Oct 2013 22:56:19 +0900" and > waiting for your response. How long are we expected to remain vulnerable due > to

Re: [PATCH] LSM: ModPin LSM for module loading restrictions

2013-10-26 Thread Tetsuo Handa
Tetsuo Handa wrote: > I would send another one which uses only security_file_alloc/free . I sent it to James, Casey and Kees on "Fri, 18 Oct 2013 22:56:19 +0900" and waiting for your response. How long are we expected to remain vulnerable due to lack of multiple concurrent LSM support? -- To unsub

Re: [PATCH] LSM: ModPin LSM for module loading restrictions

2013-10-22 Thread Lucas De Marchi
Hi Kees, On Thu, Oct 3, 2013 at 6:36 PM, Kees Cook wrote: > On Fri, Oct 04, 2013 at 06:31:42AM +0900, Tetsuo Handa wrote: >> Kees Cook wrote: >> > +static int modpin_load_module(struct file *file) >> > +{ >> > + struct dentry *module_root; >> > + >> > + if (!file) { >> > + if (!modp

Re: [PATCH] LSM: ModPin LSM for module loading restrictions

2013-10-22 Thread Casey Schaufler
On 10/22/2013 5:02 PM, James Morris wrote: > On Thu, 17 Oct 2013, Casey Schaufler wrote: > >> On 10/17/2013 1:02 AM, James Morris wrote: >>> This seems like a regression in terms of separating mechanism and policy. >>> >>> We have several access control systems available (SELinux, at least) which

Re: [PATCH] LSM: ModPin LSM for module loading restrictions

2013-10-22 Thread James Morris
On Thu, 17 Oct 2013, Casey Schaufler wrote: > On 10/17/2013 1:02 AM, James Morris wrote: > > This seems like a regression in terms of separating mechanism and policy. > > > > We have several access control systems available (SELinux, at least) which > > can implement this functionality with exi

Re: [PATCH] LSM: ModPin LSM for module loading restrictions

2013-10-17 Thread Casey Schaufler
On 10/16/2013 3:43 PM, Kees Cook wrote: > On Wed, Oct 16, 2013 at 2:42 PM, Casey Schaufler > wrote: >> On 10/16/2013 1:47 PM, Tetsuo Handa wrote: >>> Kees Cook wrote: Any update on this? It'd be nice to have it in linux-next. >>> What was the conclusion at LSS about multiple concurrent LSM s

Re: [PATCH] LSM: ModPin LSM for module loading restrictions

2013-10-17 Thread Kees Cook
On Thu, Oct 17, 2013 at 10:26 AM, Casey Schaufler wrote: > On 10/17/2013 1:02 AM, James Morris wrote: >> This seems like a regression in terms of separating mechanism and policy. >> >> We have several access control systems available (SELinux, at least) which >> can implement this functionality wi

Re: [PATCH] LSM: ModPin LSM for module loading restrictions

2013-10-17 Thread Kees Cook
On Thu, Oct 17, 2013 at 4:30 AM, Jarkko Sakkinen wrote: > On Thu, Oct 17, 2013 at 07:02:17PM +1100, James Morris wrote: >> This seems like a regression in terms of separating mechanism and policy. >> >> We have several access control systems available (SELinux, at least) which >> can implement thi

Re: [PATCH] LSM: ModPin LSM for module loading restrictions

2013-10-17 Thread Casey Schaufler
On 10/17/2013 1:02 AM, James Morris wrote: > This seems like a regression in terms of separating mechanism and policy. > > We have several access control systems available (SELinux, at least) which > can implement this functionality with existing mechanisms using dynamic > policy. They said th

Re: [PATCH] LSM: ModPin LSM for module loading restrictions

2013-10-17 Thread Jarkko Sakkinen
On Thu, Oct 17, 2013 at 07:02:17PM +1100, James Morris wrote: > This seems like a regression in terms of separating mechanism and policy. > > We have several access control systems available (SELinux, at least) which > can implement this functionality with existing mechanisms using dynamic > p

Re: [PATCH] LSM: ModPin LSM for module loading restrictions

2013-10-17 Thread James Morris
This seems like a regression in terms of separating mechanism and policy. We have several access control systems available (SELinux, at least) which can implement this functionality with existing mechanisms using dynamic policy. I'm concerned about the long term architectural impact of a prol

Re: [PATCH] LSM: ModPin LSM for module loading restrictions

2013-10-16 Thread Tetsuo Handa
Kees Cook wrote: > So I sent this LSM as one I\'d been waiting > for stacking on. Essentially, I\'m breaking the catch-22 by sending > this. I\'d like it to get into the tree so we don\'t have a catch-22 > about stacking any more. :) I\'m also trying to break the catch-22 by sending KPortReserve.

Re: [PATCH] LSM: ModPin LSM for module loading restrictions

2013-10-16 Thread Kees Cook
On Wed, Oct 16, 2013 at 2:42 PM, Casey Schaufler wrote: > On 10/16/2013 1:47 PM, Tetsuo Handa wrote: >> Kees Cook wrote: >>> Any update on this? It'd be nice to have it in linux-next. >> What was the conclusion at LSS about multiple concurrent LSM support? >> If we agreed to merge multiple concurr

Re: [PATCH] LSM: ModPin LSM for module loading restrictions

2013-10-16 Thread Casey Schaufler
On 10/16/2013 1:47 PM, Tetsuo Handa wrote: > Kees Cook wrote: >> Any update on this? It'd be nice to have it in linux-next. > What was the conclusion at LSS about multiple concurrent LSM support? > If we agreed to merge multiple concurrent LSM support, there will be nothing > to > prevent this mod

Re: [PATCH] LSM: ModPin LSM for module loading restrictions

2013-10-16 Thread Tetsuo Handa
Kees Cook wrote: > Any update on this? It'd be nice to have it in linux-next. What was the conclusion at LSS about multiple concurrent LSM support? If we agreed to merge multiple concurrent LSM support, there will be nothing to prevent this module from merging. -- To unsubscribe from this list: se

Re: [PATCH] LSM: ModPin LSM for module loading restrictions

2013-10-16 Thread Kees Cook
Hi James, On Mon, Sep 23, 2013 at 06:45:35PM -0700, Kees Cook wrote: > [+rusty] > > On Mon, Sep 23, 2013 at 6:28 PM, James Morris wrote: > > On Tue, 24 Sep 2013, James Morris wrote: > > > >> On Fri, 20 Sep 2013, Kees Cook wrote: > >> > >> > This LSM enforces that modules must all come from the s

Re: [PATCH] LSM: ModPin LSM for module loading restrictions

2013-10-03 Thread Kees Cook
On Fri, Oct 04, 2013 at 06:31:42AM +0900, Tetsuo Handa wrote: > Kees Cook wrote: > > +static int modpin_load_module(struct file *file) > > +{ > > + struct dentry *module_root; > > + > > + if (!file) { > > + if (!modpin_enforced) { > > + report_load_module(NULL, "old-

Re: [PATCH] LSM: ModPin LSM for module loading restrictions

2013-10-03 Thread Tetsuo Handa
Kees Cook wrote: > +static int modpin_load_module(struct file *file) > +{ > + struct dentry *module_root; > + > + if (!file) { > + if (!modpin_enforced) { > + report_load_module(NULL, "old-api-pinning-ignored"); > + return 0; > + } > + > +

Re: [PATCH] LSM: ModPin LSM for module loading restrictions

2013-10-03 Thread Kees Cook
On Mon, Sep 23, 2013 at 06:45:35PM -0700, Kees Cook wrote: > [+rusty] > > On Mon, Sep 23, 2013 at 6:28 PM, James Morris wrote: > > On Tue, 24 Sep 2013, James Morris wrote: > > > >> On Fri, 20 Sep 2013, Kees Cook wrote: > >> > >> > This LSM enforces that modules must all come from the same filesys

Re: [PATCH] LSM: ModPin LSM for module loading restrictions

2013-09-23 Thread Kees Cook
[+rusty] On Mon, Sep 23, 2013 at 6:28 PM, James Morris wrote: > On Tue, 24 Sep 2013, James Morris wrote: > >> On Fri, 20 Sep 2013, Kees Cook wrote: >> >> > This LSM enforces that modules must all come from the same filesystem, >> > with the expectation that such a filesystem is backed by a read-o

Re: [PATCH] LSM: ModPin LSM for module loading restrictions

2013-09-23 Thread James Morris
On Tue, 24 Sep 2013, James Morris wrote: > On Fri, 20 Sep 2013, Kees Cook wrote: > > > This LSM enforces that modules must all come from the same filesystem, > > with the expectation that such a filesystem is backed by a read-only > > device such as dm-verity or CDROM. This allows systems that ha

Re: [PATCH] LSM: ModPin LSM for module loading restrictions

2013-09-23 Thread James Morris
On Fri, 20 Sep 2013, Kees Cook wrote: > This LSM enforces that modules must all come from the same filesystem, > with the expectation that such a filesystem is backed by a read-only > device such as dm-verity or CDROM. This allows systems that have a > verified or unchanging filesystem to enforce

[PATCH] LSM: ModPin LSM for module loading restrictions

2013-09-20 Thread Kees Cook
This LSM enforces that modules must all come from the same filesystem, with the expectation that such a filesystem is backed by a read-only device such as dm-verity or CDROM. This allows systems that have a verified or unchanging filesystem to enforce module loading restrictions without needing to