Re: v2.4 megaraid2 update Re: [PATCH] Prevent NMI oopser

2005-03-02 Thread Marcelo Tosatti
On Wed, Mar 02, 2005 at 11:26:06AM -0500, Bagalkote, Sreenivas wrote: > Hello Marcelo, Hi Sreenivas, Damn, now I apologize for taking so long to answer... > As per our offline conversation, I have verified the update that went into > 2.4.30-pre2. > I confirm that all changes are correct. I

RE: v2.4 megaraid2 update Re: [PATCH] Prevent NMI oopser

2005-03-02 Thread Bagalkote, Sreenivas
, Atul; >Bagalkote, Sreenivas >Subject: v2.4 megaraid2 update Re: [PATCH] Prevent NMI oopser > > >Hi, > >As the megaraid2 maintainers dont seem to care about v2.4 >mainline at all, completly >ignoring my requests to fix the NMI oopser bug for several >months, I'm apply

RE: v2.4 megaraid2 update Re: [PATCH] Prevent NMI oopser

2005-03-02 Thread Bagalkote, Sreenivas
Subject: v2.4 megaraid2 update Re: [PATCH] Prevent NMI oopser Hi, As the megaraid2 maintainers dont seem to care about v2.4 mainline at all, completly ignoring my requests to fix the NMI oopser bug for several months, I'm applying the RHEL3 update + inline reordering, which should do

Re: v2.4 megaraid2 update Re: [PATCH] Prevent NMI oopser

2005-03-02 Thread Marcelo Tosatti
On Wed, Mar 02, 2005 at 11:26:06AM -0500, Bagalkote, Sreenivas wrote: Hello Marcelo, Hi Sreenivas, Damn, now I apologize for taking so long to answer... As per our offline conversation, I have verified the update that went into 2.4.30-pre2. I confirm that all changes are correct. I have

v2.4 megaraid2 update Re: [PATCH] Prevent NMI oopser

2005-02-23 Thread Marcelo Tosatti
Hi, As the megaraid2 maintainers dont seem to care about v2.4 mainline at all, completly ignoring my requests to fix the NMI oopser bug for several months, I'm applying the RHEL3 update + inline reordering, which should do it. At this point I'm quite sure they wont answer this message

v2.4 megaraid2 update Re: [PATCH] Prevent NMI oopser

2005-02-23 Thread Marcelo Tosatti
Hi, As the megaraid2 maintainers dont seem to care about v2.4 mainline at all, completly ignoring my requests to fix the NMI oopser bug for several months, I'm applying the RHEL3 update + inline reordering, which should do it. At this point I'm quite sure they wont answer this message

Re: [PATCH] Prevent NMI oopser

2005-02-02 Thread Andrey J. Melnikoff (TEMHOTA)
Hi Matt Domsch! On Wed, Feb 02, 2005 at 02:19:14PM -0600, Matt Domsch wrote next: > On Wed, Feb 02, 2005 at 10:32:28PM +0300, Vasily Averin wrote: > > >As a hack, one could #define inline /*nothing*/ in megaraid2.h to > > >avoid this, but it would be nice if the functions could all get > >

Re: [PATCH] Prevent NMI oopser

2005-02-02 Thread Matt Domsch
On Wed, Feb 02, 2005 at 10:32:28PM +0300, Vasily Averin wrote: > >As a hack, one could #define inline /*nothing*/ in megaraid2.h to > >avoid this, but it would be nice if the functions could all get > >reordered such that inlining works properly, and the need for function > >declarations in

Re: [PATCH] Prevent NMI oopser

2005-02-02 Thread Vasily Averin
Matt Domsch wrote: On Wed, Feb 02, 2005 at 09:42:02PM +0300, Vasily Averin wrote: This is megaraid2 driver update (2.10.8.2 version, latest 2.4-compatible version that I've seen), taken from latest RHEL3 kernel update. I believe it should prevent NMI in abort/reset handler. Thanks Vasily, I was

Re: [PATCH] Prevent NMI oopser

2005-02-02 Thread Vasily Averin
Hello Matt Matt Domsch wrote: On Wed, Feb 02, 2005 at 09:42:02PM +0300, Vasily Averin wrote: This is megaraid2 driver update (2.10.8.2 version, latest 2.4-compatible version that I've seen), taken from latest RHEL3 kernel update. I believe it should prevent NMI in abort/reset handler. Thanks

Re: [PATCH] Prevent NMI oopser

2005-02-02 Thread Vasily Averin
Hello Matt Matt Domsch wrote: On Wed, Feb 02, 2005 at 09:42:02PM +0300, Vasily Averin wrote: Marcelo, This is megaraid2 driver update (2.10.8.2 version, latest 2.4-compatible version that I've seen), taken from latest RHEL3 kernel update. I believe it should prevent NMI in abort/reset handler.

Re: [PATCH] Prevent NMI oopser

2005-02-02 Thread Andrey J. Melnikoff (TEMHOTA)
Hi Vasily Averin! On Wed, Feb 02, 2005 at 09:42:02PM +0300, Vasily Averin wrote next: > Marcelo Tosatti wrote: > >On Tue, Jan 25, 2005 at 11:00:22AM +0300, Vasily Averin wrote: > >>You should unlock io_request_lock before msleep, like in latest versions > >>of megaraid2 drivers. > > > >Andrey,

Re: [PATCH] Prevent NMI oopser

2005-02-02 Thread Matt Domsch
On Wed, Feb 02, 2005 at 09:42:02PM +0300, Vasily Averin wrote: > Marcelo Tosatti wrote: > >On Tue, Jan 25, 2005 at 11:00:22AM +0300, Vasily Averin wrote: > >>You should unlock io_request_lock before msleep, like in latest versions > >>of megaraid2 drivers. > > > >Andrey, > > > >Can you please

Re: [PATCH] Prevent NMI oopser

2005-02-02 Thread Vasily Averin
Marcelo Tosatti wrote: On Tue, Jan 25, 2005 at 11:00:22AM +0300, Vasily Averin wrote: You should unlock io_request_lock before msleep, like in latest versions of megaraid2 drivers. Andrey, Can you please update your patch to unlock io_request_lock before sleeping and locking after coming back?

Re: [PATCH] Prevent NMI oopser

2005-02-02 Thread Vasily Averin
Marcelo Tosatti wrote: On Tue, Jan 25, 2005 at 11:00:22AM +0300, Vasily Averin wrote: You should unlock io_request_lock before msleep, like in latest versions of megaraid2 drivers. Andrey, Can you please update your patch to unlock io_request_lock before sleeping and locking after coming back?

Re: [PATCH] Prevent NMI oopser

2005-02-02 Thread Matt Domsch
On Wed, Feb 02, 2005 at 09:42:02PM +0300, Vasily Averin wrote: Marcelo Tosatti wrote: On Tue, Jan 25, 2005 at 11:00:22AM +0300, Vasily Averin wrote: You should unlock io_request_lock before msleep, like in latest versions of megaraid2 drivers. Andrey, Can you please update your patch to

Re: [PATCH] Prevent NMI oopser

2005-02-02 Thread Andrey J. Melnikoff (TEMHOTA)
Hi Vasily Averin! On Wed, Feb 02, 2005 at 09:42:02PM +0300, Vasily Averin wrote next: Marcelo Tosatti wrote: On Tue, Jan 25, 2005 at 11:00:22AM +0300, Vasily Averin wrote: You should unlock io_request_lock before msleep, like in latest versions of megaraid2 drivers. Andrey, Can you

Re: [PATCH] Prevent NMI oopser

2005-02-02 Thread Vasily Averin
Hello Matt Matt Domsch wrote: On Wed, Feb 02, 2005 at 09:42:02PM +0300, Vasily Averin wrote: Marcelo, This is megaraid2 driver update (2.10.8.2 version, latest 2.4-compatible version that I've seen), taken from latest RHEL3 kernel update. I believe it should prevent NMI in abort/reset handler.

Re: [PATCH] Prevent NMI oopser

2005-02-02 Thread Vasily Averin
Hello Matt Matt Domsch wrote: On Wed, Feb 02, 2005 at 09:42:02PM +0300, Vasily Averin wrote: This is megaraid2 driver update (2.10.8.2 version, latest 2.4-compatible version that I've seen), taken from latest RHEL3 kernel update. I believe it should prevent NMI in abort/reset handler. Thanks

Re: [PATCH] Prevent NMI oopser

2005-02-02 Thread Vasily Averin
Matt Domsch wrote: On Wed, Feb 02, 2005 at 09:42:02PM +0300, Vasily Averin wrote: This is megaraid2 driver update (2.10.8.2 version, latest 2.4-compatible version that I've seen), taken from latest RHEL3 kernel update. I believe it should prevent NMI in abort/reset handler. Thanks Vasily, I was

Re: [PATCH] Prevent NMI oopser

2005-02-02 Thread Matt Domsch
On Wed, Feb 02, 2005 at 10:32:28PM +0300, Vasily Averin wrote: As a hack, one could #define inline /*nothing*/ in megaraid2.h to avoid this, but it would be nice if the functions could all get reordered such that inlining works properly, and the need for function declarations in megaraid2.h

Re: [PATCH] Prevent NMI oopser

2005-02-02 Thread Andrey J. Melnikoff (TEMHOTA)
Hi Matt Domsch! On Wed, Feb 02, 2005 at 02:19:14PM -0600, Matt Domsch wrote next: On Wed, Feb 02, 2005 at 10:32:28PM +0300, Vasily Averin wrote: As a hack, one could #define inline /*nothing*/ in megaraid2.h to avoid this, but it would be nice if the functions could all get reordered such

Re: [PATCH] Prevent NMI oopser

2005-01-31 Thread Marcelo Tosatti
Kernel Team > > # ChangeSet > # 2005/01/19 14:16:32-02:00 [EMAIL PROTECTED] > # [PATCH] Prevent NMI oopser from triggering when megaraid2 waits > # for abort/reset cmd completion > # > # > We should backport msleep() in 2.4.29-pre1. > # > # Ok, msleep()

Re: [PATCH] Prevent NMI oopser

2005-01-31 Thread Marcelo Tosatti
] # [PATCH] Prevent NMI oopser from triggering when megaraid2 waits # for abort/reset cmd completion # #We should backport msleep() in 2.4.29-pre1. # # Ok, msleep() backported, but driver isn't fixed. This patch # acceptable? # # Prevent NMI oopser kill kernel thread when

Re: [PATCH] Prevent NMI oopser

2005-01-25 Thread Marcelo Tosatti
On Tue, Jan 25, 2005 at 10:47:24AM +0300, Vasily Averin wrote: > Marcello, Andrey > > I believe this patch is wrong. > First, it prevent nothing: NMI watchdog is a signal that you wait too > long with disabled interrupts. Your controller was not answered too > long, obviously it is a hardware

Re: [PATCH] Prevent NMI oopser

2005-01-25 Thread Marcelo Tosatti
On Tue, Jan 25, 2005 at 10:47:24AM +0300, Vasily Averin wrote: Marcello, Andrey I believe this patch is wrong. First, it prevent nothing: NMI watchdog is a signal that you wait too long with disabled interrupts. Your controller was not answered too long, obviously it is a hardware issue.

[PATCH] Prevent NMI oopser

2005-01-24 Thread Vasily Averin
taken. You should unlock io_request_lock before msleep, like in latest versions of megaraid2 drivers. Please fix it. Thank you, Vasily Averin, SWSoft Linux Kernel Team # ChangeSet # 2005/01/19 14:16:32-02:00 [EMAIL PROTECTED] # [PATCH] Prevent NMI oopser from triggering when megaraid2

[PATCH] Prevent NMI oopser

2005-01-24 Thread Vasily Averin
taken. You should unlock io_request_lock before msleep, like in latest versions of megaraid2 drivers. Please fix it. Thank you, Vasily Averin, SWSoft Linux Kernel Team # ChangeSet # 2005/01/19 14:16:32-02:00 [EMAIL PROTECTED] # [PATCH] Prevent NMI oopser from triggering when megaraid2