Re: [PATCH] drivers: power: supply: goldfish_battery: Fix bogus SPDX identifier

2019-03-20 Thread Thomas Gleixner
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? On Tue, 19 Mar 2019, Roman Kiryanov wrote: > Hi, I am sorry for this war

Re: [PATCH] drivers: power: supply: goldfish_battery: Fix bogus SPDX identifier

2019-03-19 Thread Greg KH
On Tue, Mar 19, 2019 at 09:14:32AM -0700, Roman Kiryanov wrote: > Hi, I am sorry for this warning. I remember I checked all changes I > sent, maybe missed this one. > > At the bottom the file says > > MODULE_LICENSE("GPL"); > > and > > // SPDX-License-Identifier: GPL-2.0 > > makes it inconsist

Re: [PATCH] drivers: power: supply: goldfish_battery: Fix bogus SPDX identifier

2019-03-19 Thread Roman Kiryanov
Hi, I am sorry for this warning. I remember I checked all changes I sent, maybe missed this one. At the bottom the file says MODULE_LICENSE("GPL"); and // SPDX-License-Identifier: GPL-2.0 makes it inconsistent. Regards, Roman. On Tue, Mar 19, 2019 at 7:51 AM Thomas Gleixner wrote: > > spdxc

[PATCH] drivers: power: supply: goldfish_battery: Fix bogus SPDX identifier

2019-03-19 Thread Thomas Gleixner
spdxcheck.py complains: drivers/power/supply/goldfish_battery.c: 1:28 Invalid License ID: GPL which is correct because GPL is not a valid identifier. Of course this could have been caught by checkpatch.pl _before_ submitting or merging the patch. WARNING: 'SPDX-License-Identifier: GPL' is not