On Tue, Jul 31, 2007 at 02:19:53PM +0200, Cornelia Huck wrote:
>On Tue, 31 Jul 2007 19:50:16 +0800,
>WANG Cong <[EMAIL PROTECTED]> wrote:
>
>> On Mon, Jul 30, 2007 at 07:38:47PM +0800, Eugene Teo wrote:
>> >This patch fixes these warnings:
>> >
>> >fs/partitions/check.c: In function 'add_partition'
On Tue, 31 Jul 2007 19:50:16 +0800,
WANG Cong <[EMAIL PROTECTED]> wrote:
> On Mon, Jul 30, 2007 at 07:38:47PM +0800, Eugene Teo wrote:
> >This patch fixes these warnings:
> >
> >fs/partitions/check.c: In function 'add_partition':
> >fs/partitions/check.c:391: warning: ignoring return value of 'kob
On Mon, Jul 30, 2007 at 07:38:47PM +0800, Eugene Teo wrote:
>This patch fixes these warnings:
>
>fs/partitions/check.c: In function 'add_partition':
>fs/partitions/check.c:391: warning: ignoring return value of 'kobject_add',
> declared with attribute warn_unused_result
>fs/partitions/check.c
On Mon, 30 Jul 2007 19:38:47 +0800,
Eugene Teo <[EMAIL PROTECTED]> wrote:
> This patch fixes these warnings:
>
> fs/partitions/check.c: In function 'add_partition':
> fs/partitions/check.c:391: warning: ignoring return value of 'kobject_add',
> declared with attribute warn_unused_result
> f
This patch fixes these warnings:
fs/partitions/check.c: In function 'add_partition':
fs/partitions/check.c:391: warning: ignoring return value of 'kobject_add',
declared with attribute warn_unused_result
fs/partitions/check.c:394: warning: ignoring return value of
'sysfs_create_lin
On Mon, 30 Jul 2007 19:16:38 +0800,
Eugene Teo <[EMAIL PROTECTED]> wrote:
> +err_out_del_link:
> + sysfs_remove_link(&p->kobj, "subsystem");
> +err_out_del_uevent:
> + if (!disk->part_uevent_suppress)
> + kobject_uevent(&p->kobj, KOBJ_REMOVE);
You're missing kobject_del() her
This patch fixes these warnings:
fs/partitions/check.c: In function 'add_partition':
fs/partitions/check.c:391: warning: ignoring return value of 'kobject_add',
declared with attribute warn_unused_result
fs/partitions/check.c:394: warning: ignoring return value of
'sysfs_create_lin
Cornelia Huck wrote:
> On Mon, 30 Jul 2007 17:47:55 +0800,
> Eugene Teo <[EMAIL PROTECTED]> wrote:
>
>> +err_out_del_link:
>> +sysfs_remove_link(&p->kobj, "subsystem");
>> +err_out_del_kobj:
>> +if (!disk->part_uevent_suppress)
>> +kobject_uevent(&p->kobj, KOBJ_REMOVE);
>> +
On Mon, 30 Jul 2007 17:47:55 +0800,
Eugene Teo <[EMAIL PROTECTED]> wrote:
> +err_out_del_link:
> + sysfs_remove_link(&p->kobj, "subsystem");
> +err_out_del_kobj:
> + if (!disk->part_uevent_suppress)
> + kobject_uevent(&p->kobj, KOBJ_REMOVE);
> + kobject_put(&p->kobj);
> +er
This patch fixes these warnings:
fs/partitions/check.c: In function 'add_partition':
fs/partitions/check.c:391: warning: ignoring return value of 'kobject_add',
declared with attribute warn_unused_result
fs/partitions/check.c:394: warning: ignoring return value of
'sysfs_create_lin
Hi Cornelia,
Cornelia Huck wrote:
> On Sun, 29 Jul 2007 10:53:39 +0800,
> Eugene Teo <[EMAIL PROTECTED]> wrote:
[...]
>> +return;
>> +
>> +err_out_del_link:
>> +sysfs_remove_link(&p->kobj, "subsystem");
>
> You need a remove uevent if you did an add uevent above.
>
>> +err_out_del_kobj:
On Sun, 29 Jul 2007 10:53:39 +0800,
Eugene Teo <[EMAIL PROTECTED]> wrote:
> @@ -388,20 +389,34 @@ void add_partition(struct gendisk *disk, int part,
> sector_t start, sector_t len,
> p->kobj.parent = &disk->kobj;
> p->kobj.ktype = &ktype_part;
> kobject_init(&p->kobj);
> - k
This patch fixes these warnings:
fs/partitions/check.c: In function ‘add_partition’:
fs/partitions/check.c:391: warning: ignoring return value of ‘kobject_add’,
declared with attribute warn_unused_result
fs/partitions/check.c:394: warning: ignoring return value of
‘sysfs_create_lin
13 matches
Mail list logo
