Re: [PATCH] get_maintainer: Add subsystem to reviewer output

2015-10-29 Thread Lee Jones
On 29 October 2015 at 14:14, Joe Perches wrote: > On Thu, 2015-10-29 at 09:20 +, Lee Jones wrote: >> On Wed, 28 Oct 2015, Joe Perches wrote: > >> > An issue for that will be how multiple subsystem section matching >> > affects the output for reviewers who are also maintainers. >> >> I think th

Re: [PATCH] get_maintainer: Add subsystem to reviewer output

2015-10-29 Thread Joe Perches
On Thu, 2015-10-29 at 09:20 +, Lee Jones wrote: > On Wed, 28 Oct 2015, Joe Perches wrote: > > An issue for that will be how multiple subsystem section matching > > affects the output for reviewers who are also maintainers. > > I think that's okay, becuase the 'MAINTAINERS tag' will be differe

Re: [PATCH] get_maintainer: Add subsystem to reviewer output

2015-10-29 Thread Lee Jones
On Wed, 28 Oct 2015, Joe Perches wrote: > On Wed, 2015-10-28 at 17:49 +, Lee Jones wrote: > > On Wed, 28 Oct 2015, Joe Perches wrote: > > > On Wed, 2015-10-28 at 17:22 +, Lee Jones wrote: > > > > On Wed, 28 Oct 2015, Joe Perches wrote: > > > > > > Acked-by: Lee Jones > > > > > It'd be be

Re: [PATCH] get_maintainer: Add subsystem to reviewer output

2015-10-28 Thread Krzysztof Kozlowski
On 29.10.2015 01:41, Joe Perches wrote: > Reviewer output currently does not include the subsystem > that matched. Add it. > > Miscellanea: > > o Add a get_subsystem_name routine to centralize this > > Signed-off-by: Joe Perches > --- > scripts/get_maintainer.pl | 31 -

Re: [PATCH] get_maintainer: Add subsystem to reviewer output

2015-10-28 Thread Joe Perches
On Wed, 2015-10-28 at 17:49 +, Lee Jones wrote: > On Wed, 28 Oct 2015, Joe Perches wrote: > > On Wed, 2015-10-28 at 17:22 +, Lee Jones wrote: > > > On Wed, 28 Oct 2015, Joe Perches wrote: > > > > > Acked-by: Lee Jones > > > > It'd be better if you could add a "tested-by:" instead. > > >

Re: [PATCH] get_maintainer: Add subsystem to reviewer output

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Joe Perches wrote: > On Wed, 2015-10-28 at 17:22 +, Lee Jones wrote: > > On Wed, 28 Oct 2015, Joe Perches wrote: > > > > Acked-by: Lee Jones > > > It'd be better if you could add a "tested-by:" instead. > > > > Patch works as expected: > > Tested-by: Lee Jones > []

Re: [PATCH] get_maintainer: Add subsystem to reviewer output

2015-10-28 Thread Joe Perches
On Wed, 2015-10-28 at 17:22 +, Lee Jones wrote: > On Wed, 28 Oct 2015, Joe Perches wrote: > > > Acked-by: Lee Jones > > It'd be better if you could add a "tested-by:" instead. > > Patch works as expected: > Tested-by: Lee Jones [] > "I'm sure we can make the output even more simila

Re: [PATCH] get_maintainer: Add subsystem to reviewer output

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Joe Perches wrote: > On Wed, 2015-10-28 at 17:01 +, Lee Jones wrote: > > On Wed, 28 Oct 2015, Joe Perches wrote: > > > > > Reviewer output currently does not include the subsystem > > > that matched. Add it. > > > > > > Miscellanea: > > > > > > o Add a get_subsystem_na

Re: [PATCH] get_maintainer: Add subsystem to reviewer output

2015-10-28 Thread Joe Perches
On Wed, 2015-10-28 at 17:01 +, Lee Jones wrote: > It looks like I'm going to have to drop the patch where we actually > start using the R: tag properly due to some social, emotional issues. btw: it seems to me the thing you're looking for is the tree to which any particular patch could or woul

Re: [PATCH] get_maintainer: Add subsystem to reviewer output

2015-10-28 Thread Joe Perches
On Wed, 2015-10-28 at 17:01 +, Lee Jones wrote: > On Wed, 28 Oct 2015, Joe Perches wrote: > > > Reviewer output currently does not include the subsystem > > that matched. Add it. > > > > Miscellanea: > > > > o Add a get_subsystem_name routine to centralize this > > > > Signed-off-by: Joe P

Re: [PATCH] get_maintainer: Add subsystem to reviewer output

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Joe Perches wrote: > Reviewer output currently does not include the subsystem > that matched. Add it. > > Miscellanea: > > o Add a get_subsystem_name routine to centralize this > > Signed-off-by: Joe Perches > --- > scripts/get_maintainer.pl | 31

[PATCH] get_maintainer: Add subsystem to reviewer output

2015-10-28 Thread Joe Perches
Reviewer output currently does not include the subsystem that matched. Add it. Miscellanea: o Add a get_subsystem_name routine to centralize this Signed-off-by: Joe Perches --- scripts/get_maintainer.pl | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) d