Re: [PATCH] hwmon: (k10temp) Add AMD family 17h model 60h probe

2020-06-17 Thread Borislav Petkov
Ok, both of you: On Wed, Jun 17, 2020 at 11:07:35PM +0800, Jacky Hu wrote: > Hi, > > Sorry, I apologize for didn't do much lookup that you already did the patch > submission before I submitted the patch. > I have to say we are all programmed by the programs. > Also I didn't submit to either of th

Re: [PATCH] hwmon: (k10temp) Add AMD family 17h model 60h probe

2020-06-17 Thread Jacky Hu
Hi, Sorry, I apologize for didn't do much lookup that you already did the patch submission before I submitted the patch. I have to say we are all programmed by the programs. Also I didn't submit to either of the lists. A few places I did looked at are below before I did the submission. https://pci

Re: [PATCH] hwmon: (k10temp) Add AMD family 17h model 60h probe

2020-06-17 Thread Jacky Hu
Yep, here it is ~> cat thm.idle 0x059800: 29a00fef 017f1201 00012921 000f4240 0x059810: 80f9 0x059820: 0fff0078 0x059830: 002cecf9 002cecf9 002d2cfb 0x059840: 002cccf8 002cacf7 002d2cfb 002cccf8 0x059850: 002d2cfb 002c8cf6 002cccf8

Re: [PATCH] hwmon: (k10temp) Add AMD family 17h model 60h probe

2020-06-17 Thread Alexander Monakov
Hi, I've already said in my patch submission (which was Cc'ed to LKML, linux-edac and linux-hwmon so you should have been able to find it): >> It appears SMU offsets for reading current/voltage and CCD temperature >> have changed for this generation (reads from currently used offsets >> yield zer

Re: [PATCH] hwmon: (k10temp) Add AMD family 17h model 60h probe

2020-06-17 Thread Guenter Roeck
On Wed, Jun 17, 2020 at 03:19:27PM +0800, Jacky Hu wrote: > Hi Guenter, > > By increasing the regs count from 32 to 256 and looking into the output of > `cat /sys/kernel/debug/k10temp-\:00\:18.3/svi` > There is some data from 0x05a300 - 0x05a330 > Do you have any idea how we can guess the off

Re: [PATCH] hwmon: (k10temp) Add AMD family 17h model 60h probe

2020-06-17 Thread Jacky Hu
Hi Guenter, By increasing the regs count from 32 to 256 and looking into the output of `cat /sys/kernel/debug/k10temp-\:00\:18.3/svi` There is some data from 0x05a300 - 0x05a330 Do you have any idea how we can guess the offset for this model? 0x05a000: 0x0

Re: [PATCH] hwmon: (k10temp) Add AMD family 17h model 60h probe

2020-06-16 Thread Guenter Roeck
On Wed, Jun 17, 2020 at 09:32:55AM +0800, Jacky Hu wrote: > With this patch applied, output from 4800H (idle) looks as follows: > > k10temp-pci-00c3 > Adapter: PCI adapter > Vcore: 1.55 V > Vsoc: 1.55 V > Tctl: +49.6°C > Tdie: +49.6°C > Icore: 0.00 A > Isoc

[PATCH] hwmon: (k10temp) Add AMD family 17h model 60h probe

2020-06-16 Thread Jacky Hu
With this patch applied, output from 4800H (idle) looks as follows: k10temp-pci-00c3 Adapter: PCI adapter Vcore: 1.55 V Vsoc: 1.55 V Tctl: +49.6°C Tdie: +49.6°C Icore: 0.00 A Isoc: 0.00 A Signed-off-by: Jacky Hu --- drivers/hwmon/k10temp.c | 1 +