Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Alexander Holler
Am 27.01.2015 um 19:42 schrieb Steven Rostedt: Hey, if you end up doing it, it could help with your resume. Oh, young padovan, I'm writing SW since 30a and it just would make it even longer, which already seems to be a problem for many HR people. Alexander Holer -- To unsubscribe from this

Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Joe Perches
On Tue, 2015-01-27 at 13:06 +0100, Richard Weinberger wrote: > Am 27.01.2015 um 13:02 schrieb Alexander Holler: > > Am 27.01.2015 um 12:55 schrieb Richard Weinberger: > >> On Tue, Jan 27, 2015 at 12:48 PM, Alexander Holler > >> wrote: > >>> It's an interesting detail, so inform the user about it.

Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Steven Rostedt
On Tue, 27 Jan 2015 19:33:52 +0100 Alexander Holler wrote: > Am 27.01.2015 um 19:21 schrieb Steven Rostedt: > > > You want to add a way to tell a property of a device. That is *exactly* > > what sysfs was made for. Not dmesg. > > Err, dmesg existed long before sysfs. Yep, and dmesg shows you w

Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Alexander Holler
Am 27.01.2015 um 19:21 schrieb Steven Rostedt: You want to add a way to tell a property of a device. That is *exactly* what sysfs was made for. Not dmesg. Err, dmesg existed long before sysfs. Anyway, it's ok. You're all right and I should request project sponsoring for offering a simple pie

Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Steven Rostedt
On Tue, 27 Jan 2015 19:13:29 +0100 Alexander Holler wrote: > > Basically, what you are saying is "printk is more convenient for me and > > I do not care about the other cases that make much more sense with > > sysfs". The kernel does not work that way. > > No. First I don't know the name of one

Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Borislav Petkov
On Tue, Jan 27, 2015 at 07:04:13PM +0100, Alexander Holler wrote: > dmesg | grep -i mmc (or whatever is of interest) And what happens if someone has done "dmesg -c" before you? -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send t

Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Alexander Holler
Am 27.01.2015 um 18:48 schrieb Steven Rostedt: On Tue, 27 Jan 2015 18:38:36 +0100 Alexander Holler wrote: Anyway, I like(d) Linux because it didn't had a splash screen and used to spit out all types of information on the screen where it could be easily seen or found (in contrast other OS which

Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Richard Weinberger
Am 27.01.2015 um 19:04 schrieb Alexander Holler: > Am 27.01.2015 um 18:53 schrieb Arend van Spriel: > >> Ever used rgrep or grep -R. Anyway, if this is you use-case what about >> the gazillion other pieces of info in the kernel. When moving in that >> direction you can be sure dmesg will flush out

Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Alexander Holler
Am 27.01.2015 um 18:53 schrieb Arend van Spriel: Ever used rgrep or grep -R. Anyway, if this is you use-case what about the gazillion other pieces of info in the kernel. When moving in that direction you can be sure dmesg will flush out. Sorry, never heard about that -R and wasn't aware that t

Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Arend van Spriel
On 01/27/15 18:38, Alexander Holler wrote: Am 27.01.2015 um 18:24 schrieb Steven Rostedt: For most people a message in dmesg is not very useful. What you are asking for is to print a characteristic of a device. Something that someone might want to check much later in boot, where, as Boris state

Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Steven Rostedt
On Tue, 27 Jan 2015 18:38:36 +0100 Alexander Holler wrote: > Anyway, I like(d) Linux because it didn't had a splash screen and used > to spit out all types of information on the screen where it could be > easily seen or found (in contrast other OS which try to hide all > technical details from

Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Alexander Holler
Am 27.01.2015 um 18:24 schrieb Steven Rostedt: For most people a message in dmesg is not very useful. What you are asking for is to print a characteristic of a device. Something that someone might want to check much later in boot, where, as Boris stated, the dmesg could have been flushed (by sys

Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Steven Rostedt
On Tue, Jan 27, 2015 at 05:55:08PM +0100, Alexander Holler wrote: > > > >So, even if you don't always agree with them, you need to realize that > >those are the people responsible for that code and if they request a > >reasonable change in your submission, you have to do it. It is that > >simple. >

Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Alexander Holler
Am 27.01.2015 um 15:21 schrieb Borislav Petkov: On Tue, Jan 27, 2015 at 01:44:15PM +0100, Alexander Holler wrote: Yes. Sorry, but I had so many bad experiences with maintainers. Well, I can't comment on your experience for the simple reason that I haven't followed those discussions. In their d

Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Borislav Petkov
On Tue, Jan 27, 2015 at 01:44:15PM +0100, Alexander Holler wrote: > Yes. Sorry, but I had so many bad experiences with maintainers. Well, I can't comment on your experience for the simple reason that I haven't followed those discussions. In their defence, though, you have to know that those people

Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Alexander Holler
Am 27.01.2015 um 13:31 schrieb Richard Weinberger: Also it's unlikely I will send any further patch. There are still 21 from me where I've exposed sysfs attributes for NAND devices which are still not applied and most NAND devices still don't have a sysfs entry. So why should I waste my time

Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Richard Weinberger
Am 27.01.2015 um 13:15 schrieb Alexander Holler: > Am 27.01.2015 um 13:08 schrieb Borislav Petkov: >> On Tue, Jan 27, 2015 at 01:02:49PM +0100, Alexander Holler wrote: >>> Look at the source at the message which is printed just before and decide >>> which one you find more informational / useful. >

Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Arend van Spriel
On 01/27/15 12:48, Alexander Holler wrote: It's an interesting detail, so inform the user about it. Signed-off-by: Alexander Holler --- drivers/mmc/core/bus.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c index 8a1f124..4a60028 100644

Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Alexander Holler
Am 27.01.2015 um 13:08 schrieb Borislav Petkov: On Tue, Jan 27, 2015 at 01:02:49PM +0100, Alexander Holler wrote: Look at the source at the message which is printed just before and decide which one you find more informational / useful. I find such a message absolutely useless. Also, if it flie

Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Borislav Petkov
On Tue, Jan 27, 2015 at 01:02:49PM +0100, Alexander Holler wrote: > Look at the source at the message which is printed just before and decide > which one you find more informational / useful. I find such a message absolutely useless. Also, if it flies off and printk buffer gets overwritten, it ser

Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Richard Weinberger
Am 27.01.2015 um 13:02 schrieb Alexander Holler: > Am 27.01.2015 um 12:55 schrieb Richard Weinberger: >> On Tue, Jan 27, 2015 at 12:48 PM, Alexander Holler >> wrote: >>> It's an interesting detail, so inform the user about it. >>> >>> Signed-off-by: Alexander Holler >>> --- >>> drivers/mmc/cor

Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Alexander Holler
Am 27.01.2015 um 12:55 schrieb Richard Weinberger: On Tue, Jan 27, 2015 at 12:48 PM, Alexander Holler wrote: It's an interesting detail, so inform the user about it. Signed-off-by: Alexander Holler --- drivers/mmc/core/bus.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/m

Re: [PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Richard Weinberger
On Tue, Jan 27, 2015 at 12:48 PM, Alexander Holler wrote: > It's an interesting detail, so inform the user about it. > > Signed-off-by: Alexander Holler > --- > drivers/mmc/core/bus.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c > i

[PATCH] mmc: print message if a card supports secure erase/trim

2015-01-27 Thread Alexander Holler
It's an interesting detail, so inform the user about it. Signed-off-by: Alexander Holler --- drivers/mmc/core/bus.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c index 8a1f124..4a60028 100644 --- a/drivers/mmc/core/bus.c +++ b/drivers/mmc