Re: [PATCH] regmap: Fix the null function of format_val on regmap_bulk_read.

2015-08-27 Thread Mark Brown
On Thu, Aug 27, 2015 at 07:49:25AM +0200, Markus Pargmann wrote: > On Wed, Aug 26, 2015 at 06:38:12PM +0100, Mark Brown wrote: > > On Wed, Aug 26, 2015 at 03:22:46PM +0200, Markus Pargmann wrote: > > > The regmap_bulk_read() function worked before the following patch: > > > 15b8d2c41fe5 (regmap:

Re: [PATCH] regmap: Fix the null function of format_val on regmap_bulk_read.

2015-08-26 Thread Markus Pargmann
On Wed, Aug 26, 2015 at 06:38:12PM +0100, Mark Brown wrote: > On Wed, Aug 26, 2015 at 03:22:46PM +0200, Markus Pargmann wrote: > > On Wed, Aug 26, 2015 at 01:35:56PM +0100, Mark Brown wrote: > > > On Wed, Aug 26, 2015 at 07:43:16PM +0800, Henry Chen wrote: > > > > Why are these format functions se

Re: [PATCH] regmap: Fix the null function of format_val on regmap_bulk_read.

2015-08-26 Thread Mark Brown
On Wed, Aug 26, 2015 at 03:22:46PM +0200, Markus Pargmann wrote: > On Wed, Aug 26, 2015 at 01:35:56PM +0100, Mark Brown wrote: > > On Wed, Aug 26, 2015 at 07:43:16PM +0800, Henry Chen wrote: > > Why are these format functions sensible? Converting a null pointer > > dereference into data corruptio

Re: [PATCH] regmap: Fix the null function of format_val on regmap_bulk_read.

2015-08-26 Thread Markus Pargmann
On Wed, Aug 26, 2015 at 01:35:56PM +0100, Mark Brown wrote: > On Wed, Aug 26, 2015 at 07:43:16PM +0800, Henry Chen wrote: > > The regmap_format will not be initialize if device driver not declare the > > regmap_bus > > when registering the regmap. To avoid the null function of format_val when > >

Re: [PATCH] regmap: Fix the null function of format_val on regmap_bulk_read.

2015-08-26 Thread Mark Brown
On Wed, Aug 26, 2015 at 07:43:16PM +0800, Henry Chen wrote: > The regmap_format will not be initialize if device driver not declare the > regmap_bus > when registering the regmap. To avoid the null function of format_val when > called regmap_bulk_read(). It need to give a format function when regm

[PATCH] regmap: Fix the null function of format_val on regmap_bulk_read.

2015-08-26 Thread Henry Chen
The regmap_format will not be initialize if device driver not declare the regmap_bus when registering the regmap. To avoid the null function of format_val when called regmap_bulk_read(). It need to give a format function when regmap init. Signed-off-by: Henry Chen --- I ran into this bug when te