Re: [PATCH] sched: remove useless code in yield_to

2012-08-17 Thread Peter Zijlstra
On Fri, 2012-08-17 at 14:56 +0800, Michael Wang wrote: > > I think Mike also agreed to remove that piece of code, should we > action now? Right you are, applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More m

Re: [PATCH] sched: remove useless code in yield_to

2012-08-16 Thread Michael Wang
On 07/12/2012 10:07 PM, Peter Zijlstra wrote: > On Tue, 2012-07-03 at 14:34 +0800, Michael Wang wrote: >> From: Michael Wang >> >> it's impossible to enter else branch if we have set skip_clock_update >> in task_yield_fair(), as yield_to_task_fair() will directly return >> true after invoke task_y

Re: [PATCH] sched: remove useless code in yield_to

2012-08-09 Thread Mike Galbraith
On Fri, 2012-08-10 at 11:10 +0800, Michael Wang wrote: > On 08/10/2012 11:05 AM, Michael Wang wrote: > > On 07/03/2012 02:34 PM, Michael Wang wrote: > >> From: Michael Wang > >> > >> it's impossible to enter else branch if we have set skip_clock_update > >> in task_yield_fair(), as yield_to_task_

Re: [PATCH] sched: remove useless code in yield_to

2012-08-09 Thread Michael Wang
On 08/10/2012 11:05 AM, Michael Wang wrote: > On 07/03/2012 02:34 PM, Michael Wang wrote: >> From: Michael Wang >> >> it's impossible to enter else branch if we have set skip_clock_update >> in task_yield_fair(), as yield_to_task_fair() will directly return >> true after invoke task_yield_fair().

Re: [PATCH] sched: remove useless code in yield_to

2012-08-09 Thread Michael Wang
On 07/03/2012 02:34 PM, Michael Wang wrote: > From: Michael Wang > > it's impossible to enter else branch if we have set skip_clock_update > in task_yield_fair(), as yield_to_task_fair() will directly return > true after invoke task_yield_fair(). Could I get some conclusion on this patch? Should

Re: [PATCH] sched: remove useless code in yield_to

2012-07-15 Thread Michael Wang
On 07/12/2012 10:07 PM, Peter Zijlstra wrote: > On Tue, 2012-07-03 at 14:34 +0800, Michael Wang wrote: >> From: Michael Wang >> >> it's impossible to enter else branch if we have set skip_clock_update >> in task_yield_fair(), as yield_to_task_fair() will directly return >> true after invoke task_y

Re: [PATCH] sched: remove useless code in yield_to

2012-07-12 Thread Mike Galbraith
On Thu, 2012-07-12 at 16:07 +0200, Peter Zijlstra wrote: > On Tue, 2012-07-03 at 14:34 +0800, Michael Wang wrote: > > From: Michael Wang > > > > it's impossible to enter else branch if we have set skip_clock_update > > in task_yield_fair(), as yield_to_task_fair() will directly return > > true a

Re: [PATCH] sched: remove useless code in yield_to

2012-07-12 Thread Peter Zijlstra
On Tue, 2012-07-03 at 14:34 +0800, Michael Wang wrote: > From: Michael Wang > > it's impossible to enter else branch if we have set skip_clock_update > in task_yield_fair(), as yield_to_task_fair() will directly return > true after invoke task_yield_fair(). It helps if you CC the guy who wrote t

Re: [PATCH] sched: remove useless code in yield_to

2012-07-11 Thread Michael Wang
On 07/03/2012 02:34 PM, Michael Wang wrote: > From: Michael Wang > > it's impossible to enter else branch if we have set skip_clock_update > in task_yield_fair(), as yield_to_task_fair() will directly return > true after invoke task_yield_fair(). > > Signed-off-by: Michael Wang > --- > kernel/