Re: [PATCH] watchdog: add Nano 7240 driver

2007-10-30 Thread Gilles Gigan
Wim, I made the changes you requested. Cheers, Gilles From: Gilles Gigan<[EMAIL PROTECTED]> Adds support for the built-in watchdog on EPIC Nano 7240 boards from IEI. Tested on Nano-7240RS. Hardware documentation of the platform (including watchdog) can be found on the IEI website: http://www.ie

Re: [PATCH] watchdog: add Nano 7240 driver

2007-10-24 Thread Alan Cox
On Wed, 24 Oct 2007 17:22:40 +0200 Wim Van Sebroeck <[EMAIL PROTECTED]> wrote: > Hi Andrew, > > > > + case WDIOC_SETOPTIONS:{ > > > + int retval = -EINVAL; > > > + > > > + if (arg & WDIOS_DISABLECARD) { > > > + wdt_disable(); > > > +

Re: [PATCH] watchdog: add Nano 7240 driver

2007-10-24 Thread Wim Van Sebroeck
Hi Andrew, > > + case WDIOC_SETOPTIONS:{ > > + int retval = -EINVAL; > > + > > + if (arg & WDIOS_DISABLECARD) { > > + wdt_disable(); > > + retval = 0; > > + } > > + > > + i

Re: [PATCH] watchdog: add Nano 7240 driver

2007-10-24 Thread Wim Van Sebroeck
Hi Gilles, > +static ssize_t fop_write(struct file *file, const char __user *buf, > + size_t count, loff_t *ppos) > +{ > + size_t i; > + char c; > + int got_magic_char = 0; > + > + /* is there a magic char ? */ > + for (i = 0; i != count; i++) { > +

Re: [PATCH] watchdog: add Nano 7240 driver

2007-10-23 Thread Andrew Morton
On Wed, 24 Oct 2007 12:11:59 +1000 Gilles Gigan <[EMAIL PROTECTED]> wrote: > + case WDIOC_SETOPTIONS:{ > + int retval = -EINVAL; > + > + if (arg & WDIOS_DISABLECARD) { > + wdt_disable(); > + retval

[PATCH] watchdog: add Nano 7240 driver

2007-10-23 Thread Gilles Gigan
From: Gilles Gigan<[EMAIL PROTECTED]> Adds support for the built-in watchdog on EPIC Nano 7240 boards from IEI. Tested on Nano-7240RS. Hardware documentation of the platform (including watchdog) can be found on the IEI website: http://www.ieiworld.com Signed-off-by: Gilles Gigan <[EMAIL PROTEC

Re: [PATCH] watchdog: add Nano 7240 driver

2007-10-15 Thread Andrew Morton
On Sun, 07 Oct 2007 22:49:00 +1000 Gilles Gigan <[EMAIL PROTECTED]> wrote: > Andrey Panin wrote: > >> +#ifdef CONFIG_WATCHDOG_NOWAYOUT > >> +#define NOWAYOUT 1 > >> +#else > >> +#define NOWAYOUT 0 > >> +#endif > >> +static int nowayout = NOWAYOUT; > > > > You don

Re: [PATCH] watchdog: add Nano 7240 driver

2007-10-07 Thread Gilles Gigan
Andrey Panin wrote: +#ifdef CONFIG_WATCHDOG_NOWAYOUT +#define NOWAYOUT 1 +#else +#define NOWAYOUT 0 +#endif +static int nowayout = NOWAYOUT; You don't need this #ifdef crap. Just use WATCHDOG_NOWAYOUT instead. done + if ((_IOC_DIR(cmd) & _I

Re: [PATCH] watchdog: add Nano 7240 driver

2007-10-07 Thread Andrey Panin
On 280, 10 07, 2007 at 01:39:28AM +1000, Gilles Gigan wrote: > from: Gilles Gigan <[EMAIL PROTECTED]> > > Adds watchdog driver for EPIC Nano 7240 boards from IEI > > Signed-off-by: Gilles Gigan <[EMAIL PROTECTED]> > --- > > diff -uprN -X linux-2.6.23-rc9/Documentation/dontdiff > linux-2.6.23-rc9/d

[PATCH] watchdog: add Nano 7240 driver

2007-10-06 Thread Gilles Gigan
from: Gilles Gigan <[EMAIL PROTECTED]> Adds watchdog driver for EPIC Nano 7240 boards from IEI Signed-off-by: Gilles Gigan <[EMAIL PROTECTED]> --- diff -uprN -X linux-2.6.23-rc9/Documentation/dontdiff linux-2.6.23-rc9/drivers/char/watchdog/Kconfig linux-2.6.23-rc9-dirty/drivers/char/watchdog/K