On Mon, Jul 29, 2019 at 4:34 PM Mel Gorman wrote:
>
> On Sun, Jul 28, 2019 at 12:44:36AM +0800, Pengfei Li wrote:
> > On Fri, Jul 26, 2019 at 3:26 PM Mel Gorman
> > wrote:
> > >
> >
> > Thank you for your comments.
> >
> > > On Fri, Jul 26, 2019 at 02:42:43AM +0800, Pengfei Li wrote:
> > > > Obj
On Sun, Jul 28, 2019 at 12:44:36AM +0800, Pengfei Li wrote:
> On Fri, Jul 26, 2019 at 3:26 PM Mel Gorman
> wrote:
> >
>
> Thank you for your comments.
>
> > On Fri, Jul 26, 2019 at 02:42:43AM +0800, Pengfei Li wrote:
> > > Objective
> > >
> > > The motivation for this series of patches is
On Fri, Jul 26, 2019 at 3:12 PM Michal Hocko wrote:
>
Thank you for your comments.
> On Fri 26-07-19 07:48:36, Pengfei Li wrote:
> [...]
> > For the benefit, "order" may be negative, which is confusing and weird.
>
> order = -1 has a special meaning.
>
Yes. But I mean -1 can be replaced by any
On Fri, Jul 26, 2019 at 3:26 PM Mel Gorman wrote:
>
Thank you for your comments.
> On Fri, Jul 26, 2019 at 02:42:43AM +0800, Pengfei Li wrote:
> > Objective
> >
> > The motivation for this series of patches is use unsigned int for
> > "order" in compaction.c, just like in other memory subsy
On Fri, Jul 26, 2019 at 02:42:43AM +0800, Pengfei Li wrote:
> Objective
>
> The motivation for this series of patches is use unsigned int for
> "order" in compaction.c, just like in other memory subsystems.
>
Why? The series is relatively subtle in parts, particularly patch 5.
There have bee
On Fri 26-07-19 07:48:36, Pengfei Li wrote:
[...]
> For the benefit, "order" may be negative, which is confusing and weird.
order = -1 has a special meaning.
> There is no good reason not to do this since it can be avoided.
"This is good because we can do it" doesn't really sound like a
convinci
On Fri, Jul 26, 2019 at 2:52 AM Qian Cai wrote:
>
> On Fri, 2019-07-26 at 02:42 +0800, Pengfei Li wrote:
> > Objective
> >
> > The motivation for this series of patches is use unsigned int for
> > "order" in compaction.c, just like in other memory subsystems.
>
> I suppose you will need more
On Fri, 2019-07-26 at 02:42 +0800, Pengfei Li wrote:
> Objective
>
> The motivation for this series of patches is use unsigned int for
> "order" in compaction.c, just like in other memory subsystems.
I suppose you will need more justification for this change. Right now, I don't
see much real
Objective
The motivation for this series of patches is use unsigned int for
"order" in compaction.c, just like in other memory subsystems.
In addition, did some cleanup about "order" in page_alloc
and vmscan.
Description
Directly modifying the type of "order" to unsigned int is ok in m
9 matches
Mail list logo