Re: [PATCH 09/16] media: i2c: rdacm21: Re-work OV10640 initialization

2021-02-24 Thread Laurent Pinchart
Hi Jacopo, On Mon, Feb 22, 2021 at 04:19:13PM +0100, Jacopo Mondi wrote: > On Mon, Feb 22, 2021 at 03:27:25AM +0200, Laurent Pinchart wrote: > > On Tue, Feb 16, 2021 at 06:41:39PM +0100, Jacopo Mondi wrote: > > > The OV10640 image sensor reset and powerdown on signals are controlled > > > > s/ on/

Re: [PATCH 09/16] media: i2c: rdacm21: Re-work OV10640 initialization

2021-02-22 Thread Jacopo Mondi
Hi On Mon, Feb 22, 2021 at 03:27:25AM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Tue, Feb 16, 2021 at 06:41:39PM +0100, Jacopo Mondi wrote: > > The OV10640 image sensor reset and powerdown on signals are controlled > > s/ on// > > > by the embedded OV490 ISP. T

Re: [PATCH 09/16] media: i2c: rdacm21: Re-work OV10640 initialization

2021-02-21 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Tue, Feb 16, 2021 at 06:41:39PM +0100, Jacopo Mondi wrote: > The OV10640 image sensor reset and powerdown on signals are controlled s/ on// > by the embedded OV490 ISP. The current reset procedure does not respect > the 1 millisecond power-up delay and rel

Re: [PATCH 09/16] media: i2c: rdacm21: Re-work OV10640 initialization

2021-02-17 Thread Kieran Bingham
Hi Jacopo, On 16/02/2021 17:41, Jacopo Mondi wrote: > The OV10640 image sensor reset and powerdown on signals are controlled > by the embedded OV490 ISP. The current reset procedure does not respect > the 1 millisecond power-up delay and releases the reset signal before > the powerdown one. > > F

Re: [PATCH 09/16] media: i2c: rdacm21: Re-work OV10640 initialization

2021-02-17 Thread Geert Uytterhoeven
Hi Jacopo, On Tue, Feb 16, 2021 at 6:41 PM Jacopo Mondi wrote: > The OV10640 image sensor reset and powerdown on signals are controlled Drop the "on"? > by the embedded OV490 ISP. The current reset procedure does not respect > the 1 millisecond power-up delay and releases the reset signal befor

[PATCH 09/16] media: i2c: rdacm21: Re-work OV10640 initialization

2021-02-16 Thread Jacopo Mondi
The OV10640 image sensor reset and powerdown on signals are controlled by the embedded OV490 ISP. The current reset procedure does not respect the 1 millisecond power-up delay and releases the reset signal before the powerdown one. Fix the OV10640 power up sequence by releasing the powerdown signa