Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-26 Thread Guennadi Liakhovetski
On Thu, 26 Jul 2007, Sergei Shtylyov wrote: > Guennadi Liakhovetski wrote: > > > Ok, thanks for the explanation Alan. So, there's no technical argument, > > just "being nice to the users", and add a new driver, which we know we'll > > have to remove soon, thus having to persuade its users, who

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-26 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 26 July 2007, Guennadi Liakhovetski wrote: > On Wed, 25 Jul 2007, Alan Cox wrote: > > > > driver to using platform-device. I got a reply, that it's not worth it > > > now > > > that IDE is slowly becoming obsolete, and the pata_platform serves the > > > perpose perfectly well.

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-26 Thread Bartlomiej Zolnierkiewicz
On Wednesday 25 July 2007, Alan Cox wrote: > > pata_platform and ide_platform are carrying same driver names, > > to easily switch between these drivers, without need to touch > > platform code. > > > > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> > > Signed-off-by: Vitaly Bordug <[EMAIL PRO

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-26 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 25 July 2007, Vitaly Bordug wrote: > > This is now very similar to pata_platform.c, they both use > same platform data structure and same resources. > > To achieve that, byte_lanes_swapping platform data variable > and platform specified iops removed from that driver. It's fine

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-26 Thread Sergei Shtylyov
Hello. Guennadi Liakhovetski wrote: driver to using platform-device. I got a reply, that it's not worth it now that IDE is slowly becoming obsolete, and the pata_platform serves the perpose perfectly well. I found this argument reasonable, I had the same doubt, just wanted to double-check. So

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-26 Thread Guennadi Liakhovetski
On Wed, 25 Jul 2007, Alan Cox wrote: > > driver to using platform-device. I got a reply, that it's not worth it now > > that IDE is slowly becoming obsolete, and the pata_platform serves the > > perpose perfectly well. I found this argument reasonable, I had the same > > doubt, just wanted to d

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-25 Thread Alan Cox
> driver to using platform-device. I got a reply, that it's not worth it now > that IDE is slowly becoming obsolete, and the pata_platform serves the > perpose perfectly well. I found this argument reasonable, I had the same > doubt, just wanted to double-check. So, why do we now need a new lega

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-25 Thread Guennadi Liakhovetski
On Thu, 26 Jul 2007, Sergei Shtylyov wrote: > Guennadi Liakhovetski wrote: > > > > Wrong list to submit sych stuff, post to linux-ide. > > > Not entirely. The patch (or other patches in the series) would also touch > > ARM platforms in the mainline, currently using that driver. As I didn't >

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-25 Thread Sergei Shtylyov
Guennadi Liakhovetski wrote: This is now very similar to pata_platform.c, they both use same platform data structure and same resources. To achieve that, byte_lanes_swapping platform data variable and platform specified iops removed from that driver. It's fine, since those were never used any

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-25 Thread Guennadi Liakhovetski
On Wed, 25 Jul 2007, Sergei Shtylyov wrote: > Guennadi Liakhovetski wrote: > > > > This is now very similar to pata_platform.c, they both use > > > same platform data structure and same resources. > > > > To achieve that, byte_lanes_swapping platform data variable > > > and platform specified io

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-25 Thread Sergei Shtylyov
Guennadi Liakhovetski wrote: This is now very similar to pata_platform.c, they both use same platform data structure and same resources. To achieve that, byte_lanes_swapping platform data variable and platform specified iops removed from that driver. It's fine, since those were never used any

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-25 Thread Guennadi Liakhovetski
On Wed, 25 Jul 2007, Vitaly Bordug wrote: > > This is now very similar to pata_platform.c, they both use > same platform data structure and same resources. > > To achieve that, byte_lanes_swapping platform data variable > and platform specified iops removed from that driver. It's fine, > since t

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-25 Thread Sergei Shtylyov
Hello. Scott Wood wrote: +hwif->hw.io_ports[IDE_DATA_OFFSET] = port; + +port += (1 << pdata->ioport_shift); +for (i = IDE_ERROR_OFFSET; i <= IDE_STATUS_OFFSET; + i++, port += (1 << pdata->ioport_shift)) Looks like shift doesn't buy as anything, why not just use strid

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-25 Thread Scott Wood
Sergei Shtylyov wrote: + hwif->hw.io_ports[IDE_DATA_OFFSET] = port; + + port += (1 << pdata->ioport_shift); + for (i = IDE_ERROR_OFFSET; i <= IDE_STATUS_OFFSET; +i++, port += (1 << pdata->ioport_shift)) Looks like shift doesn't buy as anything, why not just us

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-25 Thread Sergei Shtylyov
Vitaly Bordug wrote: This is now very similar to pata_platform.c, they both use same platform data structure and same resources. To achieve that, byte_lanes_swapping platform data variable and platform specified iops removed from that driver. It's fine, since those were never used anyway.

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-25 Thread Kumar Gala
On Jul 25, 2007, at 11:53 AM, Vitaly Bordug wrote: This is now very similar to pata_platform.c, they both use same platform data structure and same resources. To achieve that, byte_lanes_swapping platform data variable and platform specified iops removed from that driver. It's fine, since tho

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-25 Thread Alan Cox
> pata_platform and ide_platform are carrying same driver names, > to easily switch between these drivers, without need to touch > platform code. > > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> > Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> - To

[PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-25 Thread Vitaly Bordug
This is now very similar to pata_platform.c, they both use same platform data structure and same resources. To achieve that, byte_lanes_swapping platform data variable and platform specified iops removed from that driver. It's fine, since those were never used anyway. pata_platform and ide_platf