Re: [PATCH 2/2] mmc: sdhci-of-aspeed: Fix clock divider calculation

2020-07-10 Thread Ulf Hansson
On Thu, 9 Jul 2020 at 21:57, Eddie James wrote: > > When calculating the clock divider, start dividing at 2 instead of 1. > The divider is divided by two at the end of the calculation, so starting > at 1 may result in a divider of 0, which shouldn't happen. > > Signed-off-by: Eddie James Applied

Re: [PATCH 2/2] mmc: sdhci-of-aspeed: Fix clock divider calculation

2020-07-10 Thread Andrew Jeffery
On Fri, 10 Jul 2020, at 17:09, Ulf Hansson wrote: > On Thu, 9 Jul 2020 at 21:57, Eddie James wrote: > > > > When calculating the clock divider, start dividing at 2 instead of 1. > > The divider is divided by two at the end of the calculation, so starting > > at 1 may result in a divider of 0, w

Re: [PATCH 2/2] mmc: sdhci-of-aspeed: Fix clock divider calculation

2020-07-10 Thread Ulf Hansson
On Thu, 9 Jul 2020 at 21:57, Eddie James wrote: > > When calculating the clock divider, start dividing at 2 instead of 1. > The divider is divided by two at the end of the calculation, so starting > at 1 may result in a divider of 0, which shouldn't happen. > > Signed-off-by: Eddie James Looks l

Re: [PATCH 2/2] mmc: sdhci-of-aspeed: Fix clock divider calculation

2020-07-09 Thread Adrian Hunter
On 9/07/20 10:57 pm, Eddie James wrote: > When calculating the clock divider, start dividing at 2 instead of 1. > The divider is divided by two at the end of the calculation, so starting > at 1 may result in a divider of 0, which shouldn't happen. > > Signed-off-by: Eddie James Acked-by: Adrian

Re: [PATCH 2/2] mmc: sdhci-of-aspeed: Fix clock divider calculation

2020-07-09 Thread Joel Stanley
On Fri, 10 Jul 2020 at 01:14, Andrew Jeffery wrote: > > > > On Fri, 10 Jul 2020, at 05:27, Eddie James wrote: > > When calculating the clock divider, start dividing at 2 instead of 1. > > The divider is divided by two at the end of the calculation, so starting > > at 1 may result in a divider of 0

Re: [PATCH 2/2] mmc: sdhci-of-aspeed: Fix clock divider calculation

2020-07-09 Thread Andrew Jeffery
On Fri, 10 Jul 2020, at 05:27, Eddie James wrote: > When calculating the clock divider, start dividing at 2 instead of 1. > The divider is divided by two at the end of the calculation, so starting > at 1 may result in a divider of 0, which shouldn't happen. > > Signed-off-by: Eddie James Revi

[PATCH 2/2] mmc: sdhci-of-aspeed: Fix clock divider calculation

2020-07-09 Thread Eddie James
When calculating the clock divider, start dividing at 2 instead of 1. The divider is divided by two at the end of the calculation, so starting at 1 may result in a divider of 0, which shouldn't happen. Signed-off-by: Eddie James --- drivers/mmc/host/sdhci-of-aspeed.c | 2 +- 1 file changed, 1 in