Namjae Jeon writes:
>> You have to think about compatibility with other FAT, not unix fs.
>
> Agreed, ctime is creation time, and there are comptability issues with
> the patch.
>
> But there is confusion about 'ctime' usage in the default code. When
> referring the code I found many instances
2012/11/15, OGAWA Hirofumi :
> Namjae Jeon writes:
>
>> 1)If we consider the code for FAT and MSDOS to be same with respect to
>> timing updates - there there is difference in code as mentioned below:
>> a) For:vfat_rmdir()
>> inode->i_mtime = inode->i_atime = CURRENT_TIME_SEC;
>>
2012/11/15, OGAWA Hirofumi hirof...@mail.parknet.co.jp:
Namjae Jeon linkinj...@gmail.com writes:
1)If we consider the code for FAT and MSDOS to be same with respect to
timing updates - there there is difference in code as mentioned below:
a) For:vfat_rmdir()
inode-i_mtime =
Namjae Jeon linkinj...@gmail.com writes:
You have to think about compatibility with other FAT, not unix fs.
Agreed, ctime is creation time, and there are comptability issues with
the patch.
But there is confusion about 'ctime' usage in the default code. When
referring the code I found many
Namjae Jeon writes:
> 1)If we consider the code for FAT and MSDOS to be same with respect to
> timing updates - there there is difference in code as mentioned below:
> a) For:vfat_rmdir()
> inode->i_mtime = inode->i_atime = CURRENT_TIME_SEC;
>For:msdos_rmdir()
>
2012/11/12, OGAWA Hirofumi :
> OGAWA Hirofumi writes:
>
>> Namjae Jeon writes:
>>
> What was difference with XFS, FAT, and MSDOS?
>>> Okay, the description of patch was lacked, So I will resend patch with
>>> specifical test reseult with other filesystem.
BTW, I recall I checked
2012/11/12, OGAWA Hirofumi hirof...@mail.parknet.co.jp:
OGAWA Hirofumi hirof...@mail.parknet.co.jp writes:
Namjae Jeon linkinj...@gmail.com writes:
What was difference with XFS, FAT, and MSDOS?
Okay, the description of patch was lacked, So I will resend patch with
specifical test reseult
Namjae Jeon linkinj...@gmail.com writes:
1)If we consider the code for FAT and MSDOS to be same with respect to
timing updates - there there is difference in code as mentioned below:
a) For:vfat_rmdir()
inode-i_mtime = inode-i_atime = CURRENT_TIME_SEC;
For:msdos_rmdir()
OGAWA Hirofumi writes:
> Namjae Jeon writes:
>
What was difference with XFS, FAT, and MSDOS?
>> Okay, the description of patch was lacked, So I will resend patch with
>> specifical test reseult with other filesystem.
>>>
>>> BTW, I recall I checked this, and yes, it is strange. But it is
Namjae Jeon writes:
>>> What was difference with XFS, FAT, and MSDOS?
> Okay, the description of patch was lacked, So I will resend patch with
> specifical test reseult with other filesystem.
>>
>> BTW, I recall I checked this, and yes, it is strange. But it is historical.
> "historical" means
2012/11/12, OGAWA Hirofumi :
> OGAWA Hirofumi writes:
>
>> Namjae Jeon writes:
>>
>>> 2012/11/12, OGAWA Hirofumi :
Namjae Jeon writes:
> Correctly update modification and status change time in case of
> file/directory removal and creation.
This changelog just explain
2012/11/12, OGAWA Hirofumi hirof...@mail.parknet.co.jp:
OGAWA Hirofumi hirof...@mail.parknet.co.jp writes:
Namjae Jeon linkinj...@gmail.com writes:
2012/11/12, OGAWA Hirofumi hirof...@mail.parknet.co.jp:
Namjae Jeon linkinj...@gmail.com writes:
Correctly update modification and status
Namjae Jeon linkinj...@gmail.com writes:
What was difference with XFS, FAT, and MSDOS?
Okay, the description of patch was lacked, So I will resend patch with
specifical test reseult with other filesystem.
BTW, I recall I checked this, and yes, it is strange. But it is historical.
historical
OGAWA Hirofumi hirof...@mail.parknet.co.jp writes:
Namjae Jeon linkinj...@gmail.com writes:
What was difference with XFS, FAT, and MSDOS?
Okay, the description of patch was lacked, So I will resend patch with
specifical test reseult with other filesystem.
BTW, I recall I checked this, and
OGAWA Hirofumi writes:
> Namjae Jeon writes:
>
>> 2012/11/12, OGAWA Hirofumi :
>>> Namjae Jeon writes:
>>>
Correctly update modification and status change time in case of
file/directory removal and creation.
>>>
>>> This changelog just explain "what", and it doesn't explain "why".
Namjae Jeon writes:
> 2012/11/12, OGAWA Hirofumi :
>> Namjae Jeon writes:
>>
>>> Correctly update modification and status change time in case of
>>> file/directory removal and creation.
>>
>> This changelog just explain "what", and it doesn't explain "why". Please
>> explain why we need this
2012/11/12, OGAWA Hirofumi :
> Namjae Jeon writes:
>
>> Correctly update modification and status change time in case of
>> file/directory removal and creation.
>
> This changelog just explain "what", and it doesn't explain "why". Please
> explain why we need this change.
>
> IIRC, timestamp
Namjae Jeon writes:
> Correctly update modification and status change time in case of
> file/directory removal and creation.
This changelog just explain "what", and it doesn't explain "why". Please
explain why we need this change.
IIRC, timestamp handling in FAT driver is strange historically.
Correctly update modification and status change time in case of
file/directory removal and creation.
Signed-off-by: Namjae Jeon
Signed-off-by: Amit Sahrawat
---
fs/fat/dir.c|2 +-
fs/fat/namei_vfat.c |6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git
Correctly update modification and status change time in case of
file/directory removal and creation.
Signed-off-by: Namjae Jeon linkinj...@gmail.com
Signed-off-by: Amit Sahrawat amit.sahrawa...@gmail.com
---
fs/fat/dir.c|2 +-
fs/fat/namei_vfat.c |6 +++---
2 files changed, 4
Namjae Jeon linkinj...@gmail.com writes:
Correctly update modification and status change time in case of
file/directory removal and creation.
This changelog just explain what, and it doesn't explain why. Please
explain why we need this change.
IIRC, timestamp handling in FAT driver is strange
2012/11/12, OGAWA Hirofumi hirof...@mail.parknet.co.jp:
Namjae Jeon linkinj...@gmail.com writes:
Correctly update modification and status change time in case of
file/directory removal and creation.
This changelog just explain what, and it doesn't explain why. Please
explain why we need this
Namjae Jeon linkinj...@gmail.com writes:
2012/11/12, OGAWA Hirofumi hirof...@mail.parknet.co.jp:
Namjae Jeon linkinj...@gmail.com writes:
Correctly update modification and status change time in case of
file/directory removal and creation.
This changelog just explain what, and it doesn't
OGAWA Hirofumi hirof...@mail.parknet.co.jp writes:
Namjae Jeon linkinj...@gmail.com writes:
2012/11/12, OGAWA Hirofumi hirof...@mail.parknet.co.jp:
Namjae Jeon linkinj...@gmail.com writes:
Correctly update modification and status change time in case of
file/directory removal and creation.
24 matches
Mail list logo
