Re: [BUG] jevents problem when cross building Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-16 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 16, 2020 at 11:41:10AM +, John Garry escreveu: > On 10/12/2020 19:57, John Garry wrote: > > Obviously I never tested building for one of test architectures which > > does not use PMU events - sorry! > Just wondering if you have had any more problems here? Shall I send a formal > p

Re: [BUG] jevents problem when cross building Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-16 Thread John Garry
On 10/12/2020 19:57, John Garry wrote: Hi Arnaldo, Can you try this on top: 8<- From 201aa2cb7bc8723765afd84a5d3972248af0f0a1 Mon Sep 17 00:00:00 2001 From: John Garry Date: Thu, 10 Dec 2020 19:45:14 + Subject: [PATCH] perf jevents: Add system events table for empty mapping For

Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-15 Thread Arnaldo Carvalho de Melo
Em Tue, Dec 15, 2020 at 05:18:38PM +0100, Jiri Olsa escreveu: > On Tue, Dec 15, 2020 at 01:03:32PM -0300, Arnaldo Carvalho de Melo wrote: > > I see it, but why not use the more natural ' ' space to separate the > > command from its arguments? Just like in a bash command line, say? > > I.e. why not

Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-15 Thread Jiri Olsa
On Tue, Dec 15, 2020 at 01:03:32PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Dec 15, 2020 at 04:24:20PM +0100, Jiri Olsa escreveu: > > On Tue, Dec 15, 2020 at 12:14:13PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Thu, Dec 10, 2020 at 09:43:29PM +0100, Jiri Olsa escreveu: > > > > Adding

Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-15 Thread Arnaldo Carvalho de Melo
Em Tue, Dec 15, 2020 at 04:24:20PM +0100, Jiri Olsa escreveu: > On Tue, Dec 15, 2020 at 12:14:13PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Thu, Dec 10, 2020 at 09:43:29PM +0100, Jiri Olsa escreveu: > > > Adding new control events to enable/disable specific event. > > > The interface string fo

Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-15 Thread Jiri Olsa
On Tue, Dec 15, 2020 at 12:14:13PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Dec 10, 2020 at 09:43:29PM +0100, Jiri Olsa escreveu: > > Adding new control events to enable/disable specific event. > > The interface string for control file are: > > > > 'enable-' > > 'disable-' > > Wwy do

Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-15 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 10, 2020 at 09:43:29PM +0100, Jiri Olsa escreveu: > Adding new control events to enable/disable specific event. > The interface string for control file are: > > 'enable-' > 'disable-' Wwy do we have "enable-" as the "tag" for this? Also is it possible to use "enable sched:*" and

[PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-10 Thread Jiri Olsa
Adding new control events to enable/disable specific event. The interface string for control file are: 'enable-' 'disable-' when received the command, perf will scan the current evlist for and if found it's enabled/disabled. Example session: terminal 1: # mkfifo control ack perf.pipe

Re: [BUG] jevents problem when cross building Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-10 Thread John Garry
On 10/12/2020 18:27, John Garry wrote: Its unpublished, I'll send it to the tmp.perf/core branch now. I use cross-compile for arm64 to build, and it's ok. I notice that the failures are for architectures which don't have an entry under pmu-events/arch, so maybe we're missing some 'weak' defi

Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-10 Thread Alexei Budankov
On 10.12.2020 21:20, Alexei Budankov wrote: > > On 10.12.2020 21:06, Jiri Olsa wrote: >> On Thu, Dec 10, 2020 at 05:24:30PM +0100, Jiri Olsa wrote: >>> On Mon, Dec 07, 2020 at 08:02:20PM +0300, Alexei Budankov wrote: Hi, On 06.12.2020 20:05, Jiri Olsa wrote: > Adding new cont

Re: [BUG] jevents problem when cross building Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-10 Thread John Garry
On 10/12/2020 18:17, Arnaldo Carvalho de Melo wrote: So symbol 'pmu_sys_event_tables' is introduced inhttps://lore.kernel.org/linux-arm-kernel/1607080216-36968-3-git-send-email-john.ga...@huawei.com/, but I did not think that you picked any of this series up yet, right? I checked your perf/core

Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-10 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 10, 2020 at 09:20:42PM +0300, Alexei Budankov escreveu: > > On 10.12.2020 21:06, Jiri Olsa wrote: > > On Thu, Dec 10, 2020 at 05:24:30PM +0100, Jiri Olsa wrote: > >> On Mon, Dec 07, 2020 at 08:02:20PM +0300, Alexei Budankov wrote: > >>> Hi, > >>> > >>> On 06.12.2020 20:05, Jiri Olsa wr

Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-10 Thread Alexei Budankov
On 10.12.2020 21:06, Jiri Olsa wrote: > On Thu, Dec 10, 2020 at 05:24:30PM +0100, Jiri Olsa wrote: >> On Mon, Dec 07, 2020 at 08:02:20PM +0300, Alexei Budankov wrote: >>> Hi, >>> >>> On 06.12.2020 20:05, Jiri Olsa wrote: Adding new control events to enable/disable specific event. The in

Re: [BUG] jevents problem when cross building Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-10 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 10, 2020 at 05:44:51PM +, John Garry escreveu: > > > > > > > > + evsel_name = cmd_data + > > > > > > > sizeof(EVLIST_CTL_CMD_ENABLE_EVSEL_TAG) - 1; > > > > > > > > > It makes sense to check that evsel_name still points > > > > > > into cmd_data buffer afte

Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-10 Thread Jiri Olsa
On Thu, Dec 10, 2020 at 05:24:30PM +0100, Jiri Olsa wrote: > On Mon, Dec 07, 2020 at 08:02:20PM +0300, Alexei Budankov wrote: > > Hi, > > > > On 06.12.2020 20:05, Jiri Olsa wrote: > > > Adding new control events to enable/disable specific event. > > > The interface string for control file are: > >

Re: [BUG] jevents problem when cross building Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-10 Thread John Garry
+ evsel_name = cmd_data + sizeof(EVLIST_CTL_CMD_ENABLE_EVSEL_TAG) - 1; It makes sense to check that evsel_name still points into cmd_data buffer after assigning to event name. right, will add that So, I'm finishing test builds, so probably I'll push the

[BUG] jevents problem when cross building Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-10 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 10, 2020 at 02:19:03PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Dec 10, 2020 at 02:15:03PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Thu, Dec 10, 2020 at 05:24:30PM +0100, Jiri Olsa escreveu: > > > On Mon, Dec 07, 2020 at 08:02:20PM +0300, Alexei Budankov wrote: > > >

Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-10 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 10, 2020 at 02:15:03PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Dec 10, 2020 at 05:24:30PM +0100, Jiri Olsa escreveu: > > On Mon, Dec 07, 2020 at 08:02:20PM +0300, Alexei Budankov wrote: > > > On 06.12.2020 20:05, Jiri Olsa wrote: > > > > @@ -1952,6 +1958,8 @@ int evlist__ctl

Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-10 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 10, 2020 at 05:24:30PM +0100, Jiri Olsa escreveu: > On Mon, Dec 07, 2020 at 08:02:20PM +0300, Alexei Budankov wrote: > > Hi, > > > > On 06.12.2020 20:05, Jiri Olsa wrote: > > > Adding new control events to enable/disable specific event. > > > The interface string for control file are:

Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-10 Thread Jiri Olsa
On Mon, Dec 07, 2020 at 08:02:20PM +0300, Alexei Budankov wrote: > Hi, > > On 06.12.2020 20:05, Jiri Olsa wrote: > > Adding new control events to enable/disable specific event. > > The interface string for control file are: > > > > 'enable-' > > 'disable-' > > > > > > > when received the

Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-07 Thread Alexei Budankov
Hi, On 06.12.2020 20:05, Jiri Olsa wrote: > Adding new control events to enable/disable specific event. > The interface string for control file are: > > 'enable-' > 'disable-' > > when received the command, perf will scan the current evlist > for and if found it's enabled/disabled. >

[PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-06 Thread Jiri Olsa
Adding new control events to enable/disable specific event. The interface string for control file are: 'enable-' 'disable-' when received the command, perf will scan the current evlist for and if found it's enabled/disabled. Example session: terminal 1: # mkfifo control ack perf.pipe