Re: [PATCH 3/7] Input: libps2 - use BIT() for bitmask constants

2018-01-19 Thread Dmitry Torokhov
On Fri, Jan 19, 2018 at 02:26:20PM -0800, Randy Dunlap wrote: > On 01/19/2018 11:41 AM, Dmitry Torokhov wrote: > > Let's explicitly document bit numbers with BIT() macro. > > > > Signed-off-by: Dmitry Torokhov > > Makes sense, but something should > #include Indeed, I'll add it, thanks. > >

Re: [PATCH 3/7] Input: libps2 - use BIT() for bitmask constants

2018-01-19 Thread Randy Dunlap
On 01/19/2018 11:41 AM, Dmitry Torokhov wrote: > Let's explicitly document bit numbers with BIT() macro. > > Signed-off-by: Dmitry Torokhov Makes sense, but something should #include per Documentation/process/submit-checklist.rst Rule #1: 1) If you use a facility then #include the file that de

[PATCH 3/7] Input: libps2 - use BIT() for bitmask constants

2018-01-19 Thread Dmitry Torokhov
Let's explicitly document bit numbers with BIT() macro. Signed-off-by: Dmitry Torokhov --- include/linux/libps2.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/linux/libps2.h b/include/linux/libps2.h index 365c50b097ded..649295a5ff47d 100644 --- a/include