From: Girish Mahadevan
This driver supports GENI based SPI Controller in the Qualcomm SOCs. The
Qualcomm Generic Interface (GENI) is a programmable module supporting a
wide range of serial interfaces including SPI. This driver supports SPI
operations using FIFO mode of transfer.
Signed-off-by: G
Hi,
On Wed, Oct 3, 2018 at 6:45 AM Alok Chauhan wrote:
> +static irqreturn_t geni_spi_isr(int irq, void *data)
> +{
> + struct spi_master *spi = data;
> + struct spi_geni_master *mas = spi_master_get_devdata(spi);
> + struct geni_se *se = &mas->se;
> + u32 m_irq;
> +
Quoting Doug Anderson (2018-10-08 16:52:36)
> Hi,
>
> On Mon, Oct 8, 2018 at 4:43 PM Stephen Boyd wrote:
> > > + mas->irq = platform_get_irq(pdev, 0);
> > > + if (mas->irq < 0) {
> > > + ret = mas->irq;
> > > + dev_err(&pdev->dev, "Err getting IRQ %d\n", re
Hi,
On Tue, Oct 9, 2018 at 9:12 AM Stephen Boyd wrote:
>
> Quoting Doug Anderson (2018-10-08 16:52:36)
> > Hi,
> >
> > On Mon, Oct 8, 2018 at 4:43 PM Stephen Boyd wrote:
> > > > + mas->irq = platform_get_irq(pdev, 0);
> > > > + if (mas->irq < 0) {
> > > > + ret = mas->i
Quoting Doug Anderson (2018-10-09 10:48:55)
>
> Ah, you're suggesting separating the platform_get_irq() and the
> request_irq() so that we call platform_get_irq() as the first thing in
> the function but don't do the request_irq() until later. Yeah, that
> could be done and I guess if you feel st
Hi,
On Tue, Oct 9, 2018 at 12:45 PM Stephen Boyd wrote:
>
> Quoting Doug Anderson (2018-10-09 10:48:55)
> >
> > Ah, you're suggesting separating the platform_get_irq() and the
> > request_irq() so that we call platform_get_irq() as the first thing in
> > the function but don't do the request_irq()
Quoting Doug Anderson (2018-10-09 14:18:26)
> Hi,
> On Tue, Oct 9, 2018 at 12:45 PM Stephen Boyd wrote:
> >
> > Quoting Doug Anderson (2018-10-09 10:48:55)
> > >
> > > Ah, you're suggesting separating the platform_get_irq() and the
> > > request_irq() so that we call platform_get_irq() as the firs
+static irqreturn_t geni_spi_isr(int irq, void *data)
+{
+ struct spi_master *spi = data;
+ struct spi_geni_master *mas = spi_master_get_devdata(spi);
+ struct geni_se *se = &mas->se;
+ u32 m_irq;
+ unsigned long flags;
+ irqreturn_t ret = IRQ_HANDLED;
+
+
Quoting Alok Chauhan (2018-10-03 06:44:25)
>
I just have a handful of nitpicks which can be fixed later in
follow-ups. Otherwise:
Reviewed-by: Stephen Boyd
> diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c
> new file mode 100644
> index 000..6432ecc
> --- /dev/null
>
Hi,
On Mon, Oct 8, 2018 at 4:43 PM Stephen Boyd wrote:
> > + mas->irq = platform_get_irq(pdev, 0);
> > + if (mas->irq < 0) {
> > + ret = mas->irq;
> > + dev_err(&pdev->dev, "Err getting IRQ %d\n", ret);
> > + goto spi_geni_probe_runtime_disabl
10 matches
Mail list logo
