RE: [EXT] Re: [PATCH net-next 10/13] net: mvpp2: reset the XPCS while reconfiguring the serdes lanes

2019-02-18 Thread Stefan Chulski
hevall...@bootlin.com; > gregory.clem...@bootlin.com; miquel.ray...@bootlin.com; Nadav Haklai > ; Yan Markman ; > m...@semihalf.com > Subject: Re: [EXT] Re: [PATCH net-next 10/13] net: mvpp2: reset the XPCS > while reconfiguring the serdes lanes > > Hi Stefan, > >

Re: [EXT] Re: [PATCH net-next 10/13] net: mvpp2: reset the XPCS while reconfiguring the serdes lanes

2019-02-18 Thread Russell King - ARM Linux admin
Hi Stefan, On Mon, Feb 18, 2019 at 11:08:34AM +, Stefan Chulski wrote: > HW recommendation upon Serdes reconfiguration are the following: > > 1. Disable port(CTRL0_REG - in XLG/GMAC) > 2. Put port in reset (both XLG/GMAC) > 3. For KR - put in reset MPCS (MAC control clock, RX SD clock, TX

RE: [EXT] Re: [PATCH net-next 10/13] net: mvpp2: reset the XPCS while reconfiguring the serdes lanes

2019-02-18 Thread Stefan Chulski
hevall...@bootlin.com; > gregory.clem...@bootlin.com; miquel.ray...@bootlin.com; Nadav Haklai > ; Stefan Chulski ; Yan > Markman ; m...@semihalf.com > Subject: [EXT] Re: [PATCH net-next 10/13] net: mvpp2: reset the XPCS while > reconfiguring

Re: [PATCH net-next 10/13] net: mvpp2: reset the XPCS while reconfiguring the serdes lanes

2019-02-18 Thread Antoine Tenart
Russell, On Mon, Feb 18, 2019 at 10:47:57AM +, Russell King - ARM Linux admin wrote: > > Another case that needs to be considered: if the XPCS should be placed > into reset while reconfiguring the serdes lanes, is the same treatment > needed for the GMAC? That's something I wanted to check

Re: [PATCH net-next 10/13] net: mvpp2: reset the XPCS while reconfiguring the serdes lanes

2019-02-18 Thread Antoine Tenart
Russell, On Mon, Feb 18, 2019 at 10:43:02AM +, Russell King - ARM Linux admin wrote: > On Mon, Feb 18, 2019 at 11:26:30AM +0100, Antoine Tenart wrote: > > On Fri, Feb 15, 2019 at 05:12:24PM +, Russell King - ARM Linux admin > > wrote: > > > On Fri, Feb 15, 2019 at 04:32:38PM +0100,

Re: [PATCH net-next 10/13] net: mvpp2: reset the XPCS while reconfiguring the serdes lanes

2019-02-18 Thread Russell King - ARM Linux admin
On Mon, Feb 18, 2019 at 10:43:02AM +, Russell King - ARM Linux admin wrote: > On Mon, Feb 18, 2019 at 11:26:30AM +0100, Antoine Tenart wrote: > > Hi Russell, > > > > On Fri, Feb 15, 2019 at 05:12:24PM +, Russell King - ARM Linux admin > > wrote: > > > On Fri, Feb 15, 2019 at 04:32:38PM

Re: [PATCH net-next 10/13] net: mvpp2: reset the XPCS while reconfiguring the serdes lanes

2019-02-18 Thread Russell King - ARM Linux admin
On Mon, Feb 18, 2019 at 11:26:30AM +0100, Antoine Tenart wrote: > Hi Russell, > > On Fri, Feb 15, 2019 at 05:12:24PM +, Russell King - ARM Linux admin > wrote: > > On Fri, Feb 15, 2019 at 04:32:38PM +0100, Antoine Tenart wrote: > > > The documentation advises to set the XPCS in reset while

Re: [PATCH net-next 10/13] net: mvpp2: reset the XPCS while reconfiguring the serdes lanes

2019-02-18 Thread Antoine Tenart
Hi Russell, On Fri, Feb 15, 2019 at 05:12:24PM +, Russell King - ARM Linux admin wrote: > On Fri, Feb 15, 2019 at 04:32:38PM +0100, Antoine Tenart wrote: > > The documentation advises to set the XPCS in reset while reconfiguring > > the serdes lanes. This seems to be a good thing to do, but

RE: [PATCH net-next 10/13] net: mvpp2: reset the XPCS while reconfiguring the serdes lanes

2019-02-15 Thread Stefan Chulski
> On Fri, Feb 15, 2019 at 04:32:38PM +0100, Antoine Tenart wrote: > > The documentation advises to set the XPCS in reset while reconfiguring > > the serdes lanes. This seems to be a good thing to do, but the PPv2 > > driver wasn't doing it. This patch fixes it. > > Hmm. That statment seems to

Re: [PATCH net-next 10/13] net: mvpp2: reset the XPCS while reconfiguring the serdes lanes

2019-02-15 Thread Russell King - ARM Linux admin
On Fri, Feb 15, 2019 at 04:32:38PM +0100, Antoine Tenart wrote: > The documentation advises to set the XPCS in reset while reconfiguring > the serdes lanes. This seems to be a good thing to do, but the PPv2 > driver wasn't doing it. This patch fixes it. Hmm. That statment seems to have some

[PATCH net-next 10/13] net: mvpp2: reset the XPCS while reconfiguring the serdes lanes

2019-02-15 Thread Antoine Tenart
The documentation advises to set the XPCS in reset while reconfiguring the serdes lanes. This seems to be a good thing to do, but the PPv2 driver wasn't doing it. This patch fixes it. Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 1 +