Re: [PATCH net-next 4/7] net: dsa: free orig skb on rcv if reallocated

On Tue, May 30, 2017 at 11:41:51AM -0400, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > > On Tue, May 30, 2017 at 10:21:28AM -0400, Vivien Didelot wrote: > >> If the receive function of a tagger reallocated the SKB, the original > >> SKB is currently not freed. Fix this and free

Re: [PATCH net-next 4/7] net: dsa: free orig skb on rcv if reallocated

Hi Andrew, Andrew Lunn writes: > On Tue, May 30, 2017 at 10:21:28AM -0400, Vivien Didelot wrote: >> If the receive function of a tagger reallocated the SKB, the original >> SKB is currently not freed. Fix this and free it on both copy or error. > > I don't see any of the receive functions reallo

Re: [PATCH net-next 4/7] net: dsa: free orig skb on rcv if reallocated

On Tue, May 30, 2017 at 10:21:28AM -0400, Vivien Didelot wrote: > If the receive function of a tagger reallocated the SKB, the original > SKB is currently not freed. Fix this and free it on both copy or error. I don't see any of the receive functions reallocate the skb. It might be better to just

[PATCH net-next 4/7] net: dsa: free orig skb on rcv if reallocated

If the receive function of a tagger reallocated the SKB, the original SKB is currently not freed. Fix this and free it on both copy or error. Signed-off-by: Vivien Didelot --- net/dsa/dsa.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c ind