Re: [PATCH net-next v2 3/3] net: phy: broadcom: Allow BCM54210E to configure APD

2021-03-05 Thread Florian Fainelli
On 3/4/2021 5:08 PM, Vladimir Oltean wrote: > On Tue, Mar 02, 2021 at 07:37:34PM -0800, Florian Fainelli wrote: >> Took a while but for the 54210E reference board here are the numbers, >> your mileage will vary depending on the supplies, regulator efficiency >> and PCB design around the PHY obvi

Re: [PATCH net-next v2 3/3] net: phy: broadcom: Allow BCM54210E to configure APD

2021-03-04 Thread Vladimir Oltean
On Tue, Mar 02, 2021 at 07:37:34PM -0800, Florian Fainelli wrote: > Took a while but for the 54210E reference board here are the numbers, > your mileage will vary depending on the supplies, regulator efficiency > and PCB design around the PHY obviously: > > BMCR.PDOWN: 86.12 mW >

Re: [PATCH net-next v2 3/3] net: phy: broadcom: Allow BCM54210E to configure APD

2021-03-03 Thread Florian Fainelli
On 2/14/2021 8:29 PM, Florian Fainelli wrote: > > > On 2/13/2021 2:42 AM, Vladimir Oltean wrote: >> On Fri, Feb 12, 2021 at 07:46:32PM -0800, Florian Fainelli wrote: >>> BCM54210E/BCM50212E has been verified to work correctly with the >>> auto-power down configuration done by bcm54xx_adjust_rx

Re: [PATCH net-next v2 3/3] net: phy: broadcom: Allow BCM54210E to configure APD

2021-02-14 Thread Florian Fainelli
On 2/13/2021 2:42 AM, Vladimir Oltean wrote: > On Fri, Feb 12, 2021 at 07:46:32PM -0800, Florian Fainelli wrote: >> BCM54210E/BCM50212E has been verified to work correctly with the >> auto-power down configuration done by bcm54xx_adjust_rxrefclk(), add it >> to the list of PHYs working. >> >> Wh

Re: [PATCH net-next v2 3/3] net: phy: broadcom: Allow BCM54210E to configure APD

2021-02-13 Thread Vladimir Oltean
On Fri, Feb 12, 2021 at 07:46:32PM -0800, Florian Fainelli wrote: > BCM54210E/BCM50212E has been verified to work correctly with the > auto-power down configuration done by bcm54xx_adjust_rxrefclk(), add it > to the list of PHYs working. > > While we are at it, provide an appropriate name for the

[PATCH net-next v2 3/3] net: phy: broadcom: Allow BCM54210E to configure APD

2021-02-12 Thread Florian Fainelli
BCM54210E/BCM50212E has been verified to work correctly with the auto-power down configuration done by bcm54xx_adjust_rxrefclk(), add it to the list of PHYs working. While we are at it, provide an appropriate name for the bit we are changing which disables the RXC and TXC during auto-power down wh