Re: [PATCH v2] sched/deadline: remove useless param from setup_new_dl_entity

2016-07-08 Thread Juri Lelli
On 07/07/16 09:47, Steven Rostedt wrote: > On Thu, 7 Jul 2016 09:39:09 +0100 > Juri Lelli wrote: > > > > > Having a better look at this is in my TODO list... But I still need to > > > find some time :) > > > > > > > Same here. No spare cycles right now to have a thorough look at this. :( >

Re: [PATCH v2] sched/deadline: remove useless param from setup_new_dl_entity

2016-07-07 Thread Steven Rostedt
On Thu, 7 Jul 2016 09:39:09 +0100 Juri Lelli wrote: > > Having a better look at this is in my TODO list... But I still need to > > find some time :) > > > > Same here. No spare cycles right now to have a thorough look at this. :( All in all, this should not hold up the current patch set. M

Re: [PATCH v2] sched/deadline: remove useless param from setup_new_dl_entity

2016-07-07 Thread Juri Lelli
On 06/07/16 10:44, Luca Abeni wrote: > On Tue, 5 Jul 2016 17:58:30 +0100 > Juri Lelli wrote: > > > On 05/07/16 12:47, Steven Rostedt wrote: > > > On Tue, 5 Jul 2016 15:39:33 +0100 > > > Juri Lelli wrote: > > > > > > return; > > > > > > > > > > > > /* > > > > > > +* Use the

Re: [PATCH v2] sched/deadline: remove useless param from setup_new_dl_entity

2016-07-06 Thread luca abeni
On Tue, 5 Jul 2016 10:20:13 -0400 Steven Rostedt wrote: > On Wed, 29 Jun 2016 20:07:43 +0100 > Juri Lelli wrote: > > > > --- > > kernel/sched/deadline.c | 14 +++--- > > 1 file changed, 11 insertions(+), 3 deletions(-) > > > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadl

Re: [PATCH v2] sched/deadline: remove useless param from setup_new_dl_entity

2016-07-06 Thread luca abeni
On Tue, 5 Jul 2016 17:58:30 +0100 Juri Lelli wrote: > On 05/07/16 12:47, Steven Rostedt wrote: > > On Tue, 5 Jul 2016 15:39:33 +0100 > > Juri Lelli wrote: > > > > return; > > > > > > > > > > /* > > > > > + * Use the scheduling parameters of the top > > > > > pi-waiter

Re: [PATCH v2] sched/deadline: remove useless param from setup_new_dl_entity

2016-07-05 Thread Juri Lelli
On 05/07/16 12:47, Steven Rostedt wrote: > On Tue, 5 Jul 2016 15:39:33 +0100 > Juri Lelli wrote: > > return; > > > > > > > > /* > > > > +* Use the scheduling parameters of the top pi-waiter task, > > > > +* if we have one from which we can inherit a deadlin

Re: [PATCH v2] sched/deadline: remove useless param from setup_new_dl_entity

2016-07-05 Thread Steven Rostedt
On Tue, 5 Jul 2016 15:39:33 +0100 Juri Lelli wrote: return; > > > > > > /* > > > + * Use the scheduling parameters of the top pi-waiter task, > > > + * if we have one from which we can inherit a deadline. > > > + */ > > > + if (pi_task && dl_se->dl_boosted && dl_prio(pi_tas

Re: [PATCH v2] sched/deadline: remove useless param from setup_new_dl_entity

2016-07-05 Thread Juri Lelli
On 05/07/16 10:20, Steven Rostedt wrote: > On Wed, 29 Jun 2016 20:07:43 +0100 > Juri Lelli wrote: > > > > --- > > kernel/sched/deadline.c | 14 +++--- > > 1 file changed, 11 insertions(+), 3 deletions(-) > > > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > > index f

Re: [PATCH v2] sched/deadline: remove useless param from setup_new_dl_entity

2016-07-05 Thread Steven Rostedt
On Wed, 29 Jun 2016 20:07:43 +0100 Juri Lelli wrote: > --- > kernel/sched/deadline.c | 14 +++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > index fcb7f0217ff4..2000ad2294d5 100644 > --- a/kernel/sched/deadlin

Re: [PATCH v2] sched/deadline: remove useless param from setup_new_dl_entity

2016-07-05 Thread Juri Lelli
On 05/07/16 15:37, Wanpeng Li wrote: > 2016-06-30 3:07 GMT+08:00 Juri Lelli : > > setup_new_dl_entity() takes two parameters, but it only actually uses > > one of them, under a different name, to setup a new dl_entity, after: > > > > 2f9f3fdc928 "sched/deadline: Remove dl_new from struct sched_dl_

Re: [PATCH v2] sched/deadline: remove useless param from setup_new_dl_entity

2016-07-05 Thread Wanpeng Li
2016-06-30 3:07 GMT+08:00 Juri Lelli : > setup_new_dl_entity() takes two parameters, but it only actually uses > one of them, under a different name, to setup a new dl_entity, after: > > 2f9f3fdc928 "sched/deadline: Remove dl_new from struct sched_dl_entity" > > as we currently do > > setup_new_d

Re: [PATCH v2] sched/deadline: remove useless param from setup_new_dl_entity

2016-07-04 Thread Juri Lelli
On 04/07/16 11:03, Luca Abeni wrote: > Hi Juri, > > On Wed, 29 Jun 2016 20:07:43 +0100 > Juri Lelli wrote: > > > setup_new_dl_entity() takes two parameters, but it only actually uses > > one of them, under a different name, to setup a new dl_entity, after: > > > > 2f9f3fdc928 "sched/deadline:

Re: [PATCH v2] sched/deadline: remove useless param from setup_new_dl_entity

2016-07-04 Thread luca abeni
Hi Juri, On Wed, 29 Jun 2016 20:07:43 +0100 Juri Lelli wrote: > setup_new_dl_entity() takes two parameters, but it only actually uses > one of them, under a different name, to setup a new dl_entity, after: > > 2f9f3fdc928 "sched/deadline: Remove dl_new from struct > sched_dl_entity" > > as we

[PATCH v2] sched/deadline: remove useless param from setup_new_dl_entity

2016-06-29 Thread Juri Lelli
setup_new_dl_entity() takes two parameters, but it only actually uses one of them, under a different name, to setup a new dl_entity, after: 2f9f3fdc928 "sched/deadline: Remove dl_new from struct sched_dl_entity" as we currently do setup_new_dl_entity(&p->dl, &p->dl) However, before Luca's cha