Re: [PATCH v2 2/2] ASoC: codecs: pcm186x: Fix energysense SLEEP bit

2019-02-20 Thread Mark Brown
On Tue, Feb 19, 2019 at 11:06:48AM -0600, Andrew F. Davis wrote: > Did this work for you before? Strange it would if reversed, I wonder if > the SLEEP bit is really doing anything here. Can investigate later, for > this patch: Thinking about it some more I'm wondering if it gets overridden by

Re: [PATCH v2 2/2] ASoC: codecs: pcm186x: Fix energysense SLEEP bit

2019-02-20 Thread Mark Brown
On Tue, Feb 19, 2019 at 04:29:28PM +, codrin.ciubota...@microchip.com wrote: > The ADCs are sleeping when the SLEEP bit is set and running when it's > cleared, so the bit should be inverted. > Tested on pcm1863. This definitely seems to be the case from the datasheet but... > @@ -184,8

Re: [PATCH v2 2/2] ASoC: codecs: pcm186x: Fix energysense SLEEP bit

2019-02-20 Thread Codrin.Ciubotariu
On 19.02.2019 19:06, Andrew F. Davis wrote: > On 2/19/19 10:29 AM, codrin.ciubota...@microchip.com wrote: >> From: Codrin Ciubotariu >> >> The ADCs are sleeping when the SLEEP bit is set and running when it's >> cleared, so the bit should be inverted. >> Tested on pcm1863. >> > > Did this work

Re: [PATCH v2 2/2] ASoC: codecs: pcm186x: Fix energysense SLEEP bit

2019-02-19 Thread Andrew F. Davis
On 2/19/19 10:29 AM, codrin.ciubota...@microchip.com wrote: > From: Codrin Ciubotariu > > The ADCs are sleeping when the SLEEP bit is set and running when it's > cleared, so the bit should be inverted. > Tested on pcm1863. > Did this work for you before? Strange it would if reversed, I wonder

[PATCH v2 2/2] ASoC: codecs: pcm186x: Fix energysense SLEEP bit

2019-02-19 Thread Codrin.Ciubotariu
From: Codrin Ciubotariu The ADCs are sleeping when the SLEEP bit is set and running when it's cleared, so the bit should be inverted. Tested on pcm1863. Signed-off-by: Codrin Ciubotariu --- Changes in v2: - none; sound/soc/codecs/pcm186x.c | 6 +++--- 1 file changed, 3 insertions(+), 3