Bowman, Casey G
> ; Mani, Rajmohan
>
> Subject: Re: [PATCH v2 2/2] platform/chrome: cros_ec_typec: Avoid setting
> usb role during disconnect
>
> Hi,
>
> On Thu, Aug 06, 2020 at 11:39:08AM -0700, Prashant Malani wrote:
> > I would suggest:
> >
Hi,
On Thu, Aug 06, 2020 at 11:39:08AM -0700, Prashant Malani wrote:
> I would suggest:
> - Merging Patch 1 (role set correction) and Patch 2 (moving the
> usb_role_switch_set_role() inside cros_typec_configure_mux()
> *but* keep it at the end to preserve existing ordering) into 1 patch.
> - Add
Hi Heikki,
On Thu, Aug 6, 2020 at 4:39 AM Heikki Krogerus
wrote:
>
> On Wed, Aug 05, 2020 at 12:37:14PM -0700, Prashant Malani wrote:
> > Hi Azhar,
> >
> >
> > On Wed, Aug 5, 2020 at 12:22 PM Shaikh, Azhar
> > wrote:
> > >
> > > Hi Prashant,
> > >
> > > > Is this documented anywhere? Kindly
On Wed, Aug 05, 2020 at 12:37:14PM -0700, Prashant Malani wrote:
> Hi Azhar,
>
>
> On Wed, Aug 5, 2020 at 12:22 PM Shaikh, Azhar wrote:
> >
> > Hi Prashant,
> >
> > > Is this documented anywhere? Kindly provide the links to that if so. I
> > > wasn't
> > > aware of any ordering requirements
Hi,
On Wed, Aug 05, 2020 at 08:28:22PM +, Shaikh, Azhar wrote:
> Hi Prashant,
>
> > >
> > > Hi Prashant,
> > >
> > > > Is this documented anywhere? Kindly provide the links to that if so.
> > > > I wasn't aware of any ordering requirements (but I may be missing
> > something).
> > >
> > >
com; Patel, Utkarsh H
> ; Bowman, Casey G
> ; Mani, Rajmohan
>
> Subject: Re: [PATCH v2 2/2] platform/chrome: cros_ec_typec: Avoid setting
> usb role during disconnect
>
> Hi Azhar,
>
>
> On Wed, Aug 5, 2020 at 12:22 PM Shaikh, Azhar
> wrote:
> >
> >
Hi Azhar,
On Wed, Aug 5, 2020 at 12:22 PM Shaikh, Azhar wrote:
>
> Hi Prashant,
>
> > Is this documented anywhere? Kindly provide the links to that if so. I
> > wasn't
> > aware of any ordering requirements (but I may be missing something).
>
> The configuration of the connector should always
com; Patel, Utkarsh H
> ; Bowman, Casey G
> ; Mani, Rajmohan
>
> Subject: Re: [PATCH v2 2/2] platform/chrome: cros_ec_typec: Avoid setting
> usb role during disconnect
>
> Hey Azhar,
>
> On Thu, Jul 30, 2020 at 11:06:12PM +, Shaikh, Azhar wrote:
> > Hi Pras
Hey Azhar,
On Thu, Jul 30, 2020 at 11:06:12PM +, Shaikh, Azhar wrote:
> Hi Prashant,
> >
> > Since this was the last switch being configured, please maintain the same
> > order and add this at the end of the function, after the if-else if block.
> >
>
> Please correct if my understanding
com; Patel, Utkarsh H
> ; Bowman, Casey G
> ; Mani, Rajmohan
>
> Subject: Re: [PATCH v2 2/2] platform/chrome: cros_ec_typec: Avoid setting
> usb role during disconnect
>
> Hi Azhar,
>
> On Thu, Jul 30, 2020 at 03:56:09PM -0700, Azhar Shaikh wrote:
> > On disconne
Hi Azhar,
On Thu, Jul 30, 2020 at 03:56:09PM -0700, Azhar Shaikh wrote:
> On disconnect port partner is removed and usb role is set to NONE.
> But then in cros_typec_port_update() the role is set again.
> Avoid this by moving usb_role_switch_set_role() to
> cros_typec_configure_mux().
>
>
On disconnect port partner is removed and usb role is set to NONE.
But then in cros_typec_port_update() the role is set again.
Avoid this by moving usb_role_switch_set_role() to
cros_typec_configure_mux().
Signed-off-by: Azhar Shaikh
Suggested-by: Prashant Malani
---
12 matches
Mail list logo
