Re: [PATCH v3 2/3] cgroup: revise how we re-populate root directory

2012-07-18 Thread Tejun Heo
Hello, On Wed, Jul 18, 2012 at 10:16:05AM -0400, Aristeu Rozanski wrote: > > Yeah, generally looks good to me although @added/removed_bits argument > > names irk me a bit. The name may be okay for local variables but I > > keep thinking "what bits?". @subsys_mask or something indicating that > >

Re: [PATCH v3 2/3] cgroup: revise how we re-populate root directory

2012-07-18 Thread Aristeu Rozanski
Hi Tejun, On Tue, Jul 17, 2012 at 02:40:10PM -0700, Tejun Heo wrote: > On Tue, Jul 17, 2012 at 05:29:27PM -0400, Aristeu Rozanski wrote: > > what about this version: > > Yeah, generally looks good to me although @added/removed_bits argument > names irk me a bit. The name may be okay for local var

Re: [PATCH v3 2/3] cgroup: revise how we re-populate root directory

2012-07-17 Thread Tejun Heo
Hello, On Tue, Jul 17, 2012 at 05:29:27PM -0400, Aristeu Rozanski wrote: > what about this version: Yeah, generally looks good to me although @added/removed_bits argument names irk me a bit. The name may be okay for local variables but I keep thinking "what bits?". @subsys_mask or something ind

Re: [PATCH v3 2/3] cgroup: revise how we re-populate root directory

2012-07-17 Thread Aristeu Rozanski
On Tue, Jul 17, 2012 at 11:38:51AM -0700, Tejun Heo wrote: > Hello, > > Sorry about the delay. no worries, thanks for doing this > On Tue, Jul 10, 2012 at 03:27:22PM -0400, Aristeu Rozanski wrote: > > Index: xattr/include/linux/cgroup.h > > ===

Re: [PATCH v3 2/3] cgroup: revise how we re-populate root directory

2012-07-17 Thread Tejun Heo
Hello, Sorry about the delay. On Tue, Jul 10, 2012 at 03:27:22PM -0400, Aristeu Rozanski wrote: > Index: xattr/include/linux/cgroup.h > === > --- xattr.orig/include/linux/cgroup.h 2012-07-03 15:43:43.404334484 -0400 > +++ xattr/inclu

Re: [PATCH v3 2/3] cgroup: revise how we re-populate root directory

2012-07-17 Thread Aristeu Rozanski
Hi Tejun, On Tue, Jul 10, 2012 at 03:27:22PM -0400, Aristeu Rozanski wrote: > Hi Tejun, > On Mon, Jul 09, 2012 at 10:28:31AM -0700, Tejun Heo wrote: > > On Mon, Jul 09, 2012 at 10:22:20AM -0700, Tejun Heo wrote: > > > > Changing subsys_bits via remount is being deprecated. No need to > > > > worry

Re: [PATCH v3 2/3] cgroup: revise how we re-populate root directory

2012-07-10 Thread Aristeu Rozanski
Hi Tejun, On Mon, Jul 09, 2012 at 10:28:31AM -0700, Tejun Heo wrote: > On Mon, Jul 09, 2012 at 10:22:20AM -0700, Tejun Heo wrote: > > > Changing subsys_bits via remount is being deprecated. No need to > > > worry about this. > > > > Also, why does this matter? The xattrs are kept in cgrp anyway.

Re: [PATCH v3 2/3] cgroup: revise how we re-populate root directory

2012-07-09 Thread Tejun Heo
On Mon, Jul 09, 2012 at 10:22:20AM -0700, Tejun Heo wrote: > > Changing subsys_bits via remount is being deprecated. No need to > > worry about this. > > Also, why does this matter? The xattrs are kept in cgrp anyway. Why > does keeping dentry/inode around make difference? Ah, okay, the file x

Re: [PATCH v3 2/3] cgroup: revise how we re-populate root directory

2012-07-09 Thread Tejun Heo
On Mon, Jul 09, 2012 at 10:17:48AM -0700, Tejun Heo wrote: > On Mon, Jul 02, 2012 at 10:29:27AM -0400, Aristeu Rozanski wrote: > > From: Li Zefan > > > > When remounting cgroupfs with some subsystems added to it and some > > removed, cgroup will remove all the files in root directory and then > >

Re: [PATCH v3 2/3] cgroup: revise how we re-populate root directory

2012-07-09 Thread Tejun Heo
On Mon, Jul 02, 2012 at 10:29:27AM -0400, Aristeu Rozanski wrote: > From: Li Zefan > > When remounting cgroupfs with some subsystems added to it and some > removed, cgroup will remove all the files in root directory and then > re-popluate it. > > What I'm doing here is, only remove files which b