Re: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

2018-10-05 Thread Jarkko Sakkinen
On Thu, Oct 04, 2018 at 11:45:30AM +, Winkler, Tomas wrote: > There is no API change, in that sense. > The exported API is in tpm-interface.c int tpm_pcr_extend(struct tpm_chip > *chip, int pcr_idx, const u8 *hash) > that is used is outside of the tpm reminds the same, only the open coded

Re: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

2018-10-05 Thread Jarkko Sakkinen
On Thu, Oct 04, 2018 at 11:45:30AM +, Winkler, Tomas wrote: > There is no API change, in that sense. > The exported API is in tpm-interface.c int tpm_pcr_extend(struct tpm_chip > *chip, int pcr_idx, const u8 *hash) > that is used is outside of the tpm reminds the same, only the open coded

Re: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

2018-10-04 Thread Roberto Sassu
; Struk, Tadeusz ; linux-integr...@vger.kernel.org; linux-security-mod...@vger.kernel.org; linux-kernel@vger.kernel.org; roberto.sa...@huawei.com Subject: Re: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c On Wed, Oct 03, 2018 at 10:24:09PM +, Winkler, Tomas wrote: -Original

Re: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

2018-10-04 Thread Roberto Sassu
; Struk, Tadeusz ; linux-integr...@vger.kernel.org; linux-security-mod...@vger.kernel.org; linux-kernel@vger.kernel.org; roberto.sa...@huawei.com Subject: Re: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c On Wed, Oct 03, 2018 at 10:24:09PM +, Winkler, Tomas wrote: -Original

RE: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

2018-10-04 Thread Winkler, Tomas
> Cc: Jason Gunthorpe ; Nayna Jain > >> ; Usyskin, Alexander > >> ; Struk, Tadeusz > >> ; linux-integr...@vger.kernel.org; > >> linux-security-mod...@vger.kernel.org; > >> linux-kernel@vger.kernel.org; roberto.sa...@huawei.com > >> Subject: Re: [PATCH

RE: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

2018-10-04 Thread Winkler, Tomas
> Cc: Jason Gunthorpe ; Nayna Jain > >> ; Usyskin, Alexander > >> ; Struk, Tadeusz > >> ; linux-integr...@vger.kernel.org; > >> linux-security-mod...@vger.kernel.org; > >> linux-kernel@vger.kernel.org; roberto.sa...@huawei.com > >> Subject: Re: [PATCH

Re: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

2018-10-04 Thread Roberto Sassu
...@vger.kernel.org; linux-security-mod...@vger.kernel.org; linux-kernel@vger.kernel.org; roberto.sa...@huawei.com Subject: Re: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c On Wed, Oct 03, 2018 at 10:24:09PM +, Winkler, Tomas wrote: -Original Message- From: Jarkko Sakkinen

Re: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

2018-10-04 Thread Roberto Sassu
...@vger.kernel.org; linux-security-mod...@vger.kernel.org; linux-kernel@vger.kernel.org; roberto.sa...@huawei.com Subject: Re: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c On Wed, Oct 03, 2018 at 10:24:09PM +, Winkler, Tomas wrote: -Original Message- From: Jarkko Sakkinen

RE: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

2018-10-04 Thread Winkler, Tomas
.org; linux-security-mod...@vger.kernel.org; > linux-kernel@vger.kernel.org; roberto.sa...@huawei.com > Subject: Re: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c > > On Wed, Oct 03, 2018 at 10:24:09PM +, Winkler, Tomas wrote: > > > > > > &g

RE: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

2018-10-04 Thread Winkler, Tomas
.org; linux-security-mod...@vger.kernel.org; > linux-kernel@vger.kernel.org; roberto.sa...@huawei.com > Subject: Re: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c > > On Wed, Oct 03, 2018 at 10:24:09PM +, Winkler, Tomas wrote: > > > > > > &g

Re: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

2018-10-04 Thread Jarkko Sakkinen
t; Sent: Wednesday, October 03, 2018 15:02 > > > To: Winkler, Tomas > > > Cc: Jason Gunthorpe ; Nayna Jain > > > ; Usyskin, Alexander > > > ; Struk, Tadeusz ; > > > linux-integr...@vger.kernel.org; linux-security-mod...@vger.kernel.org; > > > linux-ke

Re: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

2018-10-04 Thread Jarkko Sakkinen
t; Sent: Wednesday, October 03, 2018 15:02 > > > To: Winkler, Tomas > > > Cc: Jason Gunthorpe ; Nayna Jain > > > ; Usyskin, Alexander > > > ; Struk, Tadeusz ; > > > linux-integr...@vger.kernel.org; linux-security-mod...@vger.kernel.org; > > > linux-ke

Re: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

2018-10-04 Thread Jarkko Sakkinen
Nayna Jain > > ; Usyskin, Alexander > > ; Struk, Tadeusz ; > > linux-integr...@vger.kernel.org; linux-security-mod...@vger.kernel.org; > > linux-kernel@vger.kernel.org; roberto.sa...@huawei.com > > Subject: Re: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

Re: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

2018-10-04 Thread Jarkko Sakkinen
Nayna Jain > > ; Usyskin, Alexander > > ; Struk, Tadeusz ; > > linux-integr...@vger.kernel.org; linux-security-mod...@vger.kernel.org; > > linux-kernel@vger.kernel.org; roberto.sa...@huawei.com > > Subject: Re: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

RE: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

2018-10-03 Thread Winkler, Tomas
.org; linux-security-mod...@vger.kernel.org; > linux-kernel@vger.kernel.org; roberto.sa...@huawei.com > Subject: Re: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c > > On Tue, Oct 02, 2018 at 04:58:25AM +, Winkler, Tomas wrote: > > > > > > > > >

RE: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

2018-10-03 Thread Winkler, Tomas
.org; linux-security-mod...@vger.kernel.org; > linux-kernel@vger.kernel.org; roberto.sa...@huawei.com > Subject: Re: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c > > On Tue, Oct 02, 2018 at 04:58:25AM +, Winkler, Tomas wrote: > > > > > > > > >

Re: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

2018-10-03 Thread Jarkko Sakkinen
On Tue, Oct 02, 2018 at 04:58:25AM +, Winkler, Tomas wrote: > > > > > > On Sat, Sep 29, 2018 at 01:30:26AM +0300, Tomas Winkler wrote: > > > Add tpm2_pcr_extend() function to tpm2-cmd.c with signature required > > > by tpm-interface.c. It wraps the original open code implementation. > > >

Re: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

2018-10-03 Thread Jarkko Sakkinen
On Tue, Oct 02, 2018 at 04:58:25AM +, Winkler, Tomas wrote: > > > > > > On Sat, Sep 29, 2018 at 01:30:26AM +0300, Tomas Winkler wrote: > > > Add tpm2_pcr_extend() function to tpm2-cmd.c with signature required > > > by tpm-interface.c. It wraps the original open code implementation. > > >

RE: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

2018-10-01 Thread Winkler, Tomas
> > On Sat, Sep 29, 2018 at 01:30:26AM +0300, Tomas Winkler wrote: > > Add tpm2_pcr_extend() function to tpm2-cmd.c with signature required > > by tpm-interface.c. It wraps the original open code implementation. > > The original original tpm2_pcr_extend() function is renamed to > >

RE: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

2018-10-01 Thread Winkler, Tomas
> > On Sat, Sep 29, 2018 at 01:30:26AM +0300, Tomas Winkler wrote: > > Add tpm2_pcr_extend() function to tpm2-cmd.c with signature required > > by tpm-interface.c. It wraps the original open code implementation. > > The original original tpm2_pcr_extend() function is renamed to > >

Re: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

2018-10-01 Thread Jarkko Sakkinen
On Sat, Sep 29, 2018 at 01:30:26AM +0300, Tomas Winkler wrote: > Add tpm2_pcr_extend() function to tpm2-cmd.c with signature required > by tpm-interface.c. It wraps the original open code > implementation. The original original tpm2_pcr_extend() function > is renamed to __tpm2_pcr_extend() and

Re: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

2018-10-01 Thread Jarkko Sakkinen
On Sat, Sep 29, 2018 at 01:30:26AM +0300, Tomas Winkler wrote: > Add tpm2_pcr_extend() function to tpm2-cmd.c with signature required > by tpm-interface.c. It wraps the original open code > implementation. The original original tpm2_pcr_extend() function > is renamed to __tpm2_pcr_extend() and

[PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

2018-09-28 Thread Tomas Winkler
Add tpm2_pcr_extend() function to tpm2-cmd.c with signature required by tpm-interface.c. It wraps the original open code implementation. The original original tpm2_pcr_extend() function is renamed to __tpm2_pcr_extend() and made static, it is called only from new tpm2_pcr_extend(). Fix warnings

[PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c

2018-09-28 Thread Tomas Winkler
Add tpm2_pcr_extend() function to tpm2-cmd.c with signature required by tpm-interface.c. It wraps the original open code implementation. The original original tpm2_pcr_extend() function is renamed to __tpm2_pcr_extend() and made static, it is called only from new tpm2_pcr_extend(). Fix warnings