Re: [PATCH v9 9/9] gpio: uniphier: Utilize for_each_set_clump8 macro

2019-03-12 Thread Andy Shevchenko
On Tue, Mar 12, 2019 at 10:58 AM Masahiro Yamada wrote: > On Tue, Mar 12, 2019 at 4:19 PM Andy Shevchenko > wrote: > > On Tue, Mar 12, 2019 at 6:40 AM Masahiro Yamada > > wrote: > > > On Sun, Mar 3, 2019 at 4:51 PM William Breathitt Gray > > > wrote: > > > > > > > > Replace verbose implementati

Re: [PATCH v9 9/9] gpio: uniphier: Utilize for_each_set_clump8 macro

2019-03-12 Thread Masahiro Yamada
On Tue, Mar 12, 2019 at 4:19 PM Andy Shevchenko wrote: > > On Tue, Mar 12, 2019 at 6:40 AM Masahiro Yamada > wrote: > > On Sun, Mar 3, 2019 at 4:51 PM William Breathitt Gray > > wrote: > > > > > > Replace verbose implementation in set_multiple callback with > > > for_each_set_clump8 macro to sim

Re: [PATCH v9 9/9] gpio: uniphier: Utilize for_each_set_clump8 macro

2019-03-12 Thread William Breathitt Gray
On Tue, Mar 12, 2019 at 01:36:57PM +0900, Masahiro Yamada wrote: > On Sun, Mar 3, 2019 at 4:51 PM William Breathitt Gray > wrote: > > > > Replace verbose implementation in set_multiple callback with > > for_each_set_clump8 macro to simplify code and improve clarity. An > > improvement in this case

Re: [PATCH v9 9/9] gpio: uniphier: Utilize for_each_set_clump8 macro

2019-03-12 Thread Andy Shevchenko
On Tue, Mar 12, 2019 at 6:40 AM Masahiro Yamada wrote: > On Sun, Mar 3, 2019 at 4:51 PM William Breathitt Gray > wrote: > > > > Replace verbose implementation in set_multiple callback with > > for_each_set_clump8 macro to simplify code and improve clarity. An > > improvement in this case is that

Re: [PATCH v9 9/9] gpio: uniphier: Utilize for_each_set_clump8 macro

2019-03-11 Thread Masahiro Yamada
On Sun, Mar 3, 2019 at 4:51 PM William Breathitt Gray wrote: > > Replace verbose implementation in set_multiple callback with > for_each_set_clump8 macro to simplify code and improve clarity. An > improvement in this case is that banks that are not masked will now be > skipped. > > Cc: Masahiro Ya

[PATCH v9 9/9] gpio: uniphier: Utilize for_each_set_clump8 macro

2019-03-02 Thread William Breathitt Gray
Replace verbose implementation in set_multiple callback with for_each_set_clump8 macro to simplify code and improve clarity. An improvement in this case is that banks that are not masked will now be skipped. Cc: Masahiro Yamada Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-uniphie