RE: [RFC][PATCH 1/2] efivars: Disable external interrupt while holding efivars->lock

2012-08-17 Thread Seiji Aguchi
> This isn't necessary (nor desirable). If the API here is that we get called > from process context for ->open and ->close(), just use the > spin_lock_irq and spin_unlock_irq variants for these paths (avoiding the need > to remove the lock acquire in ->open and ->close. OK. I will update my pa

Re: [RFC][PATCH 1/2] efivars: Disable external interrupt while holding efivars->lock

2012-08-17 Thread Mike Waychison
On Fri, Aug 17, 2012 at 12:42 PM, Seiji Aguchi wrote: > [Problem] > Currently, efivars doesn't disable interrupt while taking efivars->lock. > So, there is a risk to be deadlocking in a write callback of efi_pstore > if kernel panics in interrupt context while taking efivars->lock. > > [Patch D

[RFC][PATCH 1/2] efivars: Disable external interrupt while holding efivars->lock

2012-08-17 Thread Seiji Aguchi
[Problem] Currently, efivars doesn't disable interrupt while taking efivars->lock. So, there is a risk to be deadlocking in a write callback of efi_pstore if kernel panics in interrupt context while taking efivars->lock. [Patch Description] This patch disables an external interruption while ho