Re: [patch 4/4] mm: memcontrol: remove unnecessary PCG_USED pc->mem_cgroup valid flag

2014-10-22 Thread Michal Hocko
On Mon 20-10-14 11:22:12, Johannes Weiner wrote: > pc->mem_cgroup had to be left intact after uncharge for the final LRU > removal, and !PCG_USED indicated whether the page was uncharged. But > since 0a31bc97c80c ("mm: memcontrol: rewrite uncharge API") pages are > uncharged after the final LRU re

Re: [patch 4/4] mm: memcontrol: remove unnecessary PCG_USED pc->mem_cgroup valid flag

2014-10-22 Thread Vladimir Davydov
On Mon, Oct 20, 2014 at 11:22:12AM -0400, Johannes Weiner wrote: > pc->mem_cgroup had to be left intact after uncharge for the final LRU > removal, and !PCG_USED indicated whether the page was uncharged. But > since 0a31bc97c80c ("mm: memcontrol: rewrite uncharge API") pages are > uncharged after

Re: [patch 4/4] mm: memcontrol: remove unnecessary PCG_USED pc->mem_cgroup valid flag

2014-10-21 Thread Kamezawa Hiroyuki
(2014/10/21 0:22), Johannes Weiner wrote: > pc->mem_cgroup had to be left intact after uncharge for the final LRU > removal, and !PCG_USED indicated whether the page was uncharged. But > since 0a31bc97c80c ("mm: memcontrol: rewrite uncharge API") pages are > uncharged after the final LRU removal.

[patch 4/4] mm: memcontrol: remove unnecessary PCG_USED pc->mem_cgroup valid flag

2014-10-20 Thread Johannes Weiner
pc->mem_cgroup had to be left intact after uncharge for the final LRU removal, and !PCG_USED indicated whether the page was uncharged. But since 0a31bc97c80c ("mm: memcontrol: rewrite uncharge API") pages are uncharged after the final LRU removal. Uncharge can simply clear the pointer and the PCG