Re: SPDX: Appletalk FW license in the kernel

2023-09-26 Thread J Lovejoy
On 9/26/23 1:34 AM, Christoph Hellwig wrote: On Fri, Sep 15, 2023 at 09:39:05AM -0400, Prarit Bhargava wrote: Is there anyone you know of that we could approach to determine a proper SPDX License for these files? Answering this question generally, even though it sounds like it wasn't

Re: SPDX: Appletalk FW license in the kernel

2023-09-26 Thread Prarit Bhargava
On 9/26/23 04:02, Greg KH wrote: On Tue, Sep 26, 2023 at 12:34:03AM -0700, Christoph Hellwig wrote: On Fri, Sep 15, 2023 at 09:39:05AM -0400, Prarit Bhargava wrote: To be clear, I am not asking for their removal, however, I do think a better license should be issued for these files. The files

Re: SPDX: Appletalk FW license in the kernel

2023-09-26 Thread Greg KH
On Tue, Sep 26, 2023 at 12:34:03AM -0700, Christoph Hellwig wrote: > On Fri, Sep 15, 2023 at 09:39:05AM -0400, Prarit Bhargava wrote: > > To be clear, I am not asking for their removal, however, I do think a better > > license should be issued for these files. The files were trivially modified >

Re: SPDX: Appletalk FW license in the kernel

2023-09-26 Thread Christoph Hellwig
On Fri, Sep 15, 2023 at 09:39:05AM -0400, Prarit Bhargava wrote: > To be clear, I am not asking for their removal, however, I do think a better > license should be issued for these files. The files were trivially modified > in 2006. It could be that the code in question is now unused and it is

[PATCH 5.11 139/210] nfp: flower: ignore duplicate merge hints from FW

2021-04-12 Thread Greg Kroah-Hartman
From: Yinjun Zhang [ Upstream commit 2ea538dbee1c79f6f6c24a6f2f82986e4b7ccb78 ] A merge hint message needs some time to process before the merged flow actually reaches the firmware, during which we may get duplicate merge hints if there're more than one packet that hit the pre-merged flow. And

[PATCH 5.10 127/188] nfp: flower: ignore duplicate merge hints from FW

2021-04-12 Thread Greg Kroah-Hartman
From: Yinjun Zhang [ Upstream commit 2ea538dbee1c79f6f6c24a6f2f82986e4b7ccb78 ] A merge hint message needs some time to process before the merged flow actually reaches the firmware, during which we may get duplicate merge hints if there're more than one packet that hit the pre-merged flow. And

[PATCH 5.4 066/111] nfp: flower: ignore duplicate merge hints from FW

2021-04-12 Thread Greg Kroah-Hartman
From: Yinjun Zhang [ Upstream commit 2ea538dbee1c79f6f6c24a6f2f82986e4b7ccb78 ] A merge hint message needs some time to process before the merged flow actually reaches the firmware, during which we may get duplicate merge hints if there're more than one packet that hit the pre-merged flow. And

[PATCH v2 2/3] remoteproc: pru: Fix wrong success return value for fw events

2021-04-07 Thread Suman Anna
;mapped_irq[i] = irq_create_fwspec_mapping(); if (!pru->mapped_irq[i]) { - dev_err(dev, "failed to get virq\n"); - ret = pru->mapped_irq[i]; + dev_err(dev, "failed to get virq for fw mapping %d: event %d chnl %d host %d\n&q

[PATCH v2 1/3] remoteproc: pru: Fixup interrupt-parent logic for fw events

2021-04-07 Thread Suman Anna
The PRU firmware interrupt mapping logic in pru_handle_intrmap() uses of_irq_find_parent() with PRU device node to get a handle to the PRUSS Interrupt Controller at present. This logic however requires that the PRU nodes always define a interrupt-parent property. This property is neither a

Re: [PATCH 1/3] remoteproc: pru: Fixup interrupt-parent logic for fw events

2021-04-07 Thread Suman Anna
On 4/6/21 6:28 PM, Mathieu Poirier wrote: > On Tue, Mar 23, 2021 at 05:38:37PM -0500, Suman Anna wrote: >> The PRU firmware interrupt mapping logic in pru_handle_intrmap() uses >> of_irq_find_parent() with PRU device node to get a handle to the PRUSS >> Interrupt Controller at present. This logic

Re: [PATCH 2/3] remoteproc: pru: Fix wrong success return value for fw events

2021-04-06 Thread Mathieu Poirier
ru_handle_intrmap(struct rproc *rproc) > > pru->mapped_irq[i] = irq_create_fwspec_mapping(); > if (!pru->mapped_irq[i]) { > - dev_err(dev, "failed to get virq\n"); > - ret = pru->mapped_irq

Re: [PATCH 1/3] remoteproc: pru: Fixup interrupt-parent logic for fw events

2021-04-06 Thread Mathieu Poirier
On Tue, Mar 23, 2021 at 05:38:37PM -0500, Suman Anna wrote: > The PRU firmware interrupt mapping logic in pru_handle_intrmap() uses > of_irq_find_parent() with PRU device node to get a handle to the PRUSS > Interrupt Controller at present. This logic however requires that the > PRU nodes always

[PATCH] habanalabs: support DEVICE_UNUSABLE error indication from FW

2021-04-04 Thread Oded Gabbay
From: Koby Elbaz In case of multiple ECC errors, FW will set the DEVICE_UNUSABLE bit. On boot-up, the driver will therefore fail inserting the device. Signed-off-by: Koby Elbaz Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/common/firmware_if.c| 3

[PATCH 24/25] HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues

2021-03-26 Thread Lee Jones
And demote non-conformant header Fixes the following W=1 kernel build warning(s): drivers/hid/intel-ish-hid/ishtp-fw-loader.c:46: warning: Enum value 'LOADER_CMD_XFER_QUERY' not described in enum 'ish_loader_commands' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:46: warning: Enum value

Re: [PATCH] staging: greybus: fix fw is NULL but dereferenced

2021-03-25 Thread Greg KH
> > > drivers/staging/greybus/bootrom.c:301:41-45: ERROR: > > > fw is NULL but dereferenced. > > > > > > if procedure goto label directly, ret will be nefative, so the fw > > > is NULL and the if(condition) end with dereferenced fw. let's fix > &

Re: [PATCH] staging: greybus: fix fw is NULL but dereferenced

2021-03-25 Thread Jian Dong
On Thu, 25 Mar 2021 11:29:06 +0100 Greg KH wrote: > On Thu, Mar 25, 2021 at 06:19:26PM +0800, Jian Dong wrote: > > From: Jian Dong > > > > fixes coccicheck Error: > > > > drivers/staging/greybus/bootrom.c:301:41-45: ERROR: > > fw is NULL but derefere

Re: [PATCH] staging: greybus: fix fw is NULL but dereferenced

2021-03-25 Thread Viresh Kumar
On 25-03-21, 18:19, Jian Dong wrote: > From: Jian Dong > > fixes coccicheck Error: > > drivers/staging/greybus/bootrom.c:301:41-45: ERROR: > fw is NULL but dereferenced. > > if procedure goto label directly, ret will be nefative, so the fw is NULL >

Re: [PATCH] staging: greybus: fix fw is NULL but dereferenced

2021-03-25 Thread Dan Carpenter
The commit description is not clear but this patch doesn't change how the code works, it just silences a static checker false positive. Just ignore the false positive. Always just ignore static checkers when they are wrong. regards, dan carpenter

Re: [PATCH] staging: greybus: fix fw is NULL but dereferenced

2021-03-25 Thread Greg KH
On Thu, Mar 25, 2021 at 06:19:26PM +0800, Jian Dong wrote: > From: Jian Dong > > fixes coccicheck Error: > > drivers/staging/greybus/bootrom.c:301:41-45: ERROR: > fw is NULL but dereferenced. > > if procedure goto label directly, ret will be nef

[PATCH] staging: greybus: fix fw is NULL but dereferenced

2021-03-25 Thread Jian Dong
From: Jian Dong fixes coccicheck Error: drivers/staging/greybus/bootrom.c:301:41-45: ERROR: fw is NULL but dereferenced. if procedure goto label directly, ret will be nefative, so the fw is NULL and the if(condition) end with dereferenced fw. let's fix it. Signed-off-by: Jian Dong

[PATCH 2/3] remoteproc: pru: Fix wrong success return value for fw events

2021-03-23 Thread Suman Anna
ret = pru->mapped_irq[i]; + dev_err(dev, "failed to get virq for fw mapping %d: event %d chnl %d host %d\n", + i, fwspec.param[0], fwspec.param[1], + fwspec.param[2]); + ret = -EINVAL

[PATCH 1/3] remoteproc: pru: Fixup interrupt-parent logic for fw events

2021-03-23 Thread Suman Anna
The PRU firmware interrupt mapping logic in pru_handle_intrmap() uses of_irq_find_parent() with PRU device node to get a handle to the PRUSS Interrupt Controller at present. This logic however requires that the PRU nodes always define a interrupt-parent property. This property is neither a

Re: FW: [PATCHv5 0/7] Extend Intel service layer, FPGA manager and region

2021-03-22 Thread Richard Gong
Hi Tom, On 3/22/21 8:53 AM, Tom Rix wrote: On 3/21/21 2:05 PM, Richard Gong wrote: Hi Tom >> On 3/19/21 4:22 PM, Richard Gong wrote: Hi Moritz, Thanks for approving the 1st patch of my version 5 patchest, which submitted on 02/09/21. This change e23bd83368af ("firmware:

Re: FW: [PATCHv5 0/7] Extend Intel service layer, FPGA manager and region

2021-03-22 Thread Tom Rix
On 3/21/21 2:05 PM, Richard Gong wrote: > > Hi Tom, > >> >> >> On 3/19/21 4:22 PM, Richard Gong wrote: >>> >>> Hi Moritz, >>> >>> Thanks for approving the 1st patch of my version 5 patchest, which >>> submitted on 02/09/21. >> >> This change >> >> e23bd83368af ("firmware: stratix10-svc: fix

Re: FW: [PATCHv5 0/7] Extend Intel service layer, FPGA manager and region

2021-03-21 Thread Richard Gong
Hi Tom, On 3/19/21 4:22 PM, Richard Gong wrote: Hi Moritz, Thanks for approving the 1st patch of my version 5 patchest, which submitted on 02/09/21. This change e23bd83368af ("firmware: stratix10-svc: fix kernel-doc markups") This patch e23bd83368af is not from my version 5 patch

Re: [PATCH] wireless: intel: iwlwifi: fw: api: Absolute rudimentary typo fixes in the file power.h

2021-03-16 Thread Randy Dunlap
On 3/16/21 9:25 PM, Bhaskar Chowdhury wrote: > > s/folowing/following/ > s/Celsuis/Celsius/ > s/temerature/temperature/ ...twice > > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/net/wireless/intel/iwlwifi/fw/api/power.h | 8 ++

[PATCH] wireless: intel: iwlwifi: fw: api: Absolute rudimentary typo fixes in the file power.h

2021-03-16 Thread Bhaskar Chowdhury
s/folowing/following/ s/Celsuis/Celsius/ s/temerature/temperature/ ...twice Signed-off-by: Bhaskar Chowdhury --- drivers/net/wireless/intel/iwlwifi/fw/api/power.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/api/power.h b

[PATCH v3 09/14] arm64: dts: qcom: Add reserved memory for fw

2021-03-11 Thread Rajendra Nayak
From: Maulik Shah Add fw reserved memory area for CPUCP (CPUSS control processor) and AOP (Always ON processor) Signed-off-by: Maulik Shah Signed-off-by: Rajendra Nayak --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot

[PATCH V13 07/10] remoteproc: imx_rproc: add i.MX specific parse fw hook

2021-03-06 Thread peng . fan
_mem_alloc, imx_rproc_mem_release, + it.node->name); + + if (mem) + rproc_coredump_add_segment(rproc, da, rmem->size); + else + return -ENOMEM; + + rproc_add_carveout(rproc, mem); +

[PATCH v2 09/14] arm64: dts: qcom: Add reserved memory for fw

2021-03-03 Thread Rajendra Nayak
From: Maulik Shah Add fw reserved memory area for CPUCP (CPUSS control processor) and AOP (Always ON processor) Signed-off-by: Maulik Shah Signed-off-by: Rajendra Nayak --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot

[PATCH 5.11 716/775] mei: bus: block send with vtag on non-conformat FW

2021-03-01 Thread Greg Kroah-Hartman
From: Alexander Usyskin commit b398d53cd421454d64850f8b1f6d609ede9042d9 upstream. Block data send with vtag if either transport layer or FW client are not supporting vtags. Cc: # v5.10+ Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler Link: https://lore.kernel.org/r

[PATCH 5.11 526/775] i40e: Fix addition of RX filters after enabling FW LLDP agent

2021-03-01 Thread Greg Kroah-Hartman
From: Mateusz Palczewski [ Upstream commit 28b1208e7a7fa3ddc9345b022bb93e53d9dcc28a ] Fix addition of VLAN filter for PF after enabling FW LLDP agent. Changing LLDP Agent causes FW to re-initialize per NVM settings. Remove default PF filter and move "Enable/Disable" to currently used

[PATCH 5.10 437/663] i40e: Fix addition of RX filters after enabling FW LLDP agent

2021-03-01 Thread Greg Kroah-Hartman
From: Mateusz Palczewski [ Upstream commit 28b1208e7a7fa3ddc9345b022bb93e53d9dcc28a ] Fix addition of VLAN filter for PF after enabling FW LLDP agent. Changing LLDP Agent causes FW to re-initialize per NVM settings. Remove default PF filter and move "Enable/Disable" to currently used

[PATCH 5.4 219/340] i40e: Fix addition of RX filters after enabling FW LLDP agent

2021-03-01 Thread Greg Kroah-Hartman
From: Mateusz Palczewski [ Upstream commit 28b1208e7a7fa3ddc9345b022bb93e53d9dcc28a ] Fix addition of VLAN filter for PF after enabling FW LLDP agent. Changing LLDP Agent causes FW to re-initialize per NVM settings. Remove default PF filter and move "Enable/Disable" to currently used

[PATCH 1/2] habanalabs: skip DISABLE PCI packet to FW on heartbeat

2021-02-28 Thread Oded Gabbay
From: Ohad Sharabi if reset is due to heartbeat, device CPU is no responsive in which case no point sending PCI disable message to it. Signed-off-by: Ohad Sharabi Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- .../habanalabs/common/command_submission.c| 4 +-

[PATCH] habanalabs: use a single FW loading bringup flag

2021-02-24 Thread Oded Gabbay
From: Ofir Bitton For simplicity, use a single bringup flag indicating which FW binaries should loaded to device. Signed-off-by: Ofir Bitton Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/common/firmware_if.c| 10 +++--- drivers/misc/habanalabs

Re: [PATCH 09/13] arm64: dts: qcom: Add reserved memory for fw

2021-02-23 Thread Rajendra Nayak
On 2/23/2021 1:15 PM, Stephen Boyd wrote: Quoting Rajendra Nayak (2021-02-11 23:28:46) From: Maulik Shah Add fw reserved memory area for CPUCP and AOP. Does CPUCP stand for CPU Content Protection? AOP is Always On Processor. It would help if the commit text told us what these acronyms

Re: [PATCH 09/13] arm64: dts: qcom: Add reserved memory for fw

2021-02-22 Thread Stephen Boyd
Quoting Rajendra Nayak (2021-02-11 23:28:46) > From: Maulik Shah > > Add fw reserved memory area for CPUCP and AOP. Does CPUCP stand for CPU Content Protection? AOP is Always On Processor. It would help if the commit text told us what these acronyms were. > > Signed-off-

FW: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-18 Thread Min Li
-Original Message- From: Min Li Sent: February 18, 2021 11:14 AM To: 'Arnd Bergmann' Cc: Derek Kiernan ; Dragan Cvetic ; Arnd Bergmann ; gregkh ; linux-kernel@vger.kernel.org; Networking ; Richard Cochran Subject: RE: [PATCH net-next] misc: Add Renesas Synchronization Management

[PATCH V12 07/10] remoteproc: imx_rproc: add i.MX specific parse fw hook

2021-02-17 Thread peng . fan
_mem_alloc, imx_rproc_mem_release, + it.node->name); + + if (mem) + rproc_coredump_add_segment(rproc, da, rmem->size); + else + return -ENOMEM; + + rproc_add_carveout(rproc, mem); +

[PATCH V10 07/10] remoteproc: imx_rproc: add i.MX specific parse fw hook

2021-02-15 Thread peng . fan
_mem_alloc, imx_rproc_mem_release, + it.node->name); + + if (mem) + rproc_coredump_add_segment(rproc, da, rmem->size); + else + return -ENOMEM; + + rproc_add_carveout(rproc, mem); +

[PATCH 09/13] arm64: dts: qcom: Add reserved memory for fw

2021-02-11 Thread Rajendra Nayak
From: Maulik Shah Add fw reserved memory area for CPUCP and AOP. Signed-off-by: Maulik Shah Signed-off-by: Rajendra Nayak --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom

[PATCH 5.10 21/54] ASoC: wm_adsp: Fix control name parsing for multi-fw

2021-02-11 Thread Greg Kroah-Hartman
wm_coeff_ctl *pos, *rslt = NULL; + const char *fw_txt = wm_adsp_fw_text[dsp->fw]; list_for_each_entry(pos, >ctl_list, list) { if (!pos->subname) continue; if (strncmp(pos->subname, name, pos->su

[PATCH v3 0/2] Enable usage of Marvell FW SIP services

2021-02-11 Thread kostap
registered at ap-cpu clock driver probe according to FW response v3: * fix build errors and rebase on top of clk-next branch Grzegorz Jaszczyk (2): thermal: armada: ap806: use firmware SiP services for thermal operations clk: mvebu: use firmware SiP service for accessing dfx register set

[PATCH 0/2] Enable usage of Marvell FW SIP services

2021-02-11 Thread kostap
registered at ap-cpu clock driver probe according to FW response v3: * fix build errors and rebase on clk-next branch Grzegorz Jaszczyk (2): thermal: armada: ap806: use firmware SiP services for thermal operations clk: mvebu: use firmware SiP service for accessing dfx register set

[char-misc-next 1/2] mei: bus: block send with vtag on non-conformat FW

2021-02-08 Thread Tomas Winkler
From: Alexander Usyskin Block data send with vtag if either transport layer or FW client are not supporting vtags. Cc: # v5.10+ Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/misc

[PATCH V10 07/10] remoteproc: imx_rproc: add i.MX specific parse fw hook

2021-02-08 Thread peng . fan
_mem_alloc, imx_rproc_mem_release, + it.node->name); + + if (mem) + rproc_coredump_add_segment(rproc, da, rmem->size); + else + return -ENOMEM; + + rproc_add_carveout(rproc, mem); +

[PATCH 5.10 51/57] habanalabs: zero pci counters packet before submit to FW

2021-02-05 Thread Greg Kroah-Hartman
From: Ofir Bitton [ Upstream commit 9354f1b421f76f8368be13954f87d07bcbd6fffe ] Driver does not zero some pci counters packets before sending to FW. This causes an out of sync PI/CI between driver and FW. Signed-off-by: Ofir Bitton Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay Signed

[PATCH 5.10 53/57] habanalabs: disable FW events on device removal

2021-02-05 Thread Greg Kroah-Hartman
From: Oded Gabbay [ Upstream commit 2dc4a6d79168e7e426e8ddf8e7219c9ffd13b2b1 ] When device is removed, we need to make sure the F/W won't send us any more events because during the remove process we disable the interrupts. Signed-off-by: Oded Gabbay Signed-off-by: Sasha Levin ---

drivers/staging/greybus/fw-management.c:493:21: sparse: sparse: incorrect type in argument 1 (different address spaces)

2021-02-04 Thread kernel test robot
"sparse warnings: (new ones prefixed by >>)" drivers/staging/greybus/fw-management.c:493:21: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected unsigned int const *__gu_addr @@ got unsigned int [noderef] __user * @@ drivers/st

[PATCH AUTOSEL 5.10 03/25] ASoC: wm_adsp: Fix control name parsing for multi-fw

2021-02-02 Thread Sasha Levin
wm_coeff_ctl *pos, *rslt = NULL; + const char *fw_txt = wm_adsp_fw_text[dsp->fw]; list_for_each_entry(pos, >ctl_list, list) { if (!pos->subname) continue; if (strncmp(pos->subname, name, pos->su

Re: [PATCH] staging: net: wimax: i2400m: fw: remove redundant initialization of variable result

2021-01-28 Thread Joe Perches
On Thu, 2021-01-28 at 17:37 +, Colin King wrote: > From: Colin Ian King > > The variable result is being initialized with a value that is never > read and it is being updated later with a new value. The initialization > is redundant and can be removed. Isn't WIMAX dead? Shouldn't it be

[PATCH] staging: net: wimax: i2400m: fw: remove redundant initialization of variable result

2021-01-28 Thread Colin King
From: Colin Ian King The variable result is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King ---

RE: [EXT] Re: [PATCH v4 net-next 11/19] net: mvpp2: add spinlock for FW FCA configuration path

2021-01-27 Thread Stefan Chulski
> > index 9d8993f..f34e260 100644 > > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h > > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h > > @@ -1021,6 +1021,11 @@ struct mvpp2 { > > > > /* CM3 SRAM pool */ > > struct gen_pool *sram_pool; > > + > > + bool custom_dma_mask;

Re: [PATCH v4 net-next 11/19] net: mvpp2: add spinlock for FW FCA configuration path

2021-01-27 Thread Willem de Bruijn
On Wed, Jan 27, 2021 at 7:19 AM wrote: > > From: Stefan Chulski > > Spinlock added to MSS shared memory configuration space. > > Signed-off-by: Stefan Chulski > --- > drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 5 + > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 3 +++ > 2 files

[PATCH v4 net-next 11/19] net: mvpp2: add spinlock for FW FCA configuration path

2021-01-27 Thread stefanc
From: Stefan Chulski Spinlock added to MSS shared memory configuration space. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 5 + drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 3 +++ 2 files changed, 8 insertions(+) diff --git

[PATCH v3 RFC net-next 11/19] net: mvpp2: add spinlock for FW FCA configuration path

2021-01-25 Thread stefanc
From: Stefan Chulski Spinlock added to MSS shared memory configuration space. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 5 + drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 3 +++ 2 files changed, 8 insertions(+) diff --git

[PATCH v2 RFC net-next 10/18] net: mvpp2: add spinlock for FW FCA configuration path

2021-01-24 Thread stefanc
From: Stefan Chulski Spinlock added to MSS shared memory configuration space. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 5 + drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 3 +++ 2 files changed, 8 insertions(+) diff --git

[PATCH V9 07/10] remoteproc: imx_rproc: add i.MX specific parse fw hook

2021-01-20 Thread peng . fan
_mem_alloc, imx_rproc_mem_release, + it.node->name); + + if (mem) + rproc_coredump_add_segment(rproc, da, rmem->size); + else + return -ENOMEM; + + rproc_add_carveout(rproc, mem); +

Re: [PATCH v5] venus: core: add support to dump FW region

2021-01-19 Thread Stephen Boyd
Quoting Dikshita Agarwal (2020-12-15 10:08:36) > Add support to dump video FW region during FW crash > using devcoredump helpers. > > Signed-off-by: Dikshita Agarwal > Reviewed-by: Stephen Boyd > Reviewed-by: Stanimir Varbanov > > Major changes since v1: > -

[PATCH V8 07/10] remoteproc: imx_rproc: add i.MX specific parse fw hook

2021-01-18 Thread peng . fan
_mem_alloc, imx_rproc_mem_release, + it.node->name); + + if (mem) + rproc_coredump_add_segment(rproc, da, rmem->size); + else + return -ENOMEM; + + rproc_add_carveout(rproc, mem); +

[PATCH 1/3] habanalabs: zero pci counters packet before submit to FW

2021-01-18 Thread Oded Gabbay
From: Ofir Bitton Driver does not zero some pci counters packets before sending to FW. This causes an out of sync PI/CI between driver and FW. Signed-off-by: Ofir Bitton Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/common/firmware_if.c | 5 + 1 file

[PATCH 3/3] habanalabs: disable FW events on device removal

2021-01-18 Thread Oded Gabbay
When device is removed, we need to make sure the F/W won't send us any more events because during the remove process we disable the interrupts. Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/common/device.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH V7 07/10] remoteproc: imx_rproc: add i.MX specific parse fw hook

2021-01-18 Thread peng . fan
_mem_alloc, imx_rproc_mem_release, + it.node->name); + + if (mem) + rproc_coredump_add_segment(rproc, da, rmem->size); + else + return -ENOMEM; + + rproc_add_carveout(rproc, mem); +

RE: [PATCH V6 07/10] remoteproc: imx_rproc: add i.MX specific parse fw hook

2021-01-14 Thread Peng Fan
> Subject: Re: [PATCH V6 07/10] remoteproc: imx_rproc: add i.MX specific > parse fw hook > > On Tue, Jan 12, 2021 at 05:39:16PM +0800, peng@nxp.com wrote: > > From: Peng Fan > > > > The hook is used to parse memory-regions and load resource table from > &

Re: [PATCH V6 07/10] remoteproc: imx_rproc: add i.MX specific parse fw hook

2021-01-14 Thread Mathieu Poirier
/* Register memory region */ > + mem = rproc_mem_entry_init(priv->dev, NULL, > (dma_addr_t)rmem->base, rmem->size, da, > +imx_rproc_mem_alloc, > imx_rproc_mem_release, > +it.

Re: [PATCH RESEND v3] venus: venc: set inband mode property to FW.

2021-01-12 Thread Fritz Koenig
On Thu, Jan 7, 2021 at 11:26 PM Dikshita Agarwal wrote: > > set HFI_PROPERTY_CONFIG_VENC_SYNC_FRAME_SEQUENCE_HEADER to FW > to support inband sequence header mode. > > Signed-off-by: Dikshita Agarwal > > Changes since v2: > - fixed Null pointer dereference (Stanim

[PATCH V6 07/10] remoteproc: imx_rproc: add i.MX specific parse fw hook

2021-01-12 Thread peng . fan
_mem_alloc, imx_rproc_mem_release, + it.node->name); + + if (mem) + rproc_coredump_add_segment(rproc, da, rmem->size); + else + return -ENOMEM; + + rproc_add_carveout(rproc, mem); +

[PATCH RFC net-next 10/19] net: mvpp2: add spinlock for FW FCA configuration path

2021-01-10 Thread stefanc
From: Stefan Chulski Spinlock added to MSS shared memory configuration space. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 5 + drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 3 +++ 2 files changed, 8 insertions(+) diff --git

[PATCH RESEND v3] venus: venc: set inband mode property to FW.

2021-01-07 Thread Dikshita Agarwal
set HFI_PROPERTY_CONFIG_VENC_SYNC_FRAME_SEQUENCE_HEADER to FW to support inband sequence header mode. Signed-off-by: Dikshita Agarwal Changes since v2: - fixed Null pointer dereference (Stanimir, Fritz) - added set property call at correct place. --- drivers/media/platform/qcom/venus/venc.c

[PATCH v3] venus: venc: set inband mode property to FW.

2021-01-07 Thread Dikshita Agarwal
set HFI_PROPERTY_CONFIG_VENC_SYNC_FRAME_SEQUENCE_HEADER to FW to support inband sequence header mode. Signed-off-by: Dikshita Agarwal Changes since v2: - fixed Null pointer dereference (Stanimir, Fritz) - added set property call at correct place. --- drivers/media/platform/qcom/venus/venc.c

Fw: Hiding the vim user in amdgpu_vcn.c (typo in comment)

2021-01-05 Thread Stefan Hagen
Hi, Ricardo Mestre wrote: > Stefan Hagen wrote: >> I can totally relate to this one. >> >> Found after a conversation about muscle memory and grepping the >> source tree for ":wq". >> > This issue is present in upstream [0], please take it with them. > > [0] >

[PATCH V5 5/8] remoteproc: imx_rproc: add i.MX specific parse fw hook

2020-12-28 Thread peng . fan
_mem_alloc, imx_rproc_mem_release, + it.node->name); + + if (mem) + rproc_coredump_add_segment(rproc, da, rmem->size); + else + return -ENOMEM; + + rproc_add_carveout(rproc, mem); +

[PATCH 5.10 379/717] scsi: qla2xxx: Fix FW initialization error on big endian machines

2020-12-28 Thread Greg Kroah-Hartman
From: Arun Easi [ Upstream commit 8a78dd6ed1af06bfa7b4ade81328ff7ea11b6947 ] Some fields are not correctly byte swapped causing failure during initialization. As probe() returns failure, HBAs will not be claimed when this happens. qla2xxx [0007:01:00.0]-:3: Secure Flash Update in FW

[PATCH AUTOSEL 5.4 012/130] scsi: pm80xx: Avoid busywait in FW ready check

2020-12-22 Thread Sasha Levin
(struct pm8001_hba_info *pm8001_ha) /** * check_fw_ready - The LLDD check if the FW is ready, if not, return error. + * This function sleeps hence it must not be used in atomic context. * @pm8001_ha: our hba card information */ static int check_fw_ready(struct pm8001_hba_info *pm8001_ha

[PATCH AUTOSEL 4.19 05/87] scsi: pm80xx: Avoid busywait in FW ready check

2020-12-22 Thread Sasha Levin
(struct pm8001_hba_info *pm8001_ha) /** * check_fw_ready - The LLDD check if the FW is ready, if not, return error. + * This function sleeps hence it must not be used in atomic context. * @pm8001_ha: our hba card information */ static int check_fw_ready(struct pm8001_hba_info *pm8001_ha

[PATCH AUTOSEL 4.14 05/66] scsi: pm80xx: Avoid busywait in FW ready check

2020-12-22 Thread Sasha Levin
(struct pm8001_hba_info *pm8001_ha) /** * check_fw_ready - The LLDD check if the FW is ready, if not, return error. + * This function sleeps hence it must not be used in atomic context. * @pm8001_ha: our hba card information */ static int check_fw_ready(struct pm8001_hba_info *pm8001_ha

[PATCH AUTOSEL 4.9 05/48] scsi: pm80xx: Avoid busywait in FW ready check

2020-12-22 Thread Sasha Levin
(struct pm8001_hba_info *pm8001_ha) /** * check_fw_ready - The LLDD check if the FW is ready, if not, return error. + * This function sleeps hence it must not be used in atomic context. * @pm8001_ha: our hba card information */ static int check_fw_ready(struct pm8001_hba_info *pm8001_ha

[PATCH AUTOSEL 4.4 04/38] scsi: pm80xx: Avoid busywait in FW ready check

2020-12-22 Thread Sasha Levin
(struct pm8001_hba_info *pm8001_ha) /** * check_fw_ready - The LLDD check if the FW is ready, if not, return error. + * This function sleeps hence it must not be used in atomic context. * @pm8001_ha: our hba card information */ static int check_fw_ready(struct pm8001_hba_info *pm8001_ha

[PATCH AUTOSEL 5.10 032/217] scsi: pm80xx: Avoid busywait in FW ready check

2020-12-22 Thread Sasha Levin
(struct pm8001_hba_info *pm8001_ha) /** * check_fw_ready - The LLDD check if the FW is ready, if not, return error. + * This function sleeps hence it must not be used in atomic context. * @pm8001_ha: our hba card information */ static int check_fw_ready(struct pm8001_hba_info *pm8001_ha

Re: [PATCH v2] venus: venc: set inband mode property to FW.

2020-12-21 Thread Stanimir Varbanov
On 12/16/20 8:49 AM, Dikshita Agarwal wrote: > set HFI_PROPERTY_CONFIG_VENC_SYNC_FRAME_SEQUENCE_HEADER to FW > to support inband sequence header mode. > > Signed-off-by: Dikshita Agarwal > > Changes since v1: > - added codec check > - fixed the mask while

Re: [PATCH] venus: venc: set IDR period to FW only for H264 & HEVC

2020-12-21 Thread Stanimir Varbanov
On 12/16/20 9:06 AM, Dikshita Agarwal wrote: > HFI_PROPERTY_CONFIG_VENC_IDR_PERIOD is supported for only > H264 & HEVC codec. There is no need to set it for VP8 since > all key frames are treated as IDR frames for VP8. > > Signed-off-by: Dikshita Agarwal > --- >

[PATCH 5/8] remoteproc: imx_rproc: add i.MX specific parse fw hook

2020-12-21 Thread Peng Fan (OSS)
_mem_alloc, imx_rproc_mem_release, + it.node->name); + + if (mem) + rproc_coredump_add_segment(rproc, da, rmem->size); + else + return -ENOMEM; + + rproc_add_carveout(rproc, mem); +

Re: [PATCH v4] Bluetooth: btqca: Add support to read FW build version for WCN3991 BTSoC

2020-12-18 Thread Marcel Holtmann
Hi Venkata, > Add support to read FW build version from debugfs node. > This info can be read from > /sys/kernel/debug/bluetooth/hci0/firmware_info > > Signed-off-by: Venkata Lakshmi Narayana Gubba > --- > drivers/bluetooth/btqca.c | 54

[PATCH] venus: venc: set IDR period to FW only for H264 & HEVC

2020-12-15 Thread Dikshita Agarwal
HFI_PROPERTY_CONFIG_VENC_IDR_PERIOD is supported for only H264 & HEVC codec. There is no need to set it for VP8 since all key frames are treated as IDR frames for VP8. Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/venus/venc.c | 23 +-- 1 file changed, 13

[PATCH v2] venus: venc: set inband mode property to FW.

2020-12-15 Thread Dikshita Agarwal
set HFI_PROPERTY_CONFIG_VENC_SYNC_FRAME_SEQUENCE_HEADER to FW to support inband sequence header mode. Signed-off-by: Dikshita Agarwal Changes since v1: - added codec check - fixed the mask while initializing the control --- drivers/media/platform/qcom/venus/venc_ctrls.c | 15

Re: Fw: [External] Re: [PATCH v4 0/4] Improve s0ix flows for systems i219LM

2020-12-15 Thread Neftin, Sasha
On 12/15/2020 19:20, Limonciello, Mario wrote: Absolutely - I'll ask them to look into this again. we need to explain why on Windows systems required 1s and on Linux systems up to 2.5s - otherwise it is not reliable approach - you will encounter others buggy system. (ME not POR on the Linux

[PATCH v5] venus: core: add support to dump FW region

2020-12-15 Thread Dikshita Agarwal
Add support to dump video FW region during FW crash using devcoredump helpers. Signed-off-by: Dikshita Agarwal Reviewed-by: Stephen Boyd Reviewed-by: Stanimir Varbanov Major changes since v1: - update the name of function (Stephen) - store start address and size in resource structure during

RE: Fw: [External] Re: [PATCH v4 0/4] Improve s0ix flows for systems i219LM

2020-12-15 Thread Limonciello, Mario
> > Absolutely - I'll ask them to look into this again. > > > we need to explain why on Windows systems required 1s and on Linux > systems up to 2.5s - otherwise it is not reliable approach - you will > encounter others buggy system. > (ME not POR on the Linux systems - is only one possible

Re: Fw: [External] Re: [PATCH v4 0/4] Improve s0ix flows for systems i219LM

2020-12-15 Thread Neftin, Sasha
On 12/14/2020 20:40, Mark Pearson wrote: Thanks Hans On 14/12/2020 13:31, Mark Pearson wrote: *From:* Hans de Goede *Sent:* December 14, 2020 13:24 *To:* Mario Limonciello ; Jeff Kirsher ; Tony Nguyen ;

Re: [PATCH v4] venus: core: add support to dump FW region

2020-12-14 Thread Stanimir Varbanov
On 12/14/20 3:03 PM, Dikshita Agarwal wrote: > Add support to dump video FW region during FW crash > using devcoredump helpers. > > Major changes since v1: > - update the name of function (Stephen) > - store start address and size in resource structure during > probe an

Re: Fw: [External] Re: [PATCH v4 0/4] Improve s0ix flows for systems i219LM

2020-12-14 Thread Mark Pearson
Thanks Hans On 14/12/2020 13:31, Mark Pearson wrote: > > > > *From:* Hans de Goede > *Sent:* December 14, 2020 13:24 > *To:* Mario Limonciello ; Jeff Kirsher > ; Tony Nguyen ; > intel-wired-...@lists.osuosl.org ; > David

[PATCH 5.9 077/105] media: pulse8-cec: add support for FW v10 and up

2020-12-14 Thread Greg Kroah-Hartman
*/ MSGCODE_GET_DEVICE_TYPE, MSGCODE_SET_DEVICE_TYPE, - MSGCODE_GET_HDMI_VERSION, + MSGCODE_GET_HDMI_VERSION, /* Removed in FW >= 10 */ MSGCODE_SET_HDMI_VERSION, MSGCODE_GET_OSD_NAME, MSGCODE_SET_OSD_NAME, MSGCODE_WRITE_EEPROM, MSGCODE_GET_ADAPTER_T

[PATCH 5.9 095/105] drm/amdgpu: fix sdma instance fw version and feature version init

2020-12-14 Thread Greg Kroah-Hartman
From: Stanley.Yang commit 6896887b8676d8fb445c85ea56333b9661a6a8aa upstream. each sdma instance fw_version and feature_version should be set right value when asic type isn't between SIENNA_CICHILD and CHIP_DIMGREY_CAVEFISH Signed-off-by: Stanley.Yang Reviewed-by: Tao Zhou Signed-off-by: Alex

[PATCH] venus: venc: set inband mode property to FW.

2020-12-14 Thread Dikshita Agarwal
set HFI_PROPERTY_CONFIG_VENC_SYNC_FRAME_SEQUENCE_HEADER to FW to support inband sequence header mode. Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/venus/venc_ctrls.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform

[PATCH v4] venus: core: add support to dump FW region

2020-12-14 Thread Dikshita Agarwal
Add support to dump video FW region during FW crash using devcoredump helpers. Major changes since v1: - update the name of function (Stephen) - store start address and size in resource structure during probe and reuse while dumping (Stephen, Stanimir) Signed-off-by: Dikshita Agarwal Reviewed

Re: [PATCH wireless] iwlwifi: fw: simplify the iwl_fw_dbg_collect_trig()

2020-12-09 Thread Kalle Valo
Zheng Yongjun writes: > Simplify the return expression. > > Signed-off-by: Zheng Yongjun > --- > drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c

[PATCH wireless] iwlwifi: fw: simplify the iwl_fw_dbg_collect_trig()

2020-12-09 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c index ab4a8b942c81

[PATCH] habanalabs: full FW hard reset support

2020-12-08 Thread Oded Gabbay
From: Ofir Bitton Driver must fetch FW hard reset capability at every FW boot stage: preboot, CPU boot, CPU application. If hard reset is triggered, driver will take into consideration only the last capability received. Signed-off-by: Ofir Bitton Reviewed-by: Oded Gabbay Signed-off-by: Oded

Request to Update WCN3991 FW files

2020-12-08 Thread sampnimm
Hello Team, Please include updated firmware bins for WCN3991. Snapshot of pull request is as below, let me know if anything is missing. The following changes since commit 7455a36066741a6e52fba65e04f6451b4cdfd9c4: Merge branch 'guc_v49' of

  1   2   3   4   5   6   7   8   9   10   >