On Thu, 2020-12-17 at 09:27 -0800, Linus Torvalds wrote:
> On Thu, Dec 17, 2020 at 8:25 AM Josh Poimboeuf wrote:
> >
> > Oh yeah, I forgot about that. That would be another option if my patch
> > doesn't work out.
>
> Well, one option is to just say "ok, we know gcc generates horrible
> code th
On Thu, Dec 17, 2020 at 9:27 AM Linus Torvalds
wrote:
>
> So I think I'll just apply this patch instead.
Commit d652d5f1eeeb ("drm/edid: fix objtool warning in
drm_cvt_modes()") has the long and boring explanation.
Linus
On Thu, Dec 17, 2020 at 8:25 AM Josh Poimboeuf wrote:
>
> Oh yeah, I forgot about that. That would be another option if my patch
> doesn't work out.
Well, one option is to just say "ok, we know gcc generates horrible
code that falls through to another function in a situation that we
claim is unr
On Thu, Dec 17, 2020 at 11:45:56AM +0100, Peter Zijlstra wrote:
> On Wed, Dec 16, 2020 at 02:01:58PM -0600, Josh Poimboeuf wrote:
> > So this is kind of tricky, because the unreachable() annotation usually
> > means "the previous instruction is a dead end". Most of the time, the
> > next instructi
On Wed, Dec 16, 2020 at 02:01:58PM -0600, Josh Poimboeuf wrote:
> So this is kind of tricky, because the unreachable() annotation usually
> means "the previous instruction is a dead end". Most of the time, the
> next instruction -- the one actually pointed to by the annotation -- is
> actually rea
On Tue, Dec 15, 2020 at 09:32:29PM -0800, Linus Torvalds wrote:
> > The asm code looks like this:
> >
> > cmpb$4, %al #, _30
> > jne .L176 #,
> > ...
> > cmpb$12, %al#, _30
> > jne .L176 #,
> > ...
> > .L176:
> > # drivers/gpu/drm/drm_edid
On Wed, Dec 16, 2020 at 10:46:31AM +, David Laight wrote:
> From: Josh Poimboeuf
> > Sent: 16 December 2020 04:49
> >
> > On Tue, Dec 15, 2020 at 08:22:23PM -0800, Linus Torvalds wrote:
> > > I only see this on my laptop, but that's probably because my desktop
> > > is built using clang. So it
On Tue, Dec 15, 2020 at 09:31:50PM -0800, Linus Torvalds wrote:
> On Tue, Dec 15, 2020 at 8:49 PM Josh Poimboeuf wrote:
> >
> > But yeah, it _might_ be possible to make objtool a little smarter here.
> > Gimme the .o file and I can take a look tomorrow.
>
> Hmm. I tried to send it to you, but the
From: Josh Poimboeuf
> Sent: 16 December 2020 04:49
>
> On Tue, Dec 15, 2020 at 08:22:23PM -0800, Linus Torvalds wrote:
> > I only see this on my laptop, but that's probably because my desktop
> > is built using clang. So it's a gcc code generation interaction, I
> > suspect..
> >
> > Anyway, the
On Tue, Dec 15, 2020 at 8:49 PM Josh Poimboeuf wrote:
>
> But yeah, it _might_ be possible to make objtool a little smarter here.
> Gimme the .o file and I can take a look tomorrow.
Hmm. I tried to send it to you, but then I get a bounce with
554 Email rejected due to security policies
becaus
On Tue, Dec 15, 2020 at 08:22:23PM -0800, Linus Torvalds wrote:
> I only see this on my laptop, but that's probably because my desktop
> is built using clang. So it's a gcc code generation interaction, I
> suspect..
>
> Anyway, the new warning is
>
> drivers/gpu/drm/drm_edid.o: warning: objto
I only see this on my laptop, but that's probably because my desktop
is built using clang. So it's a gcc code generation interaction, I
suspect..
Anyway, the new warning is
drivers/gpu/drm/drm_edid.o: warning: objtool: do_cvt_mode() falls
through to next function drm_mode_detailed.isra.0()
a
12 matches
Mail list logo
