Re: [PATCH v18 2/6] remoteproc: Add TEE support

2025-06-16 Thread Bjorn Andersson
On Mon, Jun 16, 2025 at 09:55:26AM +0200, Arnaud Pouliquen wrote: > Add a remoteproc TEE (Trusted Execution Environment) driver that will be > probed by the TEE bus. If the associated Trusted application is supported > on the secure part, this driver offers a client interface to load firmware > by

Re: [PATCH v18 3/6] remoteproc: Introduce release_fw optional operation

2025-06-16 Thread Bjorn Andersson
On Mon, Jun 16, 2025 at 09:55:27AM +0200, Arnaud Pouliquen wrote: > The release_fw operation is the inverse operation of the load, responsible > for releasing the remote processor resources configured from the loading > of the remoteproc firmware (e.g., memories). > I was under the impression tha

Re: [PATCH 1/3] rcu: Return early if callback is not specified

2025-06-16 Thread Joel Fernandes
On 6/12/2025 5:03 PM, Boqun Feng wrote: [..] > >> The kernel robot reports it and it is already a strong indication that >> the subsystem is not hardened against invalid inputs: >> >> "BUG: unable to handle kernel NULL pointer dereference in rcu_core (3)" >> >> so this in the rcu_core() which i

Re: [PATCH v2 1/3] dt-bindings: remoteproc: fsl,imx-rproc: Add support for i.MX95

2025-06-16 Thread Peng Fan
Hi Daniel, On Mon, Jun 16, 2025 at 04:07:02PM +0300, Daniel Baluta wrote: >On Fri, Jun 6, 2025 at 4:57???AM Peng Fan (OSS) wrote: >> >> From: Peng Fan >> >> i.MX95 has a System Manager(SM) core runs the System Control Management >> Interface(SCMI) firmware. Vendor extenions are implemented in th

Re: [PATCH rc 1/4] iommufd/selftest: Fix iommufd_dirty_tracking with large hugepage sizes

2025-06-16 Thread Nicolin Chen
> + free(self->buffer); > > + free(self->bitmap); > > teardown_iommufd(self->fd, _metadata); > > munmap followed by free isn't right.. You are right. I re-checked with Copilot. It says the same thing. I think the whole posix_memalign() + mmap() confus

Re: [RFC 08/19] exec: add API specification for execve

2025-06-16 Thread Sasha Levin
On Mon, Jun 16, 2025 at 11:39:31PM +0200, Florian Weimer wrote: * Sasha Levin: + KAPI_RETURN("long", "Does not return on success; returns -1 on error") + .type = KAPI_TYPE_INT, + .check_type = KAPI_RETURN_ERROR_CHECK, + KAPI_RETURN_END Is the -1 part co

Re: [PATCH v4 3/3] remoteproc: imx_rproc: detect and attach to pre-booted remote cores

2025-06-16 Thread Peng Fan
On Mon, Jun 16, 2025 at 01:05:11PM -0300, Hiago De Franco wrote: >Hi Peng, > >On Thu, Jun 12, 2025 at 02:03:17PM -0300, Hiago De Franco wrote: >> Hi Peng, >> >> On Wed, Jun 11, 2025 at 03:27:09AM +, Peng Fan wrote: >> > > >> > > Sorry for the delay. >> > > >> > > I tested it now and there mu

Re: [PATCH net-next v3 0/3] vsock/test: Improve transport_uaf test

2025-06-16 Thread Jakub Kicinski
On Wed, 11 Jun 2025 21:56:49 +0200 Michal Luczaj wrote: > Increase the coverage of a test implemented in commit 301a62dfb0d0 > ("vsock/test: Add test for UAF due to socket unbinding"). Take this > opportunity to factor out some utility code, drop a redundant sync between > client and server, and in

Re: [PATCH 2/2] vhost: vringh: Remove unused functions

2025-06-16 Thread Dr. David Alan Gilbert
* Simon Horman (ho...@kernel.org) wrote: > On Sat, Jun 14, 2025 at 12:07:31AM +0100, li...@treblig.org wrote: > > From: "Dr. David Alan Gilbert" > > > > The functions: > > vringh_abandon_kern() > > vringh_abandon_user() > > vringh_iov_pull_kern() and > > vringh_iov_push_kern() > > were al

Re: [PATCH v5 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct

2025-06-16 Thread Andrew Morton
On Mon, 16 Jun 2025 15:34:06 +0530 Ujwal Kundur wrote: > Refactor macros and non-composite global variable definitions into a > struct that is defined at the start of a test and is passed around > instead of relying on global vars. Well I guess that's nicer. > 5 files changed, 616 insertions(+

Re: [PATCH net-next v3 0/8] netpoll: Untangle netconsole and netpoll

2025-06-16 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Fri, 13 Jun 2025 04:31:29 -0700 you wrote: > Initially netpoll and netconsole were created together, and some > functions are in the wrong file. Seperate netconsole-only functions > in netconsole, avoiding exports

Re: [RFC 08/19] exec: add API specification for execve

2025-06-16 Thread Florian Weimer
* Sasha Levin: > + KAPI_RETURN("long", "Does not return on success; returns -1 on error") > + .type = KAPI_TYPE_INT, > + .check_type = KAPI_RETURN_ERROR_CHECK, > + KAPI_RETURN_END Is the -1 part correct? Many later errors during execve are not recoverable and resu

Re: [PATCH v2 0/4] arm64: dts: qcom: msm8976-longcheer-l9360: Add initial device tree

2025-06-16 Thread Rob Herring (Arm)
On Sun, 15 Jun 2025 22:35:02 +0200, André Apitzsch wrote: > This dts adds support for BQ Aquaris X5 Plus (Longcheer L9360) released > in 2016. > > Add a device tree with initial support for: > > - GPIO keys > - NFC > - SDHCI > - Status LED > - Touchscreen > > Signed-off-by: André Apitzsch > -

Re: [PATCH net-next v4] page_pool: import Jesper's page_pool benchmark

2025-06-16 Thread Mina Almasry
On Mon, Jun 16, 2025 at 2:29 AM Jesper Dangaard Brouer wrote: > On 15/06/2025 22.59, Mina Almasry wrote: > > From: Jesper Dangaard Brouer > > > > We frequently consult with Jesper's out-of-tree page_pool benchmark to > > evaluate page_pool changes. > > > > Import the benchmark into the upstream l

Re: clang: selftests/mm gup_longterm error while loading shared libraries liburing.so.2 cannot open shared object file No such file or directory

2025-06-16 Thread David Hildenbrand
On 16.06.25 21:14, Christian Heusel wrote: On 25/06/16 11:02PM, Naresh Kamboju wrote: The following test regressions noticed while running selftests/mm gup_longterm test cases on Dragonboard-845c, Dragonboard-410c, rock-pi-4, qemu-arm64 and qemu-x86_64 this build have required selftest/mm/config

Re: clang: selftests/mm gup_longterm error while loading shared libraries liburing.so.2 cannot open shared object file No such file or directory

2025-06-16 Thread Christian Heusel
On 25/06/16 11:02PM, Naresh Kamboju wrote: > The following test regressions noticed while running selftests/mm gup_longterm > test cases on Dragonboard-845c, Dragonboard-410c, rock-pi-4, qemu-arm64 and > qemu-x86_64 this build have required selftest/mm/configs included and > toolchain > is clang n

Re: [PATCH v2 0/4] arm64: dts: qcom: msm8976-longcheer-l9360: Add initial device tree

2025-06-16 Thread André Apitzsch
Am Montag, dem 16.06.2025 um 13:46 +0200 schrieb Konrad Dybcio: > On 6/15/25 10:35 PM, André Apitzsch via B4 Relay wrote: > > This dts adds support for BQ Aquaris X5 Plus (Longcheer L9360) > > released > > in 2016. > > > > Add a device tree with initial support for: > > > > - GPIO keys > > - NFC

Re: Virtio-IOMMU interrupt remapping design

2025-06-16 Thread Jason Gunthorpe
On Mon, Jun 16, 2025 at 12:53:40PM -0400, Demi Marie Obenour wrote: > > AFAIK hyperv shows how to build something like this. > Would this need KVM patches? I'm concerned that implementing this > in userspace would interact badly with the irqfd fast path. I don't know. I think you get the same is

Re: [PATCH 2/6] selftest/mm: Fix ksm_funtional_test failures

2025-06-16 Thread Liam R. Howlett
* Aboorva Devarajan [250616 12:07]: > From: Donet Tom > > This patch fixed 2 issues. > > 1)After fork() in test_prctl_fork, the child process uses the file > descriptors from the parent process to read ksm_stat and > ksm_merging_pages. This results in incorrect values being read (parent > proce

Re: Virtio-IOMMU interrupt remapping design

2025-06-16 Thread Demi Marie Obenour
On 6/16/25 09:20, Jason Gunthorpe wrote: > On Sun, Jun 15, 2025 at 02:47:15PM -0400, Demi Marie Obenour wrote: > >> Is a paravirtualized IOMMU with interrupt remapping something that makes >> sense? > > IMHO linking interrupt remapping to the iommu is a poor design, > interrupt routing belongs in

Re: [PATCH rc 2/4] iommufd/selftest: Add missing close(mfd) in memfd_mmap()

2025-06-16 Thread Jason Gunthorpe
On Sun, Jun 15, 2025 at 10:02:04PM -0700, Nicolin Chen wrote: > Do not forget to close mfd in the error paths, since none of the callers > would close it when ASSERT_NE(MAP_FAILED, buf) fails. > > Fixes: 0bcceb1f51c7 ("iommufd: Selftest coverage for IOMMU_IOAS_MAP_FILE") > Cc: sta...@vger.kernel.o

Re: [PATCH 3/6] selftests/mm : fix test_prctl_fork_exec failure

2025-06-16 Thread Dev Jain
On 16/06/25 9:36 pm, Aboorva Devarajan wrote: From: Donet Tom execv argument is an array of pointers to null-terminated strings. In this patch we added NULL in the execv argument to fix the test failure. Just a comment, how did this test suddenly start failing now? Also is a fixes tag requi

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-16 Thread Dev Jain
On 16/06/25 9:36 pm, Aboorva Devarajan wrote: From: Donet Tom In this patch, we are fixing three issues in the virtual_address_range test. 1. validate_addr() checks if the allocated address is within the range. In the current implementation, if addr is greater than HIGH_ADDR_MARK, the test f

Re: [PATCH rc 4/4] iommufd/selftest: Fix build warnings due to uninitialized mfd

2025-06-16 Thread Jason Gunthorpe
On Sun, Jun 15, 2025 at 10:02:06PM -0700, Nicolin Chen wrote: > Commit 869c788909b9 ("selftests: harness: Stop using setjmp()/longjmp()") > changed the harness structure. For some unknown reason, two build warnings > occur to the iommufd selftest: > > iommufd.c: In function ‘wrapper_iommufd_mock_d

Re: [PATCH rc 3/4] iommufd/selftest: Add asserts testing global mfd

2025-06-16 Thread Jason Gunthorpe
On Sun, Jun 15, 2025 at 10:02:05PM -0700, Nicolin Chen wrote: > The mfd and mfd_buffer will be used in the tests directly without an extra > check. Test them in setup_sizes() to ensure they are safe to use. > > Fixes: 0bcceb1f51c7 ("iommufd: Selftest coverage for IOMMU_IOAS_MAP_FILE") > Cc: sta...

Re: [PATCH rc 1/4] iommufd/selftest: Fix iommufd_dirty_tracking with large hugepage sizes

2025-06-16 Thread Jason Gunthorpe
On Sun, Jun 15, 2025 at 10:02:03PM -0700, Nicolin Chen wrote: > FIXTURE_TEARDOWN(iommufd_dirty_tracking) > { > - munmap(self->buffer, variant->buffer_size); > - munmap(self->bitmap, DIV_ROUND_UP(self->bitmap_size, BITS_PER_BYTE)); > + unsigned long size = variant->buffer_size; > + > +

Re: [PATCH 0/6] selftests/mm: Fix false positives and skip unsupported tests

2025-06-16 Thread Lorenzo Stoakes
Hi Aboorva, It's (highly!) forgivable as things have changed fairly recently, but the tippy tip of mm development is now done in the mm-new branch, against which this series doesn't apply. I thought this might be the case, as there is a series I implemented there that changes the split huge page

Re: Virtio interrupt remapping

2025-06-16 Thread Jean-Philippe Brucker
[+Eric] On Sat, Jun 14, 2025 at 10:11:52AM +0200, Alyssa Ross wrote: > Demi Marie Obenour writes: > > > On 6/13/25 14:13, Jean-Philippe Brucker wrote: > >> Hi, > >> > >> On Fri, Jun 13, 2025 at 01:08:07PM -0400, Demi Marie Obenour wrote: > >>> I’m working on virtio-IOMMU interrupt remapping for

Re: [PATCH v4 3/3] remoteproc: imx_rproc: detect and attach to pre-booted remote cores

2025-06-16 Thread Hiago De Franco
Hi Peng, On Thu, Jun 12, 2025 at 02:03:17PM -0300, Hiago De Franco wrote: > Hi Peng, > > On Wed, Jun 11, 2025 at 03:27:09AM +, Peng Fan wrote: > > > > > > Sorry for the delay. > > > > > > I tested it now and there must be something missing on my U-Boot: > > > > > > Disable imx8x-cm4 rsrc 2

Re: [PATCH v2] selftests: nettest: Fix typo in log and error messages for clarity

2025-06-16 Thread Simon Horman
On Sun, Jun 15, 2025 at 01:48:12AM -0700, Alok Tiwari wrote: > This patch corrects several logging and error message in nettest.c: > - Corrects function name in log messages "setsockopt" -> "getsockopt". > - Closes missing parentheses in "setsockopt(IPV6_FREEBIND)". > - Replaces misleading error te

Re: [PATCH net-next v2 3/3] test/vsock: Add ioctl SIOCINQ tests

2025-06-16 Thread Stefano Garzarella
On Mon, 16 Jun 2025 at 16:39, Xuewei Niu wrote: > > > On Fri, Jun 13, 2025 at 11:11:52AM +0800, Xuewei Niu wrote: > > >This patch adds SIOCINQ ioctl tests for both SOCK_STREAM and > > >SOCK_SEQPACKET. > > > > > >The client waits for the server to send data, and checks if the SIOCINQ > > >ioctl val

Re: [PATCH net-next v2 1/3] vsock: Add support for SIOCINQ ioctl

2025-06-16 Thread Xuewei Niu
> On Mon, Jun 16, 2025 at 03:42:53PM +0200, Luigi Leonardi wrote: > >On Fri, Jun 13, 2025 at 11:11:50AM +0800, Xuewei Niu wrote: > >>This patch adds support for SIOCINQ ioctl, which returns the number of > >>bytes unread in the socket. > >> > >>Signed-off-by: Xuewei Niu > >>--- > >>include/net/af_

Re: [PATCH net-next v2 1/3] netmem: fix netmem comments

2025-06-16 Thread Stanislav Fomichev
On 06/15, Mina Almasry wrote: > Trivial fix to a couple of outdated netmem comments. No code changes, > just more accurately describing current code. > > Signed-off-by: Mina Almasry Acked-by: Stanislav Fomichev

Re: [PATCH net-next v2 3/3] selftests: devmem: add ipv4 support to chunks test

2025-06-16 Thread Stanislav Fomichev
On 06/15, Mina Almasry wrote: > Add ipv4 support to the recently added chunks tests, which was added as > ipv6 only. > > Signed-off-by: Mina Almasry Acked-by: Stanislav Fomichev

Re: [PATCH net-next v2 3/3] test/vsock: Add ioctl SIOCINQ tests

2025-06-16 Thread Xuewei Niu
> On Fri, Jun 13, 2025 at 11:11:52AM +0800, Xuewei Niu wrote: > >This patch adds SIOCINQ ioctl tests for both SOCK_STREAM and > >SOCK_SEQPACKET. > > > >The client waits for the server to send data, and checks if the SIOCINQ > >ioctl value matches the data size. After consuming the data, the client

Re: [PATCH net-next v2 2/3] selftests: devmem: remove unused variable

2025-06-16 Thread Stanislav Fomichev
On 06/15, Mina Almasry wrote: > Trivial fix to unused variable. > > Signed-off-by: Mina Almasry Acked-by: Stanislav Fomichev

Re: [PATCH net-next v2 1/3] vsock: Add support for SIOCINQ ioctl

2025-06-16 Thread Stefano Garzarella
On Mon, Jun 16, 2025 at 10:28:22PM +0800, Xuewei Niu wrote: On Fri, Jun 13, 2025 at 11:11:50AM +0800, Xuewei Niu wrote: >This patch adds support for SIOCINQ ioctl, which returns the number of >bytes unread in the socket. > >Signed-off-by: Xuewei Niu >--- > include/net/af_vsock.h | 2 ++ > net/

Re: [PATCH net-next v3] vsock/test: Add test for null ptr deref when transport changes

2025-06-16 Thread Luigi Leonardi
ill always pass. Should we re-use what Michal is doing in https://lore.kernel.org/virtualization/20250528-vsock-test-inc-cov-v2-0-8f655b40d...@rbox.co/ to print a warning? Yes, good idea! IMHO we can skip the test if a G2H transport is loaded. I'll wait for Michal's patch to be merg

Re: [PATCH net-next v2 1/3] vsock: Add support for SIOCINQ ioctl

2025-06-16 Thread Luigi Leonardi
On Mon, Jun 16, 2025 at 03:42:53PM +0200, Luigi Leonardi wrote: On Fri, Jun 13, 2025 at 11:11:50AM +0800, Xuewei Niu wrote: This patch adds support for SIOCINQ ioctl, which returns the number of bytes unread in the socket. Signed-off-by: Xuewei Niu --- include/net/af_vsock.h | 2 ++ net/vmw_

Re: [PATCH net-next v2 1/3] vsock: Add support for SIOCINQ ioctl

2025-06-16 Thread Xuewei Niu
> On Fri, Jun 13, 2025 at 11:11:50AM +0800, Xuewei Niu wrote: > >This patch adds support for SIOCINQ ioctl, which returns the number of > >bytes unread in the socket. > > > >Signed-off-by: Xuewei Niu > >--- > > include/net/af_vsock.h | 2 ++ > > net/vmw_vsock/af_vsock.c | 22

Re: [PATCH v2 1/3] soc: qcom: mdt_loader: Ensure we don't read past the ELF header

2025-06-16 Thread Dmitry Baryshkov
On Tue, Jun 10, 2025 at 09:58:28PM -0500, Bjorn Andersson wrote: > When the MDT loader is used in remoteproc, the ELF header is sanitized > beforehand, but that's not necessary the case for other clients. > > Validate the size of the firmware buffer to ensure that we don't read > past the end as w

Re: [PATCH bpf-next v3 1/2] bpftool: Use appropriate permissions for map access

2025-06-16 Thread Quentin Monnet
2025-06-12 08:18 UTC+1000 ~ Slava Imameev > Modify several functions in tools/bpf/bpftool/common.c to allow > specification of requested access for file descriptors, such as > read-only access. > > Update bpftool to request only read access for maps when write > access is not required. This fixes

Re: [PATCH bpf-next v3 2/2] selftests/bpf: Add test for bpftool access to read-only protected maps

2025-06-16 Thread Quentin Monnet
2025-06-12 08:18 UTC+1000 ~ Slava Imameev > Add selftest cases that validate bpftool's expected behavior when > accessing maps protected from modification via security_bpf_map. > > The test includes a BPF program attached to security_bpf_map with two maps: > - A protected map that only allows rea

Re: [PATCH 1/2] module: Fix memory deallocation on error path in move_module()

2025-06-16 Thread Petr Pavlu
On 6/14/25 11:28 PM, Daniel Gomez wrote: >> This seems to be off by one. For instance, if the loop reaches the last >> valid type in mod_mem_type, MOD_INIT_RODATA, and successfully allocates >> its memory, the variable t gets set to MOD_INIT_RODATA. Subsequently, if >> an error occurs later in move

Re: [PATCH net-next v2 3/3] test/vsock: Add ioctl SIOCINQ tests

2025-06-16 Thread Stefano Garzarella
On Fri, Jun 13, 2025 at 11:11:52AM +0800, Xuewei Niu wrote: This patch adds SIOCINQ ioctl tests for both SOCK_STREAM and SOCK_SEQPACKET. The client waits for the server to send data, and checks if the SIOCINQ ioctl value matches the data size. After consuming the data, the client checks if the S

Re: [PATCH net-next v2 1/3] vsock: Add support for SIOCINQ ioctl

2025-06-16 Thread Stefano Garzarella
On Fri, Jun 13, 2025 at 11:11:50AM +0800, Xuewei Niu wrote: This patch adds support for SIOCINQ ioctl, which returns the number of bytes unread in the socket. Signed-off-by: Xuewei Niu --- include/net/af_vsock.h | 2 ++ net/vmw_vsock/af_vsock.c | 22 ++ 2 files changed, 24

Re: [PATCH net-next v2 1/3] vsock: Add support for SIOCINQ ioctl

2025-06-16 Thread Luigi Leonardi
On Fri, Jun 13, 2025 at 11:11:50AM +0800, Xuewei Niu wrote: This patch adds support for SIOCINQ ioctl, which returns the number of bytes unread in the socket. Signed-off-by: Xuewei Niu --- include/net/af_vsock.h | 2 ++ net/vmw_vsock/af_vsock.c | 22 ++ 2 files changed, 24

Re: [PATCH 2/2] vhost: vringh: Remove unused functions

2025-06-16 Thread Dr. David Alan Gilbert
* Simon Horman (ho...@kernel.org) wrote: > On Sat, Jun 14, 2025 at 12:07:31AM +0100, li...@treblig.org wrote: > > From: "Dr. David Alan Gilbert" > > > > The functions: > > vringh_abandon_kern() > > vringh_abandon_user() > > vringh_iov_pull_kern() and > > vringh_iov_push_kern() > > were al

Re: [PATCH v2 2/3] remoteproc: imx_rproc: Add support for System Manager API

2025-06-16 Thread Daniel Baluta
On Fri, Jun 6, 2025 at 4:57 AM Peng Fan (OSS) wrote: > > From: Peng Fan > > i.MX95 features a Cortex-M33 core, six Cortex-A55 cores, and > one Cortex-M7 core. The System Control Management Interface(SCMI) > firmware runs on the M33 core. The i.MX95 SCMI firmware named System > Manager(SM) include

Re: Virtio-IOMMU interrupt remapping design

2025-06-16 Thread Jason Gunthorpe
On Sun, Jun 15, 2025 at 02:47:15PM -0400, Demi Marie Obenour wrote: > Is a paravirtualized IOMMU with interrupt remapping something that makes > sense? IMHO linking interrupt remapping to the iommu is a poor design, interrupt routing belongs in the irq subsystem, not in the iommu. The fact AMD a

Re: [PATCH 2/2] vhost: vringh: Remove unused functions

2025-06-16 Thread Simon Horman
On Sat, Jun 14, 2025 at 12:07:31AM +0100, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > The functions: > vringh_abandon_kern() > vringh_abandon_user() > vringh_iov_pull_kern() and > vringh_iov_push_kern() > were all added in 2013 by > commit f87d0fbb5798 ("vringh: host-sid

Re: [PATCH 1/2] vhost: vringh: Remove unused iotlb functions

2025-06-16 Thread Simon Horman
On Sat, Jun 14, 2025 at 12:07:30AM +0100, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > The functions: > vringh_abandon_iotlb() > vringh_notify_disable_iotlb() and > vringh_notify_enable_iotlb() > > were added in 2020 by > commit 9ad9c49cfe97 ("vringh: IOTLB support") > but

Re: [PATCH v4 1/3] pmdomain: core: introduce dev_pm_genpd_is_on

2025-06-16 Thread Ulf Hansson
On Thu, 12 Jun 2025 at 19:31, Hiago De Franco wrote: > > On Wed, Jun 11, 2025 at 10:32:28AM -0500, Bjorn Andersson wrote: > > On Mon, Jun 02, 2025 at 10:19:03AM -0300, Hiago De Franco wrote: > > > From: Hiago De Franco > > > > > > This helper function returns the current power status of a given g

Re: [PATCH v2 1/3] dt-bindings: remoteproc: fsl,imx-rproc: Add support for i.MX95

2025-06-16 Thread Daniel Baluta
On Fri, Jun 6, 2025 at 4:57 AM Peng Fan (OSS) wrote: > > From: Peng Fan > > i.MX95 has a System Manager(SM) core runs the System Control Management > Interface(SCMI) firmware. Vendor extenions are implemented in the > firmware, Logical Machine Management(LMM) protocol to manage > Logical Machines

Re: [PATCH v2 0/4] arm64: dts: qcom: msm8976-longcheer-l9360: Add initial device tree

2025-06-16 Thread Konrad Dybcio
On 6/15/25 10:35 PM, André Apitzsch via B4 Relay wrote: > This dts adds support for BQ Aquaris X5 Plus (Longcheer L9360) released > in 2016. > > Add a device tree with initial support for: > > - GPIO keys > - NFC > - SDHCI > - Status LED > - Touchscreen > > Signed-off-by: André Apitzsch > --- >

Re: [PATCH net-next v4] page_pool: import Jesper's page_pool benchmark

2025-06-16 Thread Jesper Dangaard Brouer
On 15/06/2025 22.59, Mina Almasry wrote: From: Jesper Dangaard Brouer We frequently consult with Jesper's out-of-tree page_pool benchmark to evaluate page_pool changes. Import the benchmark into the upstream linux kernel tree so that (a) we're all running the same version, (b) pave the way

Re: [PATCH v2 2/4] dt-bindings: arm: qcom: Add MSM8976 BQ Aquaris X5 Plus

2025-06-16 Thread Krzysztof Kozlowski
On 15/06/2025 22:35, André Apitzsch via B4 Relay wrote: > From: André Apitzsch > > BQ Aquaris X5 Plus (Longcheer L9360) is a smartphone based on MSM8976 > SoC. > > Signed-off-by: André Apitzsch > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v4 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct

2025-06-15 Thread Ujwal Kundur
> And I hit this: > > # - > # running ./uffd-unit-tests > # - > # Testing UFFDIO_API (with syscall)... done > # Testing UFFDIO_API (with /dev/userfaultfd)... done > # Testing register-ioctls on anon... ERROR: munmap (errno=22, > @uffd-common.c:277) >

Re: [PATCH v4 0/7] Add managed SOFT RESERVE resource handling

2025-06-15 Thread Zhijian Li (Fujitsu)
On 05/06/2025 02:59, Koralahalli Channabasappa, Smita wrote: >> >> >> To the CXL community, >> >> The scenarios mentioned here essentially cover what a correct firmware may  >> provide. However, >> I would like to discuss one more scenario that I can simulate with a  >> modified QEMU: >> The E820

Re: [PATCH bpf 2/7] bpf/x86: prevent trampoline attachment when args location on stack is uncertain

2025-06-15 Thread Alexei Starovoitov
On Sun, Jun 15, 2025 at 7:00 AM Alexis Lothoré wrote: > > On Sat Jun 14, 2025 at 12:35 AM CEST, Alexei Starovoitov wrote: > > On Fri, Jun 13, 2025 at 1:59 AM Alexis Lothoré > > wrote: > >> > >> On Fri Jun 13, 2025 at 10:32 AM CEST, Peter Zijlstra wrote: > >> > On Fri, Jun 13, 2025 at 10:26:37AM +

Re: [PATCH v11 0/3] vhost: Add support of kthread API

2025-06-15 Thread Cindy Lu
On Thu, Jun 12, 2025 at 2:20 PM Michael S. Tsirkin wrote: > > On Mon, Jun 09, 2025 at 03:33:06PM +0800, Cindy Lu wrote: > > In this series, a new UAPI is implemented to allow > > userspace applications to configure their thread mode. > > > > Changelog v2: > > 1. Change the module_param's name to

Re: [PATCH v11 3/3] vhost: Add configuration controls for vhost worker's mode

2025-06-15 Thread Cindy Lu
On Thu, Jun 12, 2025 at 2:31 PM Michael S. Tsirkin wrote: > > On Mon, Jun 09, 2025 at 03:33:09PM +0800, Cindy Lu wrote: > > This patch introduces functionality to control the vhost worker mode: > > > > - Add two new IOCTLs: > > * VHOST_SET_FORK_FROM_OWNER: Allows userspace to select between > >

Re: [PATCH bpf 2/7] bpf/x86: prevent trampoline attachment when args location on stack is uncertain

2025-06-15 Thread Alexis Lothoré
On Sat Jun 14, 2025 at 12:35 AM CEST, Alexei Starovoitov wrote: > On Fri, Jun 13, 2025 at 1:59 AM Alexis Lothoré > wrote: >> >> On Fri Jun 13, 2025 at 10:32 AM CEST, Peter Zijlstra wrote: >> > On Fri, Jun 13, 2025 at 10:26:37AM +0200, Alexis Lothoré wrote: [...] >> If I need to respin, I'll rewr

Re: [PATCH][v2] virtio_fs: Remove redundant spinlock in virtio_fs_request_complete()

2025-06-15 Thread Stefan Hajnoczi
On Sun, Jun 15, 2025 at 9:21 AM lirongqing wrote: > > From: Li RongQing > > Since clear_bit is an atomic operation, the spinlock is redundant and > can be removed, reducing lock contention is good for performance. > > Signed-off-by: Li RongQing > --- > Diff with v1: remove unused variable "fpq"

Re: [PATCH] virtio_fs: Remove redundant spinlock in virtio_fs_request_complete()

2025-06-15 Thread Stefan Hajnoczi
On Fri, Jun 13, 2025 at 1:51 AM lirongqing wrote: > > From: Li RongQing > > Since clear_bit is an atomic operation, the spinlock is redundant and > can be removed, reducing lock contention is good for performance. > > Signed-off-by: Li RongQing > --- > fs/fuse/virtio_fs.c | 2 -- > 1 file chang

Re: [PATCH 1/2] module: Fix memory deallocation on error path in move_module()

2025-06-14 Thread Daniel Gomez
> This seems to be off by one. For instance, if the loop reaches the last > valid type in mod_mem_type, MOD_INIT_RODATA, and successfully allocates > its memory, the variable t gets set to MOD_INIT_RODATA. Subsequently, if > an error occurs later in move_module() and control is transferred to > out

Re: [PATCH 3/3] arm64: dts: qcom: msm8976-longcheer-l9360: Add initial device tree

2025-06-14 Thread Konrad Dybcio
On 6/13/25 12:37 AM, André Apitzsch via B4 Relay wrote: > From: André Apitzsch > > This dts adds support for BQ Aquaris X5 Plus (Longcheer L9360) released > in 2016. > > Add a device tree with initial support for: > > - GPIO keys > - NFC > - SDHCI > - Status LED > - Touchscreen > > Signed-off-

Re: [PATCH 1/3] arm64: dts: qcom: msm8976: Make blsp_dma controlled-remotely

2025-06-14 Thread Konrad Dybcio
On 6/13/25 12:37 AM, André Apitzsch via B4 Relay wrote: > From: André Apitzsch > > The blsp_dma controller is shared between the different subsystems, > which is why it is already initialized by the firmware. We should not > reinitialize it from Linux to avoid potential other users of the DMA > e

Re: [PATCH net-next v1 2/4] netmem: fix netmem comments

2025-06-14 Thread Jakub Kicinski
On Fri, 13 Jun 2025 04:28:02 + Mina Almasry wrote: > +/* __netmem_clear_lsb - clear the lsb of &netmem and return it as > + * a net_iov*. nit: "clear the lsb" spells out the name of the function.. how about: convert netmem_ref to struct net_iov * for metadata access or some such ? > + * @netm

Re: [PATCH net-next v1 1/4] net: netmem: fix skb_ensure_writable with unreadable skbs

2025-06-14 Thread Jakub Kicinski
On Fri, 13 Jun 2025 04:28:01 + Mina Almasry wrote: > skb_ensure_writable actually makes sure that the header of the skb is > writable, and doesn't touch the payload. It doesn't need an > skb_frags_readable check. "doesn't touch the payload" is a bit misleading. What I'd say instead is that the

Re: [PATCH net-next v3] page_pool: import Jesper's page_pool benchmark

2025-06-14 Thread Jakub Kicinski
On Fri, 13 Jun 2025 23:44:20 + Mina Almasry wrote: > From: Jesper Dangaard Brouer > > We frequently consult with Jesper's out-of-tree page_pool benchmark to > evaluate page_pool changes. > > Import the benchmark into the upstream linux kernel tree so that (a) > we're all running the same ver

Re: Virtio interrupt remapping

2025-06-14 Thread Alyssa Ross
Demi Marie Obenour writes: > On 6/13/25 14:13, Jean-Philippe Brucker wrote: >> Hi, >> >> On Fri, Jun 13, 2025 at 01:08:07PM -0400, Demi Marie Obenour wrote: >>> I’m working on virtio-IOMMU interrupt remapping for Spectrum OS [1], >>> and am running into a problem. All of the current interrupt r

Re: [PATCH net-next, v3] selftest: Add selftest for multicast address notifications

2025-06-13 Thread Yuyang Huang
Thanks for the suggestion. >Perhaps move these to lib.sh as a separate commit? >They seem generic. I am looking at the existing test cases, and it seems that each case is doing its own way of handling the end_test()/run_cmd(). It's non-trivial to unify everything into lib.sh, and it seems to be a

Re: [PATCH v3 RESEND] selftests: filesystems: Add functional test for the abort file in fusectl

2025-06-13 Thread Chen Linxuan
On Thu, Jun 12, 2025 at 4:56 PM Miklos Szeredi wrote: > > On Tue, 10 Jun 2025 at 04:10, Chen Linxuan wrote: > > > > This patch add a simple functional test for the "abort" file > > in fusectlfs (/sys/fs/fuse/connections/ID/about). > > > > A simple fuse daemon is added for testing. > > > > Related

Re: [PATCH v17 2/6] remoteproc: Add TEE support

2025-06-13 Thread kernel test robot
Hi Arnaud, kernel test robot noticed the following build warnings: [auto build test WARNING on 19272b37aa4f83ca52bdf9c16d5d81bdd1354494] url: https://github.com/intel-lab-lkp/linux/commits/Arnaud-Pouliquen/remoteproc-core-Introduce-rproc_pa_to_va-helper/20250613-172251 base: 19272b37aa4f83

Re: [PATCH] gendwarfksyms: Fix structure type overrides

2025-06-13 Thread Sami Tolvanen
Hi Petr, On Fri, Jun 13, 2025 at 12:52 PM Petr Pavlu wrote: > > Nit: This code was the only user of __cache_was_expanded() and > __cache_mark_expanded(). It is now possible to merge > __cache_was_expanded() into cache_was_expanded() and > __cache_mark_expanded() into cache_mark_expanded(). Nice

Re: [PATCH net-next RFC] selftests: net: add netpoll basic functionality test

2025-06-13 Thread Jakub Kicinski
On Fri, 13 Jun 2025 05:47:50 -0700 Breno Leitao wrote: > > Or is there another way that the packets could be observed, e.g., > > counters. > > Unfortunately netpoll doesn't expose any data, thus, it is hard to get > it. > > I have plans to create a configfs for netpoll, so, we can check for >

Re: [PATCH net-next, v3] selftest: Add selftest for multicast address notifications

2025-06-13 Thread Jakub Kicinski
On Thu, 12 Jun 2025 11:05:14 +0900 Yuyang Huang wrote: > +VERBOSE=0 > +PAUSE=no > +PAUSE_ON_FAIL=no > + > +source lib.sh > + > +# set global exit status, but never reset nonzero one. > +check_err() > +{ > + if [ $ret -eq 0 ]; then > + ret=$1 > + fi > + [ -n "$2" ] && echo "$

Re: [PATCH bpf 2/7] bpf/x86: prevent trampoline attachment when args location on stack is uncertain

2025-06-13 Thread Alexei Starovoitov
On Fri, Jun 13, 2025 at 1:59 AM Alexis Lothoré wrote: > > On Fri Jun 13, 2025 at 10:32 AM CEST, Peter Zijlstra wrote: > > On Fri, Jun 13, 2025 at 10:26:37AM +0200, Alexis Lothoré wrote: > >> Hi Peter, > >> > >> On Fri Jun 13, 2025 at 10:11 AM CEST, Peter Zijlstra wrote: > >> > On Fri, Jun 13, 2025

Re: [PATCH v4 7/7] mm/maps: execute PROCMAP_QUERY ioctl under per-vma locks

2025-06-13 Thread Andrii Nakryiko
On Wed, Jun 4, 2025 at 4:12 PM Suren Baghdasaryan wrote: > > Utilize per-vma locks to stabilize vma after lookup without taking > mmap_lock during PROCMAP_QUERY ioctl execution. While we might take > mmap_lock for reading during contention, we do that momentarily only > to lock the vma. > This cha

Re: [PATCH] virtio_fs: Remove redundant spinlock in virtio_fs_request_complete()

2025-06-13 Thread kernel test robot
Hi lirongqing, kernel test robot noticed the following build warnings: [auto build test WARNING on mszeredi-fuse/for-next] [also build test WARNING on linus/master v6.16-rc1 next-20250613] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we sugges

Re: [PATCH v4 0/7] use per-vma locks for /proc/pid/maps reads and PROCMAP_QUERY

2025-06-13 Thread Lorenzo Stoakes
On Fri, Jun 13, 2025 at 12:11:43PM -0700, Suren Baghdasaryan wrote: > On Fri, Jun 13, 2025 at 8:01 AM Lorenzo Stoakes > wrote: > > > > Hi Suren, > > > > I promised I'd share VMA merging scenarios so we can be absolutely sure we > > have > > all cases covered, I share that below. I also included i

Re: [PATCH v4 0/7] use per-vma locks for /proc/pid/maps reads and PROCMAP_QUERY

2025-06-13 Thread Suren Baghdasaryan
On Fri, Jun 13, 2025 at 8:01 AM Lorenzo Stoakes wrote: > > Hi Suren, > > I promised I'd share VMA merging scenarios so we can be absolutely sure we > have > all cases covered, I share that below. I also included information on split. Thanks Lorenzo! This is great and very helpful. > > Hopefully

Re: Virtio interrupt remapping

2025-06-13 Thread Demi Marie Obenour
On 6/13/25 14:13, Jean-Philippe Brucker wrote: > Hi, > > On Fri, Jun 13, 2025 at 01:08:07PM -0400, Demi Marie Obenour wrote: >> I’m working on virtio-IOMMU interrupt remapping for Spectrum OS [1], >> and am running into a problem. All of the current interrupt remapping >> drivers use __init code

Re: Virtio interrupt remapping

2025-06-13 Thread Jean-Philippe Brucker
Hi, On Fri, Jun 13, 2025 at 01:08:07PM -0400, Demi Marie Obenour wrote: > I’m working on virtio-IOMMU interrupt remapping for Spectrum OS [1], > and am running into a problem. All of the current interrupt remapping > drivers use __init code during initialization, and I’m not sure how to > plumb t

Re: [PATCH v2] remoteproc: xlnx: allow single core use in split mode

2025-06-13 Thread Tanmay Shah
On 6/13/25 12:18 PM, Mathieu Poirier wrote: Good day, On Tue, Jun 10, 2025 at 12:27:38PM -0700, Tanmay Shah wrote: It's a valid use case to have only one core enabled in cluster in split mode. Remove exact core count expecatation from the driver. I suggest: "When operating in split mode,

Re: [PATCH v2] remoteproc: xlnx: allow single core use in split mode

2025-06-13 Thread Mathieu Poirier
Good day, On Tue, Jun 10, 2025 at 12:27:38PM -0700, Tanmay Shah wrote: > It's a valid use case to have only one core enabled in cluster in split > mode. Remove exact core count expecatation from the driver. I suggest: "When operating in split mode, it is a valid usecase to have only one core ena

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-13 Thread Vladimir Zapolskiy
On 6/13/25 12:33, Vincent Knecht via B4 Relay wrote: From: Vincent Knecht Add bindings for qcom,msm8939-camss in order to support the camera subsystem for MSM8939. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Vincent Knecht Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir

Re: [RFC PATCH 1/1] nvdimm: allow exposing RAM carveouts as NVDIMM DIMM devices

2025-06-13 Thread Mike Rapoport
On Thu, Jun 12, 2025 at 02:12:42PM -0700, jane@oracle.com wrote: > > On 6/12/2025 1:31 AM, Mike Rapoport wrote: > > From: "Mike Rapoport (Microsoft)" > > > > There are use cases, for example virtual machine hosts, that create > > "persistent" memory regions using memmap= option on x86 or dum

Re: [PATCH v3 2/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pmd()

2025-06-13 Thread David Hildenbrand
On 13.06.25 16:00, Lorenzo Stoakes wrote: On Fri, Jun 13, 2025 at 03:53:58PM +0200, David Hildenbrand wrote: On 13.06.25 15:49, Oscar Salvador wrote: On Fri, Jun 13, 2025 at 11:27:01AM +0200, David Hildenbrand wrote: Marking PMDs that map a "normal" refcounted folios as special is against our

Re: [PATCH net] virtio-net: drop the multi-buffer XDP packet in zerocopy

2025-06-13 Thread Bui Quang Minh
On 6/11/25 03:37, Jakub Kicinski wrote: On Tue, 10 Jun 2025 22:18:32 +0700 Bui Quang Minh wrote: Furthermore, we are in the zerocopy so we cannot linearize by allocating a large enough buffer to cover the whole frame then copy the frame data to it. That's not zerocopy anymore. Also, XDP socket z

Re: [PATCH net-next v3 2/3] vsock/test: Introduce get_transports()

2025-06-13 Thread Luigi Leonardi
Hi Michal, On Wed, Jun 11, 2025 at 09:56:51PM +0200, Michal Luczaj wrote: Return a bitmap of registered vsock transports. As guesstimated by grepping /proc/kallsyms (CONFIG_KALLSYMS=y) for known symbols of type `struct vsock_transport`, or `struct virtio_transport` in case the vsock_transport

Re: [PATCH net-next v2 4/4] netdevsim: account dropped packet length in stats on queue free

2025-06-13 Thread Breno Leitao
On Fri, Jun 13, 2025 at 07:55:07AM -0700, Jakub Kicinski wrote: > On Fri, 13 Jun 2025 07:47:11 -0700 Breno Leitao wrote: > > > static void nsim_queue_free(struct nsim_rq *rq) > > > { > > > + struct net_device *dev = rq->napi.dev; > > > + > > > hrtimer_cancel(&rq->napi_timer); > > > + dev_dstats

Re: [PATCH v4 0/7] use per-vma locks for /proc/pid/maps reads and PROCMAP_QUERY

2025-06-13 Thread Lorenzo Stoakes
Hi Suren, I promised I'd share VMA merging scenarios so we can be absolutely sure we have all cases covered, I share that below. I also included information on split. Hopefully this is useful! And maybe we can somehow put in a comment or commit msg or something somewhere? Not sure if a bit much f

Re: [PATCH net-next v3 1/3] vsock/test: Introduce vsock_bind_try() helper

2025-06-13 Thread Luigi Leonardi
On Wed, Jun 11, 2025 at 09:56:50PM +0200, Michal Luczaj wrote: Create a socket and bind() it. If binding failed, gracefully return an error code while preserving `errno`. Base vsock_bind() on top of it. Suggested-by: Stefano Garzarella Reviewed-by: Stefano Garzarella Signed-off-by: Michal Luc

Re: [PATCH net-next v2 4/4] netdevsim: account dropped packet length in stats on queue free

2025-06-13 Thread Jakub Kicinski
On Fri, 13 Jun 2025 07:47:11 -0700 Breno Leitao wrote: > > static void nsim_queue_free(struct nsim_rq *rq) > > { > > + struct net_device *dev = rq->napi.dev; > > + > > hrtimer_cancel(&rq->napi_timer); > > + dev_dstats_rx_dropped_add(dev, rq->skb_queue.qlen); > > This is wrong and it wi

Re: [PATCH net-next v2 4/4] netdevsim: account dropped packet length in stats on queue free

2025-06-13 Thread Breno Leitao
On Fri, Jun 13, 2025 at 03:40:01AM -0700, Breno Leitao wrote: > Add a call to dev_dstats_rx_dropped_add() in nsim_queue_free() to > account for the number of packets dropped when purging the skb queue. > > This improves the accuracy of RX drop statistics reported by > netdevsim. > > Suggested-by:

Re: [PATCH 1/2] dt-bindings: remoteproc: qcom,sa8775p-pas: Correct the interrupt number

2025-06-13 Thread Dmitry Baryshkov
On Thu, Jun 12, 2025 at 10:39:32AM +0800, Lijuan Gao wrote: > Correct the interrupt number of ready and handover in the DTS example. > > Fixes: af5da7b0944c ("dt-bindings: remoteproc: qcom,sa8775p-pas: Document the > SA8775p ADSP, CDSP and GPDSP") > Signed-off-by: Lijuan Gao > --- > Documentati

Re: [PATCH net-next RFC] selftests: net: add netpoll basic functionality test

2025-06-13 Thread Breno Leitao
On Fri, Jun 13, 2025 at 09:43:35AM -0400, Willem de Bruijn wrote: > Breno Leitao wrote: > > > > +def check_traffic_flowing(cfg: NetDrvEpEnv, netdevnl: NetdevFamily) -> > > > > int: > > > > +"""Check if traffic is flowing on the interface""" > > > > +stat1 = get_stats(cfg, netdevnl) > > >

Re: [PATCH v3 2/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pmd()

2025-06-13 Thread Lorenzo Stoakes
On Fri, Jun 13, 2025 at 03:53:58PM +0200, David Hildenbrand wrote: > On 13.06.25 15:49, Oscar Salvador wrote: > > On Fri, Jun 13, 2025 at 11:27:01AM +0200, David Hildenbrand wrote: > > > Marking PMDs that map a "normal" refcounted folios as special is > > > against our rules documented for vm_norma

  1   2   3   4   5   6   7   8   9   10   >