Re: [PATCH 1/2] extcon: Use the unique id for external connector instead of string

2015-05-19 Thread Chanwoo Choi
On 05/20/2015 12:24 PM, Krzysztof Kozlowski wrote: > On 19.05.2015 21:28, Chanwoo Choi wrote: >> Hi Krzysztof, >> > + > + if (i == edev->max_supported) > + return -EINVAL; > > if (index < 0 || (edev->max_supported && edev->max_supported <= > inde

Re: [PATCH 1/2] extcon: Use the unique id for external connector instead of string

2015-05-19 Thread Krzysztof Kozlowski
On 19.05.2015 21:28, Chanwoo Choi wrote: > Hi Krzysztof, > + + if (i == edev->max_supported) + return -EINVAL; if (index < 0 || (edev->max_supported && edev->max_supported <= index)) return -EINVAL; @@ -605,7 +644

Re: [PATCH 1/2] extcon: Use the unique id for external connector instead of string

2015-05-19 Thread Chanwoo Choi
Hi Krzysztof, >>> + >>> + if (i == edev->max_supported) >>> + return -EINVAL; >>> >>> if (index < 0 || (edev->max_supported && edev->max_supported <= >>> index)) >>> return -EINVAL; >>> @@ -605,7 +644,7 @@ static void dummy_sysfs_dev_release(struct devi

Re: [PATCH 1/2] extcon: Use the unique id for external connector instead of string

2015-05-17 Thread Krzysztof Kozlowski
--george.cher...@ti.com Mail bounces. 2015-05-17 16:53 GMT+09:00 Chanwoo Choi : > Hi Krzysztof, > > On Sun, May 17, 2015 at 4:10 PM, Krzysztof Kozlowski >>> @@ -32,36 +35,43 @@ >>> #include >>> #include >>> >>> -/* >>> - * extcon_cable_name suggests the standard cable names for commonly used >

Re: [PATCH 1/2] extcon: Use the unique id for external connector instead of string

2015-05-17 Thread Chanwoo Choi
Hi Krzysztof, On Sun, May 17, 2015 at 4:10 PM, Krzysztof Kozlowski wrote: > 2015-05-15 23:31 GMT+09:00 Chanwoo Choi : >> This patch uses the unique id to identify the type of external connector >> instead >> of string name. The string name have the many potential issues. So, this >> patch >> de

Re: [PATCH 1/2] extcon: Use the unique id for external connector instead of string

2015-05-17 Thread Krzysztof Kozlowski
2015-05-15 23:31 GMT+09:00 Chanwoo Choi : > This patch uses the unique id to identify the type of external connector > instead > of string name. The string name have the many potential issues. So, this patch > defines the 'extcon' enumeration which includes all supported external > connector > on

RE: [PATCH 1/2] extcon: Use the unique id for external connector instead of string

2015-05-15 Thread Pallala, Ramakrishna
> This patch uses the unique id to identify the type of external connector > instead > of string name. The string name have the many potential issues. So, this patch > defines the 'extcon' enumeration which includes all supported external > connector > on EXTCON subsystem. If new external connecto

Re: [PATCH 1/2] extcon: Use the unique id for external connector instead of string

2015-05-15 Thread Charles Keepax
On Fri, May 15, 2015 at 11:31:17PM +0900, Chanwoo Choi wrote: > This patch uses the unique id to identify the type of external connector > instead > of string name. The string name have the many potential issues. So, this patch > defines the 'extcon' enumeration which includes all supported extern

Re: [PATCH 1/2] extcon: Use the unique id for external connector instead of string

2015-05-15 Thread Roger Quadros
On 15/05/15 17:31, Chanwoo Choi wrote: This patch uses the unique id to identify the type of external connector instead of string name. The string name have the many potential issues. So, this patch defines the 'extcon' enumeration which includes all supported external connector on EXTCON subsyst