Re: [PATCH v2] selftest: remoteproc: Add basic test for start/stop sequence

2024-10-03 Thread Wasim Nazir
On Sun, Sep 29, 2024 at 10:03:23PM -0500, Bjorn Andersson wrote: > On Fri, Sep 27, 2024 at 04:51:32PM GMT, Wasim Nazir wrote: > > This test includes: > > 1) Start/stop test for each rproc instance sequencially > > 2) Start/stop test for all rproc instances concurrently > > > > This fails

Re: [PATCH net-next v8 12/24] ovpn: store tunnel and transport statistics

2024-10-03 Thread kernel test robot
Hi Antonio, kernel test robot noticed the following build warnings: [auto build test WARNING on 44badc908f2c85711cb18e45e13119c10ad3a05f] url: https://github.com/intel-lab-lkp/linux/commits/Antonio-Quartulli/netlink-add-NLA_POLICY_MAX_LEN-macro/20241002-172734 base: 44badc908f2c85711cb18e4

Re: [PATCH] vsock/virtio: use GFP_ATOMIC under RCU read lock

2024-10-03 Thread Christian Brauner
On Wed, Oct 02, 2024 at 09:41:42AM GMT, Michael S. Tsirkin wrote: > virtio_transport_send_pkt in now called on transport fast path, > under RCU read lock. In that case, we have a bug: virtio_add_sgs > is called with GFP_KERNEL, and might sleep. > > Pass the gfp flags as an argument, and use GFP_AT

Re: [PATCH] selftests/net: Add missing va_end.

2024-10-03 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by Paolo Abeni : On Fri, 27 Sep 2024 12:00:50 +0800 you wrote: > From: zhang jiao > > There is no va_end after va_copy, just add it. > > Signed-off-by: zhang jiao > --- > tools/testing/selftests/net/tcp_ao/lib/aolib.h | 1 + > 1 fil

Re: [PATCH v3 1/1] lib/llist_kunit.c: add KUnit tests for llist

2024-10-02 Thread David Gow
On Tue, 17 Sept 2024 at 08:51, Artur Alves wrote: > > Add KUnit tests for the llist data structure. They test the vast > majority of methods and macros defined in include/linux/llist.h. > > These are inspired by the existing tests for the 'list' doubly > linked in lib/list-test.c. Each test case (

Re: [PATCH slab hotfixes 2/2] kunit: move call to kunit_run_all_tests() after rcu_end_inkernel_boot()

2024-10-02 Thread David Gow
On Tue, 1 Oct 2024 at 07:55, Guenter Roeck wrote: > > On 9/30/24 11:50, Guenter Roeck wrote: > > On 9/30/24 01:37, Vlastimil Babka wrote: > >> Guenter Roeck reports that the new slub kunit tests added by commit > >> 4e1c44b3db79 ("kunit, slub: add test_kfree_rcu() and > >> test_leak_destroy()") ca

Re: [PATCH] Revert "list: test: fix tests for list_cut_position()"

2024-10-02 Thread David Gow
gt; Revert it. > >> > >> Fixes: e620799c414a ("list: test: fix tests for list_cut_position()") > >> Cc: I Hsin Cheng > >> Cc: David Gow > >> Cc: Andrew Morton > >> Signed-off-by: Guenter Roeck > >> --- > > >

Re: [RESEND PATCH v3] list: test: Mending tests for list_cut_position()

2024-10-02 Thread David Gow
On Tue, 1 Oct 2024 at 01:06, I Hsin Cheng wrote: > > Mending test for list_cut_position*() for the missing check of integer > "i" after the second loop. The variable should be checked for second > time to make sure both lists after the cut operation are formed as > expected. > > Signed-off-by: I H

Re: [PATCH V3 1/1] livepatch: Add "stack_order" sysfs attribute

2024-10-02 Thread zhang warden
Hi, Josh! > On Oct 1, 2024, at 07:26, Josh Poimboeuf wrote: >> >> diff --git a/Documentation/ABI/testing/sysfs-kernel-livepatch >> b/Documentation/ABI/testing/sysfs-kernel-livepatch >> index a5df9b4910dc..2a60b49aa9a5 100644 >> --- a/Documentation/ABI/testing/sysfs-kernel-livepatch >> +++ b/Do

Re: [PATCH 6.6 000/538] 6.6.54-rc1 review

2024-10-02 Thread Naresh Kamboju
On Wed, 2 Oct 2024 at 19:56, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 6.6.54 release. > There are 538 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Resp

Re: [PATCH 1/2] compiler.h: Introduce ptr_eq() to preserve address dependency

2024-10-02 Thread 'Alan Stern'
On Wed, Oct 02, 2024 at 03:24:45PM +, David Laight wrote: > I think I know what you are trying to do, and you just fail. > Whether something can work is another matter, but that code > can't ever work. > > Inside if (a == b) the compiler will always use the same register > for references to a

Re: [PATCH] vsock/virtio: use GFP_ATOMIC under RCU read lock

2024-10-02 Thread Luigi Leonardi
> Link: > https://lore.kernel.org/all/hfcr2aget2zojmqpr4uhlzvnep4vgskblx5b6xf2ddosbsrke7@nt34bxgp7j2x > Fixes: efcd71af38be ("vsock/virtio: avoid queuing packets when intermediate > queue is empty") > Reported-by: Christian Brauner > Cc: Stefano Garzarella > Cc: Luigi Leonardi > Signed-off-by:

Re: [PATCH net] selftests: rds: move include.sh to TEST_FILES

2024-10-02 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Fri, 27 Sep 2024 12:13:49 +0800 you wrote: > The include.sh file is generated for inclusion and should not be executable. > Otherwise, it will be added to kselftest-list.txt. Additionally, add the > executable bit for t

Re: [RFC PATCH 3/4] hp: Implement Hazard Pointers

2024-10-02 Thread Boqun Feng
On Tue, Oct 01, 2024 at 09:02:04PM -0400, Mathieu Desnoyers wrote: > This API provides existence guarantees of objects through Hazard > Pointers (HP). > > Each HP domain defines a fixed number of hazard pointer slots (nr_cpus) > across the entire system. > > Its main benefit over RCU is that it a

Re: [RFC PATCH 1/4] compiler.h: Introduce ptr_eq() to preserve address dependency

2024-10-02 Thread Joel Fernandes
On Tue, Oct 01, 2024 at 09:02:02PM -0400, Mathieu Desnoyers wrote: > Compiler CSE and SSA GVN optimizations can cause the address dependency > of addresses returned by rcu_dereference to be lost when comparing those > pointers with either constants or previously loaded pointers. > > Introduce ptr_

Re: [PATCH] selftests/vdso: Add linux/sched.h to fix CLONE_NEWTIME build error

2024-10-02 Thread Jason A. Donenfeld
Wasn't this already submitted and commented on? https://lore.kernel.org/all/20240919111841.20226-1-liaoy...@huawei.com/

Re: [PATCH HID v3 0/9] HID: bpf: add a new hook to control hid-generic

2024-10-02 Thread Shuah Khan
On 10/1/24 08:30, Benjamin Tissoires wrote: This is a slight change from the fundamentals of HID-BPF. In theory, HID-BPF is abstract to the kernel itself, and makes only changes at the HID level (through report descriptors or events emitted to/from the device). However, we have seen a few use ca

Re: [PATCH] selftests/vdso: Add linux/sched.h to fix CLONE_NEWTIME build error

2024-10-02 Thread Shuah Khan
On 10/2/24 09:28, SurajSonawane2415 wrote: Fix build error in vdso_test_getrandom.c due to missing CLONE_NEWTIME. Include linux/sched.h to define CLONE_NEWTIME. Ensure successful compilation by resolving the missing header issue. Did you run "make headers" before building this test? It builds

Re: [PATCH net-next v8 24/24] testing/selftest: add test tool and scripts for ovpn module

2024-10-02 Thread Shuah Khan
On 10/2/24 03:02, Antonio Quartulli wrote: The ovpn-cli tool can be compiled and used as selftest for the ovpn kernel module. Does this test load ovpn module before running tests? If so does it unload the modules after tests are complete? It implementes the netlink API and can thus be integr

Re: [PATCH RFT v9 4/8] fork: Add shadow stack support to clone3()

2024-10-02 Thread Edgecombe, Rick P
On Wed, 2024-10-02 at 22:01 +0100, Mark Brown wrote: > BTW it's probably also worth noting that at least on arm64 (perhaps x86 > is different here?) the shadow stack of a thread that exited won't have > a token placed on it so it won't be possible to use it with clone3() at > all unless another tok

Re: [PATCH net v4 2/2] bpf: selftests: send packet to devmap redirect XDP

2024-10-02 Thread Martin KaFai Lau
On 9/11/24 1:41 AM, Florian Kauer wrote: @@ -25,14 +28,11 @@ static void test_xdp_with_devmap_helpers(void) if (!ASSERT_OK_PTR(skel, "test_xdp_with_devmap_helpers__open_and_load")) return; - dm_fd = bpf_program__fd(skel->progs.xdp_redir_prog); - err = bpf_xdp_att

Re: [PATCH RFT v9 4/8] fork: Add shadow stack support to clone3()

2024-10-02 Thread Mark Brown
On Wed, Oct 02, 2024 at 02:42:58PM +0100, Mark Brown wrote: > On Tue, Oct 01, 2024 at 11:03:10PM +, Edgecombe, Rick P wrote: > > I'm not so sure. The thing is a regular stack can be re-used in full - just > > set > > the RSP to the end and take advantage of the w

Re: [PATCH] Revert "list: test: fix tests for list_cut_position()"

2024-10-02 Thread Shuah Khan
On 9/30/24 17:18, Jacob Keller wrote: On 9/22/2024 8:05 AM, Guenter Roeck wrote: This reverts commit e620799c414a035dea1208bcb51c869744931dbb. The commit introduces unit test failures. Expected cur == &entries[i], but cur == 037fffadfd80 &entries[i] == 037ff

Re: [PATCH v3] kselftest/devices/probe: Fix SyntaxWarning in regex strings for Python3

2024-10-02 Thread Shuah Khan
On 10/2/24 03:00, Alessandro Zanni wrote: Hello, this email is just a friendly reminder to know if the present patch is going to be applied or not. Thank you. Best Regards, Alessandro Zanni No top posting please. On 24/08/06 02:14, Alessandro Zanni wrote: Insert raw strings to prevent Py

Re: [PATCH v3 1/1] lib/llist_kunit.c: add KUnit tests for llist

2024-10-02 Thread Rae Moar
On Mon, Sep 16, 2024 at 8:51 PM Artur Alves wrote: > > Add KUnit tests for the llist data structure. They test the vast > majority of methods and macros defined in include/linux/llist.h. > > These are inspired by the existing tests for the 'list' doubly > linked in lib/list-test.c. Each test case

Re: [PATCH rcu 0/11] Add light-weight readers for SRCU

2024-10-02 Thread Andrii Nakryiko
SRCU-lite over SRCU for uprobes, taking RCU Tasks Trace > performance out of the equation. > > In uprobes I used basically two benchmarks. One, uprobe-nop, that > benchmarks entry uprobes (which are the fastest most optimized case, > using RCU Tasks Trace in A and SRCU in D), and anoth

Re: [PATCH net v4 1/2] bpf: devmap: provide rxq after redirect

2024-10-02 Thread Jakub Kicinski
On Wed, 11 Sep 2024 10:41:18 +0200 Florian Kauer wrote: > rxq contains a pointer to the device from where > the redirect happened. Currently, the BPF program > that was executed after a redirect via BPF_MAP_TYPE_DEVMAP* > does not have it set. Acked-by: Jakub Kicinski

Re: [RFC PATCH 0/4] sched+mm: Track lazy active mm existence with hazard pointers

2024-10-02 Thread Linus Torvalds
e mm refcount - the reason the lazy-tlb handling uses it is because we already had that refcount and it was easy to extend on existing logic, not because it's really required any more. The lazy-tlb activation is basically "I'm switching to a kernel thread, so I'll re-use the T

Re: [PATCH] vsock/virtio: use GFP_ATOMIC under RCU read lock

2024-10-02 Thread Stefano Garzarella
On Wed, Oct 02, 2024 at 04:02:06PM GMT, Stefano Garzarella wrote: On Wed, Oct 02, 2024 at 09:41:42AM GMT, Michael S. Tsirkin wrote: virtio_transport_send_pkt in now called on transport fast path, under RCU read lock. In that case, we have a bug: virtio_add_sgs is called with GFP_KERNEL, and migh

Re: [RFC PATCH 0/4] sched+mm: Track lazy active mm existence with hazard pointers

2024-10-02 Thread Jens Axboe
ID:AuthenticAMD >>>> Model name: AMD EPYC 9654 96-Core Processor >>>> CPU family: 25 >>>> Model:17 >>>> Thread(s) per core: 2 >>>> Core(s) per socket:

Re: [RFC PATCH 0/4] sched+mm: Track lazy active mm existence with hazard pointers

2024-10-02 Thread Mathieu Desnoyers
). I've noticed I had schedstats and sched debug enabled in my config, so I'll have to re-run my tests. A quick re-run of the 128-thread case with schedstats and sched debug disabled still show around 26% speedup, similar to my prior numbers. I'm not sure why Jens has much bette

Re: [RFC PATCH 0/4] sched+mm: Track lazy active mm existence with hazard pointers

2024-10-02 Thread Jens Axboe
654 96-Core Processor >> CPU family: 25 >> Model:17 >> Thread(s) per core: 2 >> Core(s) per socket: 96 >> Socket(s):2 >> Stepping: 1 >> Frequency boost: enabled >>

Re: [RFC PATCH 0/4] sched+mm: Track lazy active mm existence with hazard pointers

2024-10-02 Thread Mathieu Desnoyers
: 4800.00 Note that Jens Axboe got even more impressive speedups testing this on his 512-hw-thread EPYC [1] (390% speedup for 192 threads). I've noticed I had schedstats and sched debug enabled in my config, so I'll have to re-run my tests. Thanks, Mathieu [1] https://discuss.s

Re: [PATCH] remoteproc: virtio: Add synchronize_cbs to remoteproc_virtio

2024-10-02 Thread Mathieu Poirier
On Fri, Sep 27, 2024 at 02:51:38AM +, Mark-PK Tsai (蔡沛剛) wrote: > Hi, > > Could someone help to review it or provide suggestions? > Any comments are welcome. > > This patch is intended to allow the rproc driver to handle the > following use-after-free issue: > > > ### UAF log What does "UA

Re: [RFC PATCH 0/4] sched+mm: Track lazy active mm existence with hazard pointers

2024-10-02 Thread Matthew Wilcox
On Wed, Oct 02, 2024 at 11:26:27AM -0400, Mathieu Desnoyers wrote: > On 2024-10-02 16:09, Paul E. McKenney wrote: > > On Tue, Oct 01, 2024 at 09:02:01PM -0400, Mathieu Desnoyers wrote: > > > Hazard pointers appear to be a good fit for replacing refcount based lazy > > > active mm tracking. > > > >

Re: [PATCH v4 3/3] selftests: livepatch: test livepatching a kprobed function

2024-10-02 Thread Miroslav Benes
Hi, On Mon, 30 Sep 2024, Michael Vetter wrote: > The test proves that a function that is being kprobed and uses a > post_handler cannot be livepatched. > > Only one ftrace_ops with FTRACE_OPS_FL_IPMODIFY set may be registered > to any given function at a time. > > Signed-off-by: Michael Vetter

Re: [RFC PATCH 0/4] sched+mm: Track lazy active mm existence with hazard pointers

2024-10-02 Thread Mathieu Desnoyers
On 2024-10-02 16:09, Paul E. McKenney wrote: On Tue, Oct 01, 2024 at 09:02:01PM -0400, Mathieu Desnoyers wrote: Hazard pointers appear to be a good fit for replacing refcount based lazy active mm tracking. Highlight: will-it-scale context_switch1_threads nr threads (-t) speedup 24

RE: [PATCH 1/2] compiler.h: Introduce ptr_eq() to preserve address dependency

2024-10-02 Thread David Laight
From: 'Alan Stern' > Sent: 02 October 2024 15:15 > > On Wed, Oct 02, 2024 at 08:13:15AM +, David Laight wrote: > > From: 'Alan Stern' > > > Sent: 01 October 2024 23:57 > > > > > > On Tue, Oct 01, 2024 at 05:11:05PM +, David Laight wrote: > > > > From: Alan Stern > > > > > Sent: 30 Septembe

Re: [PATCH v4 1/3] selftests: livepatch: rename KLP_SYSFS_DIR to SYSFS_KLP_DIR

2024-10-02 Thread Miroslav Benes
Hi, On Mon, 30 Sep 2024, Michael Vetter wrote: > This naming makes more sense according to the directory structure. > Especially when we later add more paths. > > Signed-off-by: Michael Vetter > --- > tools/testing/selftests/livepatch/functions.sh | 6 +++--- > 1 file changed, 3 insertions(+),

Re: [PATCH 3/3] rcu: Report callbacks enqueued on offline CPU blind spot

2024-10-02 Thread Frederic Weisbecker
Le Wed, Oct 02, 2024 at 04:57:38PM +0200, Frederic Weisbecker a écrit : > Callbacks enqueued after rcutree_report_cpu_dead() fall into RCU barrier > blind spot. Report any potential misuse. > > Reported-by: Paul E. McKenney > Signed-off-by: Frederic Weisbecker > --- > kernel/rcu/tree.c | 3 +++

Re: [PATCH slab hotfixes v2 2/2] slub/kunit: skip test_kfree_rcu when the slub kunit test is built-in

2024-10-02 Thread Vlastimil Babka
On 10/2/24 15:52, Guenter Roeck wrote: > On 10/2/24 03:26, Vlastimil Babka wrote: >> On 10/1/24 18:20, Vlastimil Babka wrote: >>> Guenter Roeck reports that the new slub kunit tests added by commit >>> 4e1c44b3db79 ("kunit, slub: add test_kfree_rcu() and >>> test_leak_destroy()") cause a lockup on

Re: [PATCH v2] vhost/vsock: specify module version

2024-10-02 Thread Jakub Kicinski
On Mon, 30 Sep 2024 19:03:52 +0200 Aleksandr Mikhalitsyn wrote: > > At this point my question is, should we solve the problem higher and > > show all the modules in /sys/modules, either way? > > Probably, yes. We can ask Luis Chamberlain's opinion on this one. > > +cc Luis Chamberlain > > > >

Re: [PATCH 1/2] compiler.h: Introduce ptr_eq() to preserve address dependency

2024-10-02 Thread 'Alan Stern'
On Wed, Oct 02, 2024 at 08:13:15AM +, David Laight wrote: > From: 'Alan Stern' > > Sent: 01 October 2024 23:57 > > > > On Tue, Oct 01, 2024 at 05:11:05PM +, David Laight wrote: > > > From: Alan Stern > > > > Sent: 30 September 2024 19:53 > > > > > > > > On Mon, Sep 30, 2024 at 07:05:06PM +

Re: [PATCH net-next v8 03/24] ovpn: add basic netlink support

2024-10-02 Thread kernel test robot
Hi Antonio, kernel test robot noticed the following build warnings: [auto build test WARNING on 44badc908f2c85711cb18e45e13119c10ad3a05f] url: https://github.com/intel-lab-lkp/linux/commits/Antonio-Quartulli/netlink-add-NLA_POLICY_MAX_LEN-macro/20241002-172734 base: 44badc908f2c85711cb18e4

Re: [PATCH v3 1/2] exec: fix up /proc/pid/comm in the execveat(AT_EMPTY_PATH) case

2024-10-02 Thread Tycho Andersen
On Wed, Oct 02, 2024 at 01:45:15PM +, Zbigniew Jędrzejewski-Szmek wrote: > On Tue, Oct 01, 2024 at 08:42:56PM +0200, Aleksa Sarai wrote: > > On 2024-10-01, Tycho Andersen wrote: > > > From: Tycho Andersen > > > > > > Zbigniew mentioned at Linux Plumber's that systemd is interested in > > > s

Re: [RFC PATCH 0/4] sched+mm: Track lazy active mm existence with hazard pointers

2024-10-02 Thread Paul E. McKenney
On Tue, Oct 01, 2024 at 09:02:01PM -0400, Mathieu Desnoyers wrote: > Hazard pointers appear to be a good fit for replacing refcount based lazy > active mm tracking. > > Highlight: > > will-it-scale context_switch1_threads > > nr threads (-t) speedup > 24+3% > 48

Re: [PATCH] vsock/virtio: use GFP_ATOMIC under RCU read lock

2024-10-02 Thread Stefano Garzarella
On Wed, Oct 02, 2024 at 09:41:42AM GMT, Michael S. Tsirkin wrote: virtio_transport_send_pkt in now called on transport fast path, under RCU read lock. In that case, we have a bug: virtio_add_sgs is called with GFP_KERNEL, and might sleep. Pass the gfp flags as an argument, and use GFP_ATOMIC on

Re: [PATCH v4 0/3] selftests: livepatch: test livepatching a kprobed function

2024-10-02 Thread Marcos Paulo de Souza
On Mon, 2024-09-30 at 11:33 +0200, Michael Vetter wrote: > Thanks to Miroslav, Petr and Marcos for the reviews! As the only changes were regarding bash nitpicks I keep my review from earlier patchset, so: Reviewed-by: Marcos Paulo de Souza > > V4: > Use variable for /sys/kernel/debug. > Be con

Re: [PATCH v3 1/2] exec: fix up /proc/pid/comm in the execveat(AT_EMPTY_PATH) case

2024-10-02 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Oct 01, 2024 at 08:42:56PM +0200, Aleksa Sarai wrote: > On 2024-10-01, Tycho Andersen wrote: > > From: Tycho Andersen > > > > Zbigniew mentioned at Linux Plumber's that systemd is interested in > > switching to execveat() for service execution, but can't, because the > > contents of /pro

Re: [PATCH slab hotfixes v2 2/2] slub/kunit: skip test_kfree_rcu when the slub kunit test is built-in

2024-10-02 Thread Guenter Roeck
On 10/2/24 03:26, Vlastimil Babka wrote: On 10/1/24 18:20, Vlastimil Babka wrote: Guenter Roeck reports that the new slub kunit tests added by commit 4e1c44b3db79 ("kunit, slub: add test_kfree_rcu() and test_leak_destroy()") cause a lockup on boot on several architectures when the kunit tests ar

Re: [PATCH slab hotfixes v2 2/2] slub/kunit: skip test_kfree_rcu when the slub kunit test is built-in

2024-10-02 Thread Guenter Roeck
On 10/1/24 09:20, Vlastimil Babka wrote: Guenter Roeck reports that the new slub kunit tests added by commit 4e1c44b3db79 ("kunit, slub: add test_kfree_rcu() and test_leak_destroy()") cause a lockup on boot on several architectures when the kunit tests are configured to be built-in and not module

Re: [PATCH RFT v9 4/8] fork: Add shadow stack support to clone3()

2024-10-02 Thread Mark Brown
h it which > > would face similar issues with having an unusual method for specifying > > the stack top so I don't know how much we're really winning. > I'm not so sure. The thing is a regular stack can be re-used in full - just > set > the RSP to the end and take ad

Re: [PATCH v8 3/3] irqchip/loongson-eiointc: Add extioi virt extension support

2024-10-02 Thread Thomas Gleixner
On Wed, Sep 11 2024 at 17:11, Huacai Chen wrote: > Hi, Thomas, > > On Fri, Aug 30, 2024 at 5:32 PM Bibo Mao wrote: >> >> Interrupts can be routed to maximal four virtual CPUs with one HW >> EIOINTC interrupt controller model, since interrupt routing is encoded with >> CPU bitmap and EIOINTC node c

Re: [PATCH] selftests/bpf: Add __init and __exit to the functions bpf_test_no_cfi_init()/bpf_test_no_cfi_exit()

2024-10-02 Thread Daniel Borkmann
On 9/30/24 3:33 AM, Yaxiong Tian wrote: From: Yaxiong Tian To save some running memory,Add __init and __exit to the module load/unload functions. Signed-off-by: Yaxiong Tian --- tools/testing/selftests/bpf/bpf_test_no_cfi/bpf_test_no_cfi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 delet

Re: [PATCH V3 0/1] livepatch: Add "stack_order" sysfs attribute

2024-10-02 Thread Miroslav Benes
Hello, On Sun, 29 Sep 2024, Wardenjohn wrote: > As previous discussion, maintainers think that patch-level sysfs interface is > the > only acceptable way to maintain the information of the order that klp_patch > is > applied to the system. > > However, the previous patch introduce klp_ops int

Re: [PATCH bpf] bpf: fix unpopulated name_len field in perf_event link info

2024-10-02 Thread Jiri Olsa
On Mon, Sep 30, 2024 at 11:59:20PM +, tyrone-wu wrote: > Previously when retrieving `bpf_link_info.perf_event` for > kprobe/uprobe/tracepoint, the `name_len` field was not populated by the > kernel, leaving it to reflect the value initially set by the user. This > behavior was inconsistent with

Re: [PATCH net-next v8 02/24] net: introduce OpenVPN Data Channel Offload (ovpn)

2024-10-02 Thread kernel test robot
Hi Antonio, kernel test robot noticed the following build warnings: [auto build test WARNING on 44badc908f2c85711cb18e45e13119c10ad3a05f] url: https://github.com/intel-lab-lkp/linux/commits/Antonio-Quartulli/netlink-add-NLA_POLICY_MAX_LEN-macro/20241002-172734 base: 44badc908f2c85711cb18e4

Re: [PATCH slab hotfixes v2 2/2] slub/kunit: skip test_kfree_rcu when the slub kunit test is built-in

2024-10-02 Thread Vlastimil Babka
On 10/1/24 18:20, Vlastimil Babka wrote: > Guenter Roeck reports that the new slub kunit tests added by commit > 4e1c44b3db79 ("kunit, slub: add test_kfree_rcu() and > test_leak_destroy()") cause a lockup on boot on several architectures > when the kunit tests are configured to be built-in and not

Re: [PATCH v3] kselftest/devices/probe: Fix SyntaxWarning in regex strings for Python3

2024-10-02 Thread Alessandro Zanni
Hello, this email is just a friendly reminder to know if the present patch is going to be applied or not. Thank you. Best Regards, Alessandro Zanni On 24/08/06 02:14, Alessandro Zanni wrote: > Insert raw strings to prevent Python3 from interpreting string literals > as Unicode strings and "\d"

Re: [PATCH bpf-next v2 0/6] selftests/bpf: Various sockmap-related fixes

2024-10-02 Thread Michal Luczaj
On 9/27/24 11:15, Jakub Sitnicki wrote: > On Fri, Sep 27, 2024 at 12:54 AM +02, Michal Luczaj wrote: >> ... >> Here's a follow up: my guess is that some checks are missing. I'm not sure >> if it's the best approach, but this fixes things for me: > > So you have already found a bug with a negative

RE: [PATCH 1/2] compiler.h: Introduce ptr_eq() to preserve address dependency

2024-10-02 Thread David Laight
From: 'Alan Stern' > Sent: 01 October 2024 23:57 > > On Tue, Oct 01, 2024 at 05:11:05PM +, David Laight wrote: > > From: Alan Stern > > > Sent: 30 September 2024 19:53 > > > > > > On Mon, Sep 30, 2024 at 07:05:06PM +0200, Jonas Oberhauser wrote: > > > > > > > > > > > > Am 9/30/2024 um 6:43 PM

Re: [PATCH] selftests: Makefile: create OUTPUT dir

2024-10-01 Thread Anders Roxell
On Wed, 25 Sept 2024 at 19:26, Shuah Khan wrote: > > On 9/20/24 04:38, Jakub Kicinski wrote: > > On Thu, 19 Sep 2024 09:51:47 -0600 Shuah Khan wrote: > >>> @@ -261,6 +261,7 @@ ifdef INSTALL_PATH > >>> @ret=1; \ > >>> for TARGET in $(TARGETS) $(INSTALL_DEP_TARGETS); do \ > >>> B

Re: [PATCH v2] selftests/powerpc: Remove the path after initialization.

2024-10-01 Thread IBM
zhangjiao2 writes: > From: zhang jiao > > If there were no anamolies noted, then we can > simply remove the log file and return, after the path variable has been initialized. (minor nit) > > Signed-off-by: zhang jiao > --- > v1->v2: > Remove the path after initialization. > > to

Re: [PATCH v13 00/12] Initial Marvell PXA1908 support

2024-10-01 Thread Rob Herring (Arm)
On Tue, 01 Oct 2024 16:37:30 +0200, Duje Mihanović wrote: > Hello, > > This series adds initial support for the Marvell PXA1908 SoC and > "samsung,coreprimevelte", a smartphone using the SoC. > > USB works and the phone can boot a rootfs from an SD card, but there are > some warnings in the dme

Re: [PATCH bpf-next v3 1/2] bpf: verifier: Support eliding map lookup nullness

2024-10-01 Thread Daniel Xu
On Wed, Sep 25, 2024 at 10:24:01AM GMT, Alexei Starovoitov wrote: > On Tue, Sep 24, 2024 at 12:40 PM Daniel Xu wrote: > > > > + > > +/* Returns constant key value if possible, else -1 */ > > +static long get_constant_map_key(struct bpf_verifier_env *env, > > +struct

Re: [PATCH bpf-next v3 1/2] bpf: verifier: Support eliding map lookup nullness

2024-10-01 Thread Daniel Xu
Hit send too early. On Tue, Oct 1, 2024, at 5:07 PM, Daniel Xu wrote: > On Wed, Sep 25, 2024 at 10:24:01AM GMT, Alexei Starovoitov wrote: >> On Tue, Sep 24, 2024 at 12:40 PM Daniel Xu wrote: >> > >> > + >> > +/* Returns constant key value if possible, else -1 */ >> > +static long get_constant_map

Re: [PATCH RFT v9 4/8] fork: Add shadow stack support to clone3()

2024-10-01 Thread Edgecombe, Rick P
ying > the stack top so I don't know how much we're really winning. I'm not so sure. The thing is a regular stack can be re-used in full - just set the RSP to the end and take advantage of the whole stack. A shadow stack can only be used where there is a token. >   Like we >

Re: [RFC PATCH 14/39] KVM: guest_memfd: hugetlb: initialization and cleanup

2024-10-01 Thread Ackerley Tng
Vishal Annapurve writes: > On Wed, Sep 11, 2024 at 1:44 AM Ackerley Tng wrote: >> >> ... >> +} >> + >> +static void kvm_gmem_evict_inode(struct inode *inode) >> +{ >> + u64 flags = (u64)inode->i_private; >> + >> + if (flags & KVM_GUEST_MEMFD_HUGETLB) >> + kvm_gmem_huget

Re: [PATCH 1/2] compiler.h: Introduce ptr_eq() to preserve address dependency

2024-10-01 Thread 'Alan Stern'
On Tue, Oct 01, 2024 at 05:11:05PM +, David Laight wrote: > From: Alan Stern > > Sent: 30 September 2024 19:53 > > > > On Mon, Sep 30, 2024 at 07:05:06PM +0200, Jonas Oberhauser wrote: > > > > > > > > > Am 9/30/2024 um 6:43 PM schrieb Alan Stern: > > > > On Mon, Sep 30, 2024 at 01:26:53PM +020

Re: [PATCH v3 10/20] gendwarfksyms: Expand structure types

2024-10-01 Thread Sami Tolvanen
On Tue, Oct 1, 2024 at 2:16 PM Petr Pavlu wrote: > > On 9/23/24 20:18, Sami Tolvanen wrote: > > +static void process_variant_type(struct state *state, struct die *cache, > > + Dwarf_Die *die) > > +{ > > + process_list_comma(state, cache); > > + process(cache, "

Re: [PATCH] remoteproc: qcom: Fix NULL pointer in glink_subdev_stop()

2024-10-01 Thread Bjorn Andersson
On Tue, Oct 01, 2024 at 12:06:17PM +0530, Mukesh Ojha wrote: > On Fri, Sep 27, 2024 at 02:59:09PM -0700, Bjorn Andersson wrote: > > On Sat, Sep 28, 2024 at 01:07:43AM +0530, Mukesh Ojha wrote: > > > On Wed, Sep 25, 2024 at 08:41:55PM -0700, Bjorn Andersson wrote: > > > > On Wed, Sep 25, 2024 at 04:

Re: [PATCH v2 1/1] lib/tests/kfifo_kunit.c: add tests for the kfifo structure

2024-10-01 Thread Rae Moar
On Tue, Sep 3, 2024 at 5:38 PM Diego Vieira wrote: > > Add KUnit tests for the kfifo data structure. > They test the vast majority of macros defined in the kfifo > header (include/linux/kfifo.h). > > These are inspired by the existing tests for the doubly > linked list in lib/tests/list-test.c (pr

Re: [PATCH v3 06/20] gendwarfksyms: Add a cache for processed DIEs

2024-10-01 Thread Sami Tolvanen
On Tue, Oct 1, 2024 at 2:10 PM Petr Pavlu wrote: > > On 9/23/24 20:18, Sami Tolvanen wrote: > > +static void update_fqn(struct die *cache, Dwarf_Die *die) > > +{ > > + if (!cache->fqn) > > + cache->fqn = get_fqn(die) ?: ""; > > +} > > When is update_fqn() called with cache->fqn bei

Re: [PATCH v3 04/20] gendwarfksyms: Add address matching

2024-10-01 Thread Sami Tolvanen
On Tue, Oct 1, 2024 at 2:06 PM Petr Pavlu wrote: > > On 9/23/24 20:18, Sami Tolvanen wrote: > > - for_each(name, get_symbol, &sym); > > + for_each(name, false, get_symbol, &sym); > > return sym; > > } > > What is the reason that the for_each() call in symbol_get() is invoked > with

Re: [PATCH v3 03/20] tools: Add gendwarfksyms

2024-10-01 Thread Sami Tolvanen
Hi Petr, On Tue, Oct 1, 2024 at 2:04 PM Petr Pavlu wrote: > > On 9/23/24 20:18, Sami Tolvanen wrote: > > + if (dwfl_getmodules(dwfl, &process_module, NULL, 0)) { > > + error("dwfl_getmodules failed for '%s'", argv[n]); > > + return -1; > > +

Re: [PATCH v3 1/2] exec: fix up /proc/pid/comm in the execveat(AT_EMPTY_PATH) case

2024-10-01 Thread Aleksa Sarai
On 2024-10-01, Aleksa Sarai wrote: > On 2024-10-01, Tycho Andersen wrote: > > From: Tycho Andersen > > > > Zbigniew mentioned at Linux Plumber's that systemd is interested in > > switching to execveat() for service execution, but can't, because the > > contents of /proc/pid/comm are the file de

Re: [PATCH v2 06/19] iommufd/viommu: Add IOMMU_VIOMMU_SET/UNSET_VDEV_ID ioctl

2024-10-01 Thread Nicolin Chen
On Tue, Oct 01, 2024 at 10:46:20AM -0300, Jason Gunthorpe wrote: > On Tue, Oct 01, 2024 at 01:54:05AM -0700, Nicolin Chen wrote: > > On Thu, Sep 05, 2024 at 10:38:23AM -0700, Nicolin Chen wrote: > > > On Thu, Sep 05, 2024 at 01:03:53PM -0300, Jason Gunthorpe wrote: > > > > On Tue, Aug 27, 2024 at 0

Re: [PATCH v3 1/2] exec: fix up /proc/pid/comm in the execveat(AT_EMPTY_PATH) case

2024-10-01 Thread Aleksa Sarai
On 2024-10-01, Tycho Andersen wrote: > From: Tycho Andersen > > Zbigniew mentioned at Linux Plumber's that systemd is interested in > switching to execveat() for service execution, but can't, because the > contents of /proc/pid/comm are the file descriptor which was used, > instead of the path t

Re: [PATCH v2 00/19] iommufd: Add VIOMMU infrastructure (Part-1)

2024-10-01 Thread Nicolin Chen
On Tue, Oct 01, 2024 at 10:48:15AM -0300, Jason Gunthorpe wrote: > On Sun, Sep 29, 2024 at 03:19:42PM +0800, Yi Liu wrote: > > > So their viommu HW concepts come along with a requirement that there > > > be a fixed translation for the VM, which we model by attaching a S2 > > > HWPT to the VIOMMU ob

Re: [PATCH net v4] selftests: net: no_forwarding: fix VID for $swp2 in one_bridge_two_pvids() test

2024-10-01 Thread Vladimir Oltean
On Mon, Sep 30, 2024 at 03:35:43PM +0900, Kacper Ludwinski wrote: > This typo has an impact on results of the test results, > potentially leading to wrong conclusions regarding > the functionality of a network device. Did you test this? You are effectively introducing a new test. Could you include

Re: [PATCH v3 2/2] cgroup/rstat: Selftests for niced CPU statistics

2024-10-01 Thread Joshua Hahn
> My motivation comes from debugging cgroup selftests when strace is quite > useful and your implementation adds the unnecessary fork which makes the > strace (slightly) less readable. This makes sense, thank you for the context. I hadn't considered debugging considerations much, but I can imagine

Re: [PATCH RFT v9 4/8] fork: Add shadow stack support to clone3()

2024-10-01 Thread Mark Brown
On Tue, Oct 01, 2024 at 05:12:38PM +0200, Christian Brauner wrote: > On Fri, Sep 27, 2024 at 03:21:59PM GMT, Edgecombe, Rick P wrote: > > Did you catch that a token can be at a different offsets location on the > > stack > > depending on args passed to map_shadow_stack? So userspace will need >

RE: [PATCH 1/2] compiler.h: Introduce ptr_eq() to preserve address dependency

2024-10-01 Thread David Laight
From: Alan Stern > Sent: 30 September 2024 19:53 > > On Mon, Sep 30, 2024 at 07:05:06PM +0200, Jonas Oberhauser wrote: > > > > > > Am 9/30/2024 um 6:43 PM schrieb Alan Stern: > > > On Mon, Sep 30, 2024 at 01:26:53PM +0200, Jonas Oberhauser wrote: > > > > > > > > > > > > Am 9/28/2024 um 4:49 PM sch

Re: Re: [PATCH] virtio: Make vring_new_virtqueue support for packed vring

2024-10-01 Thread Michael S. Tsirkin
On Tue, Oct 01, 2024 at 05:30:51PM +0800, Wenyu Huang wrote: > It used for testing in tools/virtio/vringh_test.c. > If vring_new_virtqueue supports packed vring, we can add support for > packed vring to vringh and test it. Pls say this in the commit log.

Re: [PATCH] rcu/kvfree: Refactor kvfree_rcu_queue_batch()

2024-10-01 Thread Vlastimil Babka
On 9/30/24 13:37, Uladzislau Rezki (Sony) wrote: > Improve readability of kvfree_rcu_queue_batch() function > in away that, after a first batch queuing, the loop is break > and success value is returned to a caller. > > There is no reason to loop and check batches further as all > outstanding obje

Re: [PATCH v1 0/2] selftests/mm: hugetlb_fault_after_madv improvements

2024-10-01 Thread Mario Casquero
This series has been successfully tested. Now when executing the hugetlb_fault_after_madv selftest the benefits of both patches could be observed. # ./hugetlb_fault_after_madv TAP version 13 1..1 # [INFO] detected default hugetlb page size: 1024 KiB ok 1 SIGBUS behavior # Totals: pass:1 fail:0 xfai

Re: [RFC PATCH 0/3] introduce PIDFD_SELF

2024-10-01 Thread Christian Brauner
On Mon, Sep 30, 2024 at 03:32:25PM GMT, Lorenzo Stoakes wrote: > On Mon, Sep 30, 2024 at 04:21:23PM GMT, Aleksa Sarai wrote: > > On 2024-09-30, Lorenzo Stoakes wrote: > > > On Mon, Sep 30, 2024 at 02:34:33PM GMT, Christian Brauner wrote: > > > > On Mon, Sep 30, 2024 at 11:39:49AM GMT, Lorenzo Stoa

Re: [PATCH v3 2/2] cgroup/rstat: Selftests for niced CPU statistics

2024-10-01 Thread Michal Koutný
On Mon, Sep 30, 2024 at 02:07:22PM GMT, Joshua Hahn wrote: > The reason I used a fork in the testing is so that I could isolate the niced > portion of the test to only the CPU hog. If I were to nice(1) --> cg_hog() > in a single process without forking, this would mean that the cleanup portion >

Re: Re: [PATCH] virtio: Make vring_new_virtqueue support for packed vring

2024-10-01 Thread Wenyu Huang
It used for testing in tools/virtio/vringh_test.c. If vring_new_virtqueue supports packed vring, we can add support for packed vring to vringh and test it.

Re: [PATCH RFT v9 4/8] fork: Add shadow stack support to clone3()

2024-10-01 Thread Christian Brauner
On Fri, Sep 27, 2024 at 03:21:59PM GMT, Edgecombe, Rick P wrote: > On Fri, 2024-09-27 at 10:50 +0200, Christian Brauner wrote: > > The legacy clone system call had required userspace to know in which > > direction the stack was growing and then pass down the stack pointer > > appropriately (e.g., p

Re: [PATCH v3 2/2] selftests/exec: add a test to enforce execveat()'s comm

2024-10-01 Thread Shuah Khan
On 10/1/24 07:49, Tycho Andersen wrote: From: Tycho Andersen We want to ensure that /proc/self/comm stays useful for execveat() callers. This commit message is vague? What does staying useful mean? Elaborate on the staying useful and the tests added to ensure. Add test results as well. Sig

Re: [PATCH] KVM: selftests: Fix build on architectures other than x86_64

2024-10-01 Thread Paolo Bonzini
On Mon, Sep 30, 2024 at 8:10 PM Mark Brown wrote: > > The recent addition of support for testing with the x86 specific quirk > KVM_X86_QUIRK_SLOT_ZAP_ALL disabled in the generic memslot tests broke the > build of the KVM selftests for all other architectures: > > In file included from include/kvm_

Re: [PATCH 1/1] remoteproc: Use iommu_paging_domain_alloc()

2024-10-01 Thread Jason Gunthorpe
On Mon, Sep 30, 2024 at 10:40:30AM -0600, Mathieu Poirier wrote: > On Mon, Aug 12, 2024 at 03:28:11PM +0800, Lu Baolu wrote: > > An iommu domain is allocated in rproc_enable_iommu() and is attached to > > rproc->dev.parent in the same function. > > > > Use iommu_paging_domain_alloc() to make it ex

Re: [PATCH v3 03/20] tools: Add gendwarfksyms

2024-10-01 Thread Petr Pavlu
On 9/23/24 20:18, Sami Tolvanen wrote: > Add a basic DWARF parser, which uses libdw to traverse the debugging > information in an object file and looks for functions and variables. > In follow-up patches, this will be expanded to produce symbol versions > for CONFIG_MODVERSIONS from DWARF. > > Sig

Re: [PATCH v2 06/19] iommufd/viommu: Add IOMMU_VIOMMU_SET/UNSET_VDEV_ID ioctl

2024-10-01 Thread Nicolin Chen
On Thu, Sep 05, 2024 at 10:38:23AM -0700, Nicolin Chen wrote: > On Thu, Sep 05, 2024 at 01:03:53PM -0300, Jason Gunthorpe wrote: > > On Tue, Aug 27, 2024 at 09:59:43AM -0700, Nicolin Chen wrote: > > > Introduce a pair of new ioctls to set/unset a per-viommu virtual device id > > > that should be li

Re: [PATCH] selftest: hid: add missing run-hid-tools-tests.sh

2024-10-01 Thread Shuah Khan
On 9/30/24 20:43, luyun wrote: 在 2024/10/1 04:57, Shuah Khan 写道: On 9/30/24 02:38, Benjamin Tissoires wrote: On Sep 29 2024, Yun Lu wrote: The HID test cases actually run tests using the run-hid-tools-tests.sh script. However, if installed with "make install", the run-hid-tools-tests.sh scrip

Re: [PATCH v2 06/19] iommufd/viommu: Add IOMMU_VIOMMU_SET/UNSET_VDEV_ID ioctl

2024-10-01 Thread Jason Gunthorpe
On Tue, Oct 01, 2024 at 01:54:05AM -0700, Nicolin Chen wrote: > On Thu, Sep 05, 2024 at 10:38:23AM -0700, Nicolin Chen wrote: > > On Thu, Sep 05, 2024 at 01:03:53PM -0300, Jason Gunthorpe wrote: > > > On Tue, Aug 27, 2024 at 09:59:43AM -0700, Nicolin Chen wrote: > > > > Introduce a pair of new ioct

Re: [PATCH slab hotfixes 2/2] kunit: move call to kunit_run_all_tests() after rcu_end_inkernel_boot()

2024-10-01 Thread Vlastimil Babka
On 10/1/24 1:55 AM, Guenter Roeck wrote: > On 9/30/24 11:50, Guenter Roeck wrote: >> On 9/30/24 01:37, Vlastimil Babka wrote: >>> Guenter Roeck reports that the new slub kunit tests added by commit >>> 4e1c44b3db79 ("kunit, slub: add test_kfree_rcu() and >>> test_leak_destroy()") cause a lockup on

Re: [RFC PATCH 0/3] introduce PIDFD_SELF

2024-10-01 Thread Lorenzo Stoakes
On Tue, Oct 01, 2024 at 12:21:32PM GMT, Christian Brauner wrote: > On Mon, Sep 30, 2024 at 03:32:25PM GMT, Lorenzo Stoakes wrote: > > On Mon, Sep 30, 2024 at 04:21:23PM GMT, Aleksa Sarai wrote: [snip] > > > Sorry to bike-shed, but to match /proc/self and /proc/thread-self, maybe > > > they should

Re: [PATCH v3 06/20] gendwarfksyms: Add a cache for processed DIEs

2024-10-01 Thread Petr Pavlu
On 9/23/24 20:18, Sami Tolvanen wrote: > Basic types in DWARF repeat frequently and traversing the DIEs using > libdw is relatively slow. Add a simple hashtable based cache for the > processed DIEs. > > Signed-off-by: Sami Tolvanen > --- > scripts/gendwarfksyms/Makefile| 1 + > scripts

  1   2   3   4   5   6   7   8   9   10   >