Re: [PATCH] lightnvm: pblk: stop taking the free lock in in pblk_lines_free

2019-01-25 Thread Javier González
> On 25 Jan 2019, at 10.15, Hans Holmberg > wrote: > > On Thu, Jan 24, 2019 at 2:19 PM Javier González wrote: >>> On 22 Jan 2019, at 11.15, h...@owltronix.com wrote: >>> >>> From: Hans Holmberg >>> >>> pblk_line_meta_free might sleep (it can end up calling vfree, depending >>> on how we all

Re: [PATCH] lightnvm: pblk: stop taking the free lock in in pblk_lines_free

2019-01-25 Thread Hans Holmberg
On Thu, Jan 24, 2019 at 2:19 PM Javier González wrote: > > > On 22 Jan 2019, at 11.15, h...@owltronix.com wrote: > > > > From: Hans Holmberg > > > > pblk_line_meta_free might sleep (it can end up calling vfree, depending > > on how we allocate lba lists), and this can lead to a BUG() > > if we wa

Re: [PATCH] lightnvm: pblk: stop taking the free lock in in pblk_lines_free

2019-01-24 Thread Javier González
> On 22 Jan 2019, at 11.15, h...@owltronix.com wrote: > > From: Hans Holmberg > > pblk_line_meta_free might sleep (it can end up calling vfree, depending > on how we allocate lba lists), and this can lead to a BUG() > if we wake up on a different cpu and release the lock. > > As there is no poi

Re: [PATCH] lightnvm: pblk: stop taking the free lock in in pblk_lines_free

2019-01-22 Thread Matias Bjørling
On 1/22/19 11:15 AM, h...@owltronix.com wrote: From: Hans Holmberg pblk_line_meta_free might sleep (it can end up calling vfree, depending on how we allocate lba lists), and this can lead to a BUG() if we wake up on a different cpu and release the lock. As there is no point of grabbing the fre