Re: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status

2013-11-11 Thread Vinod Koul
On Mon, Nov 11, 2013 at 09:11:18PM -0800, Olof Johansson wrote: > On Mon, Nov 11, 2013 at 8:00 PM, Vinod Koul wrote: > > On Mon, Nov 11, 2013 at 11:13:39AM -0800, Olof Johansson wrote: > >> On Wed, Oct 30, 2013 at 06:33:25PM +0530, Vinod Koul wrote: > >> > On Tue, Oct 29, 2013 at 09:47:55AM -0700,

Re: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status

2013-11-11 Thread Olof Johansson
On Mon, Nov 11, 2013 at 8:00 PM, Vinod Koul wrote: > On Mon, Nov 11, 2013 at 11:13:39AM -0800, Olof Johansson wrote: >> On Wed, Oct 30, 2013 at 06:33:25PM +0530, Vinod Koul wrote: >> > On Tue, Oct 29, 2013 at 09:47:55AM -0700, Olof Johansson wrote: >> > > This patch broke some TI platforms (using

Re: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status

2013-11-11 Thread Vinod Koul
On Mon, Nov 11, 2013 at 11:13:39AM -0800, Olof Johansson wrote: > On Wed, Oct 30, 2013 at 06:33:25PM +0530, Vinod Koul wrote: > > On Tue, Oct 29, 2013 at 09:47:55AM -0700, Olof Johansson wrote: > > > This patch broke some TI platforms (using edma) due to namespace > > > conflicts. The error is: > >

Re: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status

2013-11-11 Thread Olof Johansson
On Wed, Oct 30, 2013 at 06:33:25PM +0530, Vinod Koul wrote: > On Tue, Oct 29, 2013 at 09:47:55AM -0700, Olof Johansson wrote: > > This patch broke some TI platforms (using edma) due to namespace > > conflicts. The error is: > > > > ../../include/linux/dmaengine.h:54:2: error: expected identifier >

Re: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status

2013-11-04 Thread Sebastian Andrzej Siewior
On 30.10.13, Vinod Koul wrote: > I fixed up the error with below, can you pls verify. Pls note this is compile > tested only! I tested this and my mmc driver using edma via drivers/dma seems to work. Tested-by: Sebastian Andrzej Siewior However you missed one piece: CC [M] sound/soc/davinci/

Re: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status

2013-10-30 Thread Vinod Koul
On Tue, Oct 29, 2013 at 09:47:55AM -0700, Olof Johansson wrote: > This patch broke some TI platforms (using edma) due to namespace > conflicts. The error is: > > ../../include/linux/dmaengine.h:54:2: error: expected identifier > before numeric constant (for DMA_COMPLETE) > > .. it's because the

Re: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status

2013-10-29 Thread Olof Johansson
Hi, On Thu, Oct 24, 2013 at 11:43 PM, Guennadi Liakhovetski wrote: > On Fri, 25 Oct 2013, Vinod Koul wrote: > >> On Fri, Oct 25, 2013 at 08:32:12AM +0200, Guennadi Liakhovetski wrote: >> > Hi Vinod >> > >> > On Fri, 25 Oct 2013, Vinod Koul wrote: >> > >> > > On Thu, Oct 24, 2013 at 11:28:29PM +02

Re: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status

2013-10-24 Thread Guennadi Liakhovetski
On Fri, 25 Oct 2013, Vinod Koul wrote: > On Fri, Oct 25, 2013 at 08:32:12AM +0200, Guennadi Liakhovetski wrote: > > Hi Vinod > > > > On Fri, 25 Oct 2013, Vinod Koul wrote: > > > > > On Thu, Oct 24, 2013 at 11:28:29PM +0200, Guennadi Liakhovetski wrote: > > > > Hi Vinod > > > > > > > > On Thu, 1

Re: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status

2013-10-24 Thread Vinod Koul
On Fri, Oct 25, 2013 at 08:32:12AM +0200, Guennadi Liakhovetski wrote: > Hi Vinod > > On Fri, 25 Oct 2013, Vinod Koul wrote: > > > On Thu, Oct 24, 2013 at 11:28:29PM +0200, Guennadi Liakhovetski wrote: > > > Hi Vinod > > > > > > On Thu, 17 Oct 2013, Vinod Koul wrote: > > > > Yes i missed it in f

Re: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status

2013-10-24 Thread Guennadi Liakhovetski
Hi Vinod On Fri, 25 Oct 2013, Vinod Koul wrote: > On Thu, Oct 24, 2013 at 11:28:29PM +0200, Guennadi Liakhovetski wrote: > > Hi Vinod > > > > On Thu, 17 Oct 2013, Vinod Koul wrote: > > > Yes i missed it in first place update the patch to fix that > > > > Are you planning to post a fixed version

Re: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status

2013-10-24 Thread Vinod Koul
On Thu, Oct 24, 2013 at 11:28:29PM +0200, Guennadi Liakhovetski wrote: > Hi Vinod > > On Thu, 17 Oct 2013, Vinod Koul wrote: > > Yes i missed it in first place update the patch to fix that > > Are you planning to post a fixed version of this patch or you just fix it > internally? Would be good t

Re: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status

2013-10-24 Thread Guennadi Liakhovetski
Hi Vinod On Thu, 17 Oct 2013, Vinod Koul wrote: > On Thu, Oct 17, 2013 at 04:27:55PM +0200, Sebastian Andrzej Siewior wrote: > > On Thu, Oct 17, 2013 at 07:37:45AM +0530, Vinod Koul wrote: > > > index 0bc7275..683c380 100644 > > > --- a/include/linux/dmaengine.h > > > +++ b/include/linux/dmaengin

Re: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status

2013-10-17 Thread Vinod Koul
On Thu, Oct 17, 2013 at 04:27:55PM +0200, Sebastian Andrzej Siewior wrote: > On Thu, Oct 17, 2013 at 07:37:45AM +0530, Vinod Koul wrote: > > index 0bc7275..683c380 100644 > > --- a/include/linux/dmaengine.h > > +++ b/include/linux/dmaengine.h > > @@ -45,16 +45,17 @@ static inline int dma_submit_err

Re: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status

2013-10-17 Thread Guennadi Liakhovetski
Hi Sebastian On Thu, 17 Oct 2013, Sebastian Andrzej Siewior wrote: > On Thu, Oct 17, 2013 at 07:37:45AM +0530, Vinod Koul wrote: > > index 0bc7275..683c380 100644 > > --- a/include/linux/dmaengine.h > > +++ b/include/linux/dmaengine.h > > @@ -45,16 +45,17 @@ static inline int dma_submit_error(dma

Re: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status

2013-10-17 Thread Sebastian Andrzej Siewior
On Thu, Oct 17, 2013 at 07:37:45AM +0530, Vinod Koul wrote: > index 0bc7275..683c380 100644 > --- a/include/linux/dmaengine.h > +++ b/include/linux/dmaengine.h > @@ -45,16 +45,17 @@ static inline int dma_submit_error(dma_cookie_t cookie) > > /** > * enum dma_status - DMA transaction status > -

Re: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status

2013-10-17 Thread Vinod Koul
On Thu, Oct 17, 2013 at 10:27:13AM +0200, Guennadi Liakhovetski wrote: > On Thu, 17 Oct 2013, Vinod Koul wrote: > > > On Wed, Oct 16, 2013 at 11:45:48AM -0700, Dan Williams wrote: > > > On Wed, Oct 16, 2013 at 11:29 AM, Guennadi Liakhovetski > > > > > > > > Doesn't this break kernel compilation fo

Re: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status

2013-10-17 Thread Guennadi Liakhovetski
On Thu, 17 Oct 2013, Vinod Koul wrote: > On Wed, Oct 16, 2013 at 11:45:48AM -0700, Dan Williams wrote: > > On Wed, Oct 16, 2013 at 11:29 AM, Guennadi Liakhovetski > > > > > > Doesn't this break kernel compilation for a total of 27 commits? Or am I > > > missing anything? > > > > Yes, I think at t

Re: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status

2013-10-16 Thread Vinod Koul
On Wed, Oct 16, 2013 at 11:45:48AM -0700, Dan Williams wrote: > On Wed, Oct 16, 2013 at 11:29 AM, Guennadi Liakhovetski > > > > Doesn't this break kernel compilation for a total of 27 commits? Or am I > > missing anything? > > Yes, I think at the start DMA_COMPLETE should just be a alias for > DMA

Re: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status

2013-10-16 Thread Dan Williams
On Wed, Oct 16, 2013 at 11:29 AM, Guennadi Liakhovetski wrote: > Hi Vinod, > > On Wed, 16 Oct 2013, Vinod Koul wrote: > >> the DMA_SUCCESS is a misnomer as dmaengine indicates the transfer is >> complete and >> gives no guarantee of the transfer success. Hence we should use DMA_COMPLTE >> instead

Re: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status

2013-10-16 Thread Guennadi Liakhovetski
Hi Vinod, On Wed, 16 Oct 2013, Vinod Koul wrote: > the DMA_SUCCESS is a misnomer as dmaengine indicates the transfer is complete > and > gives no guarantee of the transfer success. Hence we should use DMA_COMPLTE > instead of DMA_SUCCESS > > Signed-off-by: Vinod Koul > --- > drivers/dma/dmaen