Re: [PATCH 10/22 take 3] UBI: EBA unit

2007-03-16 Thread Randy Dunlap
On Fri, 16 Mar 2007 12:21:08 +0200 Artem Bityutskiy wrote: > On Thu, 2007-03-15 at 14:24 -0700, Randy Dunlap wrote: > > /me repeats wish that Not Everything Should Be Sent to lkml. :( > > If you do statement like this, please, provide reasons why you say it > for these patches and suggest someth

Re: [PATCH 10/22 take 3] UBI: EBA unit

2007-03-16 Thread Artem Bityutskiy
On Thu, 2007-03-15 at 14:24 -0700, Randy Dunlap wrote: > /me repeats wish that Not Everything Should Be Sent to lkml. :( If you do statement like this, please, provide reasons why you say it for these patches and suggest something _constructive_. I do not see any point in this vague phrase. And

Re: [PATCH 10/22 take 3] UBI: EBA unit

2007-03-16 Thread Artem Bityutskiy
On Thu, 2007-03-15 at 18:49 -0700, Randy Dunlap wrote: > Here is a summary of my thinking on Linux-related mailing lists. > > 1. Bug reports can go to lkml or focused mailing lists. > > 2. Development (like patches) should go to focused mailing lists > if there is such a list and they have enou

Re: [PATCH 10/22 take 3] UBI: EBA unit

2007-03-16 Thread Artem Bityutskiy
On Thu, 2007-03-15 at 11:07 -0800, Andrew Morton wrote: > > + spin_lock(&ubi->eba.eba_tbl_lock); > > + ubi_assert(ubi->eba.eba_tbl[idx].recs); > > + leb_ver = ubi->eba.eba_tbl[idx].recs[lnum].leb_ver; > > + spin_unlock(&ubi->eba.eba_tbl_lock); > > + > > + return leb_ver; > > +} > > I ver

Re: [PATCH 10/22 take 3] UBI: EBA unit

2007-03-15 Thread Randy Dunlap
On Thu, 15 Mar 2007 18:29:51 -0500 Josh Boyer wrote: > On Thu, Mar 15, 2007 at 02:24:10PM -0700, Randy Dunlap wrote: > > On Thu, 15 Mar 2007 11:07:03 -0800 Andrew Morton wrote: > > > > > > > > There's way too much code here to expect it to get decently reviewed, > > > alas. > > > > Yes. > > >

Re: [PATCH 10/22 take 3] UBI: EBA unit

2007-03-15 Thread Josh Boyer
On Thu, Mar 15, 2007 at 02:24:10PM -0700, Randy Dunlap wrote: > On Thu, 15 Mar 2007 11:07:03 -0800 Andrew Morton wrote: > > > > > There's way too much code here to expect it to get decently reviewed, alas. > > Yes. > > /me repeats wish that Not Everything Should Be Sent to lkml. :( Just curio

Re: [PATCH 10/22 take 3] UBI: EBA unit

2007-03-15 Thread Randy Dunlap
On Thu, 15 Mar 2007 11:07:03 -0800 Andrew Morton wrote: > > There's way too much code here to expect it to get decently reviewed, alas. Yes. /me repeats wish that Not Everything Should Be Sent to lkml. :( > > On Wed, 14 Mar 2007 17:20:24 +0200 Artem Bityutskiy <[EMAIL PROTECTED]> > > wrote:

Re: [PATCH 10/22 take 3] UBI: EBA unit

2007-03-15 Thread Andrew Morton
There's way too much code here to expect it to get decently reviewed, alas. > On Wed, 14 Mar 2007 17:20:24 +0200 Artem Bityutskiy <[EMAIL PROTECTED]> wrote: > > ... > > +/** > + * leb_get_ver - get logical eraseblock version. > + * > + * @ubi: the UBI device description object > + * @vol_id: the