Re: [PATCH 2/3] input/keyboard: Add support for Dollar Cove TI power button

2017-09-01 Thread Takashi Iwai
On Fri, 01 Sep 2017 13:09:36 +0200, Andy Shevchenko wrote: > > On Thu, 2017-08-31 at 11:33 -0700, Dmitry Torokhov wrote: > > > > + > > > + ret = enable_irq_wake(irq); > > > + if (ret) > > > + dev_warn(dev, "Can't enable IRQ as wake source: > > > %d\n", ret); > > > > We do not normally en

Re: [PATCH 2/3] input/keyboard: Add support for Dollar Cove TI power button

2017-09-01 Thread Andy Shevchenko
On Thu, 2017-08-31 at 11:33 -0700, Dmitry Torokhov wrote: > > + > > + ret = enable_irq_wake(irq); > > + if (ret) > > + dev_warn(dev, "Can't enable IRQ as wake source: > > %d\n", ret); > > We do not normally enable wake IRQs in probe, but instead do: > > device_init_wakeup(&pd

Re: [PATCH 2/3] input/keyboard: Add support for Dollar Cove TI power button

2017-08-31 Thread Takashi Iwai
On Thu, 31 Aug 2017 20:33:55 +0200, Dmitry Torokhov wrote: > > Hi Takashi, > > On Tue, Aug 22, 2017 at 07:57:09AM +0200, Takashi Iwai wrote: > > This provides a new input driver for supporting the power button on > > Dollar Cove TI PMIC, found on Cherrytrail-based devices. > > The patch is based

Re: [PATCH 2/3] input/keyboard: Add support for Dollar Cove TI power button

2017-08-31 Thread Dmitry Torokhov
Hi Takashi, On Tue, Aug 22, 2017 at 07:57:09AM +0200, Takashi Iwai wrote: > This provides a new input driver for supporting the power button on > Dollar Cove TI PMIC, found on Cherrytrail-based devices. > The patch is based on the original work by Intel, found at: > https://github.com/01org/Prod

Re: [PATCH 2/3] input/keyboard: Add support for Dollar Cove TI power button

2017-08-22 Thread Johannes Stezenbach
On Tue, Aug 22, 2017 at 12:58:07PM +0200, Takashi Iwai wrote: > I updated the patches and now pushed to topic/dollar-cove-ti-4.13-v2 > branch. Will resubmit v2 (tomorrow or later) once after gathering > reviews. FWIW I tested current Linus's master + topic/dollar-cove-ti-4.13-v2 + topic/soc-cx207

Re: [PATCH 2/3] input/keyboard: Add support for Dollar Cove TI power button

2017-08-22 Thread Takashi Iwai
On Tue, 22 Aug 2017 11:42:08 +0200, Andy Shevchenko wrote: > > On Tue, 2017-08-22 at 07:57 +0200, Takashi Iwai wrote: > > This provides a new input driver for supporting the power button on > > Dollar Cove TI PMIC, found on Cherrytrail-based devices. > > The patch is based on the original work by

Re: [PATCH 2/3] input/keyboard: Add support for Dollar Cove TI power button

2017-08-22 Thread Andy Shevchenko
On Tue, 2017-08-22 at 07:57 +0200, Takashi Iwai wrote: > This provides a new input driver for supporting the power button on > Dollar Cove TI PMIC, found on Cherrytrail-based devices. > The patch is based on the original work by Intel, found at: >   https://github.com/01org/ProductionKernelQuilts