Re: [PATCH v3 04/28] IB/Verbs: Reform IB-core cm

2015-04-14 Thread Michael Wang
On 04/13/2015 09:29 PM, Jason Gunthorpe wrote: > On Mon, Apr 13, 2015 at 06:40:35PM +, Hefty, Sean wrote: - if (rdma_node_get_transport(ib_device->node_type) != >>> RDMA_TRANSPORT_IB) - return; + int count = 0; >>> >>> I'm ok with this as an intermediate patch but go

Re: [PATCH v3 04/28] IB/Verbs: Reform IB-core cm

2015-04-14 Thread Michael Wang
On 04/13/2015 08:12 PM, ira.weiny wrote: [snip] >> - >> -if (rdma_node_get_transport(ib_device->node_type) != RDMA_TRANSPORT_IB) >> -return; >> +int count = 0; > > I'm ok with this as an intermediate patch but going forward if we are going to > have calls like > > static in

Re: [PATCH v3 04/28] IB/Verbs: Reform IB-core cm

2015-04-13 Thread ira.weiny
On Mon, Apr 13, 2015 at 01:29:30PM -0600, Jason Gunthorpe wrote: > On Mon, Apr 13, 2015 at 06:40:35PM +, Hefty, Sean wrote: > > > > - if (rdma_node_get_transport(ib_device->node_type) != > > > RDMA_TRANSPORT_IB) > > > > - return; > > > > + int count = 0; > > > > > > I

Re: [PATCH v3 04/28] IB/Verbs: Reform IB-core cm

2015-04-13 Thread Jason Gunthorpe
On Mon, Apr 13, 2015 at 06:40:35PM +, Hefty, Sean wrote: > > > - if (rdma_node_get_transport(ib_device->node_type) != > > RDMA_TRANSPORT_IB) > > > - return; > > > + int count = 0; > > > > I'm ok with this as an intermediate patch but going forward if we are > > going to > > have calls

RE: [PATCH v3 04/28] IB/Verbs: Reform IB-core cm

2015-04-13 Thread Hefty, Sean
> > - if (rdma_node_get_transport(ib_device->node_type) != > RDMA_TRANSPORT_IB) > > - return; > > + int count = 0; > > I'm ok with this as an intermediate patch but going forward if we are > going to > have calls like > > static inline int cap_ib_cm_dev(struct ib_device *device) I

Re: [PATCH v3 04/28] IB/Verbs: Reform IB-core cm

2015-04-13 Thread ira.weiny
On Mon, Apr 13, 2015 at 02:23:46PM +0200, Michael Wang wrote: > > Use raw management helpers to reform IB-core cm. > > Cc: Steve Wise > Cc: Tom Talpey > Cc: Jason Gunthorpe > Cc: Doug Ledford > Cc: Ira Weiny > Cc: Sean Hefty > Signed-off-by: Michael Wang > --- > drivers/infiniband/core/cm