Hi,
On Friday, 25 of March 2005 01:49, you wrote:
]--snip--[
> > > I actually added such calls in uhci, ehci and yenta. It's ok for S3 (and
> > > definitely required for S3). Unclear if it's ok for S4, so please try
> > > revert the patch.
> >
> > 2.6.11-rc1-mm1 with the patch reverted works fine
On Thu, 2005-03-24 at 21:42, Rafael J. Wysocki wrote:
> Hi,
>
> On Thursday, 24 of March 2005 02:27, Li Shaohua wrote:
> > On Thu, 2005-03-24 at 09:03, Len Brown wrote:
> > > On Wed, 2005-03-23 at 18:49, Rafael J. Wysocki wrote:
> > > > Hi,
> > > >
> > > > On Wednesday, 23 of March 2005 23:39, Pa
Hi,
On Thursday, 24 of March 2005 02:03, Len Brown wrote:
> On Wed, 2005-03-23 at 18:49, Rafael J. Wysocki wrote:
]-- snip --[
> I'd believe that ohci_hcd and ehci_hcd are fragile since glancing
> at their lengthy .resume routines it isn't immediately obvious
> that they do this. But yenta_dev_r
Hi,
On Thursday, 24 of March 2005 02:27, Li Shaohua wrote:
> On Thu, 2005-03-24 at 09:03, Len Brown wrote:
> > On Wed, 2005-03-23 at 18:49, Rafael J. Wysocki wrote:
> > > Hi,
> > >
> > > On Wednesday, 23 of March 2005 23:39, Pavel Machek wrote:
> > > > Hi!
> > > >
> > > > > > > > Will this do it
Hi!
> > You can't put -ENODEV into pci_power_t ... but maybe we should create
> > PCI_ERROR and pass it in cases like this one?
> That makes sense, please do it.
Added:
#define PCI_POWER_ERROR ((pci_power_t __force) -1)
Pav
On Tue, 2005-03-22 at 20:20, Pavel Machek wrote:
> Hi!
>
> > >> > Yes, but it is needed. There are many drivers, and they look at
> > >> > numerical value of PMSG_*. I'm proceeding in steps. I hopefully
> > killed
> > >> > all direct accesses to the constants, and will switch constants
> to
> > >>
On Thu, 2005-03-24 at 09:03, Len Brown wrote:
> On Wed, 2005-03-23 at 18:49, Rafael J. Wysocki wrote:
> > Hi,
> >
> > On Wednesday, 23 of March 2005 23:39, Pavel Machek wrote:
> > > Hi!
> > >
> > > > > > > Will this do it for the moment?
> > > > > >
> > > > > > Its certainly better.
> > > > >
> >
On Wed, 2005-03-23 at 18:49, Rafael J. Wysocki wrote:
> Hi,
>
> On Wednesday, 23 of March 2005 23:39, Pavel Machek wrote:
> > Hi!
> >
> > > > > > Will this do it for the moment?
> > > > >
> > > > > Its certainly better.
> > > >
> > > > With the Len's patch applied I have to unload the modules:
> >
Hi,
On Wednesday, 23 of March 2005 23:39, Pavel Machek wrote:
> Hi!
>
> > > > > Will this do it for the moment?
> > > >
> > > > Its certainly better.
> > >
> > > With the Len's patch applied I have to unload the modules:
> > >
> > > ohci_hcd
> > > ehci_hcd
> > > yenta_socket
> > >
> > > befor
Hi!
> > > > Will this do it for the moment?
> > >
> > > Its certainly better.
> >
> > With the Len's patch applied I have to unload the modules:
> >
> > ohci_hcd
> > ehci_hcd
> > yenta_socket
> >
> > before suspend as each of them hangs the box solid during either
> > suspend or resume. Moreo
Hi,
On Tuesday, 22 of March 2005 22:49, Rafael J. Wysocki wrote:
> Hi,
>
> On Tuesday, 22 of March 2005 12:01, Pavel Machek wrote:
> > Hi!
> >
> > > Will this do it for the moment?
> >
> > Its certainly better.
>
> With the Len's patch applied I have to unload the modules:
>
> ohci_hcd
> ehci
Hi,
On Tuesday, 22 of March 2005 12:01, Pavel Machek wrote:
> Hi!
>
> > Will this do it for the moment?
>
> Its certainly better.
With the Len's patch applied I have to unload the modules:
ohci_hcd
ehci_hcd
yenta_socket
before suspend as each of them hangs the box solid during either
suspend
Hi!
> to Linus when he reappears and then I'll duck for cover and let you guys
> sort it out ;)
There should be little reason for taking cover, that patches were just
anotating types... BTW this is how switch to pm_message_t is going to
look. If you are developing something pm-related, you should
Hi!
> >> > Yes, but it is needed. There are many drivers, and they look at
> >> > numerical value of PMSG_*. I'm proceeding in steps. I hopefully
> killed
> >> > all direct accesses to the constants, and will switch constants to
> >> > something else... But that is going to be tommorow (need some
>
>> > Yes, but it is needed. There are many drivers, and they look at
>> > numerical value of PMSG_*. I'm proceeding in steps. I hopefully
killed
>> > all direct accesses to the constants, and will switch constants to
>> > something else... But that is going to be tommorow (need some
sleep).
>> Th
Hi!
> Will this do it for the moment?
Its certainly better.
What about
> > > +static int acpi_pci_set_power_state(struct pci_dev *dev,
> > pci_power_t state)
> > > +{
> > > + acpi_handle handle = DEVICE_ACPI_HANDLE(&dev->dev);
> > > + static int state_conv[] = {
> > > + [0]
Hi!
> > Yes, but it is needed. There are many drivers, and they look at
> > numerical value of PMSG_*. I'm proceeding in steps. I hopefully killed
> > all direct accesses to the constants, and will switch constants to
> > something else... But that is going to be tommorow (need some sleep).
> The
Hi!
> And they are both "dangerous" -- they introduce new and untested
> functionality while I'm trying to transition from int to
> pm_message_t. They also affect all the drivers.
Actually, there's one even more severe problem with
platform_pci_choose_state...
If we are doing freeze for swsusp s
On Mon, Mar 21, 2005 at 06:27:33PM -0800, Andrew Morton wrote:
> OK, well unless someone has objections I'll just send all these
>
> swsusp-add-missing-refrigerator-calls.patch
> suspend-to-ram-update-videotxt-with-more-systems.patch
> pm-remove-obsolete-pm_-from-vtc.patch
> swsusp-small-updates.p
Will this do it for the moment?
If so, lets use it until Pavel's flag-day is over -- when we'll send an
updated patch.
thanks,
-Len
= drivers/pci/pci-acpi.c 1.4 vs edited =
--- 1.4/drivers/pci/pci-acpi.c 2005-03-03 04:28:23 -05:00
+++ edited/drivers/pci/pci-acpi.c 2005-03-21 22:5
Pavel Machek <[EMAIL PROTECTED]> wrote:
>
> > Could I suggest that you prepare a fixup against 2.6.12-rc1-mm1 and send
> > that to Len and myself? If that fixup is not suitable for a 2.6.12-rc1
> > based tree then I can look after it until things get flushed out.
>
> Could you just revert thos
On Tue, 2005-03-22 at 09:35, Pavel Machek wrote:
> Hi!
>
> > > and that says:
> > >
> > > #define PMSG_FREEZE ((__force pm_message_t) 3)
> > >
> > > ... I certainly have _FREEZE defined as 1 in my local tree, but I
> do
> > > not see that change in -mm yet.
> >
> > Both 2.6.12-rc1-mm1 and 2
On Mon, Mar 21, 2005 at 05:06:23PM -0800, Andrew Morton wrote:
> # drivers/pci/pci-acpi.c
> # 2005/03/19 00:15:24-05:00 [EMAIL PROTECTED] +46 -1
> # add platform_pci_choose_state()
> #
> diff -Nru a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
> --- a/drivers/pci/pci-acpi.c 2005-03-2
On Po 21-03-05 17:52:32, Andrew Morton wrote:
> Pavel Machek <[EMAIL PROTECTED]> wrote:
> >
> > > Could I suggest that you prepare a fixup against 2.6.12-rc1-mm1 and send
> > > that to Len and myself? If that fixup is not suitable for a 2.6.12-rc1
> > > based tree then I can look after it until
Pavel Machek <[EMAIL PROTECTED]> wrote:
>
> On Po 21-03-05 17:52:32, Andrew Morton wrote:
> > Pavel Machek <[EMAIL PROTECTED]> wrote:
> > >
> > > > Could I suggest that you prepare a fixup against 2.6.12-rc1-mm1 and send
> > > > that to Len and myself? If that fixup is not suitable for a 2.6.12-r
Hi!
> > and that says:
> >
> > #define PMSG_FREEZE ((__force pm_message_t) 3)
> >
> > ... I certainly have _FREEZE defined as 1 in my local tree, but I do
> > not see that change in -mm yet.
>
> Both 2.6.12-rc1-mm1 and 2.6.12-rc1 have:
>
> #define PMSG_FREEZE ((__force pm_message_t) 3)
Pavel Machek <[EMAIL PROTECTED]> wrote:
>
> Hi!
>
> > > On Monday, 21 of March 2005 11:51, you wrote:
> > > >
> > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.12-rc1/2.6.12-rc1-mm1/
> > >
> > > I get the following BUG every time I try to suspend my box to disk.
> >
> >
Hi!
> > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.12-rc1/2.6.12-rc1-mm1/
> >
> > I get the following BUG every time I try to suspend my box to disk.
>
> Pavel, that's the BUG() in pci_choose_state(). I did have some
> reject-fixing to do on that wrt a change in Greg's
Hi!
> > On Monday, 21 of March 2005 11:51, you wrote:
> > >
> > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.12-rc1/2.6.12-rc1-mm1/
> >
> > I get the following BUG every time I try to suspend my box to disk.
>
> Pavel, that's the BUG() in pci_choose_state(). I did have s
"Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote:
>
> Hi,
>
> On Monday, 21 of March 2005 11:51, you wrote:
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.12-rc1/2.6.12-rc1-mm1/
>
> I get the following BUG every time I try to suspend my box to disk.
Pavel, that's the BUG
Hi,
On Monday, 21 of March 2005 11:51, you wrote:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.12-rc1/2.6.12-rc1-mm1/
I get the following BUG every time I try to suspend my box to disk.
Greets,
Rafael
Stopping tasks:
==
31 matches
Mail list logo
