On 4/6/07, Roland Dreier <[EMAIL PROTECTED]> wrote:
[I can't believe I'm stepping into an indentation flamewar, but here goes...]
that the line with "bar" on it is properly indented with one tab
(since it is part of the if statement that is also indented one tab),
and then four spaces are used
> > So in practical terms "\n \t" and "\n\t" are identical;
> > although the former "should not" be used, it doesn't
> > actually affect what CodingStyle is primarily trying to
> > control (i.e. what the code looks like).
>
> That's not what CodingStyle is trying to control. Not "what the
> code
On 4/6/07, Stefan Richter <[EMAIL PROTECTED]> wrote:
David Brownell wrote:
[...]
>>> 1 if (To control chain reactions, your odds
>>> 2 Improve if you've got cadmium rods) {
>>> 3 In your fission reactor
>>> 4 Their lack is a factor
>>> 5 }
>>> 6 In scre
On Friday 06 April 2007 18:57, David Brownell wrote:
> On Friday 06 April 2007 3:17 pm, Thomas Gleixner wrote:
> > David,
> >
> > http://tglx.de/private/tglx/usbnet.png
> >
> > /me recommends emacs-develock.el for colorful white space wreckage
> > display !
>
> Then I'd have to switch to EMACS .
David Brownell <[EMAIL PROTECTED]> writes:
> So in practical terms "\n \t" and "\n\t" are identical;
> although the former "should not" be used, it doesn't
> actually affect what CodingStyle is primarily trying to
> control (i.e. what the code looks like).
That's not what CodingStyle is trying to
Jan Engelhardt <[EMAIL PROTECTED]> writes:
> Tabs should be used for indent, not padding. People wanting to use
> different-sized tabs can change settings in their editor, i.e.
> to make a tab 12 instead of 8. Or 6. Or whatever. If tabs only ever
> appear at the front, this works, it breaks when t
On Apr 6 2007 15:40, David Brownell wrote:
>> >if (...) {
>> >THAT WAS ONE MORE TAB
>> >}
>> >
>> >Come on, stop wasting everyone's time with utter nonsense.
>> I was never debating these two things.
>Actually, you did.
If it was perceived I did, then I owe you an apology.
>
On Friday 06 April 2007 4:21 pm, Thomas Gleixner wrote:
> David,
>
> On Fri, 2007-04-06 at 15:57 -0700, David Brownell wrote:
> > This particular issue doesn't actually affect indentation, since the
> > tab trumps that space. So it's a bit off-agenda for this particular
> > flamage.
>
> ROTFL, t
David,
On Fri, 2007-04-06 at 15:57 -0700, David Brownell wrote:
> This particular issue doesn't actually affect indentation, since the
> tab trumps that space. So it's a bit off-agenda for this particular
> flamage.
ROTFL, the tab trumps the space. Is this a card game ?
> > Please change your c
On Friday 06 April 2007 3:17 pm, Thomas Gleixner wrote:
> David,
>
> http://tglx.de/private/tglx/usbnet.png
>
> /me recommends emacs-develock.el for colorful white space wreckage
> display !
Then I'd have to switch to EMACS ... no thanks! ;)
At the risk of switching to a VI/EMACS flamewar (cou
On Friday 06 April 2007 3:07 pm, Jan Engelhardt wrote:
>
> On Apr 6 2007 15:05, David Brownell wrote:
> >
> >> but... egads! Linus
> >> put spaces before the &&s to line them up nicely!
> >>
> >> "more in the breach" and all that I guess...
> >
> >Yeah, nobody likes style nazis. On the other h
On Friday 06 April 2007 3:04 pm, Jan Engelhardt wrote:
> > if (...) {
> > THAT WAS ONE MORE TAB
> > }
> >
> >and
> >
> > for (...) {
> > THAT WAS ALSO ONE MORE TAB
> > }
> >
> >Come on, stop wasting everyone's time with utter nonsense.
>
> I was never debat
David,
On Fri, 2007-04-06 at 14:05 -0700, David Brownell wrote:
> Please change your coding style to conform to Documentation/CodingStyle.
>
> *** Only indent with tabs!! ***
>
> Every one of those examples violates that simple rule.
>
> Why does *anyone* have even the slighte
On Apr 6 2007 15:05, David Brownell wrote:
>
>> but... egads! Linus
>> put spaces before the &&s to line them up nicely!
>>
>> "more in the breach" and all that I guess...
>
>Yeah, nobody likes style nazis. On the other hand, it's rather
>unusual to be the target of style nazism for actually f
Hello David,
On Apr 6 2007 13:57, David Brownell wrote:
>> though I do not speak for
>> them, seem to do it much the way I described, judging from the code they
>> wrote/write.
>
>Your eyes are broken then ...
Sorry? I could have simply told you to look into kernel/signal.c LINE
220 (that's in
On Friday 06 April 2007 2:38 pm, Roland Dreier wrote:
> [I can't believe I'm stepping into an indentation flamewar, but here goes...]
At least you weren't the target of attacks there ... for daring to
actually follow the only published Linux style guide in that area!!
> > Please change your cod
On Friday 06 April 2007 2:37 pm, Jeremy Fitzhardinge wrote:
> David Brownell wrote:
> > Please change your coding style to conform to Documentation/CodingStyle.
> >
> > *** Only indent with tabs!! ***
> >
> > Every one of those examples violates that simple rule.
> >
>
> Spaces
On Apr 6 2007 14:05, David Brownell wrote:
>
>Please change your coding style to conform to Documentation/CodingStyle.
>
> *** Only indent with tabs!! ***
>
>Every one of those examples violates that simple rule.
>
>Why does *anyone* have even the slightest difficulty understandi
On Fri, 2007-04-06 at 14:38 -0700, Roland Dreier wrote:
[snip]
> If you have a git tree handy, you can do "git show 68380b58" and see
> that Linus himself wrote:
>
> if (get_wq_data(work) == cwq
> && work_pending(work)
> && !list_empty(&work->entry)) {
>
> I have to admi
David Brownell wrote:
> On Friday 06 April 2007 12:03 pm, Stefan Richter wrote:
>
>> I usually indent this way if expressions exceed the 80 columns limit:
Or in other words:
- When a new scope is opened, increase indentations by 8 characters.
Use a tab for that.
- When wrapping within an
David Brownell wrote:
On Friday 06 April 2007 12:03 pm, Stefan Richter wrote:
I usually indent this way if expressions exceed the 80 columns limit:
if (foo___ &&
bar___) {
doit;
}
and
if ((one___ ||
one_an
[I can't believe I'm stepping into an indentation flamewar, but here goes...]
> Please change your coding style to conform to Documentation/CodingStyle.
>
> *** Only indent with tabs!! ***
>
> Every one of those examples violates that simple rule.
Yes, Documentation/Coding
David Brownell wrote:
> Please change your coding style to conform to Documentation/CodingStyle.
>
> *** Only indent with tabs!! ***
>
> Every one of those examples violates that simple rule.
>
Spaces are used to indent all over the kernel; using a few spaces to pad
out some i
On Friday 06 April 2007 12:16 pm, Jan Engelhardt wrote:
> >> and that the inner block code
> >> (lines 3 and 4) should have more indent than line 2.
> >
> >We disagree. The "inner" block should in all cases have one-tab indent.
>
> You disagree. "We", as in, the kernel coders,
... agree with wh
On Friday 06 April 2007 12:03 pm, Stefan Richter wrote:
>
> I usually indent this way if expressions exceed the 80 columns limit:
>
> if (foo___ &&
> bar___) {
> doit;
> }
> and
> if ((one___ ||
>one_and_a_half) &&
>
On Apr 6 2007 10:29, David Brownell wrote:
>> Using
>> /^\t+\x20{2,8}/ on continuation line(s) is perfect because it does
>> not cause either the continuation line(s) or the inner block code to
>> move too much to the right.
>
>No, that's a clear violation of CodingStyle on two separate points:
>
David Brownell wrote:
[...]
>>> 1 if (To control chain reactions, your odds
>>> 2 Improve if you've got cadmium rods) {
>>> 3 In your fission reactor
>>> 4 Their lack is a factor
>>> 5 }
>>> 6 In screams of "A meltdown! Ye gods!"
>>>
>>> Now, the former m
27 matches
Mail list logo
