Re: [PATCH] bootconfig: Remove duplicate included header file linux/bootconfig.h

2024-07-10 Thread Google
On Thu, 11 Jul 2024 02:21:53 +0200 Thorsten Blum wrote: > The header file linux/bootconfig.h is included whether __KERNEL__ is > defined or not. > > Include it only once before the #ifdef/#else/#endif preprocessor > directives and remove the following make includecheck warning: > >

Re: [PATCH v2 2/2] virtio: fix vq # for balloon

2024-07-10 Thread Michael S. Tsirkin
On Wed, Jul 10, 2024 at 03:54:22PM -0700, Daniel Verkamp wrote: > On Wed, Jul 10, 2024 at 1:39 PM Michael S. Tsirkin wrote: > > > > On Wed, Jul 10, 2024 at 12:58:11PM -0700, Daniel Verkamp wrote: > > > On Wed, Jul 10, 2024 at 11:39 AM Michael S. Tsirkin > > > wrote: > > > > > > > > On Wed, Jul

Re: [PATCH v2 2/4] x86/mce, EDAC/mce_amd: Add support for new MCA_SYND{1,2} registers

2024-07-10 Thread Naik, Avadhut
On 7/10/2024 04:38, Borislav Petkov wrote: > On Tue, Jul 09, 2024 at 01:27:25AM -0500, Naik, Avadhut wrote: > >> Userspace error decoding tools like the rasdaemon gather related hardware >> error >> information through the tracepoints. As such, its important to have these two >> registers in

Re: [PATCH v2 2/2] virtio: fix vq # for balloon

2024-07-10 Thread Daniel Verkamp
On Wed, Jul 10, 2024 at 1:39 PM Michael S. Tsirkin wrote: > > On Wed, Jul 10, 2024 at 12:58:11PM -0700, Daniel Verkamp wrote: > > On Wed, Jul 10, 2024 at 11:39 AM Michael S. Tsirkin wrote: > > > > > > On Wed, Jul 10, 2024 at 11:12:34AM -0700, Daniel Verkamp wrote: > > > > On Wed, Jul 10, 2024 at

Re: [PATCH 3/3] uprobes: make uprobe_register() return struct uprobe *

2024-07-10 Thread Andrii Nakryiko
. I think /** makes sense for documenting "public API" function, so which is why all the above. > > > > @@ -3180,10 +3181,8 @@ static void bpf_uprobe_unregister(struct path > > > *path, struct bpf_uprobe *uprobes, > > > { > > > u32 i; >

Re: [PATCH v2 2/2] virtio: fix vq # for balloon

2024-07-10 Thread Michael S. Tsirkin
On Wed, Jul 10, 2024 at 12:58:11PM -0700, Daniel Verkamp wrote: > On Wed, Jul 10, 2024 at 11:39 AM Michael S. Tsirkin wrote: > > > > On Wed, Jul 10, 2024 at 11:12:34AM -0700, Daniel Verkamp wrote: > > > On Wed, Jul 10, 2024 at 4:43 AM Michael S. Tsirkin > > > wrote: > > > > > > > > virtio

Re: [PATCH 3/3] uprobes: make uprobe_register() return struct uprobe *

2024-07-10 Thread Oleg Nesterov
register(struct path *path, > > struct bpf_uprobe *uprobes, > > { > > u32 i; > > > > - for (i = 0; i < cnt; i++) { > > - uprobe_unregister(d_real_inode(path->dentry), > > uprobes[i].offset, > > -

Re: [PATCH v2 2/2] virtio: fix vq # for balloon

2024-07-10 Thread Daniel Verkamp
On Wed, Jul 10, 2024 at 11:39 AM Michael S. Tsirkin wrote: > > On Wed, Jul 10, 2024 at 11:12:34AM -0700, Daniel Verkamp wrote: > > On Wed, Jul 10, 2024 at 4:43 AM Michael S. Tsirkin wrote: > > > > > > virtio balloon communicates to the core that in some > > > configurations vq #s are

Re: [PATCH 3/3] uprobes: make uprobe_register() return struct uprobe *

2024-07-10 Thread Andrii Nakryiko
On Wed, Jul 10, 2024 at 12:38 PM Jiri Olsa wrote: > > On Wed, Jul 10, 2024 at 11:23:10AM -0700, Andrii Nakryiko wrote: > > On Wed, Jul 10, 2024 at 9:49 AM Jiri Olsa wrote: > > > > > > On Wed, Jul 10, 2024 at 06:31:33PM +0200, Oleg Nesterov wrote: > > > > > > SNIP > > > > > > > diff --git

Re: [PATCH 3/3] uprobes: make uprobe_register() return struct uprobe *

2024-07-10 Thread Jiri Olsa
On Wed, Jul 10, 2024 at 11:23:10AM -0700, Andrii Nakryiko wrote: > On Wed, Jul 10, 2024 at 9:49 AM Jiri Olsa wrote: > > > > On Wed, Jul 10, 2024 at 06:31:33PM +0200, Oleg Nesterov wrote: > > > > SNIP > > > > > diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c > > > index

Re: [PATCH 1/3] uprobes: kill uprobe_register_refctr()

2024-07-10 Thread Oleg Nesterov
On 07/10, Andrii Nakryiko wrote: > > LGTM with few nits below. > > Acked-by: Andrii Nakryiko Thanks for looking at this. > > @@ -3477,7 +3477,7 @@ int bpf_uprobe_multi_link_attach(const union bpf_attr > > *attr, struct bpf_prog *pr > > _uprobe_multi_link_lops, prog); > >

Re: [PATCH v4] perf,x86: avoid missing caller address in stack traces captured in uprobe

2024-07-10 Thread Andrii Nakryiko
On Wed, Jul 10, 2024 at 9:24 AM Josh Poimboeuf wrote: > > On Wed, Jul 10, 2024 at 08:11:57AM -0700, Andrii Nakryiko wrote: > > On Wed, Jul 10, 2024 at 4:39 AM Peter Zijlstra wrote: > > > On Tue, Jul 09, 2024 at 10:50:00AM -0700, Andrii Nakryiko wrote: > > > > You can see it replaced the first

Re: [PATCH 3/3] uprobes: make uprobe_register() return struct uprobe *

2024-07-10 Thread Oleg Nesterov
On 07/10, Jiri Olsa wrote: > > > @@ -3180,10 +3181,8 @@ static void bpf_uprobe_unregister(struct path *path, > > struct bpf_uprobe *uprobes, > > { > > u32 i; > > > > - for (i = 0; i < cnt; i++) { > > - uprobe_unregister(d_real_inode(path->dentry), uprobes[i].offset, > > -

Re: [PATCH v2 2/2] virtio: fix vq # for balloon

2024-07-10 Thread Michael S. Tsirkin
On Wed, Jul 10, 2024 at 11:12:34AM -0700, Daniel Verkamp wrote: > On Wed, Jul 10, 2024 at 4:43 AM Michael S. Tsirkin wrote: > > > > virtio balloon communicates to the core that in some > > configurations vq #s are non-contiguous by setting name > > pointer to NULL. > > > > Unfortunately, core

Re: [PATCH v2 2/2] virtio: fix vq # for balloon

2024-07-10 Thread Michael S. Tsirkin
On Wed, Jul 10, 2024 at 11:12:34AM -0700, Daniel Verkamp wrote: > On Wed, Jul 10, 2024 at 4:43 AM Michael S. Tsirkin wrote: > > > > virtio balloon communicates to the core that in some > > configurations vq #s are non-contiguous by setting name > > pointer to NULL. > > > > Unfortunately, core

Re: [PATCH 3/3] uprobes: make uprobe_register() return struct uprobe *

2024-07-10 Thread Andrii Nakryiko
On Wed, Jul 10, 2024 at 9:49 AM Jiri Olsa wrote: > > On Wed, Jul 10, 2024 at 06:31:33PM +0200, Oleg Nesterov wrote: > > SNIP > > > diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c > > index 467f358c8ce7..7571811127a2 100644 > > --- a/kernel/trace/bpf_trace.c > > +++

Re: [PATCH 3/3] uprobes: make uprobe_register() return struct uprobe *

2024-07-10 Thread Andrii Nakryiko
On Wed, Jul 10, 2024 at 9:33 AM Oleg Nesterov wrote: > > This way uprobe_unregister() and uprobe_apply() do not need find_uprobe() + > put_uprobe(). And to me this change simplifies the code a bit. > > Signed-off-by: Oleg Nesterov > --- > include/linux/uprobes.h | 14 ++-- >

Re: [PATCH v2 2/2] virtio: fix vq # for balloon

2024-07-10 Thread Daniel Verkamp
On Wed, Jul 10, 2024 at 4:43 AM Michael S. Tsirkin wrote: > > virtio balloon communicates to the core that in some > configurations vq #s are non-contiguous by setting name > pointer to NULL. > > Unfortunately, core then turned around and just made them > contiguous again. Result is that driver

Re: [PATCH 1/3] uprobes: kill uprobe_register_refctr()

2024-07-10 Thread Andrii Nakryiko
On Wed, Jul 10, 2024 at 9:32 AM Oleg Nesterov wrote: > > It doesn't make any sense to have 2 versions of _register(). Note that > trace_uprobe_enable(), the only user of uprobe_register(), doesn't need > to check tu->ref_ctr_offset to decide which one should be used, it could > safely pass

Re: [PATCH 3/3] uprobes: make uprobe_register() return struct uprobe *

2024-07-10 Thread Jiri Olsa
On Wed, Jul 10, 2024 at 06:31:33PM +0200, Oleg Nesterov wrote: SNIP > diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c > index 467f358c8ce7..7571811127a2 100644 > --- a/kernel/trace/bpf_trace.c > +++ b/kernel/trace/bpf_trace.c > @@ -3157,6 +3157,7 @@ struct bpf_uprobe { >

Re: [PATCH v4] perf,x86: avoid missing caller address in stack traces captured in uprobe

2024-07-10 Thread Josh Poimboeuf
On Wed, Jul 10, 2024 at 08:11:57AM -0700, Andrii Nakryiko wrote: > On Wed, Jul 10, 2024 at 4:39 AM Peter Zijlstra wrote: > > On Tue, Jul 09, 2024 at 10:50:00AM -0700, Andrii Nakryiko wrote: > > > You can see it replaced the first byte, the following 3 bytes are > > > remnants of endb64 (gdb says

Re: [PATCH v3 9/9] dt-bindings: interconnect: qcom: msm8953: Fix 'See also' in description

2024-07-10 Thread Rob Herring (Arm)
On Tue, 09 Jul 2024 12:22:54 +0200, Adam Skladowski wrote: > "See also" in description seems to be wrongly defined, > make it inline with other yamls. > > Fixes: 791ed23f735b ("dt-bindings: interconnect: qcom: Add Qualcomm MSM8953 > NoC") > Signed-off-by: Adam Skladowski > --- >

Re: [PATCH v3 7/9] dt-bindings: interconnect: qcom: msm8939: Fix example

2024-07-10 Thread Rob Herring (Arm)
On Tue, 09 Jul 2024 12:22:52 +0200, Adam Skladowski wrote: > For now example list snoc_mm as children of bimc which is obviously > not valid, drop bimc and move snoc_mm into snoc. > > Signed-off-by: Adam Skladowski > --- > .../devicetree/bindings/interconnect/qcom,msm8939.yaml | 6 --

Re: [RFC PATCH v4] ptp: Add vDSO-style vmclock support

2024-07-10 Thread David Woodhouse
On Wed, 2024-07-10 at 15:07 +0200, Peter Hilber wrote: > On 08.07.24 11:27, David Woodhouse wrote: > > From: David Woodhouse > > > > The vmclock "device" provides a shared memory region with precision clock > > information. By using shared memory, it is safe across Live Migration. > > > > Like

Re: [PATCH v3 3/9] dt-bindings: interconnect: qcom: Add Qualcomm MSM8937 NoC

2024-07-10 Thread Rob Herring (Arm)
On Tue, 09 Jul 2024 12:22:48 +0200, Adam Skladowski wrote: > Add bindings for Qualcomm MSM8937 Network-On-Chip interconnect devices. > > Signed-off-by: Adam Skladowski > --- > .../bindings/interconnect/qcom,msm8939.yaml | 8 +- > .../dt-bindings/interconnect/qcom,msm8937.h | 93

Re: [PATCH 1/1] remoteproc: mediatek: Support multiple reserved memory regions

2024-07-10 Thread Mathieu Poirier
On Wed, Jul 03, 2024 at 07:53:08PM +0800, Shun-yi Wang wrote: > From: "shun-yi.wang" > > SCP supports multiple reserved memory regions, intended for > specific hardwards. > > Signed-off-by: shun-yi.wang > --- > drivers/remoteproc/mtk_scp.c | 25 + > 1 file changed, 17

Re: [PATCH v3 3/9] dt-bindings: interconnect: qcom: Add Qualcomm MSM8937 NoC

2024-07-10 Thread Rob Herring
On Tue, Jul 09, 2024 at 12:22:48PM +0200, Adam Skladowski wrote: > Add bindings for Qualcomm MSM8937 Network-On-Chip interconnect devices. That is obvious. What would be useful is detailing how 8937 is similar to the existing devices. > > Signed-off-by: Adam Skladowski > --- >

Re: [PATCH v3 1/9] dt-bindings: interconnect: qcom: Add Qualcomm MSM8976 NoC

2024-07-10 Thread Rob Herring
On Tue, Jul 09, 2024 at 12:22:46PM +0200, Adam Skladowski wrote: > Add bindings for Qualcomm MSM8976 Network-On-Chip interconnect devices. > > Signed-off-by: Adam Skladowski > --- > .../bindings/interconnect/qcom,msm8939.yaml | 15 ++- > .../dt-bindings/interconnect/qcom,msm8976.h | 97

Re: [PATCH 0/1] Support multiple reserved memory regions

2024-07-10 Thread Mathieu Poirier
Good morning, On Wed, Jul 03, 2024 at 07:53:07PM +0800, Shun-yi Wang wrote: > From: "shun-yi.wang" > > Besides the reserved memory region for SCP, there are additional > reserved memory regions for specific hardware use. > Currently, only a single memory region is supported. > Modifications

Re: [PATCH v2 2/2] virtio: fix vq # for balloon

2024-07-10 Thread Mathieu Poirier
On Wed, 10 Jul 2024 at 05:43, Michael S. Tsirkin wrote: > > virtio balloon communicates to the core that in some > configurations vq #s are non-contiguous by setting name > pointer to NULL. > > Unfortunately, core then turned around and just made them > contiguous again. Result is that driver is

Re: [PATCH v4 3/3] x86/sgx: Resolve EREMOVE page vs EAUG page data race

2024-07-10 Thread Haitao Huang
On Fri, 05 Jul 2024 02:45:24 -0500, Dmitrii Kuvaiskii wrote: Two enclave threads may try to add and remove the same enclave page simultaneously (e.g., if the SGX runtime supports both lazy allocation and MADV_DONTNEED semantics). Consider some enclave page added to the enclave. User space

Re: [PATCH v4 1/3] x86/sgx: Split SGX_ENCL_PAGE_BEING_RECLAIMED into two flags

2024-07-10 Thread Haitao Huang
On Fri, 05 Jul 2024 02:45:22 -0500, Dmitrii Kuvaiskii wrote: SGX_ENCL_PAGE_BEING_RECLAIMED flag is set when the enclave page is being reclaimed (moved to the backing store). This flag however has two logical meanings: 1. Don't attempt to load the enclave page (the page is busy). 2. Don't

Re: [PATCH v2 01/12] uprobes: update outdated comment

2024-07-10 Thread Andrii Nakryiko
On Wed, Jul 10, 2024 at 6:33 AM Oleg Nesterov wrote: > > On 07/03, Oleg Nesterov wrote: > > > > > /* > > > -* The NULL 'tsk' here ensures that any faults that occur here > > > -* will not be accounted to the task. 'mm' *is* current->mm, > > > -* but we treat this as a 'remote'

Re: [PATCH v4] perf,x86: avoid missing caller address in stack traces captured in uprobe

2024-07-10 Thread Andrii Nakryiko
On Wed, Jul 10, 2024 at 4:39 AM Peter Zijlstra wrote: > > On Tue, Jul 09, 2024 at 10:50:00AM -0700, Andrii Nakryiko wrote: > > On Tue, Jul 9, 2024 at 3:11 AM Peter Zijlstra wrote: > > > > > > On Mon, Jul 08, 2024 at 04:11:27PM -0700, Andrii Nakryiko wrote: > > > > +#ifdef CONFIG_UPROBES > > > >

Re: [PATCH bpf-next] bpf: kprobe: remove unused declaring of bpf_kprobe_override

2024-07-10 Thread Google
On Wed, 10 Jul 2024 15:13:07 +0200 Jiri Olsa wrote: > On Wed, Jul 10, 2024 at 04:59:39PM +0800, Menglong Dong wrote: > > After the commit 5ad2f102 ("tracing/kprobe: bpf: Compare instruction > > should be in Fixes: tag probably ? Yes, I'll add a Fixed tag. > > > pointer with original

Re: [PATCH v2 01/12] uprobes: update outdated comment

2024-07-10 Thread Oleg Nesterov
On 07/03, Oleg Nesterov wrote: > > > /* > > -* The NULL 'tsk' here ensures that any faults that occur here > > -* will not be accounted to the task. 'mm' *is* current->mm, > > -* but we treat this as a 'remote' access since it is > > -* essentially a kernel access to the

Re: [PATCH v3] init: staging: Fix missing warning/taint on builtin code

2024-07-10 Thread Greg Kroah-Hartman
On Sat, Jul 06, 2024 at 12:15:01AM -0300, Ágatha Isabelle Chris Moreira Guedes wrote: > Fix the absence of warning message and kernel tainting when initializing > drivers from the `drivers/staging` subtree from initcalls (when > configured as built-in). > > When such a driver is built as module

Re: [PATCH bpf-next] bpf: kprobe: remove unused declaring of bpf_kprobe_override

2024-07-10 Thread Jiri Olsa
On Wed, Jul 10, 2024 at 04:59:39PM +0800, Menglong Dong wrote: > After the commit 5ad2f102 ("tracing/kprobe: bpf: Compare instruction should be in Fixes: tag probably ? > pointer with original one"), "bpf_kprobe_override" is not used anywhere > anymore, and we can remove it now. > >

Re: [RFC PATCH v4] ptp: Add vDSO-style vmclock support

2024-07-10 Thread Peter Hilber
On 08.07.24 11:27, David Woodhouse wrote: > From: David Woodhouse > > The vmclock "device" provides a shared memory region with precision clock > information. By using shared memory, it is safe across Live Migration. > > Like the KVM PTP clock, this can convert TSC-based cross timestamps into >

Re: [PATCH V2] test/vsock: add install target

2024-07-10 Thread Stefano Garzarella
On Wed, Jul 10, 2024 at 08:27:28PM GMT, Peng Fan (OSS) wrote: From: Peng Fan Add install target for vsock to make Yocto easy to install the images. Signed-off-by: Peng Fan --- LGTM! This is a net-next material, so next time better to specify it (e.g. [PATCH net-next]). If not queued

Re: [PATCH] test/vsock: add install target

2024-07-10 Thread Stefano Garzarella
On Wed, Jul 10, 2024 at 11:34:05AM GMT, Peng Fan wrote: Subject: Re: [PATCH] test/vsock: add install target On Wed, Jul 10, 2024 at 08:11:32AM GMT, Peng Fan wrote: >> Subject: Re: [PATCH] test/vsock: add install target >> >> On Tue, Jul 09, 2024 at 09:50:51PM GMT, Peng Fan (OS

Re: [PATCH v4] perf,x86: avoid missing caller address in stack traces captured in uprobe

2024-07-10 Thread Peter Zijlstra
On Tue, Jul 09, 2024 at 10:50:00AM -0700, Andrii Nakryiko wrote: > On Tue, Jul 9, 2024 at 3:11 AM Peter Zijlstra wrote: > > > > On Mon, Jul 08, 2024 at 04:11:27PM -0700, Andrii Nakryiko wrote: > > > +#ifdef CONFIG_UPROBES > > > +/* > > > + * Heuristic-based check if uprobe is installed at the

Re: [PATCH 1/2] virtio_balloon: add work around for out of spec QEMU

2024-07-10 Thread Michael S. Tsirkin
On Wed, Jul 10, 2024 at 03:37:49PM +0800, Jason Wang wrote: > On Wed, Jul 10, 2024 at 2:16 PM Michael S. Tsirkin wrote: > > > > On Wed, Jul 10, 2024 at 11:23:20AM +0800, Jason Wang wrote: > > > On Fri, Jul 5, 2024 at 6:09 PM Michael S. Tsirkin wrote: > > > > > > > > QEMU implemented the

RE: [PATCH] test/vsock: add install target

2024-07-10 Thread Peng Fan
> Subject: Re: [PATCH] test/vsock: add install target > > On Wed, Jul 10, 2024 at 08:11:32AM GMT, Peng Fan wrote: > >> Subject: Re: [PATCH] test/vsock: add install target > >> > >> On Tue, Jul 09, 2024 at 09:50:51PM GMT, Peng Fan (OSS) wrote: > >> >

RE: [EXTERNAL] [PATCH net-next v10 04/15] mm: page_frag: add '_va' suffix to page_frag API

2024-07-10 Thread Subbaraya Sundeep Bhatta
From: Yunsheng Lin Sent: Tuesday, July 9, 2024 6:57 PM To: da...@davemloft.net; k...@kernel.org; pab...@redhat.com Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; Yunsheng Lin ; Alexander Duyck ; Jeroen de Borst ; Praveen Kaligineedi ; Shailend Chand ; Eric Dumazet ; Tony Nguyen

Re: [PATCH v3 0/2] vdpa: support set mac address from vdpa tool

2024-07-10 Thread Cindy Lu
On Wed, 10 Jul 2024 at 14:10, Michael S. Tsirkin wrote: > > On Wed, Jul 10, 2024 at 11:05:48AM +0800, Jason Wang wrote: > > On Tue, Jul 9, 2024 at 8:42 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Jul 09, 2024 at 02:19:19PM +0800, Cindy Lu wrote: > > > > On Tue, 9 Jul 2024 at 11:59, Parav

Re: [PATCH v2 2/4] x86/mce, EDAC/mce_amd: Add support for new MCA_SYND{1,2} registers

2024-07-10 Thread Borislav Petkov
On Tue, Jul 09, 2024 at 01:27:25AM -0500, Naik, Avadhut wrote: > IIUC, its an abbreviation of a Latin word and is used as a synonym for > "namely" > or "that is to say". > Might not be the best choice in this case. Will change it. I learn new stuff every day: https://en.wikipedia.org/wiki/Viz.

Re: [PATCH] test/vsock: add install target

2024-07-10 Thread Stefano Garzarella
On Wed, Jul 10, 2024 at 08:11:32AM GMT, Peng Fan wrote: Subject: Re: [PATCH] test/vsock: add install target On Tue, Jul 09, 2024 at 09:50:51PM GMT, Peng Fan (OSS) wrote: >From: Peng Fan > >Add install target for vsock to make Yocto easy to install the images. > >Signed-o

Re: [PATCH v2] filemap: add trace events for get_pages, map_pages, and fault

2024-07-10 Thread Takaya Saeki
Hello Matthew, I'd appreciate it if you could comment on this. Thank you.

RE: [PATCH] test/vsock: add install target

2024-07-10 Thread Peng Fan
> Subject: Re: [PATCH] test/vsock: add install target > > On Tue, Jul 09, 2024 at 09:50:51PM GMT, Peng Fan (OSS) wrote: > >From: Peng Fan > > > >Add install target for vsock to make Yocto easy to install the images. > > > >Signed-off-by: Peng Fan >

Re: [PATCH 1/2] virtio_balloon: add work around for out of spec QEMU

2024-07-10 Thread Jason Wang
On Wed, Jul 10, 2024 at 2:16 PM Michael S. Tsirkin wrote: > > On Wed, Jul 10, 2024 at 11:23:20AM +0800, Jason Wang wrote: > > On Fri, Jul 5, 2024 at 6:09 PM Michael S. Tsirkin wrote: > > > > > > QEMU implemented the configuration > > > VIRTIO_BALLOON_F_REPORTING && !

Re: [PATCH] vdpa_sim_blk: add `capacity` module parameter

2024-07-10 Thread Stefano Garzarella
On Wed, Jul 10, 2024 at 03:28:31PM GMT, Jason Wang wrote: On Wed, Jul 10, 2024 at 3:19 PM Stefano Garzarella wrote: On Wed, Jul 10, 2024 at 11:08:48AM GMT, Jason Wang wrote: >On Tue, Jul 9, 2024 at 8:41 PM Stefano Garzarella wrote: >> >> On Tue, Jul 09, 2024 at 10:56:16AM GMT, Jason Wang

Re: [PATCH] test/vsock: add install target

2024-07-10 Thread Stefano Garzarella
On Tue, Jul 09, 2024 at 09:50:51PM GMT, Peng Fan (OSS) wrote: From: Peng Fan Add install target for vsock to make Yocto easy to install the images. Signed-off-by: Peng Fan --- tools/testing/vsock/Makefile | 12 1 file changed, 12 insertions(+) diff --git

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-07-10 Thread Petr Pavlu
On 6/17/24 19:58, Sami Tolvanen wrote: > Hi folks, > > This series implements CONFIG_MODVERSIONS for Rust, an important > feature for distributions like Android that want to ship Rust > kernel modules, and depend on modversions to help ensure module ABI > compatibility. Thanks for working on

Re: [PATCH] vdpa_sim_blk: add `capacity` module parameter

2024-07-10 Thread Jason Wang
On Wed, Jul 10, 2024 at 3:19 PM Stefano Garzarella wrote: > > On Wed, Jul 10, 2024 at 11:08:48AM GMT, Jason Wang wrote: > >On Tue, Jul 9, 2024 at 8:41 PM Stefano Garzarella > >wrote: > >> > >> On Tue, Jul 09, 2024 at 10:56:16AM GMT, Jason Wang wrote: > >> >On Mon, Jul 8, 2024 at 4:15 PM Stefano

Re: [PATCH] vdpa_sim_blk: add `capacity` module parameter

2024-07-10 Thread Stefano Garzarella
On Wed, Jul 10, 2024 at 11:08:48AM GMT, Jason Wang wrote: On Tue, Jul 9, 2024 at 8:41 PM Stefano Garzarella wrote: On Tue, Jul 09, 2024 at 10:56:16AM GMT, Jason Wang wrote: >On Mon, Jul 8, 2024 at 4:15 PM Stefano Garzarella wrote: >> >> Hi Cindy, Jason, >> >> On Mon, Jul 08, 2024 at

Re: [PATCH 1/2] virtio_balloon: add work around for out of spec QEMU

2024-07-10 Thread Michael S. Tsirkin
On Wed, Jul 10, 2024 at 11:23:20AM +0800, Jason Wang wrote: > On Fri, Jul 5, 2024 at 6:09 PM Michael S. Tsirkin wrote: > > > > QEMU implemented the configuration > > VIRTIO_BALLOON_F_REPORTING && ! VIRTIO_BALLOON_F_FREE_PAGE_HINT > > incorrectly: it then uses vq3 for reporting, spec says

Re: [PATCH v3 0/2] vdpa: support set mac address from vdpa tool

2024-07-10 Thread Michael S. Tsirkin
On Wed, Jul 10, 2024 at 11:05:48AM +0800, Jason Wang wrote: > On Tue, Jul 9, 2024 at 8:42 PM Michael S. Tsirkin wrote: > > > > On Tue, Jul 09, 2024 at 02:19:19PM +0800, Cindy Lu wrote: > > > On Tue, 9 Jul 2024 at 11:59, Parav Pandit wrote: > > > > > > > > Hi Cindy, > > > > > > > > > From: Cindy

RE: [PATCH v3 0/2] vdpa: support set mac address from vdpa tool

2024-07-09 Thread Parav Pandit
Hi Cindy, > From: Jason Wang > Sent: Wednesday, July 10, 2024 8:36 AM > > On Tue, Jul 9, 2024 at 8:42 PM Michael S. Tsirkin wrote: > > > > On Tue, Jul 09, 2024 at 02:19:19PM +0800, Cindy Lu wrote: > > > On Tue, 9 Jul 2024 at 11:59, Parav Pandit wrote: > > > > > > > > Hi Cindy, > > > > > > > >

Re: [PATCH 2/2] virtio: fix vq # when vq skipped

2024-07-09 Thread Jason Wang
On Fri, Jul 5, 2024 at 6:09 PM Michael S. Tsirkin wrote: > > virtio balloon communicates to the core that in some > configurations vq #s are non-contiguous by setting name > pointer to NULL. > > Unfortunately, core then turned around and just made them > contiguous again. Result is that driver is

Re: [PATCH 1/2] virtio_balloon: add work around for out of spec QEMU

2024-07-09 Thread Jason Wang
On Fri, Jul 5, 2024 at 6:09 PM Michael S. Tsirkin wrote: > > QEMU implemented the configuration > VIRTIO_BALLOON_F_REPORTING && ! VIRTIO_BALLOON_F_FREE_PAGE_HINT > incorrectly: it then uses vq3 for reporting, spec says it is always 4. > > This is masked by a corresponding bug in driver: >

Re: [PATCH 2/2] virtio: fix vq # when vq skipped

2024-07-09 Thread David Hildenbrand
On 05.07.24 12:09, Michael S. Tsirkin wrote: virtio balloon communicates to the core that in some configurations vq #s are non-contiguous by setting name pointer to NULL. Unfortunately, core then turned around and just made them contiguous again. Result is that driver is out of spec. Implement

Re: [PATCH 1/2] virtio_balloon: add work around for out of spec QEMU

2024-07-09 Thread David Hildenbrand
On 05.07.24 12:08, Michael S. Tsirkin wrote: QEMU implemented the configuration VIRTIO_BALLOON_F_REPORTING && ! VIRTIO_BALLOON_F_FREE_PAGE_HINT incorrectly: it then uses vq3 for reporting, spec says it is always 4. This is masked by a corresponding bug in driver: add a work around as

Re: [PATCH] vdpa_sim_blk: add `capacity` module parameter

2024-07-09 Thread Jason Wang
On Tue, Jul 9, 2024 at 8:41 PM Stefano Garzarella wrote: > > On Tue, Jul 09, 2024 at 10:56:16AM GMT, Jason Wang wrote: > >On Mon, Jul 8, 2024 at 4:15 PM Stefano Garzarella > >wrote: > >> > >> Hi Cindy, Jason, > >> > >> On Mon, Jul 08, 2024 at 03:59:34PM GMT, Jason Wang wrote: > >> >On Mon, Jul

Re: [PATCH v3 0/2] vdpa: support set mac address from vdpa tool

2024-07-09 Thread Jason Wang
On Tue, Jul 9, 2024 at 8:42 PM Michael S. Tsirkin wrote: > > On Tue, Jul 09, 2024 at 02:19:19PM +0800, Cindy Lu wrote: > > On Tue, 9 Jul 2024 at 11:59, Parav Pandit wrote: > > > > > > Hi Cindy, > > > > > > > From: Cindy Lu > > > > Sent: Monday, July 8, 2024 12:17 PM > > > > > > > > Add support

Re: [PATCH net-next v3 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-07-09 Thread Jason Wang
sing a stacked device. I'm not we had others but the commit log is probably too small to say all of it. > > > > Cc: Venkat Venkatsubra > > Cc: Gia-Khanh Nguyen > > Signed-off-by: Jason Wang > > Yes but this just forces lots of re-reads of config on each > open/close for

Re: [PATCH for-next v4] tracing/kprobes: Add symbol counting check when module loads

2024-07-09 Thread Google
sy - this should have gone. */ > __unregister_trace_kprobe(tk); > - ret = __register_trace_kprobe(tk); > + ret = register_module_trace_kprobe(mod, tk); > if (ret) > pr_warn("Fail

Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management

2024-07-09 Thread Andrii Nakryiko
On Tue, Jul 9, 2024 at 2:33 PM Oleg Nesterov wrote: > > On 07/09, Andrii Nakryiko wrote: > > > > On Tue, Jul 9, 2024 at 11:49 AM Oleg Nesterov wrote: > > > > > > > Yep, that would be unfortunate (just like SIGILL sent when uretprobe > > > > detects "improper" stack pointer progression, for

Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management

2024-07-09 Thread Oleg Nesterov
On 07/09, Andrii Nakryiko wrote: > > On Tue, Jul 9, 2024 at 11:49 AM Oleg Nesterov wrote: > > > > > Yep, that would be unfortunate (just like SIGILL sent when uretprobe > > > detects "improper" stack pointer progression, for example), > > > > In this case we a) assume that user-space tries to

Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management

2024-07-09 Thread Andrii Nakryiko
On Tue, Jul 9, 2024 at 11:49 AM Oleg Nesterov wrote: > > On 07/08, Andrii Nakryiko wrote: > > > > On Sun, Jul 7, 2024 at 7:48 AM Oleg Nesterov wrote: > > > > > > And I forgot to mention... > > > > > > In any case __uprobe_unregister() can't ignore the error code from > > >

Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management

2024-07-09 Thread Oleg Nesterov
On 07/08, Andrii Nakryiko wrote: > > On Sun, Jul 7, 2024 at 7:48 AM Oleg Nesterov wrote: > > > > And I forgot to mention... > > > > In any case __uprobe_unregister() can't ignore the error code from > > register_for_each_vma(). If it fails to restore the original insn, > > we should not remove

Re: [PATCH v4] perf,x86: avoid missing caller address in stack traces captured in uprobe

2024-07-09 Thread Andrii Nakryiko
On Tue, Jul 9, 2024 at 3:11 AM Peter Zijlstra wrote: > > On Mon, Jul 08, 2024 at 04:11:27PM -0700, Andrii Nakryiko wrote: > > +#ifdef CONFIG_UPROBES > > +/* > > + * Heuristic-based check if uprobe is installed at the function entry. > > + * > > + * Under assumption of user code being compiled

Re: [PATCH] kallsyms, livepatch: Fix livepatch with CONFIG_LTO_CLANG

2024-07-09 Thread Matthew Maurer
On Mon, Jul 8, 2024 at 5:07 PM Sami Tolvanen wrote: > > On Mon, Jul 8, 2024 at 2:33 PM Luis Chamberlain wrote: > > > > Looking at this again its not to me why Masahiro Yamada's suggestion on > > that old patch series to just increase the length and put long symbols > > names into its own section

Re: [PATCH] kallsyms, livepatch: Fix livepatch with CONFIG_LTO_CLANG

2024-07-09 Thread Song Liu
> On Jul 9, 2024, at 8:07 AM, Sami Tolvanen wrote: [...] > >>> I am a bit scared because using hashed symbol names in backtraces, gdb, >>> ... would be a nightmare. Hashes are not human readable and >>> they would complicate the life a lot. And using different names >>> in different

Re: [PATCH v4] perf,x86: avoid missing caller address in stack traces captured in uprobe

2024-07-09 Thread Peter Zijlstra
On Tue, Jul 09, 2024 at 11:10:17PM +0900, Masami Hiramatsu wrote: > On Tue, 9 Jul 2024 12:11:33 +0200 > Peter Zijlstra wrote: > > > On Mon, Jul 08, 2024 at 04:11:27PM -0700, Andrii Nakryiko wrote: > > > +#ifdef CONFIG_UPROBES > > > +/* > > > + * Heuristic-based check if uprobe is installed at

Re: [PATCH v4] perf,x86: avoid missing caller address in stack traces captured in uprobe

2024-07-09 Thread Google
On Tue, 9 Jul 2024 12:11:33 +0200 Peter Zijlstra wrote: > On Mon, Jul 08, 2024 at 04:11:27PM -0700, Andrii Nakryiko wrote: > > +#ifdef CONFIG_UPROBES > > +/* > > + * Heuristic-based check if uprobe is installed at the function entry. > > + * > > + * Under assumption of user code being compiled

Re: [PATCH net-next v3 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-07-09 Thread Michael S. Tsirkin
is confusing. It seems to say that the issue fixed is synchronizing state with hardware config change. But your example does not show any hardware change. Isn't this example really just a side effect of setting carrier off on close? > Cc: Venkat Venkatsubra > Cc: Gia-Khanh Nguyen > Si

Re: [PATCH v3 0/2] vdpa: support set mac address from vdpa tool

2024-07-09 Thread Michael S. Tsirkin
On Tue, Jul 09, 2024 at 02:19:19PM +0800, Cindy Lu wrote: > On Tue, 9 Jul 2024 at 11:59, Parav Pandit wrote: > > > > Hi Cindy, > > > > > From: Cindy Lu > > > Sent: Monday, July 8, 2024 12:17 PM > > > > > > Add support for setting the MAC address using the VDPA tool. > > > This feature will allow

Re: [PATCH] vdpa_sim_blk: add `capacity` module parameter

2024-07-09 Thread Stefano Garzarella
On Tue, Jul 09, 2024 at 10:56:16AM GMT, Jason Wang wrote: On Mon, Jul 8, 2024 at 4:15 PM Stefano Garzarella wrote: Hi Cindy, Jason, On Mon, Jul 08, 2024 at 03:59:34PM GMT, Jason Wang wrote: >On Mon, Jul 8, 2024 at 3:06 PM Cindy Lu wrote: >> >> On Fri, 5 Jul 2024 at 20:42, Stefano Garzarella

Re: [PATCH v4] perf,x86: avoid missing caller address in stack traces captured in uprobe

2024-07-09 Thread Peter Zijlstra
On Mon, Jul 08, 2024 at 04:11:27PM -0700, Andrii Nakryiko wrote: > +#ifdef CONFIG_UPROBES > +/* > + * Heuristic-based check if uprobe is installed at the function entry. > + * > + * Under assumption of user code being compiled with frame pointers, > + * `push %rbp/%ebp` is a good indicator that we

Re: [PATCH] rust: add `module_params` macro

2024-07-09 Thread Miguel Ojeda
On Mon, Jul 8, 2024 at 11:42 PM Luis Chamberlain wrote: > > The rationale here is that a rust binding means commitment then also > from fresh blood to help co-maintain review C / Rust for exising code > when there is will / desire to collaborate from an existing C maintainer. > > I realize this

Re: [PATCH v4 3/5] arm64: dts: qcom: sdx75: update reserved memory regions for mpss

2024-07-09 Thread Konrad Dybcio
On 9.07.2024 8:49 AM, Naina Mehta wrote: > Rename qdss@8880 memory region as qlink_logging memory region > and add qdss_mem memory region at address of 0x8850, > qlink_logging is being added at the memory region at the address > of 0x8880 as the region is being used by modem firmware.

Re: [PATCH] rust: add `module_params` macro

2024-07-09 Thread nmi
Hi Greg, On Tuesday, 9 July 2024 at 10:27, Greg KH wrote: > On Tue, Jul 09, 2024 at 06:00:46AM +, nmi wrote: > > > Hi Luis, > > > > On Monday, July 8th, 2024 at 23:42, Luis Chamberlain mcg...@kernel.org > > wrote: > > > > > I'm starting to feel the same way about modules, but

Re: [PATCH v8 2/5] remoteproc: Add TEE support

2024-07-09 Thread Arnaud POULIQUEN
On 7/8/24 17:43, Mathieu Poirier wrote: > On Fri, Jul 05, 2024 at 09:33:55AM +0200, Arnaud POULIQUEN wrote: >> >> >> On 7/4/24 17:32, Mathieu Poirier wrote: >>> On Thu, Jul 04, 2024 at 10:05:24AM +0200, Arnaud POULIQUEN wrote: On 7/3/24 17:14, Mathieu Poirier wrote: > On Wed,

Re: [PATCH] rust: add `module_params` macro

2024-07-09 Thread Greg KH
On Tue, Jul 09, 2024 at 06:00:46AM +, nmi wrote: > Hi Luis, > > On Monday, July 8th, 2024 at 23:42, Luis Chamberlain > wrote: > > > I'm starting to feel the same way about modules, but modules requires > > more work than the firmware loader. And since I also know Andreas has > > already a

Re: [PATCH net-next v3 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-07-09 Thread Xuan Zhuo
v); > + } else { > + vi->status = VIRTIO_NET_S_LINK_UP; > + virtnet_update_settings(vi); > + netif_carrier_on(dev); > + } > + > return 0; > > err_enable_qp: > @@ -2936,12 +2967,19 @@ static int virtnet_close(struct n

Re: [PATCH net-next v3 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-07-09 Thread Xuan Zhuo
lse { > + vi->status = VIRTIO_NET_S_LINK_UP; > + virtnet_update_settings(vi); > + netif_carrier_on(dev); > + } > + > return 0; > > err_enable_qp: > @@ -2936,12 +2967,19 @@ static int virtnet_close(struct net_device *dev) >

Re: [PATCH net-next v3 2/3] virtio: allow driver to disable the configure change notification

2024-07-09 Thread Xuan Zhuo
On Tue, 9 Jul 2024 16:02:13 +0800, Jason Wang wrote: > Sometime, it would be useful to disable the configure change > notification from the driver. So this patch allows this by introducing > a variable config_change_driver_disabled and only allow the configure > change notification callback to

Re: [PATCH net-next v3 2/3] virtio: allow driver to disable the configure change notification

2024-07-09 Thread Xuan Zhuo
On Tue, 9 Jul 2024 16:02:13 +0800, Jason Wang wrote: > Sometime, it would be useful to disable the configure change > notification from the driver. So this patch allows this by introducing > a variable config_change_driver_disabled and only allow the configure > change notification callback to

Re: [PATCH net-next v3 1/3] virtio: rename virtio_config_enabled to virtio_config_core_enabled

2024-07-09 Thread Xuan Zhuo
On Tue, 9 Jul 2024 16:02:12 +0800, Jason Wang wrote: > Following patch will allow the config interrupt to be disabled by a > specific driver via another boolean. So this patch renames > virtio_config_enabled and relevant helpers to > virtio_config_core_enabled. > > Cc: Venkat Venkatsubra > Cc:

Re: [PATCH -fixes] riscv: patch: Flush the icache right after patching to avoid illegal insns

2024-07-09 Thread Geert Uytterhoeven
Hi Alexandre, On Mon, Jun 24, 2024 at 10:23 AM Alexandre Ghiti wrote: > We cannot delay the icache flush after patching some functions as we may > have patched a function that will get called before the icache flush. > > The only way to completely avoid such scenario is by flushing the icache >

Re: [PATCH] vdpa/mlx5: Add the support of set mac address

2024-07-09 Thread Cindy Lu
On Mon, 8 Jul 2024 at 15:27, Dragos Tatulea wrote: > > On Mon, 2024-07-08 at 14:55 +0800, Cindy Lu wrote: > > Add the function to support setting the MAC address. > > For vdpa/mlx5, the function will use mlx5_mpfs_add_mac > > to set the mac address > > > > Tested in ConnectX-6 Dx device > > > >

Re: [PATCH] vdpa/mlx5: Add the support of set mac address

2024-07-09 Thread Cindy Lu
On Tue, 9 Jul 2024 at 12:56, Ratheesh Kannoth wrote: > > On 2024-07-08 at 12:25:49, Cindy Lu (l...@redhat.com) wrote: > > +static int mlx5_vdpa_set_attr_mac(struct vdpa_mgmt_dev *v_mdev, > > + struct vdpa_device *dev, > > + const struct

Re: [PATCH] vdpa/mlx5: Add the support of set mac address

2024-07-09 Thread Cindy Lu
On Mon, 8 Jul 2024 at 19:26, Michael S. Tsirkin wrote: > > On Mon, Jul 08, 2024 at 02:55:49PM +0800, Cindy Lu wrote: > > Add the function to support setting the MAC address. > > For vdpa/mlx5, the function will use mlx5_mpfs_add_mac > > to set the mac address > > > > Tested in ConnectX-6 Dx

Re: [PATCH] vdpa/mlx5: Add the support of set mac address

2024-07-09 Thread Cindy Lu
On Mon, 8 Jul 2024 at 15:03, Jason Wang wrote: > > On Mon, Jul 8, 2024 at 2:56 PM Cindy Lu wrote: > > > > Add the function to support setting the MAC address. > > For vdpa/mlx5, the function will use mlx5_mpfs_add_mac > > to set the mac address > > > > Tested in ConnectX-6 Dx device > > Great. >

Re: [PATCH v3] init: staging: Fix missing warning/taint on builtin code

2024-07-09 Thread Uwe Kleine-König
Hello, On Sat, Jul 06, 2024 at 12:15:01AM -0300, Ágatha Isabelle Chris Moreira Guedes wrote: > Fix the absence of warning message and kernel tainting when initializing > drivers from the `drivers/staging` subtree from initcalls (when > configured as built-in). > > When such a driver is built as

Re: [PATCH 4/6] pwm: Add tracing for waveform callbacks

2024-07-09 Thread Uwe Kleine-König
On Mon, Jul 08, 2024 at 02:14:09PM -0400, Trevor Gamblin wrote: > Missing a sign-off? Yes, and a commit log. Thanks for your review! Best regards Uwe signature.asc Description: PGP signature

Re: [PATCH v2 4/4] EDAC/mce_amd: Add support for FRU Text in MCA

2024-07-09 Thread Naik, Avadhut
On 6/26/2024 13:20, Borislav Petkov wrote: > On Wed, Jun 26, 2024 at 01:00:30PM -0500, Naik, Avadhut wrote: >>> >>> Why are you clearing it if you're overwriting it immediately? >>> >> Since its a local variable, wanted to ensure that the memory is zeroed out >> to prevent >> any issues with

Re: [PATCH v2 2/4] x86/mce, EDAC/mce_amd: Add support for new MCA_SYND{1,2} registers

2024-07-09 Thread Naik, Avadhut
On 6/26/2024 13:18, Borislav Petkov wrote: > On Wed, Jun 26, 2024 at 12:24:20PM -0500, Naik, Avadhut wrote: >> >> >> On 6/26/2024 06:10, Borislav Petkov wrote: >>> On Tue, Jun 25, 2024 at 02:56:22PM -0500, Avadhut Naik wrote: AMD's Scalable MCA systems viz. Genoa will include two new

Re: [PATCH v3 0/2] vdpa: support set mac address from vdpa tool

2024-07-09 Thread Cindy Lu
On Tue, 9 Jul 2024 at 11:59, Parav Pandit wrote: > > Hi Cindy, > > > From: Cindy Lu > > Sent: Monday, July 8, 2024 12:17 PM > > > > Add support for setting the MAC address using the VDPA tool. > > This feature will allow setting the MAC address using the VDPA tool. > > For example, in

  1   2   3   4   5   6   7   8   9   10   >