Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-25 Thread Alexey Zaytsev
On Mon, Feb 25, 2008 at 3:25 PM, Pekka J Enberg <[EMAIL PROTECTED]> wrote: > On Mon, 25 Feb 2008, Michael Buesch wrote: > > > Neither of which seem like acceptable solutions for a 2.6.23 -> 2.6.24 > > > _regression_. Or maybe I am just too naive to believe Linus' statement > > > on not letting t

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-25 Thread Pekka J Enberg
On Mon, 25 Feb 2008, Michael Buesch wrote: > > Neither of which seem like acceptable solutions for a 2.6.23 -> 2.6.24 > > _regression_. Or maybe I am just too naive to believe Linus' statement > > on not letting the kernel regress... > > So, please sign-off the patch that we have, if you think it'

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-25 Thread Michael Buesch
On Monday 25 February 2008 13:11:04 Pekka Enberg wrote: > On Mon, Feb 25, 2008 at 11:54 AM, Michael Buesch <[EMAIL PROTECTED]> wrote: > > > Isn't the resolution Michael is suggesting is, "use the different > > driver"? > > > > I have two resolutions. One being: > > rmmod b44 > > rmmod ssb > >

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-25 Thread Pekka Enberg
On Mon, Feb 25, 2008 at 11:54 AM, Michael Buesch <[EMAIL PROTECTED]> wrote: > > Isn't the resolution Michael is suggesting is, "use the different driver"? > > I have two resolutions. One being: > rmmod b44 > rmmod ssb > modprobe bcm43xx > modprobe b44 > > The other being: Wait for 2.6.25 and

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-25 Thread Michael Buesch
On Monday 25 February 2008 11:49:34 Xavier Bestel wrote: > On Mon, 2008-02-25 at 11:38 +0100, Michael Buesch wrote: > > [1] bcm43xx is unmaintained. Larry used to be the maintainer until > > he dropped it a few months ago. > > Doesn't that mean that Alexey gets to be the maintainer, as he's the o

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-25 Thread Xavier Bestel
On Mon, 2008-02-25 at 11:38 +0100, Michael Buesch wrote: > [1] bcm43xx is unmaintained. Larry used to be the maintainer until > he dropped it a few months ago. Doesn't that mean that Alexey gets to be the maintainer, as he's the one patching it ? Xav -- To unsubscribe from this list: s

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-25 Thread Michael Buesch
On Monday 25 February 2008 11:23:02 Alexey Zaytsev wrote: > On Mon, Feb 25, 2008 at 9:49 AM, Greg KH <[EMAIL PROTECTED]> wrote: > > > > On Mon, Feb 25, 2008 at 08:16:17AM +0200, Pekka J Enberg wrote: > > > Hi Michael, > > > > > > On Sun, 24 Feb 2008, Michael Buesch wrote: > > > > > The ony way

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-25 Thread Alexey Zaytsev
On Mon, Feb 25, 2008 at 9:49 AM, Greg KH <[EMAIL PROTECTED]> wrote: > > On Mon, Feb 25, 2008 at 08:16:17AM +0200, Pekka J Enberg wrote: > > Hi Michael, > > > > On Sun, 24 Feb 2008, Michael Buesch wrote: > > > > The ony way I see this was possible, you manually changed the > > > > module loadin

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-25 Thread Michael Buesch
On Monday 25 February 2008 07:49:35 Greg KH wrote: > On Mon, Feb 25, 2008 at 08:16:17AM +0200, Pekka J Enberg wrote: > > Hi Michael, > > > > On Sun, 24 Feb 2008, Michael Buesch wrote: > > > > The ony way I see this was possible, you manually changed the > > > > module loading order, so that the b4

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-24 Thread Pekka J Enberg
Hi Greg, On Sun, 24 Feb 2008, Greg KH wrote: > > Lets make this simple: it used to work before and now it doesn't. > > Therefore it's a regression that must be addressed. Period. > > Isn't the resolution Michael is suggesting is, "use the different driver"? Alexey said it didn't work but even i

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-24 Thread Greg KH
On Mon, Feb 25, 2008 at 08:16:17AM +0200, Pekka J Enberg wrote: > Hi Michael, > > On Sun, 24 Feb 2008, Michael Buesch wrote: > > > The ony way I see this was possible, you manually changed the > > > module loading order, so that the b43xx module was loaded prior > > > to the ssb and b44 modules. R

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-24 Thread Pekka J Enberg
Hi Michael, On Sun, 24 Feb 2008, Michael Buesch wrote: > > The ony way I see this was possible, you manually changed the > > module loading order, so that the b43xx module was loaded prior > > to the ssb and b44 modules. Right? > > Right. So "so I'm left with either no wifi or no ethenet" being w

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-24 Thread Michael Buesch
On Sunday 24 February 2008, Alexey Zaytsev wrote: > On Sun, Feb 24, 2008 at 5:29 PM, Michael Buesch <[EMAIL PROTECTED]> wrote: > > On Saturday 23 February 2008 12:32:50 Alexey Zaytsev wrote: > > > The problem is not with enabling both b43 and bcm43xx (will, whis won't > > work > > > anyway, and

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-24 Thread Alexey Zaytsev
On Sun, Feb 24, 2008 at 5:29 PM, Michael Buesch <[EMAIL PROTECTED]> wrote: > On Saturday 23 February 2008 12:32:50 Alexey Zaytsev wrote: > > The problem is not with enabling both b43 and bcm43xx (will, whis won't > work > > anyway, and there is no chance fixing it). The problem is with enabling

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-24 Thread Michael Buesch
On Saturday 23 February 2008 12:32:50 Alexey Zaytsev wrote: > The problem is not with enabling both b43 and bcm43xx (will, whis won't work > anyway, and there is no chance fixing it). The problem is with enabling the > bcm43xx wifi driver and the b44 Ethernet driver. The ethernet driver then > wron

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-23 Thread Michael Buesch
On Saturday 23 February 2008 22:32:46 Alexey Zaytsev wrote: > > The insults being? A few quotes, please. > If you really want to know, the > "Because the new driver works, if you just set it up right." > for me was clearly a hint that I'm just an other imcompetent > user, who can't even follow the

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-23 Thread Alexey Zaytsev
On Sat, Feb 23, 2008 at 7:27 PM, Michael Buesch <[EMAIL PROTECTED]> wrote: > On Saturday 23 February 2008 12:07:51 Ingo Molnar wrote: > > > I have to say, after having observed multiple incidents around b43 in > > the past few months you are one of the worst driver maintainers i've > > ever seen

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-23 Thread Michael Buesch
On Saturday 23 February 2008 17:44:33 Ingo Molnar wrote: > > * Michael Buesch <[EMAIL PROTECTED]> wrote: > > > On Saturday 23 February 2008 12:07:51 Ingo Molnar wrote: > > > I have to say, after having observed multiple incidents around b43 in > > > the past few months you are one of the worst d

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-23 Thread Ingo Molnar
* Michael Buesch <[EMAIL PROTECTED]> wrote: > On Saturday 23 February 2008 12:07:51 Ingo Molnar wrote: > > I have to say, after having observed multiple incidents around b43 in > > the past few months you are one of the worst driver maintainers i've > > ever seen on lkml: you are ignoring regre

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-23 Thread Michael Buesch
On Saturday 23 February 2008 12:07:51 Ingo Molnar wrote: > I have to say, after having observed multiple incidents around b43 in > the past few months you are one of the worst driver maintainers i've > ever seen on lkml: you are ignoring regressions, you are frequently > insulting our testers an

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-23 Thread Michael Buesch
On Saturday 23 February 2008 12:07:51 Ingo Molnar wrote: > > * Michael Buesch <[EMAIL PROTECTED]> wrote: > > > > If this is not a repgession, than I don't know what is. And if it is > > > a regression, it should be fixed at least in the 2.6.24.y series, do > > > you agree? > > > > No. Playing

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-23 Thread Pekka Enberg
Hi, On Sat, Feb 23, 2008 at 2:37 PM, Pekka Enberg <[EMAIL PROTECTED]> wrote: > > > > So does reverting commit 753f492093da7a40141bfe083073400f518f4c68 > > > > ("[B44]: port to native ssb support") fix the regression? On Sat, Feb 23, 2008 at 2:17 PM, Alexey Zaytsev <[EMAIL PROTECTED]> wrote: >

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-23 Thread Alexey Zaytsev
On Sat, Feb 23, 2008 at 2:57 PM, Pekka J Enberg <[EMAIL PROTECTED]> wrote: > Hi Alexey, > > > On Sat, Feb 23, 2008 at 2:37 PM, Pekka Enberg <[EMAIL PROTECTED]> wrote: > > > > So does reverting commit 753f492093da7a40141bfe083073400f518f4c68 > > > ("[B44]: port to native ssb support") fix the re

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-23 Thread Pekka J Enberg
Hi Alexey, On Sat, Feb 23, 2008 at 2:37 PM, Pekka Enberg <[EMAIL PROTECTED]> wrote: > > So does reverting commit 753f492093da7a40141bfe083073400f518f4c68 > > ("[B44]: port to native ssb support") fix the regression? > > On Sat, 23 Feb 2008, Alexey Zaytsev wrote: > Compiling it right now. > >

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-23 Thread Alexey Zaytsev
On Sat, Feb 23, 2008 at 2:37 PM, Pekka Enberg <[EMAIL PROTECTED]> wrote: > On Sat, Feb 23, 2008 at 1:32 PM, Alexey Zaytsev > <[EMAIL PROTECTED]> wrote: > > The problem is not with enabling both b43 and bcm43xx (will, whis won't > work > > anyway, and there is no chance fixing it). The problem

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-23 Thread Pekka Enberg
On Sat, Feb 23, 2008 at 1:32 PM, Alexey Zaytsev <[EMAIL PROTECTED]> wrote: > The problem is not with enabling both b43 and bcm43xx (will, whis won't work > anyway, and there is no chance fixing it). The problem is with enabling the > bcm43xx wifi driver and the b44 Ethernet driver. The ethernet

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-23 Thread Alexey Zaytsev
On Sat, Feb 23, 2008 at 2:24 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Pekka Enberg <[EMAIL PROTECTED]> wrote: > > > Agreed. Alexey, did you identify a specific git commit that caused the > > regression? Can we just revert that from 2.6.24? Michael, even if > > _you're_ planning to remov

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-23 Thread Ingo Molnar
* Pekka Enberg <[EMAIL PROTECTED]> wrote: > Agreed. Alexey, did you identify a specific git commit that caused the > regression? Can we just revert that from 2.6.24? Michael, even if > _you're_ planning to remove bcm43xx we must not let it regress until > it's gone. btw., if the best answer i

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-23 Thread Pekka Enberg
On Sat, Feb 23, 2008 at 1:07 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > I have to say, after having observed multiple incidents around b43 in > the past few months you are one of the worst driver maintainers i've > ever seen on lkml: you are ignoring regressions, you are frequently > insultin

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-23 Thread Ingo Molnar
* Michael Buesch <[EMAIL PROTECTED]> wrote: > > If this is not a repgession, than I don't know what is. And if it is > > a regression, it should be fixed at least in the 2.6.24.y series, do > > you agree? > > No. Playing with kconfig SELECT is really _nothing_ for a -stable > series. I am _no

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-22 Thread Michael Buesch
On Friday 22 February 2008, Alexey Zaytsev wrote: > Well, it looks like Michael is not the bcm43xx maintaner. I sent the > patch to him, > because it was his code that broke the driver, and I thought it would > be easy for him to review my patch, as it touches his code. See? I'm tired of this "how

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-22 Thread Alexey Zaytsev
On Sat, Feb 23, 2008 at 1:12 AM, Greg KH <[EMAIL PROTECTED]> wrote: > > On Fri, Feb 22, 2008 at 11:38:34PM +0300, Alexey Zaytsev wrote: > > On Fri, Feb 22, 2008 at 11:12 PM, Michael Buesch <[EMAIL PROTECTED]> wrote: > > > On Friday 22 February 2008 21:06:00 Alexey Zaytsev wrote: > > > > > It i

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-22 Thread Greg KH
On Fri, Feb 22, 2008 at 11:38:34PM +0300, Alexey Zaytsev wrote: > On Fri, Feb 22, 2008 at 11:12 PM, Michael Buesch <[EMAIL PROTECTED]> wrote: > > On Friday 22 February 2008 21:06:00 Alexey Zaytsev wrote: > > > > It is not my problem, if you refuse to use b43. > > > > You also still refuse to te

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-22 Thread Greg KH
On Fri, Feb 22, 2008 at 06:56:14PM +0100, Michael Buesch wrote: > On Friday 22 February 2008 18:51:32 Gabriel C wrote: > > > I'm not going to play these kconfig SELECT tricks anymore. > > > > Fix it different then. > > Please do so. > > > Yes it is but that is still not a valid reason to NACK th

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-22 Thread Alexey Zaytsev
On Fri, Feb 22, 2008 at 11:12 PM, Michael Buesch <[EMAIL PROTECTED]> wrote: > On Friday 22 February 2008 21:06:00 Alexey Zaytsev wrote: > > > It is not my problem, if you refuse to use b43. > > > You also still refuse to tell me details about your card and _what_ > > > does not work. I do own

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-22 Thread Michael Buesch
On Friday 22 February 2008 21:06:00 Alexey Zaytsev wrote: > > It is not my problem, if you refuse to use b43. > > You also still refuse to tell me details about your card and _what_ > > does not work. I do own lots of different card and they > > all work fine with b43. There's one exception, th

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-22 Thread Alexey Zaytsev
[replying from my non-work account] On Fri, Feb 22, 2008 at 8:48 PM, Michael Buesch <[EMAIL PROTECTED]> wrote: > On Friday 22 February 2008 19:10:39 Alexey Zaytsev wrote: > > Sorry, I don't get it. You are going to remove the (somehow) > > working driver, while there are known problems with the

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-22 Thread Michael Buesch
On Friday 22 February 2008 18:51:32 Gabriel C wrote: > > I'm not going to play these kconfig SELECT tricks anymore. > > Fix it different then. Please do so. > Yes it is but that is still not a valid reason to NACK that patch , I'm sorry. NACK means I (being the maintainer of the modified code)

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-22 Thread Gabriel C
Michael Buesch wrote: > On Friday 22 February 2008 12:17:15 Alexey Zaytsev wrote: >> Hello. >> >> The bcm43xx driver won't work any more, if the b44 Ethernet >> driver is enabled. This happens because the b44 driver >> needlessly enables the b43_pci_bridge code, which claims >> the same pci ids as

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-22 Thread Michael Buesch
On Friday 22 February 2008 19:10:39 Alexey Zaytsev wrote: > Sorry, I don't get it. You are going to remove the (somehow) > working driver, while there are known problems with the new > one? Why? Because the new driver works, if you just set it up right. Until now every "breakage" was just a usage

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-22 Thread Alexey Zaytsev
Michael Buesch wrote: On Friday 22 February 2008 12:17:15 Alexey Zaytsev wrote: Hello. The bcm43xx driver won't work any more, if the b44 Ethernet driver is enabled. This happens because the b44 driver needlessly enables the b43_pci_bridge code, which claims the same pci ids as the bcm43xx driv

Re: bcm43xx regression in 2.6.24 (with patch)

2008-02-22 Thread Michael Buesch
On Friday 22 February 2008 12:17:15 Alexey Zaytsev wrote: > > Hello. > > The bcm43xx driver won't work any more, if the b44 Ethernet > driver is enabled. This happens because the b44 driver > needlessly enables the b43_pci_bridge code, which claims > the same pci ids as the bcm43xx driver. The b4

bcm43xx regression in 2.6.24 (with patch)

2008-02-22 Thread Alexey Zaytsev
Hello. The bcm43xx driver won't work any more, if the b44 Ethernet driver is enabled. This happens because the b44 driver needlessly enables the b43_pci_bridge code, which claims the same pci ids as the bcm43xx driver. The b43_pci_bridge code is needed for the b43{legacy} drivers, but for the b4