Re: [PATCH v3] media: add virtio-media driver

2025-06-20 Thread Alexandre Courbot
pus and memory, but didn't find a way to setup >> > network without running it as root. The gpu parameter has several >> > options. Not sure what backend works well for media apps like qv4l2, >> > camorama, X11, ... >> >> I'm afraid getting GPU

Re: [PATCH v3] media: add virtio-media driver

2025-06-18 Thread Mauro Carvalho Chehab
200 > >> Mauro Carvalho Chehab escreveu: > >> > >> > Hi Alex, > >> > > >> > Em Tue, 27 May 2025 23:03:39 +0900 > >> > Alexandre Courbot escreveu: > >> > > >> > > > > > Btw, I was looking at: &g

Re: [PATCH v3] media: add virtio-media driver

2025-06-18 Thread Mauro Carvalho Chehab
veu: > > > >> > > > Btw, I was looking at: > >> > > > > >> > > > https://github.com/chromeos/virtio-media > >> > > > > >> > > > (I'm assuming that this is the QEMU counterpart, right?) > >> > >

Re: [PATCH v3] media: add virtio-media driver

2025-06-18 Thread Alexandre Courbot
> Em Tue, 27 May 2025 23:03:39 +0900 >> > Alexandre Courbot escreveu: >> > >> > > > > > Btw, I was looking at: >> > > > > > >> > > > > > https://github.com/chromeos/virtio-media >> > > > > >

Re: [PATCH v3] media: add virtio-media driver

2025-06-18 Thread Alexandre Courbot
Hi Mauro, On Tue Jun 17, 2025 at 5:49 PM JST, Mauro Carvalho Chehab wrote: > Hi Alex, > > Em Tue, 27 May 2025 23:03:39 +0900 > Alexandre Courbot escreveu: > >> > > > Btw, I was looking at: >> > > > >> > > > https://github.co

Re: [PATCH v3] media: add virtio-media driver

2025-06-17 Thread Mauro Carvalho Chehab
t; > > > > > > Btw, I was looking at: > > > > > > > > > > > > https://github.com/chromeos/virtio-media > > > > > > > > > > > > (I'm assuming that this is the QEMU counterpart, right?) > > > > >

Re: [PATCH v3] media: add virtio-media driver

2025-06-17 Thread Mauro Carvalho Chehab
Em Tue, 17 Jun 2025 10:49:38 +0200 Mauro Carvalho Chehab escreveu: > Hi Alex, > > Em Tue, 27 May 2025 23:03:39 +0900 > Alexandre Courbot escreveu: > > > > > > Btw, I was looking at: > > > > > > > > > > https://github.com/

Re: [PATCH v3] media: add virtio-media driver

2025-06-17 Thread Mauro Carvalho Chehab
Hi Alex, Em Tue, 27 May 2025 23:03:39 +0900 Alexandre Courbot escreveu: > > > > Btw, I was looking at: > > > > > > > > https://github.com/chromeos/virtio-media > > > > > > > > (I'm assuming that this is the QEMU counte

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-13 Thread Vladimir Zapolskiy
On 6/13/25 12:33, Vincent Knecht via B4 Relay wrote: From: Vincent Knecht Add bindings for qcom,msm8939-camss in order to support the camera subsystem for MSM8939. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Vincent Knecht Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-13 Thread Bryan O'Donoghue
On 13/06/2025 10:33, Vincent Knecht via B4 Relay wrote: From: Vincent Knecht Add bindings for qcom,msm8939-camss in order to support the camera subsystem for MSM8939. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Vincent Knecht --- .../bindings/media/qcom,msm8939-camss.yaml

[PATCH v5 1/4] media: qcom: camss: vfe: Add VBIF setting support

2025-06-13 Thread Vincent Knecht via B4 Relay
From: Vincent Knecht Some devices need writing values to VFE VBIF registers. Add helper functions to do this. Reviewed-by: Bryan O'Donoghue Signed-off-by: Vincent Knecht --- drivers/media/platform/qcom/camss/Makefile | 1 + drivers/media/platform/qcom/camss/camss-vfe-4-1.c

[PATCH v5 2/4] media: qcom: camss: Add support for MSM8939

2025-06-13 Thread Vincent Knecht via B4 Relay
stripes across sensor and garbage in CSID TPG outputs. Add support for the MSM8939 camera subsystem. Reviewed-by: Bryan O'Donoghue Signed-off-by: Vincent Knecht --- drivers/media/platform/qcom/camss/camss-csiphy.c | 1 + drivers/media/platform/qcom/camss/camss-ispif.c| 8 +- dr

[PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-13 Thread Vincent Knecht via B4 Relay
From: Vincent Knecht Add bindings for qcom,msm8939-camss in order to support the camera subsystem for MSM8939. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Vincent Knecht --- .../bindings/media/qcom,msm8939-camss.yaml | 254 + 1 file changed, 254 insertions

Re: [PATCH v4 2/4] media: qcom: camss: Add support for MSM8939

2025-06-13 Thread Bryan O'Donoghue
black stripes across sensor and garbage in CSID TPG outputs. Add support for the MSM8939 camera subsystem. Reviewed-by: Bryan O'Donoghue Signed-off-by: Vincent Knecht There was a preceding and partially reviewed changeset published on linux-media [1] before v1 of the MSM8939 platform suppor

Re: [PATCH v4 2/4] media: qcom: camss: Add support for MSM8939

2025-06-13 Thread Vincent Knecht
amera subsystem. > > > > > > > > Reviewed-by: Bryan O'Donoghue > > > > Signed-off-by: Vincent Knecht > > > > > > There was a preceding and partially reviewed changeset published on > > > linux-media [1] before

Re: [PATCH v4 2/4] media: qcom: camss: Add support for MSM8939

2025-06-13 Thread Bryan O'Donoghue
: Bryan O'Donoghue Signed-off-by: Vincent Knecht There was a preceding and partially reviewed changeset published on linux-media [1] before v1 of the MSM8939 platform support in CAMSS, due to a merge conflict this platform changeset should be rebased IMHO. [1] https://lore.kernel.or

Re: [PATCH v4 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-09 Thread Vladimir Zapolskiy
order to support the camera subsystem for MSM8939. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Vincent Knecht ---   .../bindings/media/qcom,msm8939-camss.yaml | 254 +   1 file changed, 254 insertions(+) diff --git a/Documentation/devicetree/bindings/media/qcom

Re: [PATCH v4 2/4] media: qcom: camss: Add support for MSM8939

2025-06-07 Thread Vincent Knecht
ts. > > > > Add support for the MSM8939 camera subsystem. > > > > Reviewed-by: Bryan O'Donoghue > > Signed-off-by: Vincent Knecht > > There was a preceding and partially reviewed changeset published on > linux-media [1] before v1 of the MSM8939 platform support

Re: [PATCH v4 2/4] media: qcom: camss: Add support for MSM8939

2025-06-06 Thread Vladimir Zapolskiy
geset published on linux-media [1] before v1 of the MSM8939 platform support in CAMSS, due to a merge conflict this platform changeset should be rebased IMHO. [1] https://lore.kernel.org/all/20250513142353.2572563-4-vladimir.zapols...@linaro.org/ -- Best wishes, Vladimir

Re: [PATCH v4 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-06 Thread Vladimir Zapolskiy
Hello Vincent. On 6/2/25 20:27, Vincent Knecht via B4 Relay wrote: From: Vincent Knecht Add bindings for qcom,msm8939-camss in order to support the camera subsystem for MSM8939. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Vincent Knecht --- .../bindings/media/qcom,msm8939-camss.yaml

[PATCH v4 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-02 Thread Vincent Knecht via B4 Relay
From: Vincent Knecht Add bindings for qcom,msm8939-camss in order to support the camera subsystem for MSM8939. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Vincent Knecht --- .../bindings/media/qcom,msm8939-camss.yaml | 254 + 1 file changed, 254 insertions

[PATCH v4 2/4] media: qcom: camss: Add support for MSM8939

2025-06-02 Thread Vincent Knecht via B4 Relay
stripes across sensor and garbage in CSID TPG outputs. Add support for the MSM8939 camera subsystem. Reviewed-by: Bryan O'Donoghue Signed-off-by: Vincent Knecht --- drivers/media/platform/qcom/camss/camss-csiphy.c | 1 + drivers/media/platform/qcom/camss/camss-ispif.c| 8 +- dr

[PATCH v4 1/4] media: qcom: camss: vfe: Add VBIF setting support

2025-06-02 Thread Vincent Knecht via B4 Relay
From: Vincent Knecht Some devices need writing values to VFE VBIF registers. Add helper functions to do this. Reviewed-by: Bryan O'Donoghue Signed-off-by: Vincent Knecht --- drivers/media/platform/qcom/camss/Makefile | 1 + drivers/media/platform/qcom/camss/camss-vfe-4-1.c

Re: [PATCH v3 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-02 Thread Krzysztof Kozlowski
On Fri, May 30, 2025 at 11:00:06AM GMT, Vincent Knecht wrote: > + interrupt-names: > +items: > + - const: csid0 > + - const: csid1 > + - const: csid2 > + - const: csiphy0 > + - const: csiphy1 > + - const: ispif > + - const: vfe0 > + > + iommus: > +maxIte

Re: [PATCH v3] media: add virtio-media driver

2025-06-01 Thread Ricardo Ribalda
unsigned long userptr, > > > + unsigned long length) > > > +{ > > > + int ret; > > > + int nents; > > Could you initialize nents and sg_list? > > old versions of gcc are a

Re: [PATCH v3] media: add virtio-media driver

2025-06-01 Thread Mauro Carvalho Chehab
unsigned long length) > > +{ > > + int ret; > > + int nents; > Could you initialize nents and sg_list? > old versions of gcc are a bit picky > https://gitlab.freedesktop.org/linux-media/users/ribalda/-/jobs/77042562#L4381 Please don't. In this spe

Re: [PATCH v3 2/4] media: qcom: camss: Add support for MSM8939

2025-05-30 Thread Konrad Dybcio
On 5/30/25 1:49 PM, Bryan O'Donoghue wrote: > On 30/05/2025 10:00, Vincent Knecht via B4 Relay wrote: >> +camss->res->version == CAMSS_8x39 || > > This is not correct - it should be 893x since 8939 and 8936 are ~ the > same SoC - probably 36 is just a binned version of 39. > > Anyway the

Re: [PATCH v3 2/4] media: qcom: camss: Add support for MSM8939

2025-05-30 Thread Bryan O'Donoghue
On 30/05/2025 12:49, Bryan O'Donoghue wrote: On 30/05/2025 10:00, Vincent Knecht via B4 Relay wrote: + camss->res->version == CAMSS_8x39 || This is not correct - it should be 893x since 8939 and 8936 are ~ the same SoC - probably 36 is just a binned version of 39. Anyway the x is the

Re: [PATCH v3 2/4] media: qcom: camss: Add support for MSM8939

2025-05-30 Thread Bryan O'Donoghue
On 30/05/2025 10:00, Vincent Knecht via B4 Relay wrote: > + camss->res->version == CAMSS_8x39 || This is not correct - it should be 893x since 8939 and 8936 are ~ the same SoC - probably 36 is just a binned version of 39. Anyway the x is the least significant digit. Please fix --- bod

Re: [PATCH v3 1/4] media: qcom: camss: vfe: Add VBIF setting support

2025-05-30 Thread Bryan O'Donoghue
On 30/05/2025 10:00, Vincent Knecht via B4 Relay wrote: > From: Vincent Knecht > > Some devices need writing values to VFE VBIF registers. > Add helper functions to do this. > > Signed-off-by: Vincent Knecht > --- > drivers/media/platform/qcom/camss/Makefile

[PATCH v3 1/4] media: qcom: camss: vfe: Add VBIF setting support

2025-05-30 Thread Vincent Knecht via B4 Relay
From: Vincent Knecht Some devices need writing values to VFE VBIF registers. Add helper functions to do this. Signed-off-by: Vincent Knecht --- drivers/media/platform/qcom/camss/Makefile | 1 + drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 12 +++ drivers/media

[PATCH v3 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-05-30 Thread Vincent Knecht via B4 Relay
From: Vincent Knecht Add bindings for qcom,msm8939-camss in order to support the camera subsystem for MSM8939. Signed-off-by: Vincent Knecht --- .../bindings/media/qcom,msm8939-camss.yaml | 253 + 1 file changed, 253 insertions(+) diff --git a/Documentation

[PATCH v3 2/4] media: qcom: camss: Add support for MSM8939

2025-05-30 Thread Vincent Knecht via B4 Relay
stripes across sensor and garbage in CSID TPG outputs. Add support for the MSM8939 camera subsystem. Signed-off-by: Vincent Knecht --- drivers/media/platform/qcom/camss/camss-csiphy.c | 1 + drivers/media/platform/qcom/camss/camss-ispif.c| 8 +- drivers/media/platform/qcom/camss/camss

Re: [PATCH v3] media: add virtio-media driver

2025-05-28 Thread Ricardo Ribalda
Hi Alexandre On Sat, 12 Apr 2025 at 06:08, Alexandre Courbot wrote: > > Add the first version of the virtio-media driver. > > This driver acts roughly as a V4L2 relay between user-space and the > virtio virtual device on the host, so it is relatively simple, yet > unconvention

Re: [PATCH v3] media: add virtio-media driver

2025-05-28 Thread Alexandre Courbot
t wasn't because maintainers were > not Cc'd so that should be all ironed out now. > Alexandre, do you want this in next for now or just drop it? I think it doesn't hurt to give some exposure to this driver, if Mauro is ok with it (and it eventually gets merged through the media tree).

Re: [PATCH v3] media: add virtio-media driver

2025-05-27 Thread Michael S. Tsirkin
On Tue, May 27, 2025 at 04:39:27PM +0200, Mauro Carvalho Chehab wrote: > > It's up to you though. > > I can keep it in next for now, so it gets some coverage by > > tools scanning that tree. > > Sure, feel free to keep it on next if you prefer so. Just > please don't submit it upstream while we do

Re: [PATCH v3] media: add virtio-media driver

2025-05-27 Thread Mauro Carvalho Chehab
; On Mon May 26, 2025 at 9:13 PM JST, Mauro Carvalho Chehab wrote: > > > > > > Hi Michael, > > > > > > > > > > > > Em Sat, 12 Apr 2025 13:08:01 +0900 > > > > > > Alexandre Courbot escreveu: > > > > > &g

Re: [PATCH v3] media: add virtio-media driver

2025-05-27 Thread Mauro Carvalho Chehab
Em Tue, 27 May 2025 10:23:32 -0400 "Michael S. Tsirkin" escreveu: > On Mon, May 26, 2025 at 02:13:16PM +0200, Mauro Carvalho Chehab wrote: > > Hi Michael, > > > > Em Sat, 12 Apr 2025 13:08:01 +0900 > > Alexandre Courbot escreveu: > > > > &

Re: [PATCH v3] media: add virtio-media driver

2025-05-27 Thread Michael S. Tsirkin
On Mon, May 26, 2025 at 02:13:16PM +0200, Mauro Carvalho Chehab wrote: > Hi Michael, > > Em Sat, 12 Apr 2025 13:08:01 +0900 > Alexandre Courbot escreveu: > > > Add the first version of the virtio-media driver. > > > > This driver acts roughly as a V4L2

Re: [PATCH v3] media: add virtio-media driver

2025-05-27 Thread Alexandre Courbot
+0900 > > > "Alexandre Courbot" escreveu: > > > > > > > Hi Mauro, > > > > > > > > On Mon May 26, 2025 at 9:13 PM JST, Mauro Carvalho Chehab wrote: > > > > > Hi Michael, > > > > > > > > &g

Re: [PATCH v3] media: add virtio-media driver

2025-05-27 Thread Mauro Carvalho Chehab
; > > > On Mon May 26, 2025 at 9:13 PM JST, Mauro Carvalho Chehab wrote: > > > > Hi Michael, > > > > > > > > Em Sat, 12 Apr 2025 13:08:01 +0900 > > > > Alexandre Courbot escreveu: > > > > > > > >> Add the first ver

Re: [PATCH v3] media: add virtio-media driver

2025-05-27 Thread Alexandre Courbot
l, > > > > > > Em Sat, 12 Apr 2025 13:08:01 +0900 > > > Alexandre Courbot escreveu: > > > > > >> Add the first version of the virtio-media driver. > > >> > > >> This driver acts roughly as a V4L2 relay between user-space and the >

Re: [PATCH v2 1/4] media: qcom: camss: vfe: Add VBIF setting support

2025-05-27 Thread Bryan O'Donoghue
On 26/05/2025 17:23, Vincent Knecht wrote: Do you mean to just rename to vfe_vbif_write_reg() Yep, its more natural language. --- bod

Re: [PATCH v3] media: add virtio-media driver

2025-05-27 Thread Mauro Carvalho Chehab
Em Tue, 27 May 2025 15:14:50 +0900 "Alexandre Courbot" escreveu: > Hi Mauro, > > On Mon May 26, 2025 at 9:13 PM JST, Mauro Carvalho Chehab wrote: > > Hi Michael, > > > > Em Sat, 12 Apr 2025 13:08:01 +0900 > > Alexandre Courbot escreveu: > >

Re: [PATCH v2 1/4] media: qcom: camss: vfe: Add VBIF setting support

2025-05-27 Thread Bryan O'Donoghue
On 26/05/2025 17:20, Vincent Knecht wrote: You have both if (vfe->res->has_vbif) { and the above switch, there's no point in checking this twice in two different ways. Choose one, suggest has_vbif is enough. I think the switch is still needed, so that distinct settings can be applied for diff

Re: [PATCH v3] media: add virtio-media driver

2025-05-26 Thread Alexandre Courbot
Hi Mauro, On Mon May 26, 2025 at 9:13 PM JST, Mauro Carvalho Chehab wrote: > Hi Michael, > > Em Sat, 12 Apr 2025 13:08:01 +0900 > Alexandre Courbot escreveu: > >> Add the first version of the virtio-media driver. >> >> This driver acts roughly as a V4L2 relay bet

Re: [PATCH v2 2/4] media: qcom: camss: Add support for MSM8939

2025-05-26 Thread Vincent Knecht
rt for the MSM8939 camera subsystem. > > > > Signed-off-by: Vincent Knecht > > --- > >   drivers/media/platform/qcom/camss/camss-csiphy.c   |   1 + > >   drivers/media/platform/qcom/camss/camss-ispif.c    |   8 +- > >   drivers/media/platform/qcom/camss/camss

Re: [PATCH v2 1/4] media: qcom: camss: vfe: Add VBIF setting support

2025-05-26 Thread Vincent Knecht
Le lundi 26 mai 2025 à 09:13 +0100, Bryan O'Donoghue a écrit : > On 25/05/2025 20:25, Vincent Knecht via B4 Relay wrote: > > +void vfe_vbif_reg_write(struct vfe_device *vfe, u32 reg, u32 val); > > write_reg() / read_reg() > > --- > bod Do you mean to just rename to vfe_vbif_write_reg(), or that

Re: [PATCH v3] media: add virtio-media driver

2025-05-26 Thread Mauro Carvalho Chehab
Hi Michael, Em Sat, 12 Apr 2025 13:08:01 +0900 Alexandre Courbot escreveu: > Add the first version of the virtio-media driver. > > This driver acts roughly as a V4L2 relay between user-space and the > virtio virtual device on the host, so it is relatively simple, yet > unc

Re: [PATCH v2 1/4] media: qcom: camss: vfe: Add VBIF setting support

2025-05-26 Thread Bryan O'Donoghue
On 25/05/2025 20:25, Vincent Knecht via B4 Relay wrote: From: Vincent Knecht Some devices need writing values to VFE VBIF registers. Add helper functions to do this. Signed-off-by: Vincent Knecht --- drivers/media/platform/qcom/camss/Makefile | 1 + drivers/media/platform/qcom

Re: [PATCH v2 1/4] media: qcom: camss: vfe: Add VBIF setting support

2025-05-26 Thread Bryan O'Donoghue
On 25/05/2025 20:25, Vincent Knecht via B4 Relay wrote: +void vfe_vbif_reg_write(struct vfe_device *vfe, u32 reg, u32 val); write_reg() / read_reg() --- bod

Re: [PATCH v2 2/4] media: qcom: camss: Add support for MSM8939

2025-05-26 Thread Bryan O'Donoghue
-camera.dtsi vbif-{regs,settings} properties). This fixes black stripes across sensor and garbage in CSID TPG outputs. Add support for the MSM8939 camera subsystem. Signed-off-by: Vincent Knecht --- drivers/media/platform/qcom/camss/camss-csiphy.c | 1 + drivers/media/platform/qcom/camss/camss

[PATCH v2 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-05-25 Thread Vincent Knecht via B4 Relay
From: Vincent Knecht Add bindings for qcom,msm8939-camss in order to support the camera subsystem for MSM8939. Signed-off-by: Vincent Knecht --- .../bindings/media/qcom,msm8939-camss.yaml | 253 + 1 file changed, 253 insertions(+) diff --git a/Documentation

[PATCH v2 2/4] media: qcom: camss: Add support for MSM8939

2025-05-25 Thread Vincent Knecht via B4 Relay
stripes across sensor and garbage in CSID TPG outputs. Add support for the MSM8939 camera subsystem. Signed-off-by: Vincent Knecht --- drivers/media/platform/qcom/camss/camss-csiphy.c | 1 + drivers/media/platform/qcom/camss/camss-ispif.c| 8 +- drivers/media/platform/qcom/camss/camss

[PATCH v2 1/4] media: qcom: camss: vfe: Add VBIF setting support

2025-05-25 Thread Vincent Knecht via B4 Relay
From: Vincent Knecht Some devices need writing values to VFE VBIF registers. Add helper functions to do this. Signed-off-by: Vincent Knecht --- drivers/media/platform/qcom/camss/Makefile | 1 + drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 11 drivers/media/platform

Re: [PATCH v3 1/2] dt-bindings: media: i2c: Add DW9719 and DW9761 VCM

2025-05-21 Thread André Apitzsch
9 and DW9761 VCM devicetree bindings. > > > > Signed-off-by: André Apitzsch > > --- > >  .../bindings/media/i2c/dongwoon,dw9719.yaml    | 45 > > ++ > >  1 file changed, 45 insertions(+) > > > > diff --git > > a/Docum

Re: [PATCH v2 4/4] media: i2c: imx214: Remove hard-coded external clock frequency

2025-05-21 Thread Laurent Pinchart
y wrote: > > > > > > > From: André Apitzsch > > > > > > > > > > > > > > Instead rely on the rate set on the clock (using > > > > > > > assigned-clock-rates > > > > > >

Re: [PATCH 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-05-21 Thread Krzysztof Kozlowski
On Tue, May 20, 2025 at 08:39:08PM GMT, Vincent Knecht wrote: > Add bindings for qcom,msm8939-camss in order to support the camera > subsystem for MSM8939. > > Signed-off-by: Vincent Knecht > --- > .../bindings/media/qcom,msm8939-camss.yaml | 269 > ++

Re: [PATCH 2/4] media: qcom: camss: Add support for MSM8939

2025-05-20 Thread Dmitry Baryshkov
lues to 2 VFE VBIF registers > (see downstream msm8939-camera.dtsi vbif-{regs,settings} properties). > This fixes black stripes across sensor and garbage in CSID TPG outputs. > > Add support for the MSM8939 camera subsystem. > > Signed-off-by: Vincent Knecht > --- > driver

Re: [PATCH 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-05-20 Thread Bryan O'Donoghue
On 20/05/2025 19:39, Vincent Knecht via B4 Relay wrote: From: Vincent Knecht Add bindings for qcom,msm8939-camss in order to support the camera subsystem for MSM8939. Signed-off-by: Vincent Knecht --- .../bindings/media/qcom,msm8939-camss.yaml | 269 + 1 file

Re: [PATCH 2/4] media: qcom: camss: Add support for MSM8939

2025-05-20 Thread Bryan O'Donoghue
On 20/05/2025 19:39, Vincent Knecht via B4 Relay wrote: +static const struct camss_subdev_resources csiphy_res_8x39[] = { + /* CSIPHY0 */ + { + .regulators = {}, Regulators should be declared with the PHY not the CSID. --- bod

[PATCH 2/4] media: qcom: camss: Add support for MSM8939

2025-05-20 Thread Vincent Knecht via B4 Relay
stripes across sensor and garbage in CSID TPG outputs. Add support for the MSM8939 camera subsystem. Signed-off-by: Vincent Knecht --- drivers/media/platform/qcom/camss/camss-csiphy.c | 1 + drivers/media/platform/qcom/camss/camss-ispif.c| 8 +- drivers/media/platform/qcom/camss/camss

[PATCH 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-05-20 Thread Vincent Knecht via B4 Relay
From: Vincent Knecht Add bindings for qcom,msm8939-camss in order to support the camera subsystem for MSM8939. Signed-off-by: Vincent Knecht --- .../bindings/media/qcom,msm8939-camss.yaml | 269 + 1 file changed, 269 insertions(+) diff --git a/Documentation

[PATCH 1/4] media: qcom: camss: vfe: Add VBIF setting support

2025-05-20 Thread Vincent Knecht via B4 Relay
From: Vincent Knecht Some devices need writing values to VFE VBIF registers. Add helper functions to do this. Signed-off-by: Vincent Knecht --- drivers/media/platform/qcom/camss/Makefile | 1 + drivers/media/platform/qcom/camss/camss-vfe-vbif.c | 30 ++ drivers

Re: [PATCH v2 4/4] media: i2c: imx214: Remove hard-coded external clock frequency

2025-05-15 Thread André Apitzsch
> > > > > > > > > > > > Instead rely on the rate set on the clock (using assigned- > > > > > > clock-rates > > > > > > etc.) > > > > > > > > > > > > Signed-off-by: André Apitzsch > > &

Re: [PATCH v2 4/4] media: i2c: imx214: Remove hard-coded external clock frequency

2025-05-15 Thread Sakari Ailus
; > > etc.) > > > > > > > > > > Signed-off-by: André Apitzsch > > > > > --- > > > > > drivers/media/i2c/imx214.c | 6 -- > > > > > 1 file changed, 6 deletions(-) > > > > > > > >

Re: [PATCH v2 4/4] media: i2c: imx214: Remove hard-coded external clock frequency

2025-05-15 Thread Laurent Pinchart
t; > wrote: > > > > From: André Apitzsch > > > > > > > > Instead rely on the rate set on the clock (using assigned-clock-rates > > > > etc.) > > > > > > > > Signed-off-by: André Apitzsch > > > > --- >

Re: [PATCH v2 4/4] media: i2c: imx214: Remove hard-coded external clock frequency

2025-05-15 Thread Sakari Ailus
> > > > > Instead rely on the rate set on the clock (using assigned-clock-rates > > > etc.) > > > > > > Signed-off-by: André Apitzsch > > > --- > > > drivers/media/i2c/imx214.c | 6 -- > > > 1 file changed, 6 deletions(

Re: [PATCH v2 4/4] media: i2c: imx214: Remove hard-coded external clock frequency

2025-05-15 Thread Laurent Pinchart
t; > > > Signed-off-by: André Apitzsch > > --- > > drivers/media/i2c/imx214.c | 6 -- > > 1 file changed, 6 deletions(-) > > > > diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c > > index > > 9e9be47394ec768a5b34d44

Re: [PATCH v2 4/4] media: i2c: imx214: Remove hard-coded external clock frequency

2025-05-14 Thread André Apitzsch
igned-clock- > > rates > > etc.) > > > > Signed-off-by: André Apitzsch > > --- > >  drivers/media/i2c/imx214.c | 6 -- > >  1 file changed, 6 deletions(-) > > > > diff --git a/drivers/media/i2c/imx214.c > > b/drivers/media/i2c/

[PATCH] media: i2c: ov8858: Add sensor's pixel matrix size

2025-05-09 Thread Vincent Knecht via B4 Relay
native and active sensor pixel sizes. Signed-off-by: Vincent Knecht --- drivers/media/i2c/ov8858.c | 37 + 1 file changed, 37 insertions(+) diff --git a/drivers/media/i2c/ov8858.c b/drivers/media/i2c/ov8858.c index 95f9ae7948463e95ce0b2cb58195de02ee72c02a

Re: [PATCH v2 3/4] media: i2c: imx214: Make use of CCS PLL calculator

2025-05-06 Thread Sakari Ailus
> > > On Mon, May 05, 2025 at 11:05:55PM +0200, André Apitzsch via B4 Relay > > wrote: > > > From: André Apitzsch > > > > > > Calculate PLL parameters based on clock frequency and link > > > frequency. > > > > > > Acked-by

Re: [PATCH v2 3/4] media: i2c: imx214: Make use of CCS PLL calculator

2025-05-06 Thread André Apitzsch
zsch > > > > Calculate PLL parameters based on clock frequency and link > > frequency. > > > > Acked-by: Ricardo Ribalda > > Signed-off-by: André Apitzsch > > --- > >  drivers/media/i2c/Kconfig  |   1 + > >  drivers/media/i2c/imx214.c | 2

Re: [PATCH v2 4/4] media: i2c: imx214: Remove hard-coded external clock frequency

2025-05-06 Thread Sakari Ailus
Hi André, On Mon, May 05, 2025 at 11:05:56PM +0200, André Apitzsch via B4 Relay wrote: > From: André Apitzsch > > Instead rely on the rate set on the clock (using assigned-clock-rates > etc.) > > Signed-off-by: André Apitzsch > --- > drivers/media/i2c/imx214.c | 6 ---

Re: [PATCH v2 3/4] media: i2c: imx214: Make use of CCS PLL calculator

2025-05-06 Thread Sakari Ailus
> --- > drivers/media/i2c/Kconfig | 1 + > drivers/media/i2c/imx214.c | 216 > + > 2 files changed, 178 insertions(+), 39 deletions(-) > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > index

[PATCH v2 4/4] media: i2c: imx214: Remove hard-coded external clock frequency

2025-05-05 Thread André Apitzsch via B4 Relay
From: André Apitzsch Instead rely on the rate set on the clock (using assigned-clock-rates etc.) Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c index

[PATCH v2 1/4] media: i2c: imx214: Reorder imx214_parse_fwnode call

2025-05-05 Thread André Apitzsch via B4 Relay
From: André Apitzsch Reorder imx214_parse_fwnode call to reduce goto paths in upcoming patches. No functional change intended. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a

[PATCH v2 2/4] media: i2c: imx214: Prepare for variable clock frequency

2025-05-05 Thread André Apitzsch via B4 Relay
From: André Apitzsch Move clock frequency related parameters out of the constant register sequences, such that the hard coded external clock frequency can be replaced by a variable in the upcoming patches. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c

[PATCH v2 3/4] media: i2c: imx214: Make use of CCS PLL calculator

2025-05-05 Thread André Apitzsch via B4 Relay
From: André Apitzsch Calculate PLL parameters based on clock frequency and link frequency. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/Kconfig | 1 + drivers/media/i2c/imx214.c | 216 + 2 files changed, 178

[PATCH v2 0/4] media: i2c: imx214: Add support for more clock frequencies

2025-05-05 Thread André Apitzsch via B4 Relay
://lore.kernel.org/linux-media/20250308-imx214_clk_freq-v1-0-467a4c083...@apitzsch.eu/ Signed-off-by: André Apitzsch --- Changes in v2: - Add A-b tags - Switch to v4l2_ctrl_s_ctrl_int64() to acquire the control handler mutex - Add error handling for v4l2_ctrl_s_ctrl_int64() and imx214_pll_update() - Replace

Re: [PATCH 4/4] media: i2c: imx214: Read clock frequency from device tree

2025-05-05 Thread Sakari Ailus
Hi André, On Tue, Apr 15, 2025 at 11:22:18PM +0200, André Apitzsch via B4 Relay wrote: > From: André Apitzsch > > Replace the hard coded external clock frequency by the one read from > device tree. > > Signed-off-by: André Apitzsch > --- > drivers/media/i2c/imx214.c |

Re: [PATCH 3/4] media: i2c: imx214: Make use of CCS PLL calculator

2025-05-05 Thread Sakari Ailus
Hi André, Thanks for the set. On Tue, Apr 15, 2025 at 11:22:17PM +0200, André Apitzsch via B4 Relay wrote: > From: André Apitzsch > > Calculate PLL parameters based on clock frequency and link frequency. > > Signed-off-by: André Apitzsch > --- > drivers/media/i2c/Kconfi

Re: [PATCH 0/4] media: i2c: imx214: Add support for more clock frequencies

2025-05-02 Thread André Apitzsch
s, like Qualcomm-MSM8916-based phones, which cannot > > provide this frequency. To make the sensor usable by those devices, > > add > > support for additional clock frequencies. > > > > This series supersedes > > https://lore.kernel.org/linux-media/20250308-imx

Re: [PATCH 0/4] media: i2c: imx214: Add support for more clock frequencies

2025-04-23 Thread Ricardo Ribalda Delgado
dd > support for additional clock frequencies. > > This series supersedes > https://lore.kernel.org/linux-media/20250308-imx214_clk_freq-v1-0-467a4c083...@apitzsch.eu/ > > Signed-off-by: André Apitzsch Acked-by: Ricardo Ribalda > --- > André Apitzsch (4): > media: i

[PATCH 4/4] media: i2c: imx214: Read clock frequency from device tree

2025-04-15 Thread André Apitzsch via B4 Relay
From: André Apitzsch Replace the hard coded external clock frequency by the one read from device tree. Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c

[PATCH 2/4] media: i2c: imx214: Prepare for variable clock frequency

2025-04-15 Thread André Apitzsch via B4 Relay
From: André Apitzsch Move clock frequency related parameters out of the constant register sequences, such that the hard coded external clock frequency can be replaced by a variable in the upcoming patches. Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 54

[PATCH 0/4] media: i2c: imx214: Add support for more clock frequencies

2025-04-15 Thread André Apitzsch via B4 Relay
://lore.kernel.org/linux-media/20250308-imx214_clk_freq-v1-0-467a4c083...@apitzsch.eu/ Signed-off-by: André Apitzsch --- André Apitzsch (4): media: i2c: imx214: Reorder imx214_parse_fwnode call media: i2c: imx214: Prepare for variable clock frequency media: i2c: imx214: Make use of CCS PLL

[PATCH 3/4] media: i2c: imx214: Make use of CCS PLL calculator

2025-04-15 Thread André Apitzsch via B4 Relay
From: André Apitzsch Calculate PLL parameters based on clock frequency and link frequency. Signed-off-by: André Apitzsch --- drivers/media/i2c/Kconfig | 1 + drivers/media/i2c/imx214.c | 208 - 2 files changed, 170 insertions(+), 39 deletions

[PATCH 1/4] media: i2c: imx214: Reorder imx214_parse_fwnode call

2025-04-15 Thread André Apitzsch via B4 Relay
From: André Apitzsch Reorder imx214_parse_fwnode call to reduce goto paths in upcoming patches. No functional change intended. Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/imx214.c b

Re: [PATCH RESEND 0/4] media: i2c: imx214: Problem with CCS PLL calculator

2025-04-14 Thread André Apitzsch
ed phones, which > > > > cannot > > > > provide this frequency. To make the sensor usable by those > > > > devices, > > > > add > > > > support for 23.88MHz clock. > > > > > > > > Signed-off-by: André Apitzsch

Re: [PATCH v3] media: add virtio-media driver

2025-04-12 Thread Markus Elfring
… > +++ b/drivers/media/virtio/virtio_media_driver.c > @@ -0,0 +1,959 @@ … > +static struct virtio_media_session * > +virtio_media_session_alloc(struct virtio_media *vv, u32 id, > +bool nonblocking_dequeue) > +{ … > + init_waitqueue_head

[PATCH v3] media: add virtio-media driver

2025-04-11 Thread Alexandre Courbot
Add the first version of the virtio-media driver. This driver acts roughly as a V4L2 relay between user-space and the virtio virtual device on the host, so it is relatively simple, yet unconventional. It doesn't use VB2 or other frameworks typically used in a V4L2 driver, and most o

Re: [PATCH RESEND 0/4] media: i2c: imx214: Problem with CCS PLL calculator

2025-04-07 Thread André Apitzsch
vices, > > > add > > > support for 23.88MHz clock. > > > > > > Signed-off-by: André Apitzsch > > > --- > > > André Apitzsch (4): > > >       media: i2c: imx214: Calculate link bit rate from clock > > > frequency > > >   media: i2

Re: [PATCH RESEND 4/4] media: i2c: imx214: Add support for 23.88MHz clock

2025-03-11 Thread Ricardo Ribalda Delgado
balda and after this patch imx214->clk_params = &imx214_clk_params[1]; Thanks for the set! > Signed-off-by: André Apitzsch > --- > drivers/media/i2c/imx214.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c

Re: [PATCH RESEND 3/4] media: i2c: imx214: Read clock frequency from device tree

2025-03-11 Thread Ricardo Ribalda Delgado
On Sat, Mar 8, 2025 at 10:48 PM André Apitzsch via B4 Relay wrote: > > From: André Apitzsch > > Replace the hard coded external clock frequency by the one read from > device tree. > > Signed-off-by: André Apitzsch > --- > driv

Re: [PATCH RESEND 2/4] media: i2c: imx214: Prepare for variable clock frequency

2025-03-11 Thread Ricardo Ribalda Delgado
commit. > Acked-by: Ricardo Ribalda > Signed-off-by: André Apitzsch > --- > drivers/media/i2c/imx214.c | 64 > -- > 1 file changed, 39 insertions(+), 25 deletions(-) > > diff --git a/drivers/media/i2c/imx

Re: [PATCH RESEND 1/4] media: i2c: imx214: Calculate link bit rate from clock frequency

2025-03-11 Thread Ricardo Ribalda Delgado
ting and the PLL multiple setting. > > Signed-off-by: André Apitzsch Acked-by: Ricardo Ribalda > --- > drivers/media/i2c/imx214.c | 51 > +- > 1 file changed, 37 insertions(+), 14 deletions(-) > > diff --git a/driver

Re: [PATCH RESEND 0/4] media: i2c: imx214: Add support for 23.88MHz clock

2025-03-10 Thread André Apitzsch
devices, like Qualcomm-MSM8916-based phones, which cannot > > provide this frequency. To make the sensor usable by those devices, > > add > > support for 23.88MHz clock. > > > > Signed-off-by: André Apitzsch > > --- > > André Apitzsch (4): > &

Re: [PATCH RESEND 0/4] media: i2c: imx214: Add support for 23.88MHz clock

2025-03-10 Thread Sakari Ailus
e devices, add > support for 23.88MHz clock. > > Signed-off-by: André Apitzsch > --- > André Apitzsch (4): > media: i2c: imx214: Calculate link bit rate from clock frequency > media: i2c: imx214: Prepare for variable clock frequency > media: i2c: imx214:

[PATCH RESEND 0/4] media: i2c: imx214: Add support for 23.88MHz clock

2025-03-08 Thread André Apitzsch via B4 Relay
): media: i2c: imx214: Calculate link bit rate from clock frequency media: i2c: imx214: Prepare for variable clock frequency media: i2c: imx214: Read clock frequency from device tree media: i2c: imx214: Add support for 23.88MHz clock drivers/media/i2c/imx214.c | 188

  1   2   3   4   5   6   7   8   9   10   >