Re: RCU idle CPU detection is broken in linux-next

2012-09-22 Thread Paul E. McKenney
On Sat, Sep 22, 2012 at 07:50:29PM +0200, Sasha Levin wrote: > On 09/22/2012 05:56 PM, Paul E. McKenney wrote: > > And now the prime suspect is the new CONFIG_RCU_USER_QS=y. Do these > > warnings ever show up with CONFIG_RCU_USER_QS=n? > > It seems that disabling that does make the warnings go aw

Re: [PATCH v3 RESEND 01/17] ARM: add mechanism for late code patching

2012-09-22 Thread Cyril Chemparathy
On 09/22/12 11:10, Nicolas Pitre wrote: On Fri, 21 Sep 2012, Cyril Chemparathy wrote: The original phys_to_virt/virt_to_phys patching implementation relied on early patching prior to MMU initialization. On PAE systems running out of >4G address space, this would have entailed an additional rou

Re: [RFC] tty: Add get- ioctls to fetch tty status

2012-09-22 Thread Cyrill Gorcunov
On Sun, Sep 23, 2012 at 12:11:44AM +0400, Cyrill Gorcunov wrote: > > > Sysfs is one value per file, you have three values here, please make 3 > > files. > > > > And document them in Documentation/ABI/. > > Hmm, sure Greg, I'll update. Thanks! Something like below I suppose? Look, if there will b

Re: rcu self-detected stall messages on OMAP3, 4 boards

2012-09-22 Thread Paul E. McKenney
On Sat, Sep 22, 2012 at 01:10:43PM -0700, Paul E. McKenney wrote: > On Sat, Sep 22, 2012 at 06:42:08PM +, Paul Walmsley wrote: > > On Fri, 21 Sep 2012, Paul E. McKenney wrote: > > > > > Could you please point me to a recipe for creating a minimal userspace? > > > Just in case it is the userspa

Re: rcu self-detected stall messages on OMAP3, 4 boards

2012-09-22 Thread Paul Walmsley
Hi Paul On Sat, 22 Sep 2012, Paul E. McKenney wrote: > Strangely enough, I believe that I have inadvertently fixed this in > my -rcu tree: > > git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/next > > Nevertheless, if you get a chance to try it, I would be interested to >

Re: rcu self-detected stall messages on OMAP3, 4 boards

2012-09-22 Thread Paul Walmsley
On Sat, 22 Sep 2012, Paul E. McKenney wrote: > And here is a patch. I am still having trouble reproducing the problem, > but figured that I should avoid serializing things. Thanks, testing this now on v3.6-rc6. One question though about the patch description: > All this begs the question of e

Re: rcu self-detected stall messages on OMAP3, 4 boards

2012-09-22 Thread Paul E. McKenney
On Sat, Sep 22, 2012 at 10:25:59PM +, Paul Walmsley wrote: > On Sat, 22 Sep 2012, Paul E. McKenney wrote: > > > And here is a patch. I am still having trouble reproducing the problem, > > but figured that I should avoid serializing things. > > Thanks, testing this now on v3.6-rc6. Very cool

Re: [RFC] tty: Add get- ioctls to fetch tty status

2012-09-22 Thread Alan Cox
> > Guys, you mean something like below? Look, I must admit I'm not really > > sure if I've done all locking right, and there is no need for additional > > kref counting on tty_struct. Could you please check if it looks more-less > > sane (I've tested it but still...) This still doesn't answer th

Re: rcu self-detected stall messages on OMAP3, 4 boards

2012-09-22 Thread Paul E. McKenney
On Sat, Sep 22, 2012 at 10:20:19PM +, Paul Walmsley wrote: > Hi Paul > > On Sat, 22 Sep 2012, Paul E. McKenney wrote: > > > Strangely enough, I believe that I have inadvertently fixed this in > > my -rcu tree: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/ne

Re: Linux 3.6-rc6

2012-09-22 Thread Fengguang Wu
On Sat, Sep 22, 2012 at 11:57:23AM -0700, Linus Torvalds wrote: > On Fri, Sep 21, 2012 at 5:59 PM, Shaun Ruffell wrote: > > > > I posted patches [1,2,3] that resolve the issue for me. Shaohui Xie > > also hit the issue and posted a slightly different patch [4]. The > > patches are currently waitin

[PATCH] edac_mc: fix messy kfree calls in the error path

2012-09-22 Thread Fengguang Wu
coccinelle warns about: + drivers/edac/edac_mc.c:429:9-23: ERROR: reference preceded by free on line 429 421 if (mci->csrows) { > 422 for (chn = 0; chn < tot_channels; chn++) { 423 csr = mci->csrows[chn]; 424 if (cs

Re: RCU idle CPU detection is broken in linux-next

2012-09-22 Thread Paul E. McKenney
On Sat, Sep 22, 2012 at 02:27:35PM -0700, Paul E. McKenney wrote: > On Sat, Sep 22, 2012 at 07:50:29PM +0200, Sasha Levin wrote: > > On 09/22/2012 05:56 PM, Paul E. McKenney wrote: > > > And now the prime suspect is the new CONFIG_RCU_USER_QS=y. Do these > > > warnings ever show up with CONFIG_RCU

Re: [RFC] status of execve() work - per-architecture patches solicited

2012-09-22 Thread Al Viro
On Sat, Sep 22, 2012 at 09:16:11PM +1000, Greg Ungerer wrote: > I sent the patch to the m68k-linux list. Its been acked by Geert. > > http://marc.info/?l=linux-m68k&m=134742688015639&w=2 > > I was going to push it through the m68knommu git tree, but I don't mind > if you would rather take it wit

Re: [RFC] tty: Add get- ioctls to fetch tty status

2012-09-22 Thread Greg Kroah-Hartman
On Sun, Sep 23, 2012 at 01:52:32AM +0400, Cyrill Gorcunov wrote: > On Sun, Sep 23, 2012 at 12:11:44AM +0400, Cyrill Gorcunov wrote: > > > > > Sysfs is one value per file, you have three values here, please make 3 > > > files. > > > > > > And document them in Documentation/ABI/. > > > > Hmm, sure

Re: [PATCH 2/2] ACPI: Override arbitrary ACPI tables via initrd for debugging

2012-09-22 Thread Thomas Renninger
Hi Len, On Saturday 22 September 2012 17:16:47 Len Brown wrote: > This isn't a NAK, but I'm at best, "like warm" on this. We had this discussion already... And you already had similar patches Signed-off and put in your queue for Linus in 2008: http://www.mail-archive.com/linux-acpi@vger.kernel.org

[PATCH] edac_mc: edac_mc_free() cannot assume mem_ctl_info is registered in sysfs.

2012-09-22 Thread Shaun Ruffell
Fix potential NULL pointer dereference in edac_unregister_sysfs() on system boot introduced in 3.6-rc1. This patch is dependent on Fengguang's "edac_mc: fix messy kfree calls in the error path". Since commit 7a623c039 ("edac: rewrite the sysfs code to use struct device") edac_mc_alloc() no longer

Re: [PATCH] regulator: deprecate regulator-compatible DT property

2012-09-22 Thread Stephen Warren
On 09/22/2012 09:56 AM, Mark Brown wrote: > On Thu, Sep 20, 2012 at 04:04:57PM -0600, Stephen Warren wrote: > >> Mark, if this gets into 3.7, I can fix up all the Tegra .dts files during >> 3.8. > > I don't know which branch you generated this against but it doesn't > apply to any of the obvious

Re: rcu self-detected stall messages on OMAP3, 4 boards

2012-09-22 Thread Paul Walmsley
idle entry/exit code. Without the bugfix patch, a boot log transcript was obtained indicating that the idle loop was entered with tick_nohz_enabled=1 during a grace period with no callbacks present: http://www.pwsan.com/omap/transcripts/20120922-rcu-stall-debug-pre-fix.txt The debugging eve

Re: [RFC] tty: Add get- ioctls to fetch tty status

2012-09-22 Thread Eric W. Biederman
I don't know where this conversation comes from but putting ptys in sysfs in combination with the newinstance mount option is completely broken unless the device name and device number duplication is handled, which I don't see here. Cyrill Gorcunov writes: > > Guys, you mean something like below

Re: [PATCH 3.6-rc6] cpufreq/powernow-k8: workqueue user shouldn't migrate the kworker to another CPU

2012-09-22 Thread Thomas Renninger
Hi, better late than never.. On Monday 17 September 2012 22:38:20 Rafael J. Wysocki wrote: > On Monday, September 17, 2012, Tejun Heo wrote: > > powernowk8_target() runs off a per-cpu work item and if the > > cpufreq_policy->cpu is different from the current one, it migrates the > > kworker to th

Re: rcu self-detected stall messages on OMAP3, 4 boards

2012-09-22 Thread Paul E. McKenney
ned > indicating that the idle loop was entered with tick_nohz_enabled=1 > during a grace period with no callbacks present: > > http://www.pwsan.com/omap/transcripts/20120922-rcu-stall-debug-pre-fix.txt > > The debugging events started to appear at 1.867370 seconds into the >

Re: rcu self-detected stall messages on OMAP3, 4 boards

2012-09-22 Thread Paul Walmsley
On Sat, 22 Sep 2012, Paul E. McKenney wrote: > Very cool, thank you for your testing efforts!!! You're welcome. > May I apply your Tested-by to this patch? Please do: Tested-by: Paul Walmsley # OMAP4430 Am testing on OMAP3730 (single-core) now. - Paul -- To unsubscribe from this list: sen

[PATCH 0/4] devpts: fix devpts mount behavior

2012-09-22 Thread Eric W. Biederman
This is the restart of an old conversation that started out with Serge noting that there are problems taking advantage of the devpts newinstance mount option. As the conversation progressed it was suggested that the devpts newinstance mount option should just be removed if possible. Then the conv

[PATCH 1/4] devpts: Remove CONFIG_DEVPTS_MULTIPLE_INSTANCES

2012-09-22 Thread Eric W. Biederman
This compile option just makes the code more complicated and makes it more difficult to transition to a time when we take advantage of the new features that DEVPTS_MULTIPLE_INSTANCES allows. Acked-by: "Serge E. Hallyn" Signed-off-by: "Eric W. Biederman" --- Documentation/filesystems/devpts.txt

[PATCH 2/4] devpts: Set the default permissions of /dev/pts/ptmx and /dev/ptmx to 0666

2012-09-22 Thread Eric W. Biederman
These are difference instances of the same device not so it only makes sense that they would have the same default permissions. Move the definitions of DEVPTS_DEEFAULT_PTMX_MODE and PTM_MINOR into devpts_fs.h so we can use the same definitions throughout. Acked-by: "Serge E. Hallyn" Signed-off-

[PATCH 3/4] devpts: Make the newinstance option historical

2012-09-22 Thread Eric W. Biederman
- Modify opening /dev/ptmx so that it opens /dev/pts/ptmx As it appares nearly impossible to get udev to create a symlink do this with a little sprinkle of in kernel magic. - Cleanup the devpts mount code and only leave the code for new instance. Tested on debian and ubuntu without any prob

[PATCH 4/4] devpts: Update the documentation

2012-09-22 Thread Eric W. Biederman
Document the updated state of devpts. Signed-off-by: "Eric W. Biederman" --- Documentation/filesystems/devpts.txt | 88 - 1 files changed, 22 insertions(+), 66 deletions(-) diff --git a/Documentation/filesystems/devpts.txt b/Documentation/filesystems/devpts.t

Re: [PATCH 3/4] devpts: Make the newinstance option historical

2012-09-22 Thread Al Viro
On Sat, Sep 22, 2012 at 08:50:44PM -0700, Eric W. Biederman wrote: > +struct inode *devpts_redirect(struct file *filp) > +{ > + struct inode *inode; > + struct file *filp2; > + > + /* Is the inode already a devpts inode? */ > + inode = filp->f_dentry->d_inode; > + if (filp->f_d

Re: [PATCH 2/2] ACPI: Override arbitrary ACPI tables via initrd for debugging

2012-09-22 Thread Len Brown
> +config ACPI_INITRD_TABLE_OVERRIDE > + bool > + default y Do distros in addition to SuSE concur they want to ship this way? The last time we tried to make debugging easier we added ACPI_CUSTOM_METHOD, which allowed root to over-ride an AML method on a running system. Distro securit

ACPICA related patch queue for Linux-3.7

2012-09-22 Thread Len Brown
Here is my ACPICA branch queued for Linux-3.7 Please let me know if you see troubles with any of them. Note that the acpidump utility is also in here. Since it lost its home on kernel.org in pmtools, and it depends on kernel headers, it seemed to make sense to put it here. Yes, it is a bit dusty

[PATCH 20/23] tools/power/acpi/acpidump: version 20070714

2012-09-22 Thread Len Brown
From: Len Brown This is unchanged version 20070714, plus a small bit in DEFINE_ALTERNATE_TYPES to enable building with latest kernel headers. Signed-off-by: Len Brown --- tools/power/acpi/Makefile | 7 ++- tools/power/acpi/acpidump.c | 127 ++-- 2 fi

[PATCH 17/23] ACPICA: Update version to 20120913

2012-09-22 Thread Len Brown
From: Bob Moore Version 20120913. Signed-off-by: Bob Moore Signed-off-by: Lv Zheng Signed-off-by: Len Brown --- include/acpi/acpixf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/acpi/acpixf.h b/include/acpi/acpixf.h index 03457a9..267bfc4 100644 --- a/include/

[PATCH 14/23] usb-acpi: Comply with the ACPI API change

2012-09-22 Thread Len Brown
From: Feng Tang acpi_get_physical_device_location()'s 2nd argument has been changed in ACPI implementaion, so need a follow-on change in usb_acpi_check_pld(). Signed-off-by: Feng Tang Signed-off-by: Bob Moore Cc: Matthew Garrett Cc: Greg Kroah-Hartman Cc: Lan Tianyu Signed-off-by: Len Brown

[PATCH 15/23] ACPICA: Headers: Add new ACPI 5 HEST notify type values.

2012-09-22 Thread Len Brown
From: Bob Moore Add values 5 (CMCI) and 6 (MCE). Signed-off-by: Bob Moore Signed-off-by: Lv Zheng Signed-off-by: Len Brown --- include/acpi/actbl1.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h index c41d6f9..280fc45 100

[PATCH 16/23] ACPICA: Table Manager: Merge duplicate code (root table)

2012-09-22 Thread Len Brown
From: Lv Zheng Merge/remove duplicate code in the root table resize functions One function is external, the other is internal. Lv Zheng, ACPICA BZ 846: https://acpica.org/bugzilla/show_bug.cgi?id=846 Signed-off-by: Bob Moore Signed-off-by: Lv Zheng Signed-off-by: Len Brown --- drivers/acpi

[PATCH 09/23] ACPICA: Headers: Add support for CSRT and DBG2 ACPI tables.

2012-09-22 Thread Len Brown
From: Bob Moore These tables are defined outside of the ACPI specification. Signed-off-by: Bob Moore Signed-off-by: Feng Tang Signed-off-by: Len Brown --- include/acpi/actbl2.h | 111 ++ include/acpi/actbl3.h | 1 - 2 files changed, 111 inser

[PATCH 10/23] ACPICA: Add support for complex _PLD buffers.

2012-09-22 Thread Len Brown
From: Bob Moore _PLD (Physical Location of Device) returns a bit-packed buffer that is difficult to parse. This change adds a new interface, AcpiDecodePldBuffer that parses the buffer into a more usable local struct. Also adds macros to both get and set individual fields within the packed _PLD bu

[PATCH 11/23] ACPICA: Add struct header support for _FDE, _GRT, _GTM, and _SRT names.

2012-09-22 Thread Len Brown
From: Bob Moore Added structs for the buffers related to these predefined names, in acbuffer.h Signed-off-by: Bob Moore Signed-off-by: Feng Tang Signed-off-by: Len Brown --- include/acpi/acbuffer.h | 43 +++ 1 file changed, 43 insertions(+) diff --git

[PATCH 12/23] ACPICA: Update version to 20120816.

2012-09-22 Thread Len Brown
From: Bob Moore Version 20120816. Signed-off-by: Bob Moore Signed-off-by: Feng Tang Signed-off-by: Len Brown --- include/acpi/acpixf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/acpi/acpixf.h b/include/acpi/acpixf.h index 270517d..03457a9 100644 --- a/include

[PATCH 13/23] ACPI: Use ACPICA native way to decode the PLD buffer

2012-09-22 Thread Len Brown
From: Feng Tang This patch is on top of the ACPICA 20120816 release, which implemented a native way to decode PLD buffer, so use it instead of leting upper level users do the decoding. v2: Modify the check for PLD buffer length to reject buffers whose length < 16 Signed-off-by: Feng Tang Signe

[PATCH 08/23] ACPICA: GPE support: Remove extraneous parameter from low-level function.

2012-09-22 Thread Len Brown
From: Feng Tang The gpe_register_info argument is no longer needed, reduce it to make code simpler. Signed-off-by: Feng Tang Signed-off-by: Bob Moore Signed-off-by: Len Brown --- drivers/acpi/acpica/achware.h | 3 +-- drivers/acpi/acpica/evgpe.c | 3 +-- drivers/acpi/acpica/evxfgpe.c |

[PATCH 04/23] ACPICA: Comment update: Fix some typos in actble.h

2012-09-22 Thread Len Brown
From: Bob Moore No functional change. Signed-off-by: Bob Moore Signed-off-by: Feng Tang Signed-off-by: Len Brown --- include/acpi/actbl.h | 48 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/include/acpi/actbl.h b/include/acpi

[PATCH 05/23] ACPICA: Add Windows8/Server2012 string for _OSI method.

2012-09-22 Thread Len Brown
From: Bob Moore This change adds a new _OSI string, "Windows 2012" for both Windows 8 and Windows Server 2012. >From Microsoft document "How to Identify the Windows Version in ACPI by Using _OSI", July 13, 2012. Signed-off-by: Bob Moore Signed-off-by: Feng Tang Signed-off-by: Len Brown ---

[PATCH 06/23] ACPICA: GPE Support: Update debug info for GPE tracing.

2012-09-22 Thread Len Brown
From: Bob Moore Add additional debug info to assist with GPE debugging. Signed-off-by: Bob Moore Signed-off-by: Feng Tang Signed-off-by: Len Brown --- drivers/acpi/acpica/evgpe.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/acpica/ev

[PATCH 07/23] ACPICA: Debug output: Update output for Processor object.

2012-09-22 Thread Len Brown
From: Bob Moore Cleanup output for Processor(). Length is a byte, not a word. Signed-off-by: Bob Moore Signed-off-by: Feng Tang Signed-off-by: Len Brown --- drivers/acpi/acpica/nsdump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/acpica/nsdump.c b/drivers

[PATCH 23/23] tools/power/acpi/acpidump: create acpidump(8), local make install targets

2012-09-22 Thread Len Brown
From: Len Brown Signed-off-by: Len Brown --- tools/power/acpi/Makefile | 4 +++ tools/power/acpi/acpidump.8 | 59 + 2 files changed, 63 insertions(+) create mode 100644 tools/power/acpi/acpidump.8 diff --git a/tools/power/acpi/Makefile b/tools/po

[PATCH 22/23] tools/power/acpi/acpidump: version 20101221 - find dynamic tables in sysfs

2012-09-22 Thread Len Brown
From: Len Brown This is unchanged version 20101221, plus a small bit in DEFINE_ALTERNATE_TYPES to enable building with latest kernel headers. This version finds dynamic tables exported by Linux in /sys/firmware/acpi/tables/dynamic Signed-off-by: Len Brown --- tools/power/acpi/acpidump.c | 187

[PATCH 21/23] tools/power/acpi/acpidump: version 20071116

2012-09-22 Thread Len Brown
From: Len Brown This is unchanged version 20071116, plus a small bit in DEFINE_ALTERNATE_TYPES to enable building with latest kernel headers. Signed-off-by: Len Brown --- tools/power/acpi/acpidump.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/power/acpi/acp

[PATCH 01/23] ACPI: delelte more BFS/GTS related definition and code

2012-09-22 Thread Len Brown
From: Feng Tang This is a follow on for commmit 3f6f49c7 "ACPI: delete _GTS/_BFS support" to do more cleanup. Signed-off-by: Feng Tang Signed-off-by: Bob Moore Signed-off-by: Len Brown --- drivers/acpi/acpica/hwxfsleep.c | 1 - include/acpi/acnames.h | 2 -- include/acpi/actypes.h

[PATCH 02/23] ACPICA: Enable Scope change to root during module-level code execution.

2012-09-22 Thread Len Brown
From: Bob Moore Allows constructs like this: If () Scope (\) ... Signed-off-by: Bob Moore Signed-off-by: Feng Tang Signed-off-by: Len Brown --- drivers/acpi/acpica/dswload.c | 14 ++ drivers/acpi/acpica/dswload2.c | 14 ++ 2 files changed, 28

[PATCH 03/23] ACPICA: Split ACPICA initialization functions to new file, utxfinit.c

2012-09-22 Thread Len Brown
From: Bob Moore Split utxface.c to improve modularity and reduce file size. Signed-off-by: Bob Moore Signed-off-by: Feng Tang Signed-off-by: Len Brown --- drivers/acpi/acpica/Makefile | 1 + drivers/acpi/acpica/utxface.c | 267 +- drivers/acpi/acpica/utxf

[PATCH 19/23] tools/power/acpi/acpidump: version 20060606

2012-09-22 Thread Len Brown
From: Len Brown This is unchanged version 20060606, plus a small bit in DEFINE_ALTERNATE_TYPES to enable building with latest kernel headers. Signed-off-by: Len Brown --- tools/power/acpi/acpidump.c | 97 +++-- 1 file changed, 59 insertions(+), 38 deleti

[PATCH 18/23] tools/power/acpi/acpidump: version 20051111

2012-09-22 Thread Len Brown
From: Len Brown This is unchanged version 2005, plus a small bit in DEFINE_ALTERNATE_TYPES to enable building with latest kernel headers. Signed-off-by: Len Brown --- tools/power/acpi/Makefile | 15 ++ tools/power/acpi/acpidump.c | 472 2 fil

Re: [PATCH 3/4] devpts: Make the newinstance option historical

2012-09-22 Thread Al Viro
On Sun, Sep 23, 2012 at 05:19:06AM +0100, Al Viro wrote: > On Sat, Sep 22, 2012 at 08:50:44PM -0700, Eric W. Biederman wrote: > > > +struct inode *devpts_redirect(struct file *filp) > > +{ > > + struct inode *inode; > > + struct file *filp2; > > + > > + /* Is the inode already a devpts inode

Re: RCU idle CPU detection is broken in linux-next

2012-09-22 Thread Sasha Levin
On 09/23/2012 02:21 AM, Paul E. McKenney wrote: > On Sat, Sep 22, 2012 at 02:27:35PM -0700, Paul E. McKenney wrote: >> On Sat, Sep 22, 2012 at 07:50:29PM +0200, Sasha Levin wrote: >>> On 09/22/2012 05:56 PM, Paul E. McKenney wrote: And now the prime suspect is the new CONFIG_RCU_USER_QS=y. Do

Re: [PATCH v2] Fix kernel stack data disclosure in binfmt_script during execve

2012-09-22 Thread halfdog
Randy Dunlap wrote: > On 09/20/2012 09:05 AM, halfdog wrote: > >> halfdog wrote: >> >> Now this is the updated and also tested patch (vs. linux-3.5.4 kernel) to fix >> https://bugzilla.kernel.org/show_bug.cgi?id=46841 . See also >> http://www.halfdog.net/Security/2012/LinuxKernelBinfmtScriptStackD

Re: [PATCH 14/23] usb-acpi: Comply with the ACPI API change

2012-09-22 Thread Greg Kroah-Hartman
On Sun, Sep 23, 2012 at 12:34:02AM -0400, Len Brown wrote: > From: Feng Tang > > acpi_get_physical_device_location()'s 2nd argument has been changed > in ACPI implementaion, so need a follow-on change in > usb_acpi_check_pld(). > > Signed-off-by: Feng Tang > Signed-off-by: Bob Moore > Cc: Matt

Re: [PATCH 3/4] devpts: Make the newinstance option historical

2012-09-22 Thread Eric W. Biederman
Al Viro writes: > On Sat, Sep 22, 2012 at 08:50:44PM -0700, Eric W. Biederman wrote: > >> +struct inode *devpts_redirect(struct file *filp) >> +{ >> +struct inode *inode; >> +struct file *filp2; >> + >> +/* Is the inode already a devpts inode? */ >> +inode = filp->f_dentry->d_inod

[2.6.38-3.x] [BUG] soft lockup - CPU#X stuck for 23s! (vfs, autofs, vserver)

2012-09-22 Thread Paweł Sikora
Hi, a long time ago i reported an ugly soft lock of heavy loaded opteron system without usable backtraces :( recently, i've logged on 3.4.6 via serial console backtraces from all 16 cores which show some kind of vfs lock (http://pluto.agmk.net/kernel/oops.txt). this lock occurs on heavy loaded

Re: [PATCH 3/4] devpts: Make the newinstance option historical

2012-09-22 Thread Al Viro
On Sat, Sep 22, 2012 at 10:59:04PM -0700, Eric W. Biederman wrote: > The test: > >> + if (filp->f_vfsmnt->mnt_root == filp->f_dentry) > kicks in and no redirection is performed. Umm... OK, after the first round of recursion. Unless you bind /something/pts on /something. Or simply create a sym

Re: [PATCH 3/4] devpts: Make the newinstance option historical

2012-09-22 Thread Al Viro
On Sun, Sep 23, 2012 at 07:30:38AM +0100, Al Viro wrote: > On Sat, Sep 22, 2012 at 10:59:04PM -0700, Eric W. Biederman wrote: > > > The test: > > >> +if (filp->f_vfsmnt->mnt_root == filp->f_dentry) > > kicks in and no redirection is performed. > > Umm... OK, after the first round of recu

Re: [RFC] tty: Add get- ioctls to fetch tty status

2012-09-22 Thread Cyrill Gorcunov
On Sat, Sep 22, 2012 at 06:09:53PM -0700, Greg Kroah-Hartman wrote: > On Sun, Sep 23, 2012 at 01:52:32AM +0400, Cyrill Gorcunov wrote: > > On Sun, Sep 23, 2012 at 12:11:44AM +0400, Cyrill Gorcunov wrote: > > > > > > > Sysfs is one value per file, you have three values here, please make 3 > > > > fi

Re: [RFC] tty: Add get- ioctls to fetch tty status

2012-09-22 Thread Cyrill Gorcunov
On Sat, Sep 22, 2012 at 06:43:37PM -0700, Eric W. Biederman wrote: > > I don't know where this conversation comes from but putting ptys in > sysfs in combination with the newinstance mount option is completely > broken unless the device name and device number duplication is handled, > which I don'

<    1   2