Re: [PATCH v3] lib/siphash.c: annotate implicit fall throughs

2019-03-14 Thread Jason A. Donenfeld
Hi Mathieu, Thanks for getting this v3 into shape. On Wed, Mar 13, 2019 at 3:12 PM Mathieu Malaterre wrote: > There is a plan to build the kernel with -Wimplicit-fallthrough and > these places in the code produced warnings (W=1). Fix them up. > > This commit remove the following warnings: > >

Re: [PATCH 1/2] cifs: remove unused status severity defines

2019-03-14 Thread Steve French
updated it to fix the spelling mistake On Thu, Mar 14, 2019 at 1:54 AM Steve French wrote: > > Since this file (smb2status.h) is intended to track the official > protocol documentation (albeit smb2status.h probably needs to be > updated), in this case the protocol document MS-ERREF. I would pre

[PATCH] tty: ipwireless: fix missing checks for ioremap

2019-03-14 Thread Kangjie Lu
ipw->attr_memory and ipw->common_memory are assigned with the return value of ioremap. ioremap may fail, but not checks are enforced. The fix insertss the checks. Signed-off-by: Kangjie Lu --- drivers/tty/ipwireless/main.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/tty/

Re: [PATCH 1/2] cifs: remove unused status severity defines

2019-03-14 Thread Sergey Senozhatsky
On (03/14/19 01:54), Steve French wrote: > Since this file (smb2status.h) is intended to track the official > protocol documentation (albeit smb2status.h probably needs to be > updated), in this case the protocol document MS-ERREF. I would prefer > to keep it closer to MS-ERREF and leave definitio

Re: [PATCH] EDAC, {skx|i10nm}_edac: Fix randconfig build error

2019-03-14 Thread Arnd Bergmann
On Thu, Mar 14, 2019 at 12:01 AM Luck, Tony wrote: > > On Wed, Mar 06, 2019 at 09:15:13PM +0100, Arnd Bergmann wrote: > > On Wed, Mar 6, 2019 at 6:58 PM Luck, Tony wrote: > > > From: Qiuxu Zhuo > > > > > > This seems cleaner than adding all the EXPORTs to skx_common.c > > > I also tried a build

Re: [RFC PATCH RT] x86/tsc: Add option to disable tsc clocksource watchdog

2019-03-14 Thread Juri Lelli
Hi, On 07/03/19 13:09, Juri Lelli wrote: > Clocksource watchdog has been found responsible for generating latency > spikes (in the 10-20 us range) when woken up to check for TSC stability. > > Add an option to disable it at boot. Gentle ping. Does this make any sense? Thanks, - Juri

Re: [PATCH] kvm/x86/vmx: switch MSR_MISC_FEATURES_ENABLES between host and guest

2019-03-14 Thread Xiaoyao Li
Besides, Peter's this patch https://patchwork.kernel.org/patch/10850143/ adds the handling of cpuid faulting in #GP handler. What's more, it enalbes cpuid fauting once function *clear_cpu_cap()* called successfully. From my tests, during kernel booting, there always are some features cleared, thu

Re: [PATCH 1/2] cifs: remove unused status severity defines

2019-03-14 Thread Sergey Senozhatsky
On (03/14/19 02:04), Steve French wrote: [..] > #define STATUS_SEVERITY_SUCCESS __constant_cpu_to_le32(0x) Does STATUS_SEVERITY_SUCCESS still use __constant_cpu_to_le32? > -#define STATUS_SEVERITY_INFORMATIONAL __constanst_cpu_to_le32(0x0001) > -#define STATUS_SEVERITY_WARNING __constanst_cp

drivers/iio/chemical/sps30.c:122:30: sparse: cast truncates bits from constant value (8004 becomes 4)

2019-03-14 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: fa3d493f7a573b4e4e2538486e912093a0161c1b commit: 62129a0849d27cc94ced832bcf9dcde283dcbe08 iio: chemical: sps30: allow changing self cleaning period date: 8 weeks ago reproduce: # apt-get install sp

[PATCH] tty: atmel_serial: fix a NULL pointer dereference

2019-03-14 Thread Kangjie Lu
In case dmaengine_prep_dma_cyclic fails, the fix return a proper error code to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu --- drivers/tty/serial/atmel_serial.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/atmel_serial.c b/dr

Re: [PATCH 1/2] cifs: remove unused status severity defines

2019-03-14 Thread Steve French
All of those uses of __constant_cpu_to_le32 apparently (at least according to checkpatch) should be changed (someday) to cpu_to_le32 but I didn't research why the change from __constant_cpu_to_le32 ---> cpu_to_le32 If it has benefit - and checkpatch is right (it warned about __constant_cpu_to_le

[PATCH] tty: mxs-auart: fix a NULL pointer dereference

2019-03-14 Thread Kangjie Lu
In case ioremap fails, the fix returns -ENOMEM to avoid NULL pointer dereferences. Multiple places use port.membase. Signed-off-by: Kangjie Lu --- drivers/tty/serial/mxs-auart.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.

Re: [PATCH 0/2] add gpu node support on rock960 and rockpi4

2019-03-14 Thread Manivannan Sadhasivam
Hi, On Thu, Mar 14, 2019 at 12:48:40PM +0530, Akash Gajjar wrote: > add gpu node support on both rockchip-rk3399 board. > performance tested with freedesktop.org panfrost mali driver. > > Akash Gajjar (2): > arm64: dts: rockchip: add mali gpu support on rockpi4 > arm64: dts: rockchip: add mal

Re: overlayfs vs. fscrypt

2019-03-14 Thread Miklos Szeredi
On Wed, Mar 13, 2019 at 11:42 PM Richard Weinberger wrote: > > Am Mittwoch, 13. März 2019, 23:26:11 CET schrieb Eric Biggers: > > What specifically is wrong with supporting the ciphertext "view" of > > encrypted > > directories, and why do you want to opt UBIFS out of it specifically but not > >

Re: [PATCH 1/2] cifs: remove unused status severity defines

2019-03-14 Thread Sergey Senozhatsky
On (03/14/19 02:19), Steve French wrote: > All of those uses of __constant_cpu_to_le32 apparently (at least > according to checkpatch) should be changed (someday) to cpu_to_le32 > but I didn't research why the change from __constant_cpu_to_le32 > ---> cpu_to_le32 Probably historic reasons. Look

[PATCH] fs: affs: fix a NULL pointer dereference

2019-03-14 Thread Kangjie Lu
If affs_bread fails, do not use ext_bh to avoid NULL pointer dereference Signed-off-by: Kangjie Lu --- fs/affs/file.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/fs/affs/file.c b/fs/affs/file.c index a85817f54483..45b96faa40f1 100644 --- a/fs/affs/file.c +++ b

Re: [PATCH 07/34] vfs: Add configuration parser helpers [ver #12]

2019-03-14 Thread Geert Uytterhoeven
Hi David, On Fri, Sep 21, 2018 at 6:33 PM David Howells wrote: > Because the new API passes in key,value parameters, match_token() cannot be > used with it. Instead, provide three new helpers to aid with parsing: > --- a/fs/Kconfig > +++ b/fs/Kconfig > @@ -8,6 +8,13 @@ menu "File systems" > co

RE: [RESEND PATCH] PM / devfreq: Fix static checker warning in try_then_request_governor

2019-03-14 Thread MyungJoo Ham
>The patch 23c7b54ca1cd: "PM / devfreq: Fix devfreq_add_device() when >drivers are built as modules." leads to the following static checker >warning: > >drivers/devfreq/devfreq.c:1043 governor_store() >warn: 'governor' can also be NULL > >The reason is that the try_then_request_governor() f

Re: [Qestion] Hit a WARN_ON_ONCE in try_to_unmap_one when runing syzkaller

2019-03-14 Thread zhong jiang
On 2019/3/14 14:27, Naoya Horiguchi wrote: > Hi, > > On Wed, Mar 13, 2019 at 12:03:20AM +0800, zhong jiang wrote: > ... >> Minchan has changed the conditon check from BUG_ON to WARN_ON_ONCE in >> try_to_unmap_one. >> However, It is still an abnormal condition when PageSwapBacked is not equal >

vmscan: Reclaim unevictable pages

2019-03-14 Thread Pankaj Suryawanshi
Hello , shrink_page_list() returns , number of pages reclaimed, when pages is unevictable it returns VM_BUG_ON_PAGE(PageLRU(page) || PageUnevicatble(page),page); We can add the unevictable pages in reclaim list in shrink_page_list(), return total number of reclaim pages including unevictable

Re: [PATCH] mm: fix a wrong flag in set_migratetype_isolate()

2019-03-14 Thread Oscar Salvador
On Wed, Mar 13, 2019 at 05:25:07PM -0400, Qian Cai wrote: > Due to has_unmovable_pages() takes an incorrect irqsave flag instead of > the isolation flag in set_migratetype_isolate(), it causes issues with > HWPOSION and error reporting where dump_page() is not called when there > is an unmoveable p

Re: [PATCH] mm/hotplug: fix notification in offline error path

2019-03-14 Thread Oscar Salvador
On Wed, Mar 13, 2019 at 05:09:39PM -0400, Qian Cai wrote: > Fixes: 7960509329c2 ("mm, memory_hotplug: print reason for the offlining > failure") > Signed-off-by: Qian Cai Reviewed-by: Oscar Salvador > --- > mm/memory_hotplug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

[PATCH v2] btrfs: raid56: properly unmap parity page in finish_parity_scrub()

2019-03-14 Thread Andrea Righi
Parity page is incorrectly unmapped in finish_parity_scrub(), triggering a reference counter bug on i386, i.e.: [ 157.662401] kernel BUG at mm/highmem.c:349! [ 157.666725] invalid opcode: [#1] SMP PTI The reason is that kunmap(p_page) was completely left out, so we never did an unmap for t

[PATCH 0/2] add gpu node support on rock960 and rockpi4

2019-03-14 Thread Akash Gajjar
add gpu node support on both rockchip-rk3399 board. performance tested with freedesktop.org panfrost mali driver. Akash Gajjar (2): arm64: dts: rockchip: add mali gpu support on rockpi4 arm64: dts: rockchip: add mali gpu support on rock960 arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts |

Re: [PATCH] arch: arm: Kconfig: pedantic formatting

2019-03-14 Thread Krzysztof Hałasa
"Enrico Weigelt, metux IT consult" writes: > Formatting of Kconfig files doesn't look so pretty, so let the > Great White Handkerchief come around and clean it up. > > Signed-off-by: Enrico Weigelt, metux IT consult > --- > arch/arm/mach-ixp4xx/Kconfig | 32 ++--- Acked

Re: [PATCH 1/2] cifs: remove unused status severity defines

2019-03-14 Thread Steve French
I am fine with taking a patch to get rid of __constant_cpu_to_XXX (and converting to the same cpu_to_XXX with the "__constant") in fs/cifs (assuming that that is still recommended). On Thu, Mar 14, 2019 at 2:39 AM Sergey Senozhatsky wrote: > > On (03/14/19 02:19), Steve French wrote: > > All of

Re: [PATCH v2] mm/hotplug: fix offline undo_isolate_page_range()

2019-03-14 Thread Michal Hocko
On Wed 13-03-19 10:31:33, Qian Cai wrote: > The commit f1dd2cd13c4b ("mm, memory_hotplug: do not associate hotadded > memory to zones until online") introduced move_pfn_range_to_zone() which > calls memmap_init_zone() during onlining a memory block. > memmap_init_zone() will reset pagetype flags an

Re: [PATCH v2] mm/hotplug: fix offline undo_isolate_page_range()

2019-03-14 Thread Oscar Salvador
On Wed, Mar 13, 2019 at 10:31:33AM -0400, Qian Cai wrote: > Also, after calling the "useless" undo_isolate_page_range() here, it > reaches the point of no returning by notifying MEM_OFFLINE. Those pages > will be marked as MIGRATE_MOVABLE again once onlining. The only thing > left to do is to decre

Re: [PATCH v2] mm/hotplug: fix offline undo_isolate_page_range()

2019-03-14 Thread Oscar Salvador
On Wed, Mar 13, 2019 at 10:31:33AM -0400, Qian Cai wrote: > The commit f1dd2cd13c4b ("mm, memory_hotplug: do not associate hotadded > memory to zones until online") introduced move_pfn_range_to_zone() which > calls memmap_init_zone() during onlining a memory block. > memmap_init_zone() will reset p

[PATCH 1/2] arm64: dts: rockchip: add mali gpu support on rockpi4

2019-03-14 Thread Akash Gajjar
add gpu node support on board and add the supplying regulator Signed-off-by: Akash Gajjar Signed-off-by: Andrius Štikonas --- arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts b/arch/arm6

[GIT PULL] arch/microblaze patches for 5.1-rc1

2019-03-14 Thread Michal Simek
Hi, please pull the following patch to your tree. Thanks, Michal The following changes since commit bfeffd155283772bbe78c6a05dec7c0128ee500c: Linux 5.0-rc1 (2019-01-06 17:08:20 -0800) are available in the git repository at: git://git.monstr.eu/linux-2.6-microblaze.git tags/microblaze-v5.

Re: [PATCH] spi: fix NULL pointer dereferences by checking dmaengine_prep_slave_sg

2019-03-14 Thread Krzysztof Kozlowski
On Thu, 14 Mar 2019 at 07:42, Kangjie Lu wrote: > > In case dmaengine_prep_slave_sg fails, the fix returns to avoid > NULL pointer dereference. > > Signed-off-by: Kangjie Lu Hi, Thanks for the patch, but the fix is the same as here: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1

Re: [PATCH v2] mm/hotplug: fix offline undo_isolate_page_range()

2019-03-14 Thread Michal Hocko
On Thu 14-03-19 09:09:22, Oscar Salvador wrote: > On Wed, Mar 13, 2019 at 10:31:33AM -0400, Qian Cai wrote: > > Also, after calling the "useless" undo_isolate_page_range() here, it > > reaches the point of no returning by notifying MEM_OFFLINE. Those pages > > will be marked as MIGRATE_MOVABLE agai

Re: vmscan: Reclaim unevictable pages

2019-03-14 Thread Pankaj Suryawanshi
Below is the Error Msg : [ 24.718792] page dumped because: VM_BUG_ON_PAGE(PageLRU(page) || PageUnevictable(page)) [ 24.726949] page->mem_cgroup:bd008c00 [ 24.730693] [ cut here ] [ 24.735304] kernel BUG at mm/vmscan.c:1350! [ 24.739478] Internal error: Oops - B

Re: [RESEND PATCH] mm/compaction: fix an undefined behaviour

2019-03-14 Thread Vlastimil Babka
On 3/13/19 7:06 PM, Qian Cai wrote: > In a low-memory situation, cc->fast_search_fail can keep increasing as > it is unable to find an available page to isolate in > fast_isolate_freepages(). As the result, it could trigger an error > below, so just compare with the maximum bits can be shifted firs

Re: [PATCH v3 2/9] mtd: rawnand: denali: refactor syndrome layout handling for raw access

2019-03-14 Thread Masahiro Yamada
Hi Miquel, On Tue, Mar 12, 2019 at 10:13 PM Miquel Raynal wrote: > > Hi Masahiro, > > Masahiro Yamada wrote on Tue, 12 Mar > 2019 20:07:27 +0900: > > > Hi Miquel, > > > > > > On Tue, Mar 12, 2019 at 7:54 PM Miquel Raynal > > wrote: > > > > > > Hi Masahiro, > > > > > > Masahiro Yamada wrote on

Re: [PATCH] mm: compaction: show gfp flag names in try_to_compact_pages tracepoint

2019-03-14 Thread Vlastimil Babka
On 3/2/19 5:38 AM, Yafang Shao wrote: > show the gfp flag names instead of the gfp_mask could make the trace > more convenient. > > Signed-off-by: Yafang Shao Acked-by: Vlastimil Babka > --- > include/trace/events/compaction.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > d

[PATCH] staging: rtl8723bs: do not use __constant_cpu_to_le16

2019-03-14 Thread Sergey Senozhatsky
A trivial patch. cpu_to_le16() is capable enough to detect __builtin_constant_p() and to use an appropriate compile time ___constant_swahbXX() function. So we can use cpu_to_le16() instead of __constant_cpu_to_le16(). Signed-off-by: Sergey Senozhatsky --- drivers/staging/rtl8723bs/include/wifi

Re: [PATCH] tty: atmel_serial: fix a NULL pointer dereference

2019-03-14 Thread Richard Genoud
Hi, Good catch ! Le 14/03/2019 à 08:17, Kangjie Lu a écrit : > In case dmaengine_prep_dma_cyclic fails, the fix return a proper > error code to avoid NULL pointer dereference. > you could add: Fixes: 34df42f59a60 ("serial: at91: add rx dma support") So that -stable branches get this. > Signed-of

Re: [PATCH v4] lib/string.c: implement a basic bcmp

2019-03-14 Thread Andy Shevchenko
On Wed, Mar 13, 2019 at 02:13:31PM -0700, Nick Desaulniers wrote: > A recent optimization in Clang (r355672) lowers comparisons of the > return value of memcmp against zero to comparisons of the return value > of bcmp against zero. This helps some platforms that implement bcmp > more efficiently t

Re: fs/notify/fanotify/fanotify.c:198:2: note: in expansion of macro 'pr_warn_ratelimited'

2019-03-14 Thread Jan Kara
AFAICS this is the known problem with weird mips definitions of __kernel_fsid_t which uses long whereas all other architectures use int, right? Seeing that mips can actually have 8-byte longs, I guess this bogosity is just wired in the kernel API and we cannot easily fix it in mips (mips guys, corr

[PATCH] jffs2: do not use __constant_cpu_to_xx

2019-03-14 Thread Sergey Senozhatsky
A trivial patch. cpu_to_XX() functions are smart enough to detect and handle __builtin_constant_p() at compile time. So we can use cpu_to_XX() instead of __constant_cpu_to_XX(). Signed-off-by: Sergey Senozhatsky --- fs/jffs2/nodelist.h | 8 1 file changed, 4 insertions(+), 4 deletions

Re: [LKP] [x86, retpolines] ce02ef06fc: will-it-scale.per_thread_ops 3.1% improvement

2019-03-14 Thread Daniel Borkmann
On 03/13/2019 06:27 AM, kernel test robot wrote: > Greeting, > > FYI, we noticed a 3.1% improvement of will-it-scale.per_thread_ops due to > commit: > > > commit: ce02ef06fcf7a399a6276adb83f37373d10cbbe1 ("x86, retpolines: Raise > limit for generating indirect calls from switch-case") > https:

Re: vmscan: Reclaim unevictable pages

2019-03-14 Thread Michal Hocko
On Thu 14-03-19 08:23:10, Pankaj Suryawanshi wrote: > > Below is the Error Msg : > > [ 24.718792] page dumped because: VM_BUG_ON_PAGE(PageLRU(page) || > PageUnevictable(page)) > [ 24.726949] page->mem_cgroup:bd008c00 > [ 24.730693] [ cut here ] > [ 24.735304] kern

Re: [PATCH] kvm/x86/vmx: switch MSR_MISC_FEATURES_ENABLES between host and guest

2019-03-14 Thread Kyle Huey
On Thu, Mar 14, 2019 at 7:50 PM Xiaoyao Li wrote: > > CPUID Faulting is a feature about CPUID instruction. When CPUID Faulting is > enabled, all execution of the CPUID instruction outside system-management > mode (SMM) cause a general-protection (#GP) if the CPL > 0. > > About this feature, detail

[PATCH 2/2] arm64: dts: rockchip: add mali gpu support on rock960

2019-03-14 Thread Akash Gajjar
add gpu node support on board and add the supplying regulator Signed-off-by: Akash Gajjar Signed-off-by: Andrius Štikonas --- arch/arm64/boot/dts/rockchip/rk3399-rock960.dts | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts b/arch/arm64/bo

Мотивиран персонал

2019-03-14 Thread Martin Adamov
Здравейте, Ваучерите за храна се нареждат сред любимите социални придобивки на работещите хора и сред най-предпочитаните начини за стимулиране от работодателите. Те подобряват ефективността и производителността на Вашите служители. Благодарение на ваучерите за храна реализирате спестявания –

Re: [External] Re: vmscan: Reclaim unevictable pages

2019-03-14 Thread Pankaj Suryawanshi
I am using kernel version 4.14.65 (on Android pie [ARM]). No additional patches applied on top of vanilla.(Core MM). If  I change in the vmscan.c as below patch, it will work. Regards, Pankaj From: Michal Hocko Sent: 14 March 2019 14:11:20 To: Pankaj Suryawanshi Cc: linux-kernel@vger.

[PATCH] ALSA: hda/realtek: Enable headset MIC of Acer AIO with ALC286

2019-03-14 Thread Jian-Hong Pan
Some Acer AIO desktops like Veriton Z6860G, Z4860G and Z4660G cannot record sound from headset MIC. This patch adds the ALC286_FIXUP_ACER_AIO_HEADSET_MIC quirk to fix this issue. Signed-off-by: Jian-Hong Pan --- sound/pci/hda/patch_realtek.c | 17 ++--- 1 file changed, 14 insertions

[PATCH] iio: pms7003: sleect IIO_TRIGGERED_BUFFER

2019-03-14 Thread Arnd Bergmann
Without IIO_TRIGGERED_BUFFER, this driver fails to link: drivers/iio/chemical/pms7003.o: In function `pms7003_probe': pms7003.c:(.text+0x21c): undefined reference to `devm_iio_triggered_buffer_setup' pms7003.c:(.text+0x21c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol

Re: [PATCH v7 10/12] perf report: implement record trace decompression

2019-03-14 Thread Jiri Olsa
On Wed, Mar 13, 2019 at 06:55:29PM +0300, Alexey Budankov wrote: > > On 13.03.2019 17:37, Jiri Olsa wrote: > > On Tue, Mar 12, 2019 at 08:36:18AM +0300, Alexey Budankov wrote: > > > > SBIP > > > >> +#ifdef HAVE_ZSTD_SUPPORT > >> +static int perf_session__process_compressed_event(struct perf_sess

Re: [PATCH v3 0/1] mm: introduce put_user_page*(), placeholder versions

2019-03-14 Thread Jan Kara
On Wed 13-03-19 19:16:51, Christopher Lameter wrote: > On Tue, 12 Mar 2019, Jerome Glisse wrote: > > > > > This has been discuss extensively already. GUP usage is now widespread > > > > in > > > > multiple drivers, removing that would regress userspace ie break > > > > existing > > > > applicati

Re: [PATCH v3 0/1] mm: introduce put_user_page*(), placeholder versions

2019-03-14 Thread Jan Kara
On Wed 13-03-19 19:21:37, Christopher Lameter wrote: > On Wed, 13 Mar 2019, Christoph Hellwig wrote: > > > On Wed, Mar 13, 2019 at 09:11:13AM +1100, Dave Chinner wrote: > > > On Tue, Mar 12, 2019 at 03:39:33AM -0700, Ira Weiny wrote: > > > > IMHO I don't think that the copy_file_range() is going t

Re: [PATCH -mmotm/-next] fs: fs_parser: fix printk format warning

2019-03-14 Thread Geert Uytterhoeven
On Sat, Feb 9, 2019 at 4:21 AM Randy Dunlap wrote: > From: Randy Dunlap > > Fix printk format warning (seen on i386 builds) by using ptrdiff > format specifier (%t): > > ../fs/fs_parser.c:413:6: warning: format ‘%lu’ expects argument of type ‘long > unsigned int’, but argument 3 has type ‘int’ [

Re: [greybus-dev] [PATCH] greybus: audio_manager: fix a missing check of ida_simple_get

2019-03-14 Thread Viresh Kumar
On 14-03-19, 01:45, Kangjie Lu wrote: > ida_simple_get could fail. The fix inserts a check for its > return value. > > Signed-off-by: Kangjie Lu > --- > drivers/staging/greybus/audio_manager.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/staging/greybus/audio_manager.c >

Re: [PATCH 4/5] lib/list_sort: Simplify and remove MAX_LIST_LENGTH_BITS

2019-03-14 Thread Andy Shevchenko
On Tue, Mar 05, 2019 at 03:06:44AM +, George Spelvin wrote: > Rather than a fixed-size array of pending sorted runs, use the ->prev > links to keep track of things. This reduces stack usage, eliminates > some ugly overflow handling, and reduces the code size. > > Also: > * merge() no longer n

Béren kívüli juttatások

2019-03-14 Thread László Péter
Üdvözlöm! 2019-től a legtöbb kiegészítő juttatás jövedelemként fog adózni (kivételt képez a SZÉP kártya). Juttatási kártyáinknak köszönhetően könnyebben nyerhet meg új tehetségeket, könnyebben tarthatja meg dolgozóit, és növelheti motivációjukat. Kártyáink tetszőleges célokra használhatók fel:

[PATCH] crypto: ccree - reduce kernel stack usage with clang

2019-03-14 Thread Arnd Bergmann
Building with clang for a 32-bit architecture runs over the stack frame limit in the setkey function: drivers/crypto/ccree/cc_cipher.c:318:12: error: stack frame size of 1152 bytes in function 'cc_cipher_setkey' [-Werror,-Wframe-larger-than=] The problem is that there are two large variables: th

Re: [RFC PATCH v1 00/25] printk: new implementation

2019-03-14 Thread Petr Mladek
On Tue 2019-03-12 16:15:55, John Ogness wrote: > On 2019-03-12, Petr Mladek wrote: > > On Tue 2019-03-12 09:17:49, John Ogness wrote: > >> The current printk implementation is handling all console printing as > >> best effort. Trying hard enough to dramatically affect the system, but > >> not tryi

Re: [PATCH V2 2/5] pwm: Add i.MX TPM PWM driver support

2019-03-14 Thread Uwe Kleine-König
On Wed, Mar 13, 2019 at 07:31:16AM +, Anson Huang wrote: > i.MX7ULP has TPM(Low Power Timer/Pulse Width Modulation Module) > inside, add TPM PWM driver support. > > Signed-off-by: Anson Huang > --- > Changes since V1: > - improve coding style, function name's prefix; > - improve K

[PATCH 1/1] Smack: Create smack_rule cache to optimize memory usage

2019-03-14 Thread Vishal Goel
This patch allows for small memory optimization by creating the kmem cache for "struct smack_rule" instead of using kzalloc. For adding new smack rule, kzalloc is used to allocate the memory for "struct smack_rule". kzalloc will always allocate 32 or 64 bytes for 1 structure depending upon the kzal

RE: [RFC 2/2] PCI: imx6: Add support for i.MX8QM/QXP PCIe

2019-03-14 Thread Richard Zhu
Hi Andrey: Thanks a lot for your review comments. Best Regards Richard Zhu Office: 86-21-28937189 Mobile: 86-13386059786 > -Original Message- > From: Andrey Smirnov [mailto:andrew.smir...@gmail.com] > Sent: 2019年3月14日 4:20 > To: Richard Zhu > Cc: bhelg...@google.com; lorenzo.pieral...@a

Re: [PATCH V2 2/5] pwm: Add i.MX TPM PWM driver support

2019-03-14 Thread Uwe Kleine-König
On Thu, Mar 14, 2019 at 10:17:02AM +0100, Uwe Kleine-König wrote: > I didn't look in depth through the complete driver yet, but there is > IIRC still some feedback on v1 that wasn't addressed in v2 (because v2 > was sent before the last feedback). So I will look in more depth in v3 > (assuming it c

Re: [PATCH V3 2/5] pwm: Add i.MX TPM PWM driver support

2019-03-14 Thread Uwe Kleine-König
On Thu, Mar 14, 2019 at 06:27:20AM +, Anson Huang wrote: > i.MX7ULP has TPM(Low Power Timer/Pulse Width Modulation Module) > inside, add TPM PWM driver support. > > Signed-off-by: Anson Huang > --- > Changes since V2: > - Add "IMX_" as prefix to macro define as TPM is already used; >

RE: [PATCH] ALSA: hda/realtek: Enable headset MIC of Acer AIO with ALC286

2019-03-14 Thread Kailang
Hi, Don't do this coef setting. It will always assign it for iphone type. You could dump alsa-info for me with dump coef bit. Also please plugged headset to dump. BR, Kailang -Original Message- From: Jian-Hong Pan Sent: Thursday, March 14, 2019 5:00 PM To: Takashi Iwai Cc: Kailang ; a

Re: Re: [External] Re: vmscan: Reclaim unevictable pages

2019-03-14 Thread Kirill Tkhai
On 14.03.2019 11:52, Pankaj Suryawanshi wrote: > > I am using kernel version 4.14.65 (on Android pie [ARM]). > > No additional patches applied on top of vanilla.(Core MM). > > If  I change in the vmscan.c as below patch, it will work. Sorry, but 4.14.65 does not have braces around trylock_page

Re: [RFC PATCH v1 00/25] printk: new implementation

2019-03-14 Thread Petr Mladek
On Wed 2019-03-13 18:27:59, Sergey Senozhatsky wrote: > On (03/13/19 09:40), Sebastian Siewior wrote: > > On 2019-03-13 09:19:32 [+0100], John Ogness wrote: > > > recursive situation. As you are pointing out, the notification/wake > > > component of printk_safe will still be needed. I will leave th

Re: [PATCH 0/7] cpufreq: Call transition notifier only once for each policy

2019-03-14 Thread Rafael J. Wysocki
On Thu, Mar 14, 2019 at 7:43 AM Viresh Kumar wrote: > > Currently we call the cpufreq transition notifiers once for each CPU of > the policy->cpus cpumask, which isn't that efficient. Why isn't it efficient? Transitions are per-policy anyway, so if something needs to be done for each CPU in the

Re: [PATCH 1/5] lib/sort: Make swap functions more generic

2019-03-14 Thread Andy Shevchenko
On Sat, Mar 09, 2019 at 03:53:41PM +, l...@sdf.org wrote: > Andy Shevchenko wrote: > > On Thu, Feb 21, 2019 at 06:30:28AM +, George Spelvin wrote: > >> +#ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS > > > > Why #ifdef is better than if (IS_ENABLED()) ? > > Because CONFIG_HAVE_EFFICIENT_UN

Re: [PATCH 1/4] leds: netdev trigger: use memcpy in device_name_store

2019-03-14 Thread Uwe Kleine-König
Hello, On Wed, Mar 13, 2019 at 09:26:12PM +0100, Rasmus Villemoes wrote: > --- a/drivers/leds/trigger/ledtrig-netdev.c > +++ b/drivers/leds/trigger/ledtrig-netdev.c > @@ -122,7 +122,8 @@ static ssize_t device_name_store(struct device *dev, > trigger_data->net_dev = NULL; > } >

Re: [RFC 1/2] dt-bindings: imx6q-pcie: Add support for i.MX8QM/QXP PCIe

2019-03-14 Thread Lucas Stach
Hi Richard, Am Mittwoch, den 13.03.2019, 09:15 + schrieb Richard Zhu: > Add codes needed to support i.MX8QM/QXP PCIe. > - HSIO(High Speed IO) subsystem is new defined on i.MX8QM/QXP. >   The PCIe and SATA modules are contained in the HSIO subsystem. There >   are two PCIe, one SATA controllers

Re: [PATCH 2/4] leds: netdev trigger: factor out middle part of device_name_store

2019-03-14 Thread Uwe Kleine-König
Hello, On Wed, Mar 13, 2019 at 09:26:13PM +0100, Rasmus Villemoes wrote: > +static void set_device(struct led_netdev_data *trigger_data, > +const char *buf, size_t size) "set_device" is a very generic name. Can you please prefix it with "ledtrig_netdev_"? Best regards Uwe --

Re: [PATCH 5/7] x86/tsc: Update cpufreq transition notifier to handle multiple CPUs

2019-03-14 Thread Rafael J. Wysocki
On Thu, Mar 14, 2019 at 7:43 AM Viresh Kumar wrote: > > The cpufreq core currently calls the cpufreq transition notifier > callback once for each affected CPU. This is going to change soon and > the cpufreq core will call the callback only once for each cpufreq > policy. The callback must look at

Re: [RFC PATCH v1 00/25] printk: new implementation

2019-03-14 Thread John Ogness
On 2019-03-14, Petr Mladek wrote: >>> I suggest the following way forward (separate patchsets): >>> >>> 1. Replace log buffer (least controversial thing) >> >> Yes. I will post a series that only implements the ringbuffer using >> your simplified API. That will be enough to remove printk_safe

Re: [PATCH v4 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc

2019-03-14 Thread Pavel Machek
Hi! Could you maybe slow down a bit. "Hey, I should review this". "Hmm, there are two new versions in the mailbox in the meantime, good thing I waited." > + ramp-up-ms = <1024>; > + ramp-down-ms = <65536>; This is wrong. > + led@1 { > + reg = <1>; > + led-so

Re: [PATCH V3 2/5] pwm: Add i.MX TPM PWM driver support

2019-03-14 Thread Claudiu.Beznea
On 14.03.2019 08:27, Anson Huang wrote: > i.MX7ULP has TPM(Low Power Timer/Pulse Width Modulation Module) > inside, add TPM PWM driver support. > > Signed-off-by: Anson Huang > --- > Changes since V2: > - Add "IMX_" as prefix to macro define as TPM is already used; > - Use macro def

Re: [PATCH 0/7] cpufreq: Call transition notifier only once for each policy

2019-03-14 Thread Rafael J. Wysocki
On Thu, Mar 14, 2019 at 10:28 AM Rafael J. Wysocki wrote: > > On Thu, Mar 14, 2019 at 7:43 AM Viresh Kumar wrote: > > > > Currently we call the cpufreq transition notifiers once for each CPU of > > the policy->cpus cpumask, which isn't that efficient. > > Why isn't it efficient? > > Transitions a

Re: mm/memory.c:3968:21: sparse: incorrect type in assignment (different base types)

2019-03-14 Thread Souptick Joarder
Hi Kbuild, On Thu, Mar 14, 2019 at 12:50 AM kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 5453a3df2a5eb49bc24615d4cf0d66b2aae05e5f > commit: 3d3539018d2cbd12e5af4a132636ee7fd8d43ef0 mm: create the new > vm_fault_t type

Re: [PATCH 4/5] lib/list_sort: Simplify and remove MAX_LIST_LENGTH_BITS

2019-03-14 Thread George Spelvin
On Thu, 14 Mar 2019 at 11:10:41 +0200, Andy Shevchenko wrote: > On Tue, Mar 05, 2019 at 03:06:44AM +, George Spelvin wrote: >> +/* Do merges corresponding to set lsbits in count */ > >> +for (bit = 1; count & bit; bit <<= 1) { >> +cur = merge(priv, (c

Re: [PATCH] mm: vmscan: drop may_writepage and classzone_idx from direct reclaim begin template

2019-03-14 Thread Yafang Shao
On Fri, Mar 1, 2019 at 2:24 PM Yafang Shao wrote: > > There are three tracepoints using this template, which are > mm_vmscan_direct_reclaim_begin, > mm_vmscan_memcg_reclaim_begin, > mm_vmscan_memcg_softlimit_reclaim_begin. > > Regarding mm_vmscan_direct_reclaim_begin, > sc.may_writepage is !laptop

[PATCH v4 0/6] Several patches to fix code bugs, improve documents and clean up

2019-03-14 Thread Baoquan He
This is v4 post. The v3 post can be found here: http://lkml.kernel.org/r/20190216140008.28671-1-...@redhat.com The v2 post was here: https://lkml.org/lkml/2018/9/9/56 This patchset includes the original three code bug fix patches in v2, and two new patches to improve code comments about kaslr_mem

[PATCH v4 1/6] x86/mm/KASLR: Improve code comments about struct kaslr_memory_region

2019-03-14 Thread Baoquan He
The old comment above kaslr_memory_region is not clear enough to explain the concepts of memory region KASLR. [Ingo suggested this and helped to prettify the text] Signed-off-by: Baoquan He --- arch/x86/mm/kaslr.c | 51 + 1 file changed, 47 insertions

[PATCH v4 2/6] x86/mm/KASLR: Open code unnecessary function get_padding

2019-03-14 Thread Baoquan He
It's used only twice and we do bit shifts in the parent function anyway so it's not like it's hiding some uninteresting detail. Signed-off-by: Baoquan He Acked-by: Kees Cook --- arch/x86/mm/kaslr.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/arch/x86/mm/kaslr.

[PATCH v4 3/6] mm: Add build time sanity check for struct page size

2019-03-14 Thread Baoquan He
Size of struct page might be larger than 64 bytes if debug options enabled, or fields added for debugging intentionally. Yet an upper limit need be added at build time to trigger an alert in case the size is too big to boot up system, warning people to check if it's be done on purpose in advance.

[PATCH v4 4/6] x86/mm/KASLR: Fix the wrong calculation of memory region initial size

2019-03-14 Thread Baoquan He
In memory region KASLR, __PHYSICAL_MASK_SHIFT is taken to calculate the initial size of the direct mapping region. This is correct in the old code where __PHYSICAL_MASK_SHIFT was equal to MAX_PHYSMEM_BITS, 46 bits, and only 4-level mode was supported. Later, in commit: b83ce5ee91471d ("x86/mm/64:

[PATCH v4 5/6] x86/mm/KASLR: Calculate the actual size of vmemmap region

2019-03-14 Thread Baoquan He
Vmemmap region has different maximum size depending on paging mode. Now its size is hardcoded as 1TB in memory KASLR, this is not right for 5-level paging mode. It will cause overflow if vmemmap region is randomized to be adjacent to cpu_entry_area region and its actual size is bigger than 1 TB. S

[PATCH v4 6/6] x86/mm/KASLR: Do not adapt the size of the direct mapping region for SGI UV system

2019-03-14 Thread Baoquan He
On SGI UV system, kernel often hangs when KASLR is enabled. Disabling KASLR makes kernel work well. The back trace is: kernel BUG at arch/x86/mm/init_64.c:311! invalid opcode: [#1] SMP [...] RIP: 0010:__init_extra_mapping+0x188/0x196 [...] Call Trace: init_extra_mapping_uc+0x13/0x15 map_hi

RE: [PATCH V2 2/5] pwm: Add i.MX TPM PWM driver support

2019-03-14 Thread Anson Huang
Hi, Uwe Best Regards! Anson Huang > -Original Message- > From: Uwe Kleine-König [mailto:u.kleine-koe...@pengutronix.de] > Sent: 2019年3月14日 17:17 > To: Anson Huang > Cc: thierry.red...@gmail.com; robh...@kernel.org; mark.rutl...@arm.com; > shawn...@kernel.org; s.ha...@pengutronix.de; ker.

Re: [PATCH v4 3/6] mm: Add build time sanity check for struct page size

2019-03-14 Thread Baoquan He
On 03/14/19 at 05:46pm, Baoquan He wrote: > Size of struct page might be larger than 64 bytes if debug options > enabled, or fields added for debugging intentionally. Yet an upper > limit need be added at build time to trigger an alert in case the > size is too big to boot up system, warning people

RE: [PATCH v4] lib/string.c: implement a basic bcmp

2019-03-14 Thread David Laight
From: Nick Desaulniers > Sent: 13 March 2019 21:14 ... > diff --git a/include/linux/string.h b/include/linux/string.h > index 7927b875f80c..6ab0a6fa512e 100644 > --- a/include/linux/string.h > +++ b/include/linux/string.h > @@ -150,6 +150,9 @@ extern void * memscan(void *,int,__kernel_size_t); > #

Re: [PATCH 1/4] leds: netdev trigger: use memcpy in device_name_store

2019-03-14 Thread Rasmus Villemoes
On 14/03/2019 10.29, Uwe Kleine-König wrote: > Hello, > > On Wed, Mar 13, 2019 at 09:26:12PM +0100, Rasmus Villemoes wrote: >> --- a/drivers/leds/trigger/ledtrig-netdev.c >> +++ b/drivers/leds/trigger/ledtrig-netdev.c >> @@ -122,7 +122,8 @@ static ssize_t device_name_store(struct device *dev, >>

Re: [PATCH v4 3/6] mm: Add build time sanity check for struct page size

2019-03-14 Thread Baoquan He
On 03/14/19 at 05:50pm, Baoquan He wrote: > On 03/14/19 at 05:46pm, Baoquan He wrote: > > Size of struct page might be larger than 64 bytes if debug options > > enabled, or fields added for debugging intentionally. Yet an upper > > limit need be added at build time to trigger an alert in case the >

Re: [PATCH 2/4] leds: netdev trigger: factor out middle part of device_name_store

2019-03-14 Thread Rasmus Villemoes
On 14/03/2019 10.31, Uwe Kleine-König wrote: > Hello, > > On Wed, Mar 13, 2019 at 09:26:13PM +0100, Rasmus Villemoes wrote: >> +static void set_device(struct led_netdev_data *trigger_data, >> + const char *buf, size_t size) > > "set_device" is a very generic name. Can you please

Re: [PATCH V2 2/5] pwm: Add i.MX TPM PWM driver support

2019-03-14 Thread Uwe Kleine-König
Hello, On Thu, Mar 14, 2019 at 09:49:06AM +, Anson Huang wrote: > > On Wed, Mar 13, 2019 at 07:31:16AM +, Anson Huang wrote: > > > +static void imx_tpm_pwm_config(struct pwm_chip *chip, > > > +struct pwm_device *pwm, > > > +struct pwm_state *

Re: [PATCH 5/7] x86/tsc: Update cpufreq transition notifier to handle multiple CPUs

2019-03-14 Thread Viresh Kumar
On 14-03-19, 10:33, Rafael J. Wysocki wrote: > On Thu, Mar 14, 2019 at 7:43 AM Viresh Kumar wrote: > > - set_cyc2ns_scale(tsc_khz, freq->cpu, rdtsc()); > > + if (boot_cpu) { > > + boot_cpu_data.loops_per_jiffy = lpj; > > + } else { >

Re: [PATCH 1/4] leds: netdev trigger: use memcpy in device_name_store

2019-03-14 Thread Uwe Kleine-König
On Thu, Mar 14, 2019 at 10:57:14AM +0100, Rasmus Villemoes wrote: > On 14/03/2019 10.29, Uwe Kleine-König wrote: > > Hello, > > > > On Wed, Mar 13, 2019 at 09:26:12PM +0100, Rasmus Villemoes wrote: > >> --- a/drivers/leds/trigger/ledtrig-netdev.c > >> +++ b/drivers/leds/trigger/ledtrig-netdev.c >

Re: [PATCH] firewire: mark expected switch fall-throughs

2019-03-14 Thread Stefan Richter
(added Cc: Mathieu Malaterre, who sent a patch which is a subset of this) On Feb 11 Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/firewire/core-d

Re: [PATCH 1/5] lib/sort: Make swap functions more generic

2019-03-14 Thread George Spelvin
On Sat, 09 Mar 2019 at 23:19:49 +0300, Andrey Abramov wrote: >> Although I'm thinking of: >> >> static bool __attribute_const__ >> is_aligned(const void *base, size_t size, unsigned char align) >> { >> unsigned char lsbits = (unsigned char)size; >> >> (void)base; >> #ifndef CONFIG_HAVE_EF

Re: [PATCH 1/5] lib/sort: Make swap functions more generic

2019-03-14 Thread George Spelvin
On Sat, 09 Mar 2019 at 23:19:49 +0300, Andrey Abramov wrote: >> Although I'm thinking of: >> >> static bool __attribute_const__ >> is_aligned(const void *base, size_t size, unsigned char align) >> { >> unsigned char lsbits = (unsigned char)size; >> >> (void)base; >> #ifndef CONFIG_HAVE_EF

Re: [PATCH 1/4] leds: netdev trigger: use memcpy in device_name_store

2019-03-14 Thread Pavel Machek
Hi! > If userspace doesn't end the input with a newline (which can easily > happen if the write happens from a C program that does write(fd, > iface, strlen(iface))), we may end up including garbage from a > previous, longer value in the device_name. For example > > # cat device_name > > # print

  1   2   3   4   5   6   >