Re: autofs: use __kernel_write() for the autofs pipe writing causes regression in -next was Re: 5.9.0-next-20201015: autofs oops in update-binfmts

2020-10-17 Thread Linus Torvalds
On Sat, Oct 17, 2020 at 12:48 PM Pavel Machek wrote: > > But: you are the last one to sign it off, so I assume committed it to > git, and you are the one to talk to about fixing it. The thing is, the commit you point to - and the one I signed off on - is fine. The buggy one is in linux-next, whi

Re: [PATCH] fat: Add KUnit tests for checksums and timestamps

2020-10-17 Thread kernel test robot
ttps://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/David-Gow/fat-Add-KUnit-tests-for-checksums-and-timestamps/20201017-144157 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 071a0578b0ce0b0e543d1e38ee6926b9cc21c198 config: m68k-al

Re: [PATCH 3/3] serial: 8250_dw: Fix clk-notifier/port suspend deadlock

2020-10-17 Thread Jonathan Liu
On Wed, 23 Sep 2020 at 16:19, Serge Semin wrote: > > It has been discovered that there is a potential deadlock between > the clock-change-notifier thread and the UART port suspending one: > >CPU0 (suspend CPU/UART) CPU1 (update clock) > >lock(&por

Re: [PATCH v7 6/6] rcu/segcblist: Add additional comments to explain smp_mb()

2020-10-17 Thread joel
On Sat, Oct 17, 2020 at 03:29:54PM +0200, Frederic Weisbecker wrote: > On Fri, Oct 16, 2020 at 11:19:41PM -0400, j...@joelfernandes.org wrote: > > On Fri, Oct 16, 2020 at 09:27:53PM -0400, j...@joelfernandes.org wrote: > > [..] > > > > > + * > > > > > + * Memory barrier is needed after adding to le

Re: [RFC 13/13] m68k: mac: convert to generic clockevent

2020-10-17 Thread Finn Thain
On Thu, 15 Oct 2020, Arnd Bergmann wrote: > On Thu, Oct 15, 2020 at 3:19 AM Finn Thain wrote: > > > > On Sat, 10 Oct 2020, Arnd Bergmann wrote: > > > > > > Perhaps patch 13 does not belong in this series (?). > > > > > > > > All m68k platforms will need conversion before the TODO can be removed >

Re: [PATCH v2] iio:core: In map_array_register() cleanup in case of error

2020-10-17 Thread Lino Sanfilippo
Hi Andy, Thanks for you suggestion. I agree that it is nicer to reuse the cleanup in iio_map_array_unregister() than to reimplement it. However I would like to avoid dropping and regaining the mutex in case of error. What about the attached approach: Introduce an unlocked version of iio_map_array

[PATCH 1/2] iio:core: Introduce unlocked version of iio_map_array_unregister()

2020-10-17 Thread Lino Sanfilippo
Introduce an unlocked version of iio_map_array_unregister(). This function can help to unwind in case of error while the iio_map_list_lock mutex is held. Signed-off-by: Lino Sanfilippo --- drivers/iio/inkern.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) di

[PATCH 2/2] iio:core: In iio_map_array_register() cleanup in case of error.

2020-10-17 Thread Lino Sanfilippo
In function iio_map_array_register() properly rewind in case of error. Signed-off-by: Lino Sanfilippo --- drivers/iio/inkern.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c index 39c1d63..fe30bcb 100644 --- a/drivers/iio/inkern.c +++ b/drivers/

Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-17 Thread Jann Horn
On Sat, Oct 17, 2020 at 8:09 PM Alexander Graf wrote: > There are applications way beyond that though. What do you do with > applications that already consumed randomness? For example a cached pool > of SSL keys. Or a higher level language primitive that consumes > randomness and caches its seed s

Re: [PATCH v2 1/2] arm64: dts: broadcom: clear the warnings caused by empty dma-ranges

2020-10-17 Thread Leizhen (ThunderTown)
On 2020/10/17 3:27, Florian Fainelli wrote: > On 10/16/20 11:23 AM, Arnd Bergmann wrote: >> On Fri, Oct 16, 2020 at 6:48 PM Florian Fainelli >> wrote: >>> On 10/16/20 4:01 AM, Arnd Bergmann wrote: On Fri, Oct 16, 2020 at 11:09 AM Zhen Lei wrote: > > Suggested-by: Arnd Bergm

[PATCH] fs/quota: update quota state flags scheme with project quota flags

2020-10-17 Thread Roman Anufriev
Current quota state flags scheme doesn't include project quota and thus shows all flags after DQUOT_USAGE_ENABLED wrong. Fix this and also add DQUOT_NOLIST_DIRTY to the scheme. Signed-off-by: Roman Anufriev --- include/linux/quota.h | 15 --- 1 file changed, 8 insertions(+), 7 deleti

Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-17 Thread Colm MacCarthaigh
On 17 Oct 2020, at 6:24, Jason A. Donenfeld wrote: There are a few design goals of notifying userspace: it should be fast, because people who are using userspace RNGs are usually doing so in the first place to completely avoid syscall overhead for whatever high performance application they ha

[PATCH v2] iio: proximity: as3935 change of_property_read to device_property_read

2020-10-17 Thread Vaishnav M A
replace the of_property_read_u32 for reading the ams,tuning-capacitor-pf, ams,nflwdth properties with device_property_read_u32, allows the driver to get the properties information using the more generic device_property_* helpers and opens the possibility of passing the properties during platform in

[PATCH v2] iio: light: tsl2563 change of_property_read to device_property_read

2020-10-17 Thread Vaishnav M A
replace the of_property_read_u32 for reading the amstaos,cover-comp-gain property with device_property_read_u32,allows the driver to get the properties information using the more generic device_property_* helpers and opens the possibility of passing the properties during platform instantiation of t

[PATCH v2] iio: proximity: vl53l0x-i2c add i2c_device_id

2020-10-17 Thread Vaishnav M A
add i2c_device_id for the vl53l0x-i2c driver so that the device can be instantiated using i2c_new_client_device or from userspace, useful in cases where device tree based description is not possible now(Eg. a device on a gbphy i2c adapter created by greybus). Signed-off-by: Vaishnav M A --- v2:

[PATCH v2] iio: light: vcnl4035 add i2c_device_id

2020-10-17 Thread Vaishnav M A
add i2c_device_id for the vcnl4035 driver so that the device can be instantiated using i2c_new_client_device or from userspace, useful in cases where device tree based description is not possible now(Eg. a device on a gbphy i2c adapter created by greybus) Signed-off-by: Vaishnav M A --- v2:

Re: [PATCH] iio: proximity: as3935 change of_property_read to device_property_read

2020-10-17 Thread Vaishnav M A
On Sun, Oct 18, 2020 at 3:57 AM Matt Ranostay wrote: > > On Fri, Oct 16, 2020 at 11:41 AM Vaishnav M A > wrote: > > > > > > This patch aims to replace the of_property_read_u32 for reading > > the ams,tuning-capacitor-pf, ams,nflwdth properties with > > device_property_read_u32. > > > > Thanks an

Re: [PATCH v1 09/29] virtio-mem: don't always trigger the workqueue when offlining memory

2020-10-17 Thread Wei Yang
On Fri, Oct 16, 2020 at 11:18:39AM +0200, David Hildenbrand wrote: >On 16.10.20 06:03, Wei Yang wrote: >> On Mon, Oct 12, 2020 at 02:53:03PM +0200, David Hildenbrand wrote: >>> Let's trigger from offlining code when we're not allowed to touch online Here "touch" means "unplug"? If so, maybe s/touc

drivers/pinctrl/intel/pinctrl-intel.c:210: error: Cannot parse enum!

2020-10-17 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 9d9af1007bc08971953ae915d88dc9bb21344b53 commit: d38c8cfb057183f619dc8534030bb64b63f78043 scripts: kernel-doc: add support for typedef enum date: 3 days ago config: x86_64-rhel (attached as .config) compil

Re: [PATCH v39 12/24] x86/sgx: Add SGX_IOC_ENCLAVE_CREATE

2020-10-17 Thread Jarkko Sakkinen
On Fri, Oct 16, 2020 at 10:07:47AM -0700, Dave Hansen wrote: > > +static u32 sgx_calc_ssa_frame_size(u32 miscselect, u64 xfrm) > > +{ > > + u32 size_max = PAGE_SIZE; > > + u32 size; > > + int i; > > + > > + for (i = 2; i < 64; i++) { > > Should this be: > > for (i = XFEATURE_YMM; i

Re: [PATCH v39 24/24] x86/sgx: Update MAINTAINERS

2020-10-17 Thread Jarkko Sakkinen
On Fri, Oct 16, 2020 at 02:04:05PM -0700, Dave Hansen wrote: > On 10/2/20 9:50 PM, Jarkko Sakkinen wrote: > > +INTEL SGX > > +M: Jarkko Sakkinen > > +M: Sean Christopherson > > +L: linux-...@vger.kernel.org > > +S: Maintained > > Should be Supported, not Maintained. Thanks, fixed. /Jarkko

RE: [PATCH v2 1/5] firmware: imx: scu-seco: Add SEcure Controller APIS

2020-10-17 Thread Aisheng Dong
> From: Franck Lenormand (OSS) > Sent: Tuesday, July 21, 2020 11:21 PM > Subject: [PATCH v2 1/5] firmware: imx: scu-seco: Add SEcure Controller APIS Is 'Secure' intended? Not 'Secure'? > > This patch adds the APIs: > - imx_sc_seco_build_info: get commit and sha of SECO > - imx_sc_seco_secvio_

drivers/pinctrl/intel/pinctrl-intel.c:210: error: Cannot parse enum!

2020-10-17 Thread kernel test robot
Hi Mauro, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 9d9af1007bc08971953ae915d88dc9bb21344b53 commit: d38c8cfb057183f619dc8534030bb64b63f78043 scripts: kernel-doc: add support for typedef enum date: 3 days ag

RE: [PATCH v2 2/5] firmware: imx: scu-irq: Add API to retrieve status of IRQ

2020-10-17 Thread Aisheng Dong
> From: Franck Lenormand (OSS) > Sent: Tuesday, July 21, 2020 11:21 PM > > This patch adds the API to retrieve the status of an IRQ. > > It also adds values used to process SECVIO IRQ from the SCU. > > Signed-off-by: Franck LENORMAND > --- > drivers/firmware/imx/imx-scu-irq.c | 37 > +

RE: [PATCH v2 3/5] dt-bindings: firmware: imx-scu: Add SECVIO resource

2020-10-17 Thread Aisheng Dong
> From: Franck Lenormand (OSS) > Sent: Tuesday, July 21, 2020 11:21 PM > > The SNVS can trigger interruption when detecting a SECurity VIOlation. > This patch adds the definition of the resource. > Not sure if the uppercase of 'SECurity VIOlation' is intended because it looks strange. Otherwis

Re: [PATCH v39 13/24] x86/sgx: Add SGX_IOC_ENCLAVE_ADD_PAGES

2020-10-17 Thread Jarkko Sakkinen
On Fri, Oct 16, 2020 at 02:25:50PM -0700, Dave Hansen wrote: > > > +/** > > + * struct sgx_enclave_add_pages - parameter structure for the > > + *%SGX_IOC_ENCLAVE_ADD_PAGE ioctl > > + * @src: start address for the page data > > + * @offset:starting page of

RE: [PATCH v2 4/5] dt-bindings: arm: imx: Documentation of the SC secvio driver

2020-10-17 Thread Aisheng Dong
> From: Franck Lenormand (OSS) > Sent: Tuesday, July 21, 2020 11:21 PM > > This patch adds the documentation for the SECurity VIOlation driver using the > SCU on imx8x and imx8q. > > Signed-off-by: Franck LENORMAND > --- > .../bindings/arm/freescale/fsl,imx-sc-secvio.yaml | 34 > +

RE: [PATCH v2 5/5] soc: imx8: Add the SC SECVIO driver

2020-10-17 Thread Aisheng Dong
> From: Shawn Guo > Sent: Wednesday, August 19, 2020 9:32 PM > > > > The SNVS is a hardware component in the imx8 SoC. One of its function > > is to detect hardware attacks, in which case it creates a SECurity > > VIOlation. > > > > This patch adds the support for the reception of these secvio and

Re: [RFC] treewide: cleanup unreachable breaks

2020-10-17 Thread Greg KH
On Sat, Oct 17, 2020 at 09:09:28AM -0700, t...@redhat.com wrote: > From: Tom Rix > > This is a upcoming change to clean up a new warning treewide. > I am wondering if the change could be one mega patch (see below) or > normal patch per file about 100 patches or somewhere half way by collecting >

Re: [PATCH 5.9 00/15] 5.9.1-rc1 review

2020-10-17 Thread Greg Kroah-Hartman
On Sat, Oct 17, 2020 at 10:02:50AM -0600, Shuah Khan wrote: > On 10/16/20 3:08 AM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.9.1 release. > > There are 15 patches in this series, all will be posted as a response > > to this one. If anyone has any issues w

Re: [PATCH v5] checkpatch: add new exception to repeated word check

2020-10-17 Thread Joe Perches
On Sat, 2020-10-17 at 22:19 +0530, Dwaipayan Ray wrote: > On Sat, Oct 17, 2020 at 10:03 PM Joe Perches wrote: > > On Sat, 2020-10-17 at 21:57 +0530, Dwaipayan Ray wrote: > > > Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated word test") > > > moved the repeated word test to check for more

Re: Re: Re: [PATCH] rtc: sun6i: Fix memleak in sun6i_rtc_clk_init

2020-10-17 Thread dinghao . liu
> On 26/08/2020 16:55:14+0800, dinghao@zju.edu.cn wrote: > > > On Sun, Aug 23, 2020 at 3:59 PM Dinghao Liu > > > wrote: > > > > > > > > When clk_hw_register_fixed_rate_with_accuracy() fails, > > > > clk_data should be freed. It's the same for the subsequent > > > > error paths. > > > > > > I

Re: [PATCH v5] checkpatch: add new exception to repeated word check

2020-10-17 Thread Dwaipayan Ray
On Sun, Oct 18, 2020 at 11:50 AM Joe Perches wrote: > > On Sat, 2020-10-17 at 22:19 +0530, Dwaipayan Ray wrote: > > On Sat, Oct 17, 2020 at 10:03 PM Joe Perches wrote: > > > On Sat, 2020-10-17 at 21:57 +0530, Dwaipayan Ray wrote: > > > > Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated w

<    1   2   3