Re: [PATCH V5 1/1] livepatch: Add stack_order sysfs attribute

2024-10-11 Thread Petr Mladek
On Tue 2024-10-08 09:48:56, Wardenjohn wrote: > Add "stack_order" sysfs attribute which holds the order in which a live > patch module was loaded into the system. A user can then determine an > active live patched version of a function. > > cat /sys/kernel/livepatch/livepatch_1/stack_order -> 1 >

Re: [PATCH 1/6] lib: math: Move kunit tests into tests/ subdir

2024-10-11 Thread Geert Uytterhoeven
Hi David, On Fri, Oct 11, 2024 at 9:31 AM David Gow wrote: > From: Luis Felipe Hernandez > > This patch is a follow-up task from a discussion stemming from point 3 > in a recent patch introducing the int_pow kunit test [1] and > documentation regarding kunit test style and nomenclature [2]. > >

RE: [PATCH net-next v02 1/2] af_packet: allow fanout_add when socket is not RUNNING

2024-10-11 Thread Gur Stavi
> > If we don't care about opening up fanout groups to ETH_P_NONE, then > patch v2 seems sufficient. If explicitly blocking this, the ENXIO > return can be added, but ideally without touching the other lines. I don't think that allowing ETH_P_NONE is relevant. In my opinion the 2 options that sho

Re: [PATCH 6/6] remoteproc: qcom: Enable map/unmap and SHM bridge support

2024-10-11 Thread neil . armstrong
On 11/10/2024 07:05, Shiraz Hashim wrote: On Thu, Oct 10, 2024 at 08:57:56AM +0200, neil.armstr...@linaro.org wrote: On 08/10/2024 08:21, Mukesh Ojha wrote: On Mon, Oct 07, 2024 at 08:22:39PM +0530, Mukesh Ojha wrote: On Mon, Oct 07, 2024 at 10:05:08AM +0200, neil.armstr...@linaro.org wrote:

Re: [PATCH 6/6] remoteproc: qcom: Enable map/unmap and SHM bridge support

2024-10-11 Thread Shiraz Hashim
On Fri, Oct 11, 2024 at 09:23:05AM +0300, Dmitry Baryshkov wrote: > On Fri, Oct 11, 2024 at 10:35:18AM GMT, Shiraz Hashim wrote: > > On Thu, Oct 10, 2024 at 08:57:56AM +0200, neil.armstr...@linaro.org wrote: > > > On 08/10/2024 08:21, Mukesh Ojha wrote: > > > > On Mon, Oct 07, 2024 at 08:22:39PM +0

Re: [PATCH 6/6] remoteproc: qcom: Enable map/unmap and SHM bridge support

2024-10-11 Thread Mukesh Ojha
On Fri, Oct 11, 2024 at 09:23:05AM +0300, Dmitry Baryshkov wrote: > On Fri, Oct 11, 2024 at 10:35:18AM GMT, Shiraz Hashim wrote: > > On Thu, Oct 10, 2024 at 08:57:56AM +0200, neil.armstr...@linaro.org wrote: > > > On 08/10/2024 08:21, Mukesh Ojha wrote: > > > > On Mon, Oct 07, 2024 at 08:22:39PM +0

Re: [PATCH 6/6] remoteproc: qcom: Enable map/unmap and SHM bridge support

2024-10-11 Thread Dmitry Baryshkov
On Fri, 11 Oct 2024 at 10:09, Shiraz Hashim wrote: > > On Fri, Oct 11, 2024 at 09:23:05AM +0300, Dmitry Baryshkov wrote: > > On Fri, Oct 11, 2024 at 10:35:18AM GMT, Shiraz Hashim wrote: > > > On Thu, Oct 10, 2024 at 08:57:56AM +0200, neil.armstr...@linaro.org wrote: > > > > On 08/10/2024 08:21, Mu

Re: (subset) [RFC PATCH 1/2] mfd: 88pm886: add the RTC cell and relevant definitions

2024-10-11 Thread Lee Jones
On Thu, 10 Oct 2024, Karel Balej wrote: > Lee Jones, 2024-10-10T09:35:19+01:00: > > On Thu, 10 Oct 2024, Lee Jones wrote: > > > > > On Wed, 09 Oct 2024, Karel Balej wrote: > > > > > > > Lee Jones, 2024-10-09T11:06:43+01:00: > > > > > On Fri, 20 Sep 2024 18:12:34 +0200, Karel Balej wrote: > > > >

[PATCH 1/6] lib: math: Move kunit tests into tests/ subdir

2024-10-11 Thread David Gow
From: Luis Felipe Hernandez This patch is a follow-up task from a discussion stemming from point 3 in a recent patch introducing the int_pow kunit test [1] and documentation regarding kunit test style and nomenclature [2]. Colocate all kunit test suites in lib/math/tests/ and follow recommended

[PATCH 0/6] KUnit test moves / renames

2024-10-11 Thread David Gow
As discussed in [1], the KUnit test naming scheme has changed to avoid name conflicts (and tab-completion woes) with the files being tested. These renames and moves have caused a nasty set of merge conflicts, so this series collates and rebases them all to be applied via mm-nonmm-unstable alongside

[PATCH 2/6] lib/math: Add int_log test suite

2024-10-11 Thread David Gow
From: Bruno Sobreira França This commit introduces KUnit tests for the intlog2 and intlog10 functions, which compute logarithms in base 2 and base 10, respectively. The tests cover a range of inputs to ensure the correctness of these functions across common and edge cases. Signed-off-by: Bruno S

Re: [PATCH v2 1/1] lib/tests/kfifo_kunit.c: add tests for the kfifo structure

2024-10-11 Thread David Gow
On Wed, 4 Sept 2024 at 05:38, Diego Vieira wrote: > > Add KUnit tests for the kfifo data structure. > They test the vast majority of macros defined in the kfifo > header (include/linux/kfifo.h). > > These are inspired by the existing tests for the doubly > linked list in lib/tests/list-test.c (pre

[PATCH 4/6] lib/tests/kfifo_kunit.c: add tests for the kfifo structure

2024-10-11 Thread David Gow
From: Diego Vieira Add KUnit tests for the kfifo data structure. They test the vast majority of macros defined in the kfifo header (include/linux/kfifo.h). These are inspired by the existing tests for the doubly linked list in lib/tests/list-test.c (previously at lib/list-test.c) [1]. Note that

[PATCH 5/6] unicode: kunit: refactor selftest to kunit tests

2024-10-11 Thread David Gow
From: Gabriela Bittencourt Refactoring 'test' functions into kunit tests, to test utf-8 support in unicode subsystem. This allows the utf8 tests to be run alongside the KUnit test suite using kunit-tool, quickly compiling and running all desired tests as part of the KUnit test suite, instead of

[PATCH 6/6] unicode: kunit: change tests filename and path

2024-10-11 Thread David Gow
From: Gabriela Bittencourt Change utf8 kunit test filename and path to follow the style convention on Documentation/dev-tools/kunit/style.rst Co-developed-by: Pedro Orlando Signed-off-by: Pedro Orlando Co-developed-by: Danilo Pereira Signed-off-by: Danilo Pereira Signed-off-by: Gabriela Bitt

Re: [PATCH 1/1] selftests: livepatch: add test cases of stack_order sysfs interface

2024-10-11 Thread Petr Mladek
On Fri 2024-10-11 09:51:07, zhang warden wrote: > > > > On Oct 10, 2024, at 23:51, Josh Poimboeuf wrote: > > > > Maybe add a replace=[true|false] module parameter. > > > > How to do it? > Isn't the way we build modules using make? > How to set this replace value? You could find inspiration

Re: [PATCH 3/3] selftests: pidfd: add tests for PIDFD_SELF_*

2024-10-11 Thread Lorenzo Stoakes
On Thu, Oct 10, 2024 at 05:16:22PM -0600, Shuah Khan wrote: > On 10/10/24 12:15, Lorenzo Stoakes wrote: > > Add tests to assert that PIDFD_SELF_* correctly refers to the current > > thread and process. > > > > This is only practically meaningful to pidfd_send_signal() and > > pidfd_getfd(), but als

Re: [PATCH v5 14/16] modules: Support extended MODVERSIONS info

2024-10-11 Thread Matthew Maurer
On Fri, Oct 11, 2024 at 3:22 PM Luis Chamberlain wrote: > > On Wed, Sep 25, 2024 at 11:38:29PM +, Matthew Maurer wrote: > > Adds a new format for MODVERSIONS which stores each field in a separate > > ELF section. This initially adds support for variable length names, but > > could later be use

Re: [PATCH v5 13/16] export_report: Rehabilitate script

2024-10-11 Thread Luis Chamberlain
On Fri, Oct 11, 2024 at 03:22:54PM -0700, Matthew Maurer wrote: > On Fri, Oct 11, 2024 at 3:13 PM Luis Chamberlain wrote: > > > > On Wed, Sep 25, 2024 at 11:38:28PM +, Matthew Maurer wrote: > > > * modules.order has .o files when in a build dir, support this > > > > The commit log is not clear

Re: [PATCH v5 14/16] modules: Support extended MODVERSIONS info

2024-10-11 Thread Luis Chamberlain
On Fri, Oct 11, 2024 at 03:27:30PM -0700, Matthew Maurer wrote: > On Fri, Oct 11, 2024 at 3:22 PM Luis Chamberlain wrote: > > > > On Wed, Sep 25, 2024 at 11:38:29PM +, Matthew Maurer wrote: > > > Adds a new format for MODVERSIONS which stores each field in a separate > > > ELF section. This in

[PATCH] selftests:timers: remove local CLOCKID defines

2024-10-11 Thread Shuah Khan
timers tests defines CLOCKIDs locally. Remove all local CLOCKIDs except CLOCK_HWSPECIFIC and use defines from time.h header file. CLOCK_HWSPECIFIC and CLOCK_SGI_CYCLE are the same and CLOCK_SGI_CYCLE is deprecated, Signed-off-by: Shuah Khan --- tools/testing/selftests/timers/adjtick.c | 2

Re: [PATCH v4 00/19] Implement DWARF modversions

2024-10-11 Thread Luis Chamberlain
On Tue, Oct 08, 2024 at 06:38:24PM +, Sami Tolvanen wrote: > Hi, > > Here's v4 of the DWARF modversions series. The main motivation is > modversions support for Rust, which is important for distributions > like Android that are about to ship Rust kernel modules. Per Luis' > request [1], v2 dro

Re: [PATCH v5 14/16] modules: Support extended MODVERSIONS info

2024-10-11 Thread Luis Chamberlain
On Fri, Oct 11, 2024 at 04:45:25PM -0700, Luis Chamberlain wrote: > > Also, just as I asked Sami, coould you split this up into patch sets? > One with all the cleanups and elf validation code shifts. And then the > other code. That will let me pick up quickly the first patch set. Oh and if you ca

Re: [PATCH v5 14/16] modules: Support extended MODVERSIONS info

2024-10-11 Thread Luis Chamberlain
Also, just as I asked Sami, coould you split this up into patch sets? One with all the cleanups and elf validation code shifts. And then the other code. That will let me pick up quickly the first patch set. Luis

Re: [PATCH 2/3] KVM: vmx, svm, mmu: Process MMIO during event delivery

2024-10-11 Thread Sean Christopherson
Same complaints on the shortlog scope. On Fri, Sep 27, 2024, Ivan Orlov wrote: > Currently, the situation when guest accesses MMIO during event delivery > is handled differently in VMX and SVM: on VMX KVM returns internal error > with suberror = KVM_INTERNAL_ERROR_DELIVERY_EV, when SVM simply goes

Re: [PATCH 1/3] KVM: x86, vmx: Add function for event delivery error generation

2024-10-11 Thread Sean Christopherson
On Fri, Oct 11, 2024, Sean Christopherson wrote: > > + kvm_x86_call(get_exit_info)(vcpu, &reason, &info1, &info2, &intr_info, > > &error_code); > > Wrap. Though calling back into vendor code is silly. Pass the necessary info > as parameters. E.g. error_code and intr_info are unused, so the a

Re: [PATCH 3/3] selftests: KVM: Add test case for MMIO during event delivery

2024-10-11 Thread Sean Christopherson
On Fri, Sep 27, 2024, Ivan Orlov wrote: > Extend the 'set_memory_region_test' with a test case which covers the > MMIO during event delivery error handling. The test case > > 1) Tries to set an IDT descriptor base to point to an MMIO address > 2) Generates a #GP > 3) Verifies that we got a correct

Re: [PATCH] selftests:timers: remove local CLOCKID defines

2024-10-11 Thread John Stultz
On Fri, Oct 11, 2024 at 3:52 PM Shuah Khan wrote: > > timers tests defines CLOCKIDs locally. Remove all local CLOCKIDs except > CLOCK_HWSPECIFIC and use defines from time.h header file. > > CLOCK_HWSPECIFIC and CLOCK_SGI_CYCLE are the same and CLOCK_SGI_CYCLE > is deprecated, > > Signed-off-by: Sh

Re: [PATCH v5 13/16] export_report: Rehabilitate script

2024-10-11 Thread Luis Chamberlain
On Wed, Sep 25, 2024 at 11:38:28PM +, Matthew Maurer wrote: > * modules.order has .o files when in a build dir, support this The commit log is not clear, is it that it's always had *.o files, and you're adding them now, why? Why is the .ko search now removed? > * .mod.c source layout has chan

Re: [PATCH v2] selftests: net/rds: add module not found

2024-10-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Thu, 10 Oct 2024 21:44:17 +0200 you wrote: > This fix solves this error, when calling kselftest with targets "net/rds": > > The error was found by running tests manually with the command: > make kselftest TARGETS="net/

Re: [PATCH v4 00/19] Implement DWARF modversions

2024-10-11 Thread Sami Tolvanen
Hi Luis, On Fri, Oct 11, 2024 at 4:42 PM Luis Chamberlain wrote: > > On Tue, Oct 08, 2024 at 06:38:24PM +, Sami Tolvanen wrote: > > Hi, > > > > Here's v4 of the DWARF modversions series. The main motivation is > > modversions support for Rust, which is important for distributions > > like And

[PATCH net-next 1/3] connector/cn_proc: Add hash table for threads

2024-10-11 Thread Anjali Kulkarni
Add a new type PROC_CN_MCAST_NOTIFY to proc connector API, which allows a thread to notify the kernel that it has exited abnormally. Thread can also send the exit status code it wants returned in the notification with it. Exiting thread can call this either when it wants to call pthread_exit() with

[PATCH net-next 2/3] connector/cn_proc: Kunit tests for threads hash table

2024-10-11 Thread Anjali Kulkarni
Kunit tests to test hash table add, delete, duplicate add and delete. Add following configs and compile kernel code: CONFIG_CONNECTOR=y CONFIG_PROC_EVENTS=y CONFIG_NET=y CONFIG_KUNIT=m/y CONFIG_CN_HASH_KUNIT_TEST=m/y To run kunit tests: sudo modprobe cn_hash_test Output of kunit tests and hash t

[PATCH net-next 3/3] connector/cn_proc: Selftest for threads

2024-10-11 Thread Anjali Kulkarni
Test to check if setting PROC_CN_MCAST_NOTIFY in proc connector API, allows a thread's non-zero exit status to be returned to proc_filter. The threads.c program creates 2 child threads. 1st thread handles signal SIGSEGV, and 2nd thread needs to indicate some error condition (value 1) to the kernel

Re: [PATCH] selftests: timers: Remove unneeded semicolon

2024-10-11 Thread John Stultz
On Fri, Oct 11, 2024 at 4:00 PM Shuah Khan wrote: > > On 10/10/24 01:37, Chen Ni wrote: > > Remove unnecessary semicolons reported by Coccinelle/coccicheck and the > > semantic patch at scripts/coccinelle/misc/semicolon.cocci. > > > > Signed-off-by: Chen Ni > > --- > > tools/testing/selftests/t

[PATCH net-next 0/3] Threads support in proc connector

2024-10-11 Thread Anjali Kulkarni
Recently we committed a fix to allow processes to receive notifications for non-zero exits via the process connector module. Commit is a4c9a56e6a2c. However, for threads, when it does a pthread_exit(&exit_status) call, the kernel is not aware of the exit status with which pthread_exit is called. I

Re: [PATCH v2] selftests: drivers: net: fix name not defined

2024-10-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Thu, 10 Oct 2024 20:30:30 +0200 you wrote: > This fix solves this error, when calling kselftest with targets > "drivers/net": > > File "tools/testing/selftests/net/lib/py/nsim.py", line 64, in __init__ > if e.errno =

Re: [RFC PATCH v1] module: sign with sha512 by default to avoid build errors

2024-10-11 Thread Luis Chamberlain
On Fri, Oct 11, 2024 at 02:00:47PM +0200, Thorsten Leemhuis wrote: > On 11.10.24 12:27, Thorsten Leemhuis wrote: > > On 10.10.24 17:52, Sami Tolvanen wrote: > > Thx for your feedback! > >> On Thu, Oct 10, 2024 at 1:57 AM Thorsten Leemhuis > >> wrote: > >>> On 10.10.24 10:42, Sedat Dilek wrote: >

Re: [PATCH 1/3] KVM: x86, vmx: Add function for event delivery error generation

2024-10-11 Thread Sean Christopherson
"KVM: VMX:" for the scope. See "Shortlog" in Documentation/process/maintainer-kvm-x86.rst On Fri, Sep 27, 2024, Ivan Orlov wrote: > Extract KVM_INTERNAL_ERROR_DELIVERY_EV internal error generation into > the SVM/VMX-agnostic 'kvm_prepare_ev_delivery_failure_exit' function, as > it is done for KV

Re: [GIT PULL] Kselftest fixes update for Linux 6.12-rc3

2024-10-11 Thread pr-tracker-bot
The pull request you sent on Fri, 11 Oct 2024 16:09:09 -0600: > git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest > tags/linux_kselftest-fixes-6.12-rc3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/09f6b0c8904bfaa1e0601bc102e1b6aa6de8c98f Thank you

Re: [PATCH v5 14/16] modules: Support extended MODVERSIONS info

2024-10-11 Thread Luis Chamberlain
On Wed, Sep 25, 2024 at 11:38:29PM +, Matthew Maurer wrote: > Adds a new format for MODVERSIONS which stores each field in a separate > ELF section. This initially adds support for variable length names, but > could later be used to add additional fields to MODVERSIONS in a > backwards compatib

[GIT PULL] Kselftest fixes update for Linux 6.12-rc3

2024-10-11 Thread Shuah Khan
Hi Linus, Please pull this kselftest fixes update for Linux 6.12-rc3. This kselftest update for Linux 6.12-rc3 consists of several fixes for build, run-time errors, and reporting errors: -- ftrace: regression test for a kernel crash when running function graph tracing and then enabling funct

Re: [PATCH v5 13/16] export_report: Rehabilitate script

2024-10-11 Thread Matthew Maurer
On Fri, Oct 11, 2024 at 3:13 PM Luis Chamberlain wrote: > > On Wed, Sep 25, 2024 at 11:38:28PM +, Matthew Maurer wrote: > > * modules.order has .o files when in a build dir, support this > > The commit log is not clear, is it that it's always had *.o files, and > you're adding them now, why? W

Re: [PATCH] selftests: timers: Remove unneeded semicolon

2024-10-11 Thread Shuah Khan
On 10/10/24 01:37, Chen Ni wrote: Remove unnecessary semicolons reported by Coccinelle/coccicheck and the semantic patch at scripts/coccinelle/misc/semicolon.cocci. Signed-off-by: Chen Ni --- tools/testing/selftests/timers/set-timer-lat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v3 2/2] selftests/futex: Create test for robust list

2024-10-11 Thread kernel test robot
Hi André, kernel test robot noticed the following build warnings: [auto build test WARNING on tip/locking/core] [also build test WARNING on linus/master v6.12-rc2 next-20241011] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [RFC PATCH 26/39] KVM: guest_memfd: Track faultability within a struct kvm_gmem_private

2024-10-11 Thread Ackerley Tng
Peter Xu writes: > On Tue, Sep 10, 2024 at 11:43:57PM +, Ackerley Tng wrote: >> The faultability xarray is stored on the inode since faultability is a >> property of the guest_memfd's memory contents. >> >> In this RFC, presence of an entry in the xarray indicates faultable, >> but this coul

[PATCH] rpmsg_ns: Work around TI non-standard message

2024-10-11 Thread Richard Weinberger
Texas Instruments ships a patch in their vendor kernels, which adds a new NS message that includes a description field. While TI is free to do whatever they want in their copy of the kernel, it becomes a mess when people switch to a mainline kernel and want to use their existing DSP programs with i

RE: [PATCH net-next v02 1/2] af_packet: allow fanout_add when socket is not RUNNING

2024-10-11 Thread Willem de Bruijn
Gur Stavi wrote: > > > > If we don't care about opening up fanout groups to ETH_P_NONE, then > > patch v2 seems sufficient. If explicitly blocking this, the ENXIO > > return can be added, but ideally without touching the other lines. > > I don't think that allowing ETH_P_NONE is relevant. > In my

[PATCH] kselftest/arm64: Ensure stable names for GCS stress test results

2024-10-11 Thread Mark Brown
t_thread(&children[i], i); /* * All children started, close the startup pipe and let them --- base-commit: bb9ae1a66c85eeb626864efd812c62026e126ec0 change-id: 20241011-arm64-gcs-stress-stable-name-8550519fe152 Best regards, -- Mark Brown

Re: [PATCH,bpf-next v3 0/4] selftests/bpf: migrate and remove cgroup/tracing related tests

2024-10-11 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (master) by Alexei Starovoitov : On Fri, 11 Oct 2024 04:48:43 + you wrote: > The BPF testing framework has evolved significantly over time. However, > some legacy tests in the samples/bpf directory have not kept up with > these changes. These

RE: [PATCH net-next v02 1/2] af_packet: allow fanout_add when socket is not RUNNING

2024-10-11 Thread Gur Stavi
> Gur Stavi wrote: > > > > > > If we don't care about opening up fanout groups to ETH_P_NONE, then > > > patch v2 seems sufficient. If explicitly blocking this, the ENXIO > > > return can be added, but ideally without touching the other lines. > > > > I don't think that allowing ETH_P_NONE is relev

[PATCH net-next 2/2] selftests: drv-net: rss_ctx: add rss ctx busy testcase

2024-10-11 Thread Daniel Zahka
It should be invalid to delete an rss context while it is being referenced from an ntuple filter. ethtool core should prevent this from happening. This patch adds a testcase to verify this behavior. Signed-off-by: Daniel Zahka --- .../selftests/drivers/net/hw/rss_ctx.py | 32 ++

Re: [PATCH V2 2/4] remoteproc: qcom: add hexagon based WCSS secure PIL driver

2024-10-11 Thread Jeff Johnson
On 8/29/2024 6:40 AM, Gokul Sriram Palanisamy wrote: ... > +++ b/drivers/remoteproc/qcom_q6v5_wcss_sec.c > @@ -0,0 +1,354 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2016-2018 Linaro Ltd. > + * Copyright (C) 2014 Sony Mobile Communications AB > + * Copyright (c) 2012-2018,

Re: [PATCH V2 4/4] arm64: dts: qcom: ipq9574: add nodes to bring up q6

2024-10-11 Thread Jeff Johnson
On 8/29/2024 6:40 AM, Gokul Sriram Palanisamy wrote: > From: Manikanta Mylavarapu > > Enable nodes required for q6 remoteproc bring up. > > Signed-off-by: Manikanta Mylavarapu > Signed-off-by: Gokul Sriram Palanisamy > --- > changes since v1: Addressed comments by Krzysztof > - updated t

Re: [PATCH V2 3/4] arm64: dts: qcom: ipq5332: add nodes to bringup q6

2024-10-11 Thread Jeff Johnson
On 8/29/2024 6:40 AM, Gokul Sriram Palanisamy wrote: > From: Manikanta Mylavarapu > > Enable nodes required for q6 remoteproc bring up. > > Signed-off-by: Manikanta Mylavarapu > Signed-off-by: Gokul Sriram Palanisamy > --- > changes since v1: Addressed comments by Krzysztof > - renamed r

[PATCH bpf v1 2/2] selftests/bpf: add asserts for netfilter link info

2024-10-11 Thread Tyrone Wu
Add assertions/tests to verify `bpf_link_info` fields for netfilter link are correctly populated. Signed-off-by: Tyrone Wu --- .../bpf/prog_tests/netfilter_link_attach.c| 40 ++- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/bpf/prog_t

[PATCH bpf v1 1/2] bpf: fix link info netfilter flags to populate defrag flag

2024-10-11 Thread Tyrone Wu
This patch correctly populates the `bpf_link_info.netfilter.flags` field when user passes the `BPF_F_NETFILTER_IP_DEFRAG` flag. Fixes: 84601d6ee68a ("bpf: add bpf_link support for BPF_NETFILTER programs") Signed-off-by: Tyrone Wu --- net/netfilter/nf_bpf_link.c | 3 ++- 1 file changed, 2 inserti

Re: [GIT PULL] RCU fix for v6.12

2024-10-11 Thread pr-tracker-bot
The pull request you sent on Fri, 11 Oct 2024 23:50:23 +0530: > git://git.kernel.org/pub/scm/linux/kernel/git/rcu/linux.git > tags/rcu.fixes.6.12-rc3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a1029768f3931b31aa52790f1dde0c7d6a6552eb Thank you! -- Deet-doot-dot

Re: [PATCH V2 2/4] remoteproc: qcom: add hexagon based WCSS secure PIL driver

2024-10-11 Thread Trilok Soni
On 10/11/2024 12:28 PM, Jeff Johnson wrote: > So I suspect this last line should be replaced with two: >> + * Copyright (c) 2012-2018 The Linux Foundation. All rights reserved. >> + * Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved. I agree. -- ---Trilok Soni

Re: [RFC PATCH v1] module: sign with sha512 by default to avoid build errors

2024-10-11 Thread Thorsten Leemhuis
On 11.10.24 12:27, Thorsten Leemhuis wrote: > On 10.10.24 17:52, Sami Tolvanen wrote: > Thx for your feedback! >> On Thu, Oct 10, 2024 at 1:57 AM Thorsten Leemhuis >> wrote: >>> On 10.10.24 10:42, Sedat Dilek wrote: On Thu, Oct 10, 2024 at 10:29 AM Sedat Dilek wrote: > On Thu, Oct 10, 2

Re: [PATCH 0/6] KUnit test moves / renames

2024-10-11 Thread Shuah Khan
On 10/11/24 01:25, David Gow wrote: As discussed in [1], the KUnit test naming scheme has changed to avoid name conflicts (and tab-completion woes) with the files being tested. These renames and moves have caused a nasty set of merge conflicts, so this series collates and rebases them all to be a

Re: [RFC PATCH v1] module: sign with sha512 by default to avoid build errors

2024-10-11 Thread Thorsten Leemhuis
On 10.10.24 17:52, Sami Tolvanen wrote: Thx for your feedback! > On Thu, Oct 10, 2024 at 1:57 AM Thorsten Leemhuis wrote: >> On 10.10.24 10:42, Sedat Dilek wrote: >>> On Thu, Oct 10, 2024 at 10:29 AM Sedat Dilek wrote: On Thu, Oct 10, 2024 at 10:19 AM Thorsten Leemhuis wrote: >

Re: [PATCH bpf-next v3 2/3] selftests/bpf: make xdp_cpumap_attach keep redirect prog attached

2024-10-11 Thread Alexis Lothoré
Hello Martin, On 10/11/24 03:23, Martin KaFai Lau wrote: > On 10/9/24 3:12 AM, Alexis Lothoré (eBPF Foundation) wrote: >> -    int err, prog_fd, map_fd; >> +    int err, prog_fd, prog_redir_fd, map_fd; >> +    struct nstoken *nstoken = NULL; >>   __u32 idx = 0; >>   +    SYS(out_close, "ip net

Re: [PATCH] selftests: clone3: Use the capget and capset syscall directly

2024-10-11 Thread Shuah Khan
On 10/11/24 00:59, zhouyuhang wrote: On 2024/10/10 23:50, Shuah Khan wrote: On 10/10/24 06:16, zhouyuhang wrote: From: zhouyuhang The libcap commit aca076443591 ("Make cap_t operations thread safe.") added a __u8 mutex at the beginning of the struct _cap_struct,it changes the offset of the m

RE: [PATCH net-next v02 1/2] af_packet: allow fanout_add when socket is not RUNNING

2024-10-11 Thread Willem de Bruijn
Gur Stavi wrote: > > Gur Stavi wrote: > > > > Gur Stavi wrote: > > > > > > Gur Stavi wrote: > > > > > > > > Gur Stavi wrote: > > > > > > > > > >> @@ -1846,21 +1846,21 @@ static int fanout_add(struct > > sock > > > > *sk, > > > > > > > > struct fanout_args *args) > > > > > > > > > >>err = -EINVA

Re: [PATCH 07/10] remoteproc: qcom_q6v5_mss: Drop redundant error printks in probe

2024-10-11 Thread Dmitry Baryshkov
On Fri, Oct 11, 2024 at 03:09:15PM +0200, Krzysztof Kozlowski wrote: > Do not print errors of getting clocks and regulators in probe twice: > once in q6v5_init_clocks() or q6v5_regulator_init() and then again in the > probe function. This also avoids dmesg flood on deferred probe. > > Signed-off-

Re: [PATCH 09/10] remoteproc: qcom_q6v5_wcss: Simplify with dev_err_probe()

2024-10-11 Thread Dmitry Baryshkov
On Fri, Oct 11, 2024 at 03:09:17PM +0200, Krzysztof Kozlowski wrote: > Use dev_err_probe() to make error and defer code handling simpler. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/remoteproc/qcom_q6v5_wcss.c | 92 > - > 1 file changed, 30 inserti

Re: [PATCH 08/10] remoteproc: qcom_q6v5_pas: Simplify with dev_err_probe()

2024-10-11 Thread Dmitry Baryshkov
On Fri, Oct 11, 2024 at 03:09:16PM +0200, Krzysztof Kozlowski wrote: > Use dev_err_probe() to make error and defer code handling simpler. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/remoteproc/qcom_q6v5_pas.c | 22 +++--- > 1 file changed, 7 insertions(+), 15 deletions

Re: [PATCH 06/10] remoteproc: qcom_q6v5_mss: Simplify with dev_err_probe()

2024-10-11 Thread Dmitry Baryshkov
On Fri, Oct 11, 2024 at 03:09:14PM +0200, Krzysztof Kozlowski wrote: > Use dev_err_probe() to make error and defer code handling simpler. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/remoteproc/qcom_q6v5_mss.c | 24 > 1 file changed, 8 insertions(+), 16 deletio

Re: [PATCH 10/10] remoteproc: qcom_wcnss_iris: Simplify with dev_err_probe()

2024-10-11 Thread Dmitry Baryshkov
On Fri, Oct 11, 2024 at 03:09:18PM +0200, Krzysztof Kozlowski wrote: > Use dev_err_probe() to make error and defer code handling simpler. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/remoteproc/qcom_wcnss_iris.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > Reviewed-

[PATCH 03/10] remoteproc: ti_k3_r5: Simplify with dev_err_probe()

2024-10-11 Thread Krzysztof Kozlowski
Use dev_err_probe() to make error and defer code handling simpler. Signed-off-by: Krzysztof Kozlowski --- drivers/remoteproc/ti_k3_r5_remoteproc.c | 69 +++- 1 file changed, 24 insertions(+), 45 deletions(-) diff --git a/drivers/remoteproc/ti_k3_r5_remoteproc.c b/dr

[PATCH 02/10] remoteproc: da8xx: Simplify with dev_err_probe()

2024-10-11 Thread Krzysztof Kozlowski
Use dev_err_probe() to make error and defer code handling simpler. Signed-off-by: Krzysztof Kozlowski --- drivers/remoteproc/da8xx_remoteproc.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/

[PATCH 01/10] remoteproc: da8xx: Handle deferred probe

2024-10-11 Thread Krzysztof Kozlowski
Don't pollute dmesg on deferred probe by using dev_err_probe(). Signed-off-by: Krzysztof Kozlowski --- drivers/remoteproc/da8xx_remoteproc.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c i

[PATCH 04/10] remoteproc: ti_k3_r5: Simplify with scoped for each OF child loop

2024-10-11 Thread Krzysztof Kozlowski
Use scoped for_each_available_child_of_node_scoped() when iterating over device nodes to make code a bit simpler. Signed-off-by: Krzysztof Kozlowski --- drivers/remoteproc/ti_k3_r5_remoteproc.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/remoteproc/ti_k3_r5_re

[PATCH 05/10] remoteproc: qcom_q6v5_adsp: Simplify with dev_err_probe()

2024-10-11 Thread Krzysztof Kozlowski
Use dev_err_probe() to make error and defer code handling simpler. Signed-off-by: Krzysztof Kozlowski --- drivers/remoteproc/qcom_q6v5_adsp.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5

[PATCH 09/10] remoteproc: qcom_q6v5_wcss: Simplify with dev_err_probe()

2024-10-11 Thread Krzysztof Kozlowski
Use dev_err_probe() to make error and defer code handling simpler. Signed-off-by: Krzysztof Kozlowski --- drivers/remoteproc/qcom_q6v5_wcss.c | 92 - 1 file changed, 30 insertions(+), 62 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers

[PATCH 08/10] remoteproc: qcom_q6v5_pas: Simplify with dev_err_probe()

2024-10-11 Thread Krzysztof Kozlowski
Use dev_err_probe() to make error and defer code handling simpler. Signed-off-by: Krzysztof Kozlowski --- drivers/remoteproc/qcom_q6v5_pas.c | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q

[PATCH 07/10] remoteproc: qcom_q6v5_mss: Drop redundant error printks in probe

2024-10-11 Thread Krzysztof Kozlowski
Do not print errors of getting clocks and regulators in probe twice: once in q6v5_init_clocks() or q6v5_regulator_init() and then again in the probe function. This also avoids dmesg flood on deferred probe. Signed-off-by: Krzysztof Kozlowski --- drivers/remoteproc/qcom_q6v5_mss.c | 24 ++---

[PATCH 06/10] remoteproc: qcom_q6v5_mss: Simplify with dev_err_probe()

2024-10-11 Thread Krzysztof Kozlowski
Use dev_err_probe() to make error and defer code handling simpler. Signed-off-by: Krzysztof Kozlowski --- drivers/remoteproc/qcom_q6v5_mss.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom

[PATCH 00/10] remoteproc: few dev_err_probe() and other cleanups/improvements

2024-10-11 Thread Krzysztof Kozlowski
insertions(+), 195 deletions(-) --- base-commit: 0cca97bf23640ff68a6e8a74e9b6659fdc27f48c change-id: 20241011-remote-proc-dev-err-probe-c986de9e93de Best regards, -- Krzysztof Kozlowski

[PATCH 10/10] remoteproc: qcom_wcnss_iris: Simplify with dev_err_probe()

2024-10-11 Thread Krzysztof Kozlowski
Use dev_err_probe() to make error and defer code handling simpler. Signed-off-by: Krzysztof Kozlowski --- drivers/remoteproc/qcom_wcnss_iris.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/remoteproc/qcom_wcnss_iris.c b/drivers/remoteproc/qcom_wcnss_iris.c ind

[PATCH 0/1] selftests: livepatch: add test cases of stack_order sysfs

2024-10-11 Thread Wardenjohn
This patch add self test cases to 'stack_order' sysfs interface. I found some existing test modules dont set '.replace=true', which can be used in 'stack_order' test. So, use the existing module for selftests. Regards. Wardenjohn.

[PATCH] selftests: livepatch: add test cases of stack_order sysfs interface

2024-10-11 Thread Wardenjohn
Add selftest test cases to sysfs attribute 'stack_order'. Signed-off-by: Wardenjohn --- .../testing/selftests/livepatch/test-sysfs.sh | 74 +++ 1 file changed, 74 insertions(+) diff --git a/tools/testing/selftests/livepatch/test-sysfs.sh b/tools/testing/selftests/livepatch/test

Re: [PATCH v2 rcu 13/13] srcu: Improve srcu_read_lock_lite() kernel-doc comment

2024-10-11 Thread Andrii Nakryiko
On Fri, Oct 11, 2024 at 10:39 AM Paul E. McKenney wrote: > > Where RCU is watching is where it is OK to invoke rcu_read_lock(). > > Reported-by: Andrii Nakryiko > Signed-off-by: Paul E. McKenney > --- > include/linux/srcu.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Acked-by:

[PATCH v2 rcu 08/13] rcutorture: Expand RCUTORTURE_RDR_MASK_[12] to eight bits

2024-10-11 Thread Paul E. McKenney
This commit prepares for testing of multiple SRCU reader flavors by expanding RCUTORTURE_RDR_MASK_1 and RCUTORTURE_RDR_MASK_2 from a single bit to eight bits, allowing them to accommodate the return values from multiple calls to srcu_read_lock*(). This will in turn permit better testing coverage f

[PATCH v2 rcu 10/13] rcutorture: Add srcu_read_lock_lite() support to rcutorture.reader_flavor

2024-10-11 Thread Paul E. McKenney
This commit causes bit 0x4 of rcutorture.reader_flavor to select the new srcu_read_lock_lite() and srcu_read_unlock_lite() functions. Signed-off-by: Paul E. McKenney Cc: Alexei Starovoitov Cc: Andrii Nakryiko Cc: Peter Zijlstra Cc: Kent Overstreet Cc: --- Documentation/admin-guide/kernel-pa

[PATCH v2 rcu 13/13] srcu: Improve srcu_read_lock_lite() kernel-doc comment

2024-10-11 Thread Paul E. McKenney
Where RCU is watching is where it is OK to invoke rcu_read_lock(). Reported-by: Andrii Nakryiko Signed-off-by: Paul E. McKenney --- include/linux/srcu.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/srcu.h b/include/linux/srcu.h index 4ba96e2cfa405..bab1dae

[PATCH v2 rcu 09/13] rcutorture: Add reader_flavor parameter for SRCU readers

2024-10-11 Thread Paul E. McKenney
This commit adds an rcutorture.reader_flavor parameter whose bits correspond to reader flavors. For example, SRCU's readers are 0x1 for normal and 0x2 for NMI-safe. Signed-off-by: Paul E. McKenney Cc: Alexei Starovoitov Cc: Andrii Nakryiko Cc: Peter Zijlstra Cc: Kent Overstreet Cc: --- ...

[PATCH v2 rcu 07/13] srcu: Allow inlining of __srcu_read_{,un}lock_lite()

2024-10-11 Thread Paul E. McKenney
This commit moves __srcu_read_lock_lite() and __srcu_read_unlock_lite() into include/linux/srcu.h and marks them "static inline" so that they can be inlined into srcu_read_lock_lite() and srcu_read_unlock_lite(), respectively. They are not hand-inlined due to Tree SRCU and Tiny SRCU having differe

[PATCH v2 rcu 11/13] rcutorture: Add light-weight SRCU scenario

2024-10-11 Thread Paul E. McKenney
This commit adds an rcutorture scenario that tests light-weight SRCU readers. While in the area, it adjusts the size of the TREE10 scenario. Signed-off-by: Paul E. McKenney Cc: Alexei Starovoitov Cc: Andrii Nakryiko Cc: Peter Zijlstra Cc: Kent Overstreet Cc: --- tools/testing/selftests/rcu

[PATCH v2 rcu 12/13] refscale: Add srcu_read_lock_lite() support using "srcu-lite"

2024-10-11 Thread Paul E. McKenney
This commit creates a new srcu-lite option for the refscale.scale_type module parameter that selects srcu_read_lock_lite() and srcu_read_unlock_lite(). Signed-off-by: Paul E. McKenney Cc: Alexei Starovoitov Cc: Andrii Nakryiko Cc: Peter Zijlstra Cc: Kent Overstreet Cc: --- kernel/rcu/refsca

[PATCH v2 rcu 01/13] srcu: Rename srcu_might_be_idle() to srcu_should_expedite()

2024-10-11 Thread Paul E. McKenney
SRCU auto-expedites grace periods that follow a sufficiently long idle period, and the srcu_might_be_idle() function is used to make this decision. However, the upcoming light-weight SRCU readers will not do auto-expediting because doing so would cause the grace-period machinery to invoke synchron

[PATCH v2 rcu 04/13] srcu: Bit manipulation changes for additional reader flavor

2024-10-11 Thread Paul E. McKenney
Currently, there are only two flavors of readers, normal and NMI-safe. Very straightforward state updates suffice to check for erroneous mixing of reader flavors on a given srcu_struct structure. This commit upgrades the checking in preparation for the addition of light-weight (as in memory-barrie

[PATCH v2 rcu 06/13] srcu: Add srcu_read_lock_lite() and srcu_read_unlock_lite()

2024-10-11 Thread Paul E. McKenney
This patch adds srcu_read_lock_lite() and srcu_read_unlock_lite(), which dispense with the read-side smp_mb() but also are restricted to code regions that RCU is watching. If a given srcu_struct structure uses srcu_read_lock_lite() and srcu_read_unlock_lite(), it is not permitted to use any other

[PATCH v2 rcu 05/13] srcu: Standardize srcu_data pointers to "sdp" and similar

2024-10-11 Thread Paul E. McKenney
This commit changes a few "cpuc" variables to "sdp" to align wiht usage elsewhere. Signed-off-by: Paul E. McKenney Cc: Alexei Starovoitov Cc: Andrii Nakryiko Cc: Peter Zijlstra Cc: Kent Overstreet Cc: --- include/linux/srcu.h | 35 ++ include/linux/srcutr

[PATCH v2 rcu 0/13] SRCU-lite changes for v6.13

2024-10-11 Thread Paul E. McKenney
Hello! This v2 series adds support and testing for srcu_read_lock_lite() and srcu_read_unlock_lite(), which avoid smp_mb(), but add a couple of synchronize_rcu() calls to the grace-period processing and may only be used where RCU is watching. 1. Rename srcu_might_be_idle() to srcu_should_exp

[PATCH v2 rcu 02/13] srcu: Introduce srcu_gp_is_expedited() helper function

2024-10-11 Thread Paul E. McKenney
Even though the open-coded expressions usually fit on one line, this commit replaces them with a call to a new srcu_gp_is_expedited() helper function in order to improve readability. Signed-off-by: Paul E. McKenney Cc: Alexei Starovoitov Cc: Andrii Nakryiko Cc: Peter Zijlstra Cc: Kent Overstre

[PATCH v2 rcu 03/13] srcu: Renaming in preparation for additional reader flavor

2024-10-11 Thread Paul E. McKenney
Currently, there are only two flavors of readers, normal and NMI-safe. A number of fields, functions, and types reflect this restriction. This renaming-only commit prepares for the addition of light-weight (as in memory-barrier-free) readers. OK, OK, there is also a drive-by white-space fixeup! S

[GIT PULL] RCU fix for v6.12

2024-10-11 Thread Neeraj Upadhyay
Hi Linus, The following changes since commit 8cf0b93919e13d1e8d4466eb4080a4c4d9d66d7b: Linux 6.12-rc2 (2024-10-06 15:32:27 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/rcu/linux.git tags/rcu.fixes.6.12-rc3 for you to fetch changes up to f734

RE: [PATCH net-next v02 1/2] af_packet: allow fanout_add when socket is not RUNNING

2024-10-11 Thread Willem de Bruijn
Gur Stavi wrote: > > Gur Stavi wrote: > > > > > > > > If we don't care about opening up fanout groups to ETH_P_NONE, then > > > > patch v2 seems sufficient. If explicitly blocking this, the ENXIO > > > > return can be added, but ideally without touching the other lines. > > > > > > I don't think th

  1   2   >