[PATCHv7 RESEND wireguard 2/2] wireguard: selftests: update to using nft for qemu test

2025-05-27 Thread Hangbin Liu
Since we will replace iptables with nft for wireguard netns testing, let's also convert the qemu test to use nft at the same time. Co-developed-by: Phil Sutter Signed-off-by: Phil Sutter Signed-off-by: Hangbin Liu --- .../testing/selftests/wireguard/qemu/Makefile | 36 ++- .../

[PATCH v3 4/6] modpost: Create modalias for builtin modules

2025-05-27 Thread Alexey Gladkov
For some modules, modalias is generated using the modpost utility and the section is added to the module file. When a module is added inside vmlinux, modpost does not generate modalias for such modules and the information is lost. As a result kmod (which uses modules.builtin.modinfo in userspace)

[PATCH v3 3/6] modpost: Make mod_device_table aliases more unique

2025-05-27 Thread Alexey Gladkov
In order to avoid symbol conflicts if they appear in the same binary, a more unique alias identifier can be generated. Signed-off-by: Alexey Gladkov Reviewed-by: Petr Pavlu --- include/linux/module.h | 14 -- scripts/mod/file2alias.c | 18 ++ 2 files changed, 26 in

Re: [PATCH v3] media: add virtio-media driver

2025-05-27 Thread Mauro Carvalho Chehab
Em Tue, 27 May 2025 15:14:50 +0900 "Alexandre Courbot" escreveu: > Hi Mauro, > > On Mon May 26, 2025 at 9:13 PM JST, Mauro Carvalho Chehab wrote: > > Hi Michael, > > > > Em Sat, 12 Apr 2025 13:08:01 +0900 > > Alexandre Courbot escreveu: > > > >> Add the first version of the virtio-media drive

[PATCH net-next] selftest: Add selftest for multicast address notifications

2025-05-27 Thread Yuyang Huang
This commit adds a new kernel selftest to verify RTNLGRP_IPV4_MCADDR and RTNLGRP_IPV6_MCADDR notifications. The test works by adding and removing a dummy interface and then confirming that the system correctly receives join and removal notifications for the 224.0.0.1 and ff02::1 multicast addresses

Re: [PATCH bpf-next v2 1/2] bpf, arm64: Support up to 12 function arguments

2025-05-27 Thread Alexis Lothoré
On Tue May 27, 2025 at 11:09 AM CEST, Xu Kuohai wrote: > On 5/27/2025 4:45 PM, Alexis Lothoré wrote: > > [...] > + /* We can not know for sure about exact alignment needs for + * struct passed on stack, so deny those + */ + if (m->arg_flags[

[PATCH v3 6/6] kbuild: Create modules.builtin.modinfo for modpost results

2025-05-27 Thread Alexey Gladkov
Create modules.builtin.modinfo as a combination of modinfo from vmlinux and the result of generating modalias by modpost. Signed-off-by: Alexey Gladkov --- scripts/Makefile.vmlinux | 30 +++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/scripts/Makefil

[PATCH v3 2/6] modules: Add macros to specify modinfo prefix

2025-05-27 Thread Alexey Gladkov
The __MODULE_INFO macros always use __MODULE_INFO_PREFIX. The only way to use a different prefix is to override __MODULE_INFO_PREFIX, which is not very useful. The new macro will be used in file2alias.c to generate modalias for builtin modules. Signed-off-by: Alexey Gladkov Reviewed-by: Petr Pav

Re: [PATCH 2/3] modpost: allow "make nsdeps" to skip module-specific symbol namespace

2025-05-27 Thread Petr Pavlu
On 5/22/25 09:17, Masahiro Yamada wrote: > When MODULE_IMPORT_NS() is missing, "make nsdeps" runs the Coccinelle > script to automatically add MODULE_IMPORT_NS() to each module. > > This should not occur for users of EXPORT_SYMBOL_GPL_FOR_MODULES(), which > is intended to export a symbol to a spec

Re: [PATCH net-next v6 0/5] vsock: SOCK_LINGER rework

2025-05-27 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Paolo Abeni : On Thu, 22 May 2025 01:18:20 +0200 you wrote: > Change vsock's lingerning to wait on close() until all data is sent, i.e. > until workers picked all the packets for processing. > > Changes in v6: > - Make vsock_wait_se

[PATCH bpf-next v3 0/2] bpf, arm64: support up to 12 arguments

2025-05-27 Thread Alexis Lothoré
Hello, this is the v2 of the many args series for arm64, being itself a revival of Xu Kuhoai's work to enable larger arguments count for BPF programs on ARM64 ([1]). The discussions in v1 shed some light on some issues around specific cases, for example with functions passing struct on stack with

[PATCH bpf-next v3 1/2] bpf, arm64: Support up to 12 function arguments

2025-05-27 Thread Alexis Lothoré
From: Xu Kuohai Currently ARM64 bpf trampoline supports up to 8 function arguments. According to the statistics from commit 473e3150e30a ("bpf, x86: allow function arguments up to 12 for TRACING"), there are about 200 functions accept 9 to 12 arguments, so adding support for up to 12 function arg

[PATCH bpf-next v3 2/2] selftests/bpf: enable many-args tests for arm64

2025-05-27 Thread eBPF Foundation
Now that support for up to 12 args is enabled for tracing programs on ARM64, enable the existing tests for this feature on this architecture. Signed-off-by: Alexis Lothoré (eBPF Foundation) --- Changes in v2: - keep tracing struct tests disabled, as structs passed on stack are not handled by th

Re: [PATCH 3/4] selftests/mm: Report unique test names for each cow test

2025-05-27 Thread Lorenzo Stoakes
On Thu, May 22, 2025 at 06:38:52PM +0100, Mark Brown wrote: > The kselftest framework uses the string logged when a test result is > reported as the unique identifier for a test, using it to track test > results between runs. The cow test completely fails to follow this pattern, > it runs test func

Re: [PATCH v3 1/6] scsi: Define MODULE_DEVICE_TABLE only if necessary

2025-05-27 Thread James Bottomley
On Tue, 2025-05-27 at 11:07 +0200, Alexey Gladkov wrote: > Define MODULE_DEVICE_TABLE only if a structure is defined for it. > > drivers/scsi/BusLogic.c:3735:26: error: use of undeclared identifier > 'blogic_pci_tbl' >  3735 | MODULE_DEVICE_TABLE(pci, blogic_pci_tbl); Well, a) need to cc the scsi

[PATCH v3 5/6] kbuild: Move modules.builtin.modinfo to another makefile

2025-05-27 Thread Alexey Gladkov
The creation of modules.builtin.modinfo is going to depend on .vmlinux.export.o so it is worth moving its creation closer to it. Signed-off-by: Alexey Gladkov --- scripts/Makefile.vmlinux | 24 scripts/Makefile.vmlinux_o | 26 +- 2 files changed

Re: [PATCH bpf-next v2 1/2] bpf, arm64: Support up to 12 function arguments

2025-05-27 Thread Xu Kuohai
On 5/27/2025 4:45 PM, Alexis Lothoré wrote: [...] + /* We can not know for sure about exact alignment needs for +* struct passed on stack, so deny those +*/ + if (m->arg_flags[i] & BTF_FMODEL_STRUCT_ARG) + return

Re: [PATCH bpf-next v3 0/2] bpf, arm64: support up to 12 arguments

2025-05-27 Thread Xu Kuohai
On 5/27/2025 6:06 PM, Alexis Lothoré wrote: Hello, this is the v2 of the many args series for arm64, being itself a revival of Xu Kuhoai's work to enable larger arguments count for BPF programs on ARM64 ([1]). The discussions in v1 shed some light on some issues around specific cases, for examp

Re: [PATCH 1/4] selftests/mm: Use standard ksft_finished() in cow and gup_longterm

2025-05-27 Thread David Hildenbrand
On 22.05.25 19:38, Mark Brown wrote: The cow and gup_longterm test programs open code something that looks a lot like the standard ksft_finished() helper to summarise the test results and provide an exit code, convert to use ksft_finished(). Signed-off-by: Mark Brown --- Acked-by: David Hilde

Re: [PATCH v3 1/6] scsi: Define MODULE_DEVICE_TABLE only if necessary

2025-05-27 Thread Alexey Gladkov
On Tue, May 27, 2025 at 07:58:27AM -0400, James Bottomley wrote: > On Tue, 2025-05-27 at 13:54 +0200, Alexey Gladkov wrote: > > On Tue, May 27, 2025 at 07:28:59AM -0400, James Bottomley wrote: > > > On Tue, 2025-05-27 at 11:07 +0200, Alexey Gladkov wrote: > > > > Define MODULE_DEVICE_TABLE only if

Re: [PATCH 3/4] selftests/mm: Report unique test names for each cow test

2025-05-27 Thread Mark Brown
On Tue, May 27, 2025 at 12:53:30PM +0100, Lorenzo Stoakes wrote: > On Tue, May 27, 2025 at 12:49:57PM +0100, Mark Brown wrote: > > On Tue, May 27, 2025 at 11:08:05AM +0100, Lorenzo Stoakes wrote: > > > On Thu, May 22, 2025 at 06:38:52PM +0100, Mark Brown wrote: > > > > > > ret = setup_comm_

Re: [PATCH 3/4] selftests/mm: Report unique test names for each cow test

2025-05-27 Thread Mark Brown
On Tue, May 27, 2025 at 11:08:05AM +0100, Lorenzo Stoakes wrote: > On Thu, May 22, 2025 at 06:38:52PM +0100, Mark Brown wrote: > > ret = setup_comm_pipes(&comm_pipes); > > if (ret) { > > - ksft_test_result_fail("pipe() failed\n"); > > + log_test_result(KAFT_FAIL); > >

Re: [PATCH 3/4] selftests/mm: Report unique test names for each cow test

2025-05-27 Thread Lorenzo Stoakes
On Tue, May 27, 2025 at 12:49:57PM +0100, Mark Brown wrote: > On Tue, May 27, 2025 at 11:08:05AM +0100, Lorenzo Stoakes wrote: > > On Thu, May 22, 2025 at 06:38:52PM +0100, Mark Brown wrote: > > > > ret = setup_comm_pipes(&comm_pipes); > > > if (ret) { > > > - ksft_test_result_fail("pip

Re: [PATCH v3 1/6] scsi: Define MODULE_DEVICE_TABLE only if necessary

2025-05-27 Thread Alexey Gladkov
On Tue, May 27, 2025 at 07:28:59AM -0400, James Bottomley wrote: > On Tue, 2025-05-27 at 11:07 +0200, Alexey Gladkov wrote: > > Define MODULE_DEVICE_TABLE only if a structure is defined for it. > > > > drivers/scsi/BusLogic.c:3735:26: error: use of undeclared identifier > > 'blogic_pci_tbl' > >  3

Re: [PATCH v2 3/3] remoteproc: imx_rproc: add power mode check for remote core attachment

2025-05-27 Thread Ulf Hansson
On Tue, 27 May 2025 at 03:29, Peng Fan wrote: > > On Mon, May 26, 2025 at 09:05:10PM -0300, Hiago De Franco wrote: > >On Mon, May 26, 2025 at 12:07:49PM +0200, Ulf Hansson wrote: > >> On Fri, 23 May 2025 at 21:17, Hiago De Franco > >> wrote: > >> > > >> > Hi Ulf, > >> > > >> > On Wed, May 21, 20

Re: [PATCH v2 0/4] CAMSS support for MSM8939

2025-05-27 Thread Konrad Dybcio
On 5/25/25 9:25 PM, Vincent Knecht via B4 Relay wrote: > This series adds CAMSS support for MSM8939. > It's mostly identical to MSM8916, except for some clocks > and an additional CSI. > > To fix black stripes across sensor output, and garbage in > CSID TPG output, 2 VFE VBIF register settings are

Re: [PATCH v3 1/6] scsi: Define MODULE_DEVICE_TABLE only if necessary

2025-05-27 Thread James Bottomley
On Tue, 2025-05-27 at 13:54 +0200, Alexey Gladkov wrote: > On Tue, May 27, 2025 at 07:28:59AM -0400, James Bottomley wrote: > > On Tue, 2025-05-27 at 11:07 +0200, Alexey Gladkov wrote: > > > Define MODULE_DEVICE_TABLE only if a structure is defined for it. > > > > > > drivers/scsi/BusLogic.c:3735:

Re: [PATCH v2 1/4] media: qcom: camss: vfe: Add VBIF setting support

2025-05-27 Thread Bryan O'Donoghue
On 26/05/2025 17:23, Vincent Knecht wrote: Do you mean to just rename to vfe_vbif_write_reg() Yep, its more natural language. --- bod

Re: [PATCH] rust: kunit: use crate-level mapping for `c_void`

2025-05-27 Thread Benno Lossin
On Mon May 26, 2025 at 6:24 PM CEST, Jesung Yang wrote: > Use `kernel::ffi::c_void` instead of `core::ffi::c_void` for consistency > and to centralize abstraction. > > Since `kernel::ffi::c_void` is a transparent wrapper around > `core::ffi::c_void`, both are functionally equivalent. However, using

Re: [PATCH 3/4] selftests/mm: Report unique test names for each cow test

2025-05-27 Thread Mark Brown
On Tue, May 27, 2025 at 12:53:30PM +0100, Lorenzo Stoakes wrote: > On Tue, May 27, 2025 at 12:49:57PM +0100, Mark Brown wrote: > > Ugh, this was masked because it's part of a series and among the > > problems with the kselftest build system is the fact that it eats > > errors. > Compile errors to

[PATCH] selftests: futex: define SYS_futex on 32-bit architectures with 64-bit time_t

2025-05-27 Thread Ben Zong-You Xie
glibc does not define SYS_futex for 32-bit architectures using 64-bit time_t e.g. riscv32, therefore this test fails to compile since it does not find SYS_futex in C library headers. Define SYS_futex as SYS_futex_time64 in this situation to ensure successful compilation and compatibility. Signed-o

Re: [PATCH v3] media: add virtio-media driver

2025-05-27 Thread Alexandre Courbot
On Tue, May 27, 2025 at 6:13 PM Mauro Carvalho Chehab wrote: > > Em Tue, 27 May 2025 15:14:50 +0900 > "Alexandre Courbot" escreveu: > > > Hi Mauro, > > > > On Mon May 26, 2025 at 9:13 PM JST, Mauro Carvalho Chehab wrote: > > > Hi Michael, > > > > > > Em Sat, 12 Apr 2025 13:08:01 +0900 > > > Alexa

Re: [PATCH v3] media: add virtio-media driver

2025-05-27 Thread Mauro Carvalho Chehab
Em Tue, 27 May 2025 22:21:42 +0900 Alexandre Courbot escreveu: > On Tue, May 27, 2025 at 6:13 PM Mauro Carvalho Chehab > wrote: > > > > Em Tue, 27 May 2025 15:14:50 +0900 > > "Alexandre Courbot" escreveu: > > > > > Hi Mauro, > > > > > > On Mon May 26, 2025 at 9:13 PM JST, Mauro Carvalho Cheha

Re: [PATCH bpf-next v2 1/2] bpf, arm64: Support up to 12 function arguments

2025-05-27 Thread Xu Kuohai
On 5/22/2025 6:14 PM, Alexis Lothoré wrote: [...] -static void save_args(struct jit_ctx *ctx, int args_off, int nregs) +struct arg_aux { + /* how many args are passed through registers, the rest of the args are +* passed through stack +*/ + int args_in_regs; +

RE: [PATCH v6 1/5] x86/sgx: Introduce a counter to count the sgx_(vepc_)open()

2025-05-27 Thread Reshetova, Elena
> -Original Message- > From: Huang, Kai > Sent: Tuesday, May 27, 2025 2:20 AM > To: Reshetova, Elena ; jar...@kernel.org > Cc: Raynor, Scott ; Hansen, Dave > ; mi...@kernel.org; Scarlata, Vincent R > ; x...@kernel.org; linux-...@vger.kernel.org; > Annapurve, Vishal ; linux-kernel@vger.ke

Re: [PATCH v2 1/4] media: qcom: camss: vfe: Add VBIF setting support

2025-05-27 Thread Bryan O'Donoghue
On 26/05/2025 17:20, Vincent Knecht wrote: You have both if (vfe->res->has_vbif) { and the above switch, there's no point in checking this twice in two different ways. Choose one, suggest has_vbif is enough. I think the switch is still needed, so that distinct settings can be applied for diff

Re: [PATCH net-next] vsock/test: Cover more CIDs in transport_uaf test

2025-05-27 Thread Stefano Garzarella
On Mon, May 26, 2025 at 10:44:05PM +0200, Michal Luczaj wrote: On 5/26/25 16:39, Stefano Garzarella wrote: On Mon, May 26, 2025 at 02:51:18PM +0200, Michal Luczaj wrote: On 5/26/25 10:25, Stefano Garzarella wrote: On Fri, May 23, 2025 at 12:31:16AM +0200, Michal Luczaj wrote: Increase the cov

Re: [PATCH] selftests: fix "memebers" typo in filesystems/mount-notify

2025-05-27 Thread Hendrik Hammernet
On 5/22/25 23:34, Shuah Khan wrote: > Change the shortlog to indicate test clearly. Check a few logs > for this file for examples. Here is how the correct format looks > like: > > selftests: filesystems: fix "memebers" typo in mount-notify > > SZend v2 with this correction. > > thanks, > -- Shuah

[PATCH v3 0/6] Add generated modalias to modules.builtin.modinfo

2025-05-27 Thread Alexey Gladkov
The modules.builtin.modinfo file is used by userspace (kmod to be specific) to get information about builtin modules. Among other information about the module, information about module aliases is stored. This is very important to determine that a particular modalias will be handled by a module that

Re: [PATCH] rust: kunit: use crate-level mapping for `c_void`

2025-05-27 Thread Jesung Yang
Hi, On Tue, May 27, 2025 at 9:06 PM Benno Lossin wrote: > > We don't need to explicitly import it, as `c_void` is present in the > prelude since 3d5bef5d47c3 ("rust: add C FFI types to the prelude"). The base commit of my patch is f4daa80d6be7 ("rust: compile libcore with edition 2024 for 1.87+"

[PATCH v2] selftests: acct: fix grammar and clarify output messages - Fixed email case mismatch in Signed-off-by

2025-05-27 Thread Abdelrahman Fekry
Hi, i already sent version 2 as a new thread 2 days ago but found out that i should also send as reply to the original thread so here it is. v2 changes: - Fixed email case mismatch in Signed-off-by This patch improves the clarity and grammar of output messages in the acct() selftest. Minor change

Re: [PATCH bpf-next v2 1/2] bpf, arm64: Support up to 12 function arguments

2025-05-27 Thread Alexis Lothoré
Hi Xu, thanks for the review On Tue May 27, 2025 at 10:11 AM CEST, Xu Kuohai wrote: > On 5/22/2025 6:14 PM, Alexis Lothoré wrote: > > [...] > >> -static void save_args(struct jit_ctx *ctx, int args_off, int nregs) >> +struct arg_aux { >> +/* how many args are passed through registers, the rest

Re: [PATCH] rust: kunit: use crate-level mapping for `c_void`

2025-05-27 Thread Miguel Ojeda
On Tue, May 27, 2025 at 2:06 PM Benno Lossin wrote: > > We don't need to explicitly import it, as `c_void` is present in the > prelude since 3d5bef5d47c3 ("rust: add C FFI types to the prelude"). Hmm... But the prelude isn't there yet in this patch, no? i.e. our prelude is (so far) not a "real pr

Re: [PATCH v3 7/6] scsi: Always define MODULE_DEVICE_TABLE

2025-05-27 Thread Alexey Gladkov
On Tue, May 27, 2025 at 09:22:09AM -0400, James Bottomley wrote: > On Tue, 2025-05-27 at 15:15 +0200, Alexey Gladkov wrote: > > Since MODULE_DEVICE_TABLE no longer depends on whether the module is > > built separately or compiled into the kernel, it now makes sense to > > always define DEVICE_TABLE

Re: [PATCH v2 3/3] remoteproc: imx_rproc: add power mode check for remote core attachment

2025-05-27 Thread Hiago De Franco
On Tue, May 27, 2025 at 01:58:46PM +0200, Ulf Hansson wrote: > On Tue, 27 May 2025 at 03:29, Peng Fan wrote: > > > > On Mon, May 26, 2025 at 09:05:10PM -0300, Hiago De Franco wrote: > > >On Mon, May 26, 2025 at 12:07:49PM +0200, Ulf Hansson wrote: > > >> On Fri, 23 May 2025 at 21:17, Hiago De Fran

[PATCH v4 1/6] scsi: Always define blogic_pci_tbl structure

2025-05-27 Thread Alexey Gladkov
The blogic_pci_tbl structure is used by the MODULE_DEVICE_TABLE macro. There is no longer a need to protect it with the MODULE condition, since this no longer causes the compiler to warn about an unused variable. Cc: Khalid Aziz Cc: "Martin K. Petersen" Suggested-by: James Bottomley Signed-off-

Re: [PATCH v3] media: add virtio-media driver

2025-05-27 Thread Alexandre Courbot
On Tue, May 27, 2025 at 10:35 PM Mauro Carvalho Chehab wrote: > > Em Tue, 27 May 2025 22:21:42 +0900 > Alexandre Courbot escreveu: > > > On Tue, May 27, 2025 at 6:13 PM Mauro Carvalho Chehab > > wrote: > > > > > > Em Tue, 27 May 2025 15:14:50 +0900 > > > "Alexandre Courbot" escreveu: > > > > >

Re: [PATCH v3] media: add virtio-media driver

2025-05-27 Thread Michael S. Tsirkin
On Mon, May 26, 2025 at 02:13:16PM +0200, Mauro Carvalho Chehab wrote: > Hi Michael, > > Em Sat, 12 Apr 2025 13:08:01 +0900 > Alexandre Courbot escreveu: > > > Add the first version of the virtio-media driver. > > > > This driver acts roughly as a V4L2 relay between user-space and the > > virti

[PATCH] virtio: document ENOSPC

2025-05-27 Thread Michael S. Tsirkin
drivers handle ENOSPC specially since it's an error one can get from a working VQ. Document the semantics. Reported-by: Parav Pandit Signed-off-by: Michael S. Tsirkin --- drivers/virtio/virtio_ring.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/virtio/virtio_ring.c b/drivers/

Re: [PATCH net-next v8] selftests/vsock: add initial vmtest.sh for vsock

2025-05-27 Thread Bobby Eshleman
On Mon, May 26, 2025 at 01:18:18PM +0200, Stefano Garzarella wrote: > On Thu, May 22, 2025 at 09:59:07PM -0700, Bobby Eshleman wrote: > > This commit introduces a new vmtest.sh runner for vsock. > > > > It uses virtme-ng/qemu to run tests in a VM. The tests validate G2H, > > H2G, and loopback. The

[PATCH v2 2/3] KVM: arm64: selftests: fix thread migration in arch_timer_edge_cases

2025-05-27 Thread Sebastian Ott
arch_timer_edge_cases tries to migrate itself across host cpus. Before the first test it migrates to cpu 0 by setting up an affinity mask with only bit 0 set. After that it looks for the next possible cpu in the current affinity mask which still has only bit 0 set. So there is no migration at all.

[PATCH v2 1/3] KVM: arm64: selftests: fix help text for arch_timer_edge_cases

2025-05-27 Thread Sebastian Ott
Fix the help text for arch_timer_edge_cases to show the correct option for setting the wait time. Signed-off-by: Sebastian Ott --- tools/testing/selftests/kvm/arm64/arch_timer_edge_cases.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/arm64/arch_

Re: [PATCH v3] media: add virtio-media driver

2025-05-27 Thread Mauro Carvalho Chehab
Em Tue, 27 May 2025 10:23:32 -0400 "Michael S. Tsirkin" escreveu: > On Mon, May 26, 2025 at 02:13:16PM +0200, Mauro Carvalho Chehab wrote: > > Hi Michael, > > > > Em Sat, 12 Apr 2025 13:08:01 +0900 > > Alexandre Courbot escreveu: > > > > > Add the first version of the virtio-media driver. >

[PATCH v2 0/3] KVM: arm64: selftests: arch_timer_edge_cases fixes

2025-05-27 Thread Sebastian Ott
Some small fixes for arch_timer_edge_cases that I stumbled upon while debugging failures for this selftest on ampere-one. Changes since v1: modified patch 3 based on suggestions from Marc. I've done some tests with this on various machines - seems to be all good, however on ampere-one I now hit t

Re: [PATCH v3] media: add virtio-media driver

2025-05-27 Thread Mauro Carvalho Chehab
Em Tue, 27 May 2025 23:03:39 +0900 Alexandre Courbot escreveu: > On Tue, May 27, 2025 at 10:35 PM Mauro Carvalho Chehab > wrote: > > > > Em Tue, 27 May 2025 22:21:42 +0900 > > Alexandre Courbot escreveu: > > > > > On Tue, May 27, 2025 at 6:13 PM Mauro Carvalho Chehab > > > wrote: > > > > >

Re: [PATCH v4 1/2] livepatch, x86/module: Generalize late module relocation locking.

2025-05-27 Thread Petr Mladek
On Thu 2025-05-22 20:52:04, Dylan Hatch wrote: > Late module relocations are an issue on any arch that supports > livepatch, so move the text_mutex locking to the livepatch core code. > > Signed-off-by: Dylan Hatch > Acked-by: Song Liu > --- > arch/x86/kernel/module.c | 8 ++-- > kernel/li

[RFC PATCH net-next v2 1/2] virtio-net: support zerocopy multi buffer XDP in mergeable

2025-05-27 Thread Bui Quang Minh
Currently, in zerocopy mode with mergeable receive buffer, virtio-net does not support multi buffer but a single buffer only. This commit adds support for multi mergeable receive buffer in the zerocopy XDP path by utilizing XDP buffer with frags. Signed-off-by: Bui Quang Minh --- drivers/net/vir

Re: [External] : Re: [PATCH 2/3] virtio-mem: fix multiple typos in struct comments and function docs

2025-05-27 Thread ALOK TIWARI
On 28-05-2025 00:42, David Hildenbrand wrote:   /*    * Test if we could add memory without creating too much offline memory - - * to avoid running OOM if memory is getting onlined deferred. + * to avoid running OOM if memory is getting online deferred. The system/user is onlining the me

Re: [PATCH 2/3] virtio-mem: fix multiple typos in struct comments and function docs

2025-05-27 Thread David Hildenbrand
/* * Test if we could add memory without creating too much offline memory - - * to avoid running OOM if memory is getting onlined deferred. + * to avoid running OOM if memory is getting online deferred. The system/user is onlining the memory, so the memory is getting "onlined"? If it wo

Re: [PATCH v4 1/5] ASoC: dt-bindings: qcom,sm8250: Add Fairphone 5 sound card

2025-05-27 Thread Rob Herring
On Wed, May 07, 2025 at 10:01:37AM +0200, Luca Weiss wrote: > Document the bindings for the sound card on Fairphone 5 which uses the > older non-audioreach audio architecture. > > Acked-by: Rob Herring (Arm) > Signed-off-by: Luca Weiss > --- > Documentation/devicetree/bindings/sound/qcom,sm8250

Re: [PATCH RFC net-next v2] page_pool: import Jesper's page_pool benchmark

2025-05-27 Thread Mina Almasry
On Mon, May 26, 2025 at 5:51 AM Toke Høiland-Jørgensen wrote: > > Fast path results: > > no-softirq-page_pool01 Per elem: 11 cycles(tsc) 4.368 ns > > > > ptr_ring results: > > no-softirq-page_pool02 Per elem: 527 cycles(tsc) 195.187 ns > > > > slow path results: > > no-softirq-page_pool03 Per elem

[PATCH v3 1/6] scsi: Define MODULE_DEVICE_TABLE only if necessary

2025-05-27 Thread Alexey Gladkov
Define MODULE_DEVICE_TABLE only if a structure is defined for it. drivers/scsi/BusLogic.c:3735:26: error: use of undeclared identifier 'blogic_pci_tbl' 3735 | MODULE_DEVICE_TABLE(pci, blogic_pci_tbl); Fixes: 1079a2d251f2 ("[SCSI] BusLogic: stop using check_region") Cc: Khalid Aziz Cc: "James E

[PATCH] rust: replace length checks with match

2025-05-27 Thread Tamir Duberstein
uity by renaming \ -a file or folder." -); } - -valid_paths[0].to_str().unwrap() } fn main() { --- base-commit: bfc3cd87559bc593bb32bb1482f9cae3308b6398 change-id: 20250527-idiomatic-match-slice-26a79d100e4d Best regards, -- Tamir Duberstein

[PATCH v3] kselftest: x86: Improve MOV SS test result message

2025-05-27 Thread Brigham Campbell
Make test result message more descriptive and grammatically correct. Signed-off-by: Brigham Campbell --- No changes in v3. I'm resending this patch to adjust patch format suggestions made by Shuah. tools/testing/selftests/x86/mov_ss_trap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH V2 06/19] virtio_ring: switch to use vring_virtqueue for virtqueue_add variants

2025-05-27 Thread Jason Wang
Those variants are used internally so let's switch to use vring_virtqueue as parameter to be consistent with other internal virtqueue helpers. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 40 +--- 1 file changed, 19 insertio

[PATCH V2 05/19] virtio_ring: switch to use vring_virtqueue for virtqueue_kick_prepare variants

2025-05-27 Thread Jason Wang
Those variants are used internally so let's switch to use vring_virtqueue as parameter to be consistent with other internal virtqueue helpers. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-)

[PATCH V2 08/19] virtio_ring: switch to use vring_virtqueue for enable_cb_prepare variants

2025-05-27 Thread Jason Wang
Those variants are used internally so let's switch to use vring_virtqueue as parameter to be consistent with other internal virtqueue helpers. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-)

[PATCH V2 00/19] virtio_ring in order support

2025-05-27 Thread Jason Wang
Hello all: This sereis tries to implement the VIRTIO_F_IN_ORDER to virtio_ring. This is done by introducing virtqueue ops so we can implement separate helpers for different virtqueue layout/features then the in-order were implemented on top. Tests shows 3%-5% imporvment with packed virtqueue PPS

[PATCH V2 02/19] virtio_ring: switch to use vring_virtqueue in virtqueue_poll variants

2025-05-27 Thread Jason Wang
Those variants are used internally so let's switch to use vring_virtqueue as parameter to be consistent with other internal virtqueue helpers. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-)

[PATCH V2 03/19] virtio_ring: unify logic of virtqueue_poll() and more_used()

2025-05-27 Thread Jason Wang
This patch unifies the logic of virtqueue_poll() and more_used() for better code reusing and ease the future in order implementation. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 48 +++- 1 file changed, 20 insertions(+), 28

[PATCH V2 04/19] virtio_ring: switch to use vring_virtqueue for virtqueue resize variants

2025-05-27 Thread Jason Wang
Those variants are used internally so let's switch to use vring_virtqueue as parameter to be consistent with other internal virtqueue helpers. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-)

[PATCH V2 13/19] virtio_ring: introduce virtqueue ops

2025-05-27 Thread Jason Wang
This patch introduces virtqueue ops which is a set of the callbacks that will be called for different queue layout or features. This would help to avoid branches for split/packed and will ease the future implementation like in order. Note that in order to eliminate the indirect calls this patch us

[PATCH V2 14/19] virtio_ring: determine descriptor flags at one time

2025-05-27 Thread Jason Wang
Let's determine the last descriptor by counting the number of sg. This would be consistent with packed virtqueue implementation and ease the future in-order implementation. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 25 + 1 file c

[PATCH V2 15/19] virtio_ring: factor out core logic of buffer detaching

2025-05-27 Thread Jason Wang
Factor out core logic of buffer detaching and leave the id population to the caller so in order can just call the core logic. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/

[PATCH V2 12/19] virtio_ring: use u16 for last_used_idx in virtqueue_poll_split()

2025-05-27 Thread Jason Wang
Use u16 for last_used_idx in virtqueue_poll_split() to align with the spec. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index 03b

[PATCH V2 19/19] virtio_ring: add in order support

2025-05-27 Thread Jason Wang
This patch implements in order support for both split virtqueue and packed virtqueue. Benchmark with KVM guest + testpmd on the host shows: For split virtqueue: no obvious differences were noticed For packed virtqueue: 1) RX gets 3.1% PPS improvements from 6.3 Mpps to 6.5 Mpps 2) TX gets 4.6% P

[PATCH V2 18/19] virtio_ring: factor out split detaching logic

2025-05-27 Thread Jason Wang
This patch factors out the split core detaching logic that could be reused by in order feature into a dedicated function. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/dri

[PATCH V2 17/19] virtio_ring: factor out split indirect detaching logic

2025-05-27 Thread Jason Wang
Factor out the split indirect descriptor detaching logic in order to make it be reused by the in order support. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 63 1 file changed, 35 insertions(+), 28 deletions(-) diff --

[PATCH V2 16/19] virtio_ring: factor out core logic for updating last_used_idx

2025-05-27 Thread Jason Wang
Factor out the core logic for updating last_used_idx to be reused by the packed in order implementation. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 43 +--- 1 file changed, 25 insertions(+), 18 deletions(-) diff --git a/d

Re: [PATCH] rust: kunit: use crate-level mapping for `c_void`

2025-05-27 Thread Benno Lossin
On Tue May 27, 2025 at 3:51 PM CEST, Miguel Ojeda wrote: > On Tue, May 27, 2025 at 2:06 PM Benno Lossin wrote: >> >> We don't need to explicitly import it, as `c_void` is present in the >> prelude since 3d5bef5d47c3 ("rust: add C FFI types to the prelude"). > > Hmm... But the prelude isn't there y

[PATCH net-next v9] selftests/vsock: add initial vmtest.sh for vsock

2025-05-27 Thread Bobby Eshleman
This commit introduces a new vmtest.sh runner for vsock. It uses virtme-ng/qemu to run tests in a VM. The tests validate G2H, H2G, and loopback. The testing tools from tools/testing/vsock/ are reused. Currently, only vsock_test is used. VMCI and hyperv support is included in the config file to be

Re: [PATCH net-next v8] selftests/vsock: add initial vmtest.sh for vsock

2025-05-27 Thread Bobby Eshleman
On Tue, May 27, 2025 at 05:55:13PM +0200, Stefano Garzarella wrote: > On Tue, May 27, 2025 at 07:30:29AM -0700, Bobby Eshleman wrote: > > On Mon, May 26, 2025 at 01:18:18PM +0200, Stefano Garzarella wrote: > > > On Thu, May 22, 2025 at 09:59:07PM -0700, Bobby Eshleman wrote: > > Yes, that would be

[PATCH v2] selftests/seccomp: Improve error logging in get_proc_stat()

2025-05-27 Thread Sameeksha Sankpal
Use TH_LOG to report failure when reading /proc//stat in get_proc_stat(), following kernel test framework conventions. Previously, printf() was used which is discouraged. Suggested-by: Kees Cook Signed-off-by: Sameeksha Sankpal --- v1 -> v2: - Used TH_LOG instead of printf for error logging -

Re: [PATCH v2] selftests: net: fix spelling and grammar mistakes

2025-05-27 Thread Jakub Kicinski
On Fri, 23 May 2025 03:22:42 +0100 Praveen Balakrishnan wrote: > Fix several spelling and grammatical mistakes in output messages from > the net selftests to improve readability. > > Only the message strings for the test output have been modified. No > changes to the functional logic of the tests

Re: [PATCH net-next 1/3] net: devmem: support single IOV with sendmsg

2025-05-27 Thread Jakub Kicinski
On Tue, 20 May 2025 13:30:42 -0700 Stanislav Fomichev wrote: > sendmsg() with a single iov becomes ITER_UBUF, sendmsg() with multiple > iovs becomes ITER_IOVEC. iter_iov_len does not return correct > value for UBUF, so teach to treat UBUF differently. Looks like this has been merged (silently), th

Re: [PATCH v3 7/6] scsi: Always define MODULE_DEVICE_TABLE

2025-05-27 Thread James Bottomley
On Tue, 2025-05-27 at 15:15 +0200, Alexey Gladkov wrote: > Since MODULE_DEVICE_TABLE no longer depends on whether the module is > built separately or compiled into the kernel, it now makes sense to > always define DEVICE_TABLE. In this case, even if the module is in > the > kernel, correct module.b

Re: [PATCH] fs/dax: Fix "don't skip locked entries when scanning entries"

2025-05-27 Thread Dan Williams
Alistair Popple wrote: > Commit 6be3e21d25ca ("fs/dax: don't skip locked entries when scanning > entries") introduced a new function, wait_entry_unlocked_exclusive(), > which waits for the current entry to become unlocked without advancing > the XArray iterator state. > > Waiting for the entry to

Re: [PATCH net-next v2 6/8] net: devmem: ksft: add 5 tuple FS support

2025-05-27 Thread Stanislav Fomichev
On 05/23, Mina Almasry wrote: > ncdevmem supports drivers that are limited to either 3-tuple or 5-tuple > FS support, but the ksft is currently 3-tuple only. Support drivers that > have 5-tuple FS supported by adding a ksft arg. > > Signed-off-by: Mina Almasry Acked-by: Stanislav Fomichev

Re: [PATCH net-next v2 4/8] net: devmem: ksft: add ipv4 support

2025-05-27 Thread Stanislav Fomichev
On 05/23, Mina Almasry wrote: > ncdevmem supports both ipv4 and ipv6, but the ksft is currently > ipv6-only. Propagate the ipv4 support to the ksft, so that folks that > are limited to these networks can also test. > > Signed-off-by: Mina Almasry Acked-by: Stanislav Fomichev

Re: [PATCH 2/7] rust: kunit: support checked `-> Result`s in KUnit `#[test]`s

2025-05-27 Thread Miguel Ojeda
On Tue, May 6, 2025 at 8:33 AM David Gow wrote: > > FWIW, having out-of-memory situations trigger a test failure is > consistent with what other KUnit tests (written in C) do. > > There's both advantages and disadvantages to this: on the one hand, > it's prone to false positives (as you mention),

Re: [PATCH net-next v2 2/8] page_pool: fix ugly page_pool formatting

2025-05-27 Thread Stanislav Fomichev
On 05/23, Mina Almasry wrote: > Minor cleanup; this line is badly formatted. > > Signed-off-by: Mina Almasry Acked-by: Stanislav Fomichev

Re: [PATCH net-next v2 1/8] net: devmem: move list_add to net_devmem_bind_dmabuf.

2025-05-27 Thread Stanislav Fomichev
On 05/23, Mina Almasry wrote: > It's annoying for the list_add to be outside net_devmem_bind_dmabuf, but > the list_del is in net_devmem_unbind_dmabuf. Make it consistent by > having both the list_add/del be inside the net_devmem_[un]bind_dmabuf. > > Cc: ap420...@gmail.com > Signed-off-by: Mina Al

[PATCH 3/3] virtio_ring: Fix typos in comments and documentation

2025-05-27 Thread Alok Tiwari
Corrected several typos in virtio_ring.c for improved clarity and consistency. Fixes include: - "dind't" -> "didn't" - "use" -> "uses" in DMA mapping context - "can been used" -> "can be used" - "buf size for sync" -> "buffer size to synchronize" No functional changes. Signed-off-by: Alok Tiwari

[PATCH 2/3] virtio-mem: fix multiple typos in struct comments and function docs

2025-05-27 Thread Alok Tiwari
Corrected several spelling mistakes in code comments, including: - "bock" -> "block" - "valued" -> "value" - "actipn" -> "action" - "accidentially" -> "accidentally" - Improved grammar in a few places for clarity. These changes are purely cosmetic and do not affect functionality. Signed-off-by: A

[PATCH 1/3] virtio: Fix typo in register_virtio_device() doc comment

2025-05-27 Thread Alok Tiwari
Corrected "suceess" to "success" in the function documentation for clarity. Signed-off-by: Alok Tiwari --- drivers/virtio/virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index 95d5d7993e5b..2c022640ec4b 100644 --- a/d

[PATCH v3 7/6] scsi: Always define MODULE_DEVICE_TABLE

2025-05-27 Thread Alexey Gladkov
Since MODULE_DEVICE_TABLE no longer depends on whether the module is built separately or compiled into the kernel, it now makes sense to always define DEVICE_TABLE. In this case, even if the module is in the kernel, correct module.builtin.modaliases will be generated. Suggested-by: James Bottomley

Re: [PATCH net v2] vsock/test: Fix occasional failure in SOCK_STREAM SHUT_RD test

2025-05-27 Thread Konstantin Shkolnyy
On 26-May-25 08:55, Stefano Garzarella wrote: BTW I think I already fixed the same issue in this series: https://lore.kernel.org/netdev/20250514141927.159456-1-sgarz...@redhat.com/ Can you check it? Yes, it looks like the same issue.

[PATCH v2 3/3] KVM: arm64: selftests: arch_timer_edge_cases - determine effective counter width

2025-05-27 Thread Sebastian Ott
arch_timer_edge_cases uses ~0 as the maximum counter value, however there's no architectural guarantee that this is valid. Figure out the effective counter width based on the effective frequency like it's done by the kernel. Note that the following subtest only worked since the counter initialize

Re: [PATCH net-next v2 3/8] net: devmem: preserve sockc_err

2025-05-27 Thread Stanislav Fomichev
On 05/23, Mina Almasry wrote: > Preserve the error code returned by sock_cmsg_send and return that on > err. > > Signed-off-by: Mina Almasry Acked-by: Stanislav Fomichev

Re: [PATCH net-next v8] selftests/vsock: add initial vmtest.sh for vsock

2025-05-27 Thread Stefano Garzarella
On Tue, May 27, 2025 at 07:30:29AM -0700, Bobby Eshleman wrote: On Mon, May 26, 2025 at 01:18:18PM +0200, Stefano Garzarella wrote: On Thu, May 22, 2025 at 09:59:07PM -0700, Bobby Eshleman wrote: > This commit introduces a new vmtest.sh runner for vsock. > > It uses virtme-ng/qemu to run tests i

  1   2   >